bixby 3.0.0 → 4.0.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/.circleci/config.yml +20 -17
- data/.github_changelog_generator +1 -1
- data/.rubocop.yml +1 -0
- data/CHANGELOG.md +101 -69
- data/CONTRIBUTING.md +43 -12
- data/README.md +35 -8
- data/bixby.gemspec +7 -4
- data/bixby_default.yml +10 -12
- data/bixby_rspec_enabled.yml +2 -4
- metadata +34 -13
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: b840e1cb51f4ea23ce4ac986a1f791ad7db6daf2d0547fd4e5c0b9994f43bddb
|
4
|
+
data.tar.gz: 84dee54f32e7ebba19ca1bd976807db111481fc560e745a44f335d85e2415261
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: 7c0c9f3aaf0e536601ccf15eec8b5e12d4371a3d46abc2414d21e76b93ed465c5e80b0d7ddd57ab93fb763a56463b23ac95469596d4791267ca5589ee8d524d6
|
7
|
+
data.tar.gz: 6649546d270bc4abd8b82653ebc1336320f322a34297d62b3d19bbab8d4c60264c12ec02d7480061e658b51c4261eac0122850663b35ed39110a3eecd04cc8df
|
data/.circleci/config.yml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
version: 2.1
|
2
2
|
|
3
3
|
orbs:
|
4
|
-
samvera: samvera/circleci-orb@
|
4
|
+
samvera: samvera/circleci-orb@1
|
5
5
|
|
6
6
|
jobs:
|
7
7
|
bundle_lint_test:
|
@@ -12,20 +12,29 @@ jobs:
|
|
12
12
|
type: string
|
13
13
|
bundler_version:
|
14
14
|
type: string
|
15
|
-
default:
|
15
|
+
default: 2.3.6
|
16
16
|
|
17
17
|
executor:
|
18
18
|
name: 'samvera/ruby'
|
19
19
|
ruby_version: << parameters.ruby_version >>
|
20
20
|
|
21
21
|
steps:
|
22
|
+
- checkout
|
23
|
+
|
24
|
+
- run:
|
25
|
+
name: Check for 'master' branch
|
26
|
+
command: |
|
27
|
+
git fetch --all --quiet --prune --prune-tags
|
28
|
+
if [[ -n "$(git branch --all --list master */master)" ]]; then
|
29
|
+
echo "A branch named 'master' was found. Please remove it."
|
30
|
+
echo "$(git branch --all --list master */master)"
|
31
|
+
fi
|
32
|
+
[[ -z "$(git branch --all --list master */master)" ]]
|
22
33
|
- samvera/cached_checkout
|
23
34
|
|
24
|
-
- samvera/
|
35
|
+
- samvera/bundle:
|
25
36
|
ruby_version: << parameters.ruby_version >>
|
26
37
|
bundler_version: << parameters.bundler_version >>
|
27
|
-
project: << parameters.project >>
|
28
|
-
cache_version: '2'
|
29
38
|
|
30
39
|
- samvera/rubocop
|
31
40
|
|
@@ -33,23 +42,17 @@ workflows:
|
|
33
42
|
version: 2
|
34
43
|
ci:
|
35
44
|
jobs:
|
36
|
-
- bundle_lint_test:
|
37
|
-
project: bixby
|
38
|
-
name: ruby2-4
|
39
|
-
ruby_version: 2.4.10
|
40
|
-
|
41
|
-
- bundle_lint_test:
|
42
|
-
project: bixby
|
43
|
-
name: ruby2-5
|
44
|
-
ruby_version: 2.5.8
|
45
|
-
|
46
45
|
- bundle_lint_test:
|
47
46
|
project: bixby
|
48
47
|
name: ruby2-6
|
49
|
-
ruby_version: 2.6.
|
48
|
+
ruby_version: 2.6.9
|
50
49
|
|
51
50
|
- bundle_lint_test:
|
52
51
|
project: bixby
|
53
52
|
name: ruby2-7
|
54
|
-
ruby_version: 2.7.
|
53
|
+
ruby_version: 2.7.5
|
55
54
|
|
55
|
+
- bundle_lint_test:
|
56
|
+
project: bixby
|
57
|
+
name: ruby3-0
|
58
|
+
ruby_version: 3.0.3
|
data/.github_changelog_generator
CHANGED
@@ -1,2 +1,2 @@
|
|
1
1
|
unreleased=true
|
2
|
-
future-release=3.0.
|
2
|
+
future-release=3.0.1
|
data/.rubocop.yml
ADDED
@@ -0,0 +1 @@
|
|
1
|
+
inherit_from: bixby_default.yml
|
data/CHANGELOG.md
CHANGED
@@ -1,160 +1,192 @@
|
|
1
1
|
# Changelog
|
2
2
|
|
3
|
-
## [
|
3
|
+
## [4.0.0](https://github.com/samvera/bixby/tree/v4.0.0) (2022-03-30)
|
4
4
|
|
5
|
-
[Full Changelog](https://github.com/samvera
|
5
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v3.0.2...v4.0.0)
|
6
6
|
|
7
7
|
**Merged pull requests:**
|
8
8
|
|
9
|
-
-
|
9
|
+
- Upgrade to rubocop 1.x [\#57](https://github.com/samvera/bixby/pull/57) ([cjcolvar](https://github.com/cjcolvar))
|
10
|
+
- Updated CONTRIBUTING [\#55](https://github.com/samvera/bixby/pull/55) ([kelynch](https://github.com/kelynch))
|
11
|
+
- Updated README [\#54](https://github.com/samvera/bixby/pull/54) ([kelynch](https://github.com/kelynch))
|
12
|
+
- Preparing the Gem for promotion to Core Component [\#60](https://github.com/samvera/bixby/pull/60) ([jrgriffiniii](https://github.com/jrgriffiniii))
|
13
|
+
- Adding the CI branch name test for `master` [\#61](https://github.com/samvera/bixby/pull/61) ([kelynch](https://github.com/kelynch))
|
14
|
+
- Make new issue link work now [\#63](https://github.com/samvera/bixby/pull/63) ([cjcolvar](https://github.com/cjcolvar))
|
15
|
+
- Fix reference in README to main branch [\#66](https://github.com/samvera/bixby/pull/66) ([bess](https://github.com/bess))
|
10
16
|
|
11
|
-
## [
|
17
|
+
## [3.0.2](https://github.com/samvera/bixby/tree/v3.0.2) (2020-09-16)
|
12
18
|
|
13
|
-
[Full Changelog](https://github.com/samvera
|
19
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v3.0.1...v3.0.2)
|
14
20
|
|
15
21
|
**Merged pull requests:**
|
16
22
|
|
17
|
-
-
|
23
|
+
- Setting rubocop-ast to ~> 0.3.0 [\#47](https://github.com/samvera/bixby/pull/47) ([jeremyf](https://github.com/jeremyf))
|
18
24
|
|
19
|
-
## [
|
25
|
+
## [3.0.1](https://github.com/samvera/bixby/tree/3.0.1) (2020-06-16)
|
20
26
|
|
21
|
-
[Full Changelog](https://github.com/samvera
|
27
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v3.0.0...3.0.1)
|
22
28
|
|
23
29
|
**Merged pull requests:**
|
24
30
|
|
25
|
-
-
|
26
|
-
-
|
31
|
+
- Removes IndentationConsistency supported styles [\#45](https://github.com/samvera/bixby/pull/45) ([rotated8](https://github.com/rotated8))
|
32
|
+
- allow non-ascii characters in comments [\#44](https://github.com/samvera/bixby/pull/44) ([no-reply](https://github.com/no-reply))
|
27
33
|
|
28
|
-
## [v3.0.0
|
34
|
+
## [v3.0.0](https://github.com/samvera/bixby/tree/v3.0.0) (2020-06-10)
|
29
35
|
|
30
|
-
[Full Changelog](https://github.com/samvera
|
36
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v3.0.0.pre3...v3.0.0)
|
31
37
|
|
32
38
|
**Merged pull requests:**
|
33
39
|
|
34
|
-
-
|
40
|
+
- Prep for 3.0.0 release [\#43](https://github.com/samvera/bixby/pull/43) ([bess](https://github.com/bess))
|
41
|
+
- Prep for 3.0.0.pre3 release [\#42](https://github.com/samvera/bixby/pull/42) ([bess](https://github.com/bess))
|
35
42
|
|
36
|
-
## [v3.0.0.
|
43
|
+
## [v3.0.0.pre3](https://github.com/samvera/bixby/tree/v3.0.0.pre3) (2020-06-10)
|
37
44
|
|
38
|
-
[Full Changelog](https://github.com/samvera
|
45
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v3.0.0.pre2...v3.0.0.pre3)
|
46
|
+
|
47
|
+
**Merged pull requests:**
|
48
|
+
|
49
|
+
- Disable Rails/DynamicFindBy [\#41](https://github.com/samvera/bixby/pull/41) ([bess](https://github.com/bess))
|
50
|
+
|
51
|
+
## [v3.0.0.pre2](https://github.com/samvera/bixby/tree/v3.0.0.pre2) (2020-06-10)
|
52
|
+
|
53
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v3.0.0.pre1...v3.0.0.pre2)
|
54
|
+
|
55
|
+
**Merged pull requests:**
|
56
|
+
|
57
|
+
- Prep for 3.0.0.pre2 release [\#40](https://github.com/samvera/bixby/pull/40) ([bess](https://github.com/bess))
|
58
|
+
- 3.0.0 fixup [\#39](https://github.com/samvera/bixby/pull/39) ([no-reply](https://github.com/no-reply))
|
59
|
+
|
60
|
+
## [v3.0.0.pre1](https://github.com/samvera/bixby/tree/v3.0.0.pre1) (2020-06-10)
|
61
|
+
|
62
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v3.0.0.pre.pre1...v3.0.0.pre1)
|
63
|
+
|
64
|
+
**Merged pull requests:**
|
65
|
+
|
66
|
+
- Fix gem version [\#38](https://github.com/samvera/bixby/pull/38) ([bess](https://github.com/bess))
|
67
|
+
|
68
|
+
## [v3.0.0.pre.pre1](https://github.com/samvera/bixby/tree/v3.0.0.pre.pre1) (2020-06-10)
|
69
|
+
|
70
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v2.1.0...v3.0.0.pre.pre1)
|
39
71
|
|
40
72
|
**Implemented enhancements:**
|
41
73
|
|
42
|
-
- Request to promote this Gem to samvera [\#33](https://github.com/samvera
|
74
|
+
- Request to promote this Gem to samvera [\#33](https://github.com/samvera/bixby/issues/33)
|
43
75
|
|
44
76
|
**Merged pull requests:**
|
45
77
|
|
46
|
-
- Prep for 3.0.0-pre1 release [\#37](https://github.com/samvera
|
47
|
-
- Prepares the Gem for promotion [\#34](https://github.com/samvera
|
78
|
+
- Prep for 3.0.0-pre1 release [\#37](https://github.com/samvera/bixby/pull/37) ([bess](https://github.com/bess))
|
79
|
+
- Prepares the Gem for promotion [\#34](https://github.com/samvera/bixby/pull/34) ([jrgriffiniii](https://github.com/jrgriffiniii))
|
48
80
|
|
49
|
-
## [v2.1.0](https://github.com/samvera
|
81
|
+
## [v2.1.0](https://github.com/samvera/bixby/tree/v2.1.0) (2020-06-09)
|
50
82
|
|
51
|
-
[Full Changelog](https://github.com/samvera
|
83
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v2.0.0...v2.1.0)
|
52
84
|
|
53
85
|
**Merged pull requests:**
|
54
86
|
|
55
|
-
- Prep for 2.1.0 release [\#36](https://github.com/samvera
|
56
|
-
- Upgrade rubocop and dependencies [\#35](https://github.com/samvera
|
57
|
-
- Prep for 2.0 release [\#31](https://github.com/samvera
|
87
|
+
- Prep for 2.1.0 release [\#36](https://github.com/samvera/bixby/pull/36) ([bess](https://github.com/bess))
|
88
|
+
- Upgrade rubocop and dependencies [\#35](https://github.com/samvera/bixby/pull/35) ([bess](https://github.com/bess))
|
89
|
+
- Prep for 2.0 release [\#31](https://github.com/samvera/bixby/pull/31) ([bess](https://github.com/bess))
|
58
90
|
|
59
|
-
## [v2.0.0](https://github.com/samvera
|
91
|
+
## [v2.0.0](https://github.com/samvera/bixby/tree/v2.0.0) (2019-12-10)
|
60
92
|
|
61
|
-
[Full Changelog](https://github.com/samvera
|
93
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v2.0.0.pre.beta1...v2.0.0)
|
62
94
|
|
63
95
|
**Closed issues:**
|
64
96
|
|
65
|
-
- Upgrade for new rubocop [\#26](https://github.com/samvera
|
66
|
-
- Update rubocop-rspec [\#25](https://github.com/samvera
|
67
|
-
- Lint/BlockAlignment has the wrong namespace - should be Layout [\#24](https://github.com/samvera
|
68
|
-
- Add Lint/RescueWithoutErrorClass [\#23](https://github.com/samvera
|
97
|
+
- Upgrade for new rubocop [\#26](https://github.com/samvera/bixby/issues/26)
|
98
|
+
- Update rubocop-rspec [\#25](https://github.com/samvera/bixby/issues/25)
|
99
|
+
- Lint/BlockAlignment has the wrong namespace - should be Layout [\#24](https://github.com/samvera/bixby/issues/24)
|
100
|
+
- Add Lint/RescueWithoutErrorClass [\#23](https://github.com/samvera/bixby/issues/23)
|
69
101
|
|
70
102
|
**Merged pull requests:**
|
71
103
|
|
72
|
-
- Skipping node\_modules directory when running cops [\#30](https://github.com/samvera
|
104
|
+
- Skipping node\_modules directory when running cops [\#30](https://github.com/samvera/bixby/pull/30) ([cgalarza](https://github.com/cgalarza))
|
73
105
|
|
74
|
-
## [v2.0.0.pre.beta1](https://github.com/samvera
|
106
|
+
## [v2.0.0.pre.beta1](https://github.com/samvera/bixby/tree/v2.0.0.pre.beta1) (2019-02-14)
|
75
107
|
|
76
|
-
[Full Changelog](https://github.com/samvera
|
108
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/1.0.0...v2.0.0.pre.beta1)
|
77
109
|
|
78
110
|
**Merged pull requests:**
|
79
111
|
|
80
|
-
- Bixby 2.0 [\#28](https://github.com/samvera
|
112
|
+
- Bixby 2.0 [\#28](https://github.com/samvera/bixby/pull/28) ([no-reply](https://github.com/no-reply))
|
113
|
+
- Bump version to 1.0.0-rc1 [\#21](https://github.com/samvera/bixby/pull/21) ([no-reply](https://github.com/no-reply))
|
81
114
|
|
82
|
-
## [1.0.0](https://github.com/samvera
|
115
|
+
## [1.0.0](https://github.com/samvera/bixby/tree/1.0.0) (2018-02-13)
|
83
116
|
|
84
|
-
[Full Changelog](https://github.com/samvera
|
117
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v1.0.0-rc1...1.0.0)
|
85
118
|
|
86
119
|
**Merged pull requests:**
|
87
120
|
|
88
|
-
- Prepare Release 1.0.0 [\#22](https://github.com/samvera
|
121
|
+
- Prepare Release 1.0.0 [\#22](https://github.com/samvera/bixby/pull/22) ([no-reply](https://github.com/no-reply))
|
89
122
|
|
90
|
-
## [v1.0.0-rc1](https://github.com/samvera
|
123
|
+
## [v1.0.0-rc1](https://github.com/samvera/bixby/tree/v1.0.0-rc1) (2018-02-09)
|
91
124
|
|
92
|
-
[Full Changelog](https://github.com/samvera
|
125
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v0.3.1...v1.0.0-rc1)
|
93
126
|
|
94
127
|
**Closed issues:**
|
95
128
|
|
96
|
-
- Disable `RSpec/MulitpleExpectations` [\#19](https://github.com/samvera
|
97
|
-
- Add tmp dir to AllCops exclusion [\#18](https://github.com/samvera
|
98
|
-
- Warning: unrecognized cop Naming/BinaryOperatorParameter found in ~/.gem/ruby/2.4.2/gems/bixby-0.3.0/bixby\_default.yml [\#14](https://github.com/samvera
|
99
|
-
- Resolve new cops/changes is in rubocop-rspec 0.18.0. [\#11](https://github.com/samvera
|
100
|
-
- Resolve new cops/changes in RuboCop 0.50.0 [\#10](https://github.com/samvera
|
101
|
-
- Bixby not compatible with latest Rubocop [\#6](https://github.com/samvera
|
129
|
+
- Disable `RSpec/MulitpleExpectations` [\#19](https://github.com/samvera/bixby/issues/19)
|
130
|
+
- Add tmp dir to AllCops exclusion [\#18](https://github.com/samvera/bixby/issues/18)
|
131
|
+
- Warning: unrecognized cop Naming/BinaryOperatorParameter found in ~/.gem/ruby/2.4.2/gems/bixby-0.3.0/bixby\_default.yml [\#14](https://github.com/samvera/bixby/issues/14)
|
132
|
+
- Resolve new cops/changes is in rubocop-rspec 0.18.0. [\#11](https://github.com/samvera/bixby/issues/11)
|
133
|
+
- Resolve new cops/changes in RuboCop 0.50.0 [\#10](https://github.com/samvera/bixby/issues/10)
|
134
|
+
- Bixby not compatible with latest Rubocop [\#6](https://github.com/samvera/bixby/issues/6)
|
102
135
|
|
103
136
|
**Merged pull requests:**
|
104
137
|
|
105
|
-
-
|
106
|
-
-
|
107
|
-
-
|
108
|
-
-
|
109
|
-
- Lock versions to `rubocop` 0.50.0 and `rubocop-rspec` 1.18.0 [\#12](https://github.com/samvera-labs/bixby/pull/12) ([no-reply](https://github.com/no-reply))
|
138
|
+
- Support newer versions of `rubocop`, `rubocop-rspec`, and Ruby [\#20](https://github.com/samvera/bixby/pull/20) ([no-reply](https://github.com/no-reply))
|
139
|
+
- Remove Lint/InvalidCharacterLiteral, fixes \#15 [\#16](https://github.com/samvera/bixby/pull/16) ([hackmastera](https://github.com/hackmastera))
|
140
|
+
- Update READEME.md to discuss versioning strategy [\#13](https://github.com/samvera/bixby/pull/13) ([no-reply](https://github.com/no-reply))
|
141
|
+
- Lock versions to `rubocop` 0.50.0 and `rubocop-rspec` 1.18.0 [\#12](https://github.com/samvera/bixby/pull/12) ([no-reply](https://github.com/no-reply))
|
110
142
|
|
111
|
-
## [v0.3.1](https://github.com/samvera
|
143
|
+
## [v0.3.1](https://github.com/samvera/bixby/tree/v0.3.1) (2017-10-04)
|
112
144
|
|
113
|
-
[Full Changelog](https://github.com/samvera
|
145
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v0.3.0...v0.3.1)
|
114
146
|
|
115
147
|
**Closed issues:**
|
116
148
|
|
117
|
-
- Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. \(obsolete configuration found in /home/ubuntu/valkyrie/valkyrie/vendor/valk\_bundle/ruby/2.3.0/gems/bixby-0.3.0/bixby\_default.yml, please update it\) [\#15](https://github.com/samvera
|
149
|
+
- Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. \(obsolete configuration found in /home/ubuntu/valkyrie/valkyrie/vendor/valk\_bundle/ruby/2.3.0/gems/bixby-0.3.0/bixby\_default.yml, please update it\) [\#15](https://github.com/samvera/bixby/issues/15)
|
118
150
|
|
119
151
|
**Merged pull requests:**
|
120
152
|
|
121
|
-
- Remove Lint/InvalidCharacterLiteral, fixes \#15 [\#17](https://github.com/samvera
|
153
|
+
- Remove Lint/InvalidCharacterLiteral, fixes \#15 [\#17](https://github.com/samvera/bixby/pull/17) ([hackmastera](https://github.com/hackmastera))
|
122
154
|
|
123
|
-
## [v0.3.0](https://github.com/samvera
|
155
|
+
## [v0.3.0](https://github.com/samvera/bixby/tree/v0.3.0) (2017-10-03)
|
124
156
|
|
125
|
-
[Full Changelog](https://github.com/samvera
|
157
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v0.2.2...v0.3.0)
|
126
158
|
|
127
159
|
**Merged pull requests:**
|
128
160
|
|
129
|
-
- Prepare Release v0.3.0 [\#9](https://github.com/samvera
|
130
|
-
- Upgrade for RuboCop 0.50.0 compatibility [\#8](https://github.com/samvera
|
131
|
-
- Allow deeper group nesting in RSpec [\#7](https://github.com/samvera
|
161
|
+
- Prepare Release v0.3.0 [\#9](https://github.com/samvera/bixby/pull/9) ([no-reply](https://github.com/no-reply))
|
162
|
+
- Upgrade for RuboCop 0.50.0 compatibility [\#8](https://github.com/samvera/bixby/pull/8) ([no-reply](https://github.com/no-reply))
|
163
|
+
- Allow deeper group nesting in RSpec [\#7](https://github.com/samvera/bixby/pull/7) ([no-reply](https://github.com/no-reply))
|
132
164
|
|
133
|
-
## [v0.2.2](https://github.com/samvera
|
165
|
+
## [v0.2.2](https://github.com/samvera/bixby/tree/v0.2.2) (2017-08-07)
|
134
166
|
|
135
|
-
[Full Changelog](https://github.com/samvera
|
167
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v0.2.1...v0.2.2)
|
136
168
|
|
137
169
|
**Closed issues:**
|
138
170
|
|
139
|
-
- Should we allow long blocks in CatalogController? [\#3](https://github.com/samvera
|
171
|
+
- Should we allow long blocks in CatalogController? [\#3](https://github.com/samvera/bixby/issues/3)
|
140
172
|
|
141
173
|
**Merged pull requests:**
|
142
174
|
|
143
|
-
- Ignore block and class length on CatalogController [\#5](https://github.com/samvera
|
144
|
-
- Include 'Capfile' in excluded filenames [\#4](https://github.com/samvera
|
175
|
+
- Ignore block and class length on CatalogController [\#5](https://github.com/samvera/bixby/pull/5) ([no-reply](https://github.com/no-reply))
|
176
|
+
- Include 'Capfile' in excluded filenames [\#4](https://github.com/samvera/bixby/pull/4) ([mark-dce](https://github.com/mark-dce))
|
145
177
|
|
146
|
-
## [v0.2.1](https://github.com/samvera
|
178
|
+
## [v0.2.1](https://github.com/samvera/bixby/tree/v0.2.1) (2017-06-01)
|
147
179
|
|
148
|
-
[Full Changelog](https://github.com/samvera
|
180
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/v0.2.0...v0.2.1)
|
149
181
|
|
150
182
|
**Merged pull requests:**
|
151
183
|
|
152
|
-
- Add bundler release tasks for easier gem management [\#2](https://github.com/samvera
|
153
|
-
- Rubocop 0 49 fixes [\#1](https://github.com/samvera
|
184
|
+
- Add bundler release tasks for easier gem management [\#2](https://github.com/samvera/bixby/pull/2) ([bess](https://github.com/bess))
|
185
|
+
- Rubocop 0 49 fixes [\#1](https://github.com/samvera/bixby/pull/1) ([bess](https://github.com/bess))
|
154
186
|
|
155
|
-
## [v0.2.0](https://github.com/samvera
|
187
|
+
## [v0.2.0](https://github.com/samvera/bixby/tree/v0.2.0) (2017-03-30)
|
156
188
|
|
157
|
-
[Full Changelog](https://github.com/samvera
|
189
|
+
[Full Changelog](https://github.com/samvera/bixby/compare/8f95541b23cfda44c8a89704127696262284215a...v0.2.0)
|
158
190
|
|
159
191
|
|
160
192
|
|
data/CONTRIBUTING.md
CHANGED
@@ -22,6 +22,28 @@ https://wiki.duraspace.org/display/samvera/Samvera+Community+Intellectual+Proper
|
|
22
22
|
|
23
23
|
You should also add yourself to the `CONTRIBUTORS.md` file in the root of the project.
|
24
24
|
|
25
|
+
## Language
|
26
|
+
|
27
|
+
The language we use matters. Today, tomorrow, and for years to come
|
28
|
+
people will read the code we write. They will judge us for our
|
29
|
+
design, logic, and the words we use to describe the system.
|
30
|
+
|
31
|
+
Our words should be accessible. Favor descriptive words that give
|
32
|
+
meaning while avoiding reinforcing systemic inequities. For example,
|
33
|
+
in the Samvera community, we should favor using allowed\_list instead
|
34
|
+
of whitelist, denied\_list instead of blacklist, or source/copy
|
35
|
+
instead of master/slave.
|
36
|
+
|
37
|
+
We're going to get it wrong, but this is a call to keep working to
|
38
|
+
make it right. View our code and the words we choose as a chance to
|
39
|
+
have a conversation. A chance to grow an understanding of the systems
|
40
|
+
we develop as well as the systems in which we live.
|
41
|
+
|
42
|
+
See [“Blacklists” and “whitelists”: a salutary warning concerning the
|
43
|
+
prevalence of racist language in discussions of predatory
|
44
|
+
publishing](https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6148600/) for
|
45
|
+
further details.
|
46
|
+
|
25
47
|
## Contribution Tasks
|
26
48
|
|
27
49
|
* Reporting Issues
|
@@ -45,15 +67,22 @@ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the pr
|
|
45
67
|
|
46
68
|
* Fork the repository on GitHub
|
47
69
|
* Create a topic branch from where you want to base your work.
|
48
|
-
* This is usually the
|
49
|
-
* To quickly create a topic branch based on
|
50
|
-
* Then checkout the new branch with `git checkout fix/
|
51
|
-
* Please avoid working directly on the `
|
70
|
+
* This is usually the `main` branch.
|
71
|
+
* To quickly create a topic branch based on `main`; `git branch fix/main/my_contribution main`
|
72
|
+
* Then checkout the new branch with `git checkout fix/main/my_contribution`.
|
73
|
+
* Please avoid working directly on the `main` branch.
|
74
|
+
* Please do not create a branch called `master`. (See note below.)
|
52
75
|
* You may find the [hub suite of commands](https://github.com/defunkt/hub) helpful
|
53
76
|
* Make sure you have added sufficient tests and documentation for your changes.
|
54
77
|
* Test functionality with RSpec; Test features / UI with Capybara.
|
55
78
|
* Run _all_ the tests to assure nothing else was accidentally broken.
|
56
79
|
|
80
|
+
NOTE: This repository follows the [Samvera Community Code of Conduct](https://samvera.atlassian.net/wiki/spaces/samvera/pages/405212316/Code+of+Conduct)
|
81
|
+
and [language recommendations](#language).
|
82
|
+
Please ***do not*** create a branch called `master` for this repository or as part of
|
83
|
+
your pull request; the branch will either need to be removed or renamed before it can
|
84
|
+
be considered for inclusion in the code base and history of this repository.
|
85
|
+
|
57
86
|
### Documenting Code
|
58
87
|
|
59
88
|
* All new public methods, modules, and classes should include inline documentation in [YARD](http://yardoc.org/).
|
@@ -109,15 +138,15 @@ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the pr
|
|
109
138
|
### Submitting Changes
|
110
139
|
|
111
140
|
* Read the article ["Using Pull Requests"](https://help.github.com/articles/using-pull-requests) on GitHub.
|
112
|
-
* Make sure your branch is up to date with its parent branch (i.e.
|
113
|
-
* `git checkout
|
141
|
+
* Make sure your branch is up to date with its parent branch (i.e. main)
|
142
|
+
* `git checkout main`
|
114
143
|
* `git pull --rebase`
|
115
144
|
* `git checkout <your-branch>`
|
116
|
-
* `git rebase
|
145
|
+
* `git rebase main`
|
117
146
|
* It is a good idea to run your tests again.
|
118
147
|
* If you've made more than one commit take a moment to consider whether squashing commits together would help improve their logical grouping.
|
119
148
|
* [Detailed Walkthrough of One Pull Request per Commit](http://ndlib.github.io/practices/one-commit-per-pull-request/)
|
120
|
-
* `git rebase --interactive
|
149
|
+
* `git rebase --interactive main` ([See Github help](https://help.github.com/articles/interactive-rebase))
|
121
150
|
* Squashing your branch's changes into one commit is "good form" and helps the person merging your request to see everything that is going on.
|
122
151
|
* Push your changes to a topic branch in your fork of the repository.
|
123
152
|
* Submit a pull request from your fork to the project.
|
@@ -127,12 +156,14 @@ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the pr
|
|
127
156
|
We adopted [Github's Pull Request Review](https://help.github.com/articles/about-pull-request-reviews/) for our repositories.
|
128
157
|
Common checks that may occur in our repositories:
|
129
158
|
|
130
|
-
1.
|
131
|
-
2.
|
159
|
+
1. [CircleCI](https://circleci.com/gh/samvera) - where our automated tests are running
|
160
|
+
2. RuboCop/Bixby - where we check for style violations
|
161
|
+
3. Approval Required - Github enforces at least one person approve a pull request. Also, all reviewers that have chimed in must approve.
|
162
|
+
4. CodeClimate - is our code remaining healthy (at least according to static code analysis)
|
132
163
|
|
133
164
|
If one or more of the required checks failed (or are incomplete), the code should not be merged (and the UI will not allow it). If all of the checks have passed, then anyone on the project (including the pull request submitter) may merge the code.
|
134
165
|
|
135
|
-
*Example: Carolyn submits a pull request, Justin reviews the pull request and approves. However, Justin is still waiting on other checks (
|
166
|
+
*Example: Carolyn submits a pull request, Justin reviews the pull request and approves. However, Justin is still waiting on other checks (CI tests are usually the culprit), so he does not merge the pull request. Eventually, all of the checks pass. At this point, Carolyn or anyone else may merge the pull request.*
|
136
167
|
|
137
168
|
#### Things to Consider When Reviewing
|
138
169
|
|
@@ -149,7 +180,7 @@ This is your chance for a mentoring moment of another developer. Take time to gi
|
|
149
180
|
* Do new or changed methods, modules, and classes have documentation?
|
150
181
|
* Does the commit contain more than it should? Are two separate concerns being addressed in one commit?
|
151
182
|
* Does the description of the new/changed specs match your understanding of what the spec is doing?
|
152
|
-
* Did the
|
183
|
+
* Did the Continuous Integration tests complete successfully?
|
153
184
|
|
154
185
|
If you are uncertain, bring other contributors into the conversation by assigning them as a reviewer.
|
155
186
|
|
data/README.md
CHANGED
@@ -4,12 +4,33 @@ Bixby: I'd buy that for a dollar!
|
|
4
4
|
[![Apache 2.0 License](http://img.shields.io/badge/APACHE2-license-blue.svg)](./LICENSE)
|
5
5
|
[![Gem Version](https://badge.fury.io/rb/bixby.svg)](https://badge.fury.io/rb/bixby)
|
6
6
|
|
7
|
+
[Jump in on Slack](http://slack.samvera.org/)
|
7
8
|
|
8
9
|
<p align="left">
|
9
|
-
<img src="
|
10
|
+
<img src="logo/murphy.jpg" alt="Murphy Sketch"/>
|
10
11
|
</p>
|
11
12
|
|
12
|
-
|
13
|
+
# What is Bixby?
|
14
|
+
|
15
|
+
Bixby is a Ruby Gem containing the default configuration settings for [RuboCop](https://github.com/rubocop/rubocop) used to enforce common Ruby style guidelines across Samvera community projects.
|
16
|
+
|
17
|
+
## Product Owner & Maintenance
|
18
|
+
|
19
|
+
Bixby is a Core Component of the Samvera community. The documentation for what this means can be found [here](http://samvera.github.io/core_components.html#requirements-for-a-core-component).
|
20
|
+
|
21
|
+
### Product Owner
|
22
|
+
|
23
|
+
[jrgriffiniii](https://github.com/jrgriffiniii)
|
24
|
+
|
25
|
+
# Help
|
26
|
+
|
27
|
+
The Samvera Community is here to help. Please see our [support guide](./.github/SUPPORT.md).
|
28
|
+
|
29
|
+
See the Samvera Confluence for information at the architecture level: <https://samvera.atlassian.net/wiki/home>
|
30
|
+
|
31
|
+
Additionally, new adopters and potential adopters may find the pages here useful: <https://samvera.org/>
|
32
|
+
|
33
|
+
Further questions? [Get in touch](https://samvera.atlassian.net/wiki/spaces/samvera/pages/405211682/Getting+Started+in+the+Samvera+Community)
|
13
34
|
|
14
35
|
## To Use This
|
15
36
|
|
@@ -43,15 +64,21 @@ Bixby is available under [the Apache 2.0 license](LICENSE.md).
|
|
43
64
|
1. Increase the same version number in `.github_changelog_generator`
|
44
65
|
1. Update `CHANGELOG.md` by running this command:
|
45
66
|
```
|
46
|
-
github_changelog_generator --user samvera
|
67
|
+
github_changelog_generator --user samvera --project bixby --token YOUR_GITHUB_TOKEN_HERE
|
47
68
|
```
|
48
|
-
1. Commit these changes to the
|
69
|
+
1. Commit these changes to the main branch
|
49
70
|
1. Run `rake release`
|
50
71
|
|
72
|
+
## Contributing
|
73
|
+
|
74
|
+
If you're working on a PR for this project, create a feature branch off of `main`.
|
75
|
+
|
76
|
+
This repository follows the [Samvera Community Code of Conduct](https://samvera.atlassian.net/wiki/spaces/samvera/pages/405212316/Code+of+Conduct) and [language recommendations](https://github.com/samvera/maintenance/blob/main/templates/CONTRIBUTING.md#language). Please ***do not*** create a branch called `master` for this repository or as part of your pull request; the branch will either need to be removed or renamed before it can be considered for inclusion in the code base and history of this repository.
|
77
|
+
|
51
78
|
## Acknowledgments
|
52
79
|
|
53
|
-
|
54
|
-
|
80
|
+
The Alex J. Murphy sketch "logo" is courtesy of [acid_lich](https://www.instagram.com/acid_lich/), all rights reserved.
|
81
|
+
|
82
|
+
This software has been developed by and is brought to you by the Samvera community. Learn more at the [Samvera Community website](https://samvera.org/).
|
55
83
|
|
56
|
-
|
57
|
-
rights reserved.
|
84
|
+
![Samvera Logo](https://samvera.atlassian.net/wiki/download/attachments/1918631965/samvera-fall-TM-220w.png?api=v2)
|
data/bixby.gemspec
CHANGED
@@ -1,21 +1,24 @@
|
|
1
1
|
# frozen_string_literal: true
|
2
2
|
|
3
3
|
Gem::Specification.new do |spec|
|
4
|
-
spec.authors = ['
|
4
|
+
spec.authors = ['Tamsin Johnson']
|
5
5
|
spec.email = ['johnson.tom@gmail.com']
|
6
6
|
spec.description = 'A Style Configuration for RuboCop'
|
7
7
|
spec.summary = 'This is the recommended style configuration for use ' \
|
8
8
|
'by Samvera Community projects.'
|
9
|
-
spec.homepage = 'http://github.com/samvera
|
9
|
+
spec.homepage = 'http://github.com/samvera/bixby'
|
10
10
|
spec.files = `git ls-files`.split($OUTPUT_RECORD_SEPARATOR)
|
11
11
|
|
12
12
|
spec.name = 'bixby'
|
13
13
|
spec.require_paths = ['lib']
|
14
14
|
|
15
|
-
spec.version = '
|
15
|
+
spec.version = '4.0.0'
|
16
16
|
spec.license = 'Apache-2.0'
|
17
17
|
|
18
|
-
spec.
|
18
|
+
spec.required_ruby_version = '>= 2.5'
|
19
|
+
|
20
|
+
spec.add_dependency 'rubocop', '>= 1', '< 2'
|
21
|
+
spec.add_dependency 'rubocop-ast'
|
19
22
|
spec.add_dependency 'rubocop-performance'
|
20
23
|
spec.add_dependency 'rubocop-rails'
|
21
24
|
spec.add_dependency 'rubocop-rspec'
|
data/bixby_default.yml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
require: rubocop-performance
|
2
2
|
|
3
3
|
AllCops:
|
4
|
-
TargetRubyVersion: 2.
|
4
|
+
TargetRubyVersion: 2.5
|
5
5
|
DisabledByDefault: true
|
6
6
|
DisplayCopNames: true
|
7
7
|
Exclude:
|
@@ -24,9 +24,6 @@ Style/AndOr:
|
|
24
24
|
Style/ArrayJoin:
|
25
25
|
Enabled: true
|
26
26
|
|
27
|
-
Style/AsciiComments:
|
28
|
-
Enabled: true
|
29
|
-
|
30
27
|
Style/Attr:
|
31
28
|
Enabled: true
|
32
29
|
|
@@ -165,9 +162,6 @@ Style/MethodCallWithoutArgsParentheses:
|
|
165
162
|
Style/MethodDefParentheses:
|
166
163
|
Enabled: true
|
167
164
|
|
168
|
-
Style/MethodMissingSuper:
|
169
|
-
Enabled: true
|
170
|
-
|
171
165
|
Style/MissingRespondToMissing:
|
172
166
|
Enabled: true
|
173
167
|
|
@@ -447,9 +441,7 @@ Layout/FirstParameterIndentation:
|
|
447
441
|
Enabled: true
|
448
442
|
|
449
443
|
Layout/IndentationConsistency:
|
450
|
-
|
451
|
-
- normal
|
452
|
-
- rails
|
444
|
+
Enabled: true
|
453
445
|
EnforcedStyle: normal
|
454
446
|
|
455
447
|
Layout/IndentationWidth:
|
@@ -611,12 +603,13 @@ Naming/VariableName:
|
|
611
603
|
|
612
604
|
Naming/VariableNumber:
|
613
605
|
Enabled: true
|
606
|
+
CheckSymbols: false
|
614
607
|
|
615
608
|
#################### Metrics ###############################
|
616
609
|
|
617
610
|
Metrics/AbcSize:
|
618
611
|
Enabled: true
|
619
|
-
Max:
|
612
|
+
Max: 32
|
620
613
|
|
621
614
|
Metrics/BlockNesting:
|
622
615
|
Enabled: true
|
@@ -631,6 +624,7 @@ Metrics/ModuleLength:
|
|
631
624
|
|
632
625
|
Metrics/CyclomaticComplexity:
|
633
626
|
Enabled: true
|
627
|
+
Max: 10
|
634
628
|
|
635
629
|
Metrics/MethodLength:
|
636
630
|
Enabled: true
|
@@ -648,6 +642,7 @@ Metrics/ParameterLists:
|
|
648
642
|
|
649
643
|
Metrics/PerceivedComplexity:
|
650
644
|
Enabled: true
|
645
|
+
Max: 11
|
651
646
|
|
652
647
|
#################### Lint ##################################
|
653
648
|
### Warnings
|
@@ -731,6 +726,9 @@ Lint/LiteralInInterpolation:
|
|
731
726
|
Lint/Loop:
|
732
727
|
Enabled: true
|
733
728
|
|
729
|
+
Lint/MissingSuper:
|
730
|
+
Enabled: true
|
731
|
+
|
734
732
|
Lint/MultipleComparison:
|
735
733
|
Enabled: true
|
736
734
|
|
@@ -800,7 +798,7 @@ Lint/UselessAccessModifier:
|
|
800
798
|
Lint/UselessAssignment:
|
801
799
|
Enabled: true
|
802
800
|
|
803
|
-
Lint/
|
801
|
+
Lint/BinaryOperatorWithIdenticalOperands:
|
804
802
|
Enabled: true
|
805
803
|
|
806
804
|
Lint/UselessElseWithoutRescue:
|
data/bixby_rspec_enabled.yml
CHANGED
@@ -1,9 +1,8 @@
|
|
1
1
|
---
|
2
2
|
require: rubocop-rspec
|
3
3
|
|
4
|
-
|
5
|
-
|
6
|
-
Patterns:
|
4
|
+
RSpec:
|
5
|
+
Include:
|
7
6
|
- _spec.rb
|
8
7
|
- "(?:^|/)spec/"
|
9
8
|
|
@@ -25,7 +24,6 @@ RSpec/DescribeMethod:
|
|
25
24
|
|
26
25
|
RSpec/EmptyExampleGroup:
|
27
26
|
Enabled: true
|
28
|
-
CustomIncludeMethods: []
|
29
27
|
|
30
28
|
RSpec/ExampleLength:
|
31
29
|
Enabled: true
|
metadata
CHANGED
@@ -1,29 +1,49 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: bixby
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version:
|
4
|
+
version: 4.0.0
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
|
-
-
|
8
|
-
autorequire:
|
7
|
+
- Tamsin Johnson
|
8
|
+
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date:
|
11
|
+
date: 2022-03-31 00:00:00.000000000 Z
|
12
12
|
dependencies:
|
13
13
|
- !ruby/object:Gem::Dependency
|
14
14
|
name: rubocop
|
15
15
|
requirement: !ruby/object:Gem::Requirement
|
16
16
|
requirements:
|
17
|
-
- -
|
17
|
+
- - ">="
|
18
|
+
- !ruby/object:Gem::Version
|
19
|
+
version: '1'
|
20
|
+
- - "<"
|
21
|
+
- !ruby/object:Gem::Version
|
22
|
+
version: '2'
|
23
|
+
type: :runtime
|
24
|
+
prerelease: false
|
25
|
+
version_requirements: !ruby/object:Gem::Requirement
|
26
|
+
requirements:
|
27
|
+
- - ">="
|
28
|
+
- !ruby/object:Gem::Version
|
29
|
+
version: '1'
|
30
|
+
- - "<"
|
18
31
|
- !ruby/object:Gem::Version
|
19
|
-
version:
|
32
|
+
version: '2'
|
33
|
+
- !ruby/object:Gem::Dependency
|
34
|
+
name: rubocop-ast
|
35
|
+
requirement: !ruby/object:Gem::Requirement
|
36
|
+
requirements:
|
37
|
+
- - ">="
|
38
|
+
- !ruby/object:Gem::Version
|
39
|
+
version: '0'
|
20
40
|
type: :runtime
|
21
41
|
prerelease: false
|
22
42
|
version_requirements: !ruby/object:Gem::Requirement
|
23
43
|
requirements:
|
24
|
-
- -
|
44
|
+
- - ">="
|
25
45
|
- !ruby/object:Gem::Version
|
26
|
-
version: 0
|
46
|
+
version: '0'
|
27
47
|
- !ruby/object:Gem::Dependency
|
28
48
|
name: rubocop-performance
|
29
49
|
requirement: !ruby/object:Gem::Requirement
|
@@ -90,6 +110,7 @@ files:
|
|
90
110
|
- ".circleci/config.yml"
|
91
111
|
- ".github_changelog_generator"
|
92
112
|
- ".gitignore"
|
113
|
+
- ".rubocop.yml"
|
93
114
|
- CHANGELOG.md
|
94
115
|
- CODE_OF_CONDUCT.md
|
95
116
|
- CONTRIBUTING.md
|
@@ -103,11 +124,11 @@ files:
|
|
103
124
|
- bixby_rails_enabled.yml
|
104
125
|
- bixby_rspec_enabled.yml
|
105
126
|
- logo/murphy.jpg
|
106
|
-
homepage: http://github.com/samvera
|
127
|
+
homepage: http://github.com/samvera/bixby
|
107
128
|
licenses:
|
108
129
|
- Apache-2.0
|
109
130
|
metadata: {}
|
110
|
-
post_install_message:
|
131
|
+
post_install_message:
|
111
132
|
rdoc_options: []
|
112
133
|
require_paths:
|
113
134
|
- lib
|
@@ -115,15 +136,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
|
|
115
136
|
requirements:
|
116
137
|
- - ">="
|
117
138
|
- !ruby/object:Gem::Version
|
118
|
-
version: '
|
139
|
+
version: '2.5'
|
119
140
|
required_rubygems_version: !ruby/object:Gem::Requirement
|
120
141
|
requirements:
|
121
142
|
- - ">="
|
122
143
|
- !ruby/object:Gem::Version
|
123
144
|
version: '0'
|
124
145
|
requirements: []
|
125
|
-
rubygems_version: 3.1.
|
126
|
-
signing_key:
|
146
|
+
rubygems_version: 3.1.6
|
147
|
+
signing_key:
|
127
148
|
specification_version: 4
|
128
149
|
summary: This is the recommended style configuration for use by Samvera Community
|
129
150
|
projects.
|