bixby 2.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98071ddaf1aae7fa578581301c5c0e633dbdcb347bf20119a598f99a4d134b87
-  data.tar.gz: 6e1404ed5873453783a7050215a9cfd57b378b16d249e1da61b092aea6a8e6f1
+  metadata.gz: 87552958616255b35a3f50738ab1d6f90c7ceab733e491e60bf7e348bae562ae
+  data.tar.gz: 6f5fd49b832323c3500483141542cfa15140c5c696a2994f0a1562b0940b7287
 SHA512:
-  metadata.gz: c36a71ff3335fd24e72773a636030943f1a1782d643d6d3a57e5b69c8038a6a7b90a337222f54952f375f3938ea433160f484010c25eade5824c1e174d0fdbba
-  data.tar.gz: cc4f54449fdf1457c93d376cf3d224fd1c1a4b8965d7916b92418b74680aac319ceb3745114d84d8ef54197870c3465fab2b3662a603dd7a71c26a1c118231e0
+  metadata.gz: 869c5b1f503eadd3edb2864d614bf40f0f032670ff1592cc59b3c5aa4bd0e576f259fc5c0b20795c484252fd13869a73502365c80f13fbe7b41cf2cf49ac3bb5
+  data.tar.gz: 40ee0c7005679a15eacd3fafb2b0f986f801d3e447fc48ac8c88a0cd858906f79cf8c500e332977e02c51e01d46c8ff496425bc1f0c55ca1a3eb228ebe24cfd8

data/.circleci/config.yml

@@ -0,0 +1,55 @@
+version: 2.1
+
+orbs:
+  samvera: samvera/circleci-orb@0
+
+jobs:
+  bundle_lint_test:
+    parameters:
+      ruby_version:
+        type: string
+      project:
+        type: string
+      bundler_version:
+        type: string
+        default: 1.17.3
+
+    executor:
+      name: 'samvera/ruby'
+      ruby_version: << parameters.ruby_version >>
+
+    steps:
+      - samvera/cached_checkout
+
+      - samvera/bundle_for_gem:
+          ruby_version: << parameters.ruby_version >>
+          bundler_version: << parameters.bundler_version >>
+          project: << parameters.project >>
+          cache_version: '2'
+
+      - samvera/rubocop
+
+workflows:
+  version: 2
+  ci:
+    jobs:
+      - bundle_lint_test:
+          project: bixby
+          name: ruby2-4
+          ruby_version: 2.4.10
+
+      - bundle_lint_test:
+          project: bixby
+          name: ruby2-5
+          ruby_version: 2.5.8
+
+      - bundle_lint_test:
+          project: bixby
+          name: ruby2-6
+          ruby_version: 2.6.6
+
+      - bundle_lint_test:
+          project: bixby
+          name: ruby2-7
+          ruby_version: 2.7.1
+

data/.github_changelog_generator

@@ -1,2 +1,2 @@
 unreleased=true
-future-release=2.0.0
+future-release=3.0.1

data/CHANGELOG.md

@@ -1,8 +1,74 @@
 # Changelog
 
-## [2.0.0](https://github.com/samvera-labs/bixby/tree/2.0.0) (2019-12-10)
+## [3.0.1](https://github.com/samvera-labs/bixby/tree/3.0.1) (2020-06-16)
 
-[Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.0.0.pre.beta1...2.0.0)
+[Full Changelog](https://github.com/samvera-labs/bixby/compare/v3.0.0...3.0.1)
+
+**Merged pull requests:**
+
+- Removes IndentationConsistency supported styles [\#45](https://github.com/samvera-labs/bixby/pull/45) ([rotated8](https://github.com/rotated8))
+- allow non-ascii characters in comments [\#44](https://github.com/samvera-labs/bixby/pull/44) ([no-reply](https://github.com/no-reply))
+
+## [v3.0.0](https://github.com/samvera-labs/bixby/tree/v3.0.0) (2020-06-10)
+
+[Full Changelog](https://github.com/samvera-labs/bixby/compare/v3.0.0.pre3...v3.0.0)
+
+**Merged pull requests:**
+
+- Prep for 3.0.0 release [\#43](https://github.com/samvera-labs/bixby/pull/43) ([bess](https://github.com/bess))
+- Prep for 3.0.0.pre3 release [\#42](https://github.com/samvera-labs/bixby/pull/42) ([bess](https://github.com/bess))
+
+## [v3.0.0.pre3](https://github.com/samvera-labs/bixby/tree/v3.0.0.pre3) (2020-06-10)
+
+[Full Changelog](https://github.com/samvera-labs/bixby/compare/v3.0.0.pre2...v3.0.0.pre3)
+
+**Merged pull requests:**
+
+- Disable Rails/DynamicFindBy [\#41](https://github.com/samvera-labs/bixby/pull/41) ([bess](https://github.com/bess))
+
+## [v3.0.0.pre2](https://github.com/samvera-labs/bixby/tree/v3.0.0.pre2) (2020-06-10)
+
+[Full Changelog](https://github.com/samvera-labs/bixby/compare/v3.0.0.pre1...v3.0.0.pre2)
+
+**Merged pull requests:**
+
+- Prep for 3.0.0.pre2 release [\#40](https://github.com/samvera-labs/bixby/pull/40) ([bess](https://github.com/bess))
+- 3.0.0 fixup [\#39](https://github.com/samvera-labs/bixby/pull/39) ([no-reply](https://github.com/no-reply))
+
+## [v3.0.0.pre1](https://github.com/samvera-labs/bixby/tree/v3.0.0.pre1) (2020-06-10)
+
+[Full Changelog](https://github.com/samvera-labs/bixby/compare/v3.0.0.pre.pre1...v3.0.0.pre1)
+
+**Merged pull requests:**
+
+- Fix gem version [\#38](https://github.com/samvera-labs/bixby/pull/38) ([bess](https://github.com/bess))
+
+## [v3.0.0.pre.pre1](https://github.com/samvera-labs/bixby/tree/v3.0.0.pre.pre1) (2020-06-10)
+
+[Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.1.0...v3.0.0.pre.pre1)
+
+**Implemented enhancements:**
+
+- Request to promote this Gem to samvera [\#33](https://github.com/samvera-labs/bixby/issues/33)
+
+**Merged pull requests:**
+
+- Prep for 3.0.0-pre1 release [\#37](https://github.com/samvera-labs/bixby/pull/37) ([bess](https://github.com/bess))
+- Prepares the Gem for promotion [\#34](https://github.com/samvera-labs/bixby/pull/34) ([jrgriffiniii](https://github.com/jrgriffiniii))
+
+## [v2.1.0](https://github.com/samvera-labs/bixby/tree/v2.1.0) (2020-06-09)
+
+[Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.0.0...v2.1.0)
+
+**Merged pull requests:**
+
+- Prep for 2.1.0 release [\#36](https://github.com/samvera-labs/bixby/pull/36) ([bess](https://github.com/bess))
+- Upgrade rubocop and dependencies [\#35](https://github.com/samvera-labs/bixby/pull/35) ([bess](https://github.com/bess))
+- Prep for 2.0 release [\#31](https://github.com/samvera-labs/bixby/pull/31) ([bess](https://github.com/bess))
+
+## [v2.0.0](https://github.com/samvera-labs/bixby/tree/v2.0.0) (2019-12-10)
+
+[Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.0.0.pre.beta1...v2.0.0)
 
 **Closed issues:**
 
@@ -22,6 +88,7 @@
 **Merged pull requests:**
 
 - Bixby 2.0 [\#28](https://github.com/samvera-labs/bixby/pull/28) ([no-reply](https://github.com/no-reply))
+- Bump version to 1.0.0-rc1 [\#21](https://github.com/samvera-labs/bixby/pull/21) ([no-reply](https://github.com/no-reply))
 
 ## [1.0.0](https://github.com/samvera-labs/bixby/tree/1.0.0) (2018-02-13)
 
@@ -46,7 +113,6 @@
 
 **Merged pull requests:**
 
-- Bump version to 1.0.0-rc1 [\#21](https://github.com/samvera-labs/bixby/pull/21) ([no-reply](https://github.com/no-reply))
 - Support newer versions of `rubocop`, `rubocop-rspec`, and Ruby [\#20](https://github.com/samvera-labs/bixby/pull/20) ([no-reply](https://github.com/no-reply))
 - Remove Lint/InvalidCharacterLiteral, fixes \#15 [\#16](https://github.com/samvera-labs/bixby/pull/16) ([hackmastera](https://github.com/hackmastera))
 - Update READEME.md to discuss versioning strategy [\#13](https://github.com/samvera-labs/bixby/pull/13) ([no-reply](https://github.com/no-reply))

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,36 @@
+The Samvera community is dedicated to providing a welcoming and
+positive experience for all its members, whether they are at a formal
+gathering, in a social setting, or taking part in activities online.
+The Samvera community welcomes participation from people all over the
+world and these members bring with them a wide variety of
+professional, personal and social backgrounds; whatever these may be,
+we treat colleagues with dignity and respect.
+
+Community members communicate primarily in English, though for many of
+them this is not their native language. We therefore strive to express
+ourselves simply and clearly remembering that unnecessary use of
+jargon and slang will be a barrier to understanding for many of our
+colleagues.  We are sensitive to the fact that the international
+nature of the community means that we span many different social norms
+around language and behaviour and we strive to conduct ourselves,
+online and in person, in ways that are unlikely to cause offence.
+
+Samvera conversations are often information-rich and intended to
+generate discussion and debate.  We discuss ideas from a standpoint of
+mutual respect and reasoned argument.
+
+Community members work together to promote a respectful and safe
+community. In the event that someone’s conduct is causing offence or
+distress, Samvera has a detailed
+[Anti-Harassment Policy and Protocol](https://wiki.duraspace.org/display/samvera/Anti-Harassment+Policy)
+which can be applied to address the problem. The first step in dealing
+with any serious misconduct is to contact a local meeting organizer,
+the
+[Samvera community helpers](https://wiki.duraspace.org/display/samvera/Samvera+Community+Helpers)
+([email](mailto:helpers@samvera.org)), a community member you
+trust, or the
+[Samvera Steering Group](https://wiki.duraspace.org/display/samvera/Samvera+Steering+Group+membership)
+immediately; at Samvera events, these people can be identified by
+distinctive name badges. The
+[Policy and Protocol](https://wiki.duraspace.org/display/samvera/Anti-Harassment+Policy)
+should be consulted for fuller details.

data/CONTRIBUTING.md

@@ -0,0 +1,161 @@
+# How to Contribute
+
+We want your help to make the Samvera community great. There are a few guidelines
+that we need contributors to follow so that we can have a chance of
+keeping on top of things.
+
+## Code of Conduct
+
+The Samvera Community is dedicated to providing a welcoming and positive
+experience for all its members, whether they are at a formal gathering, in
+a social setting, or taking part in activities online. Please see our
+[Code of Conduct](CODE_OF_CONDUCT.md) for more information.
+
+## Samvera Community Intellectual Property Licensing and Ownership
+
+All code contributors must have an Individual Contributor License Agreement
+(iCLA) on file with the Samvera Steering Group. If the contributor works for
+an institution, the institution must have a Corporate Contributor License
+Agreement (cCLA) on file.
+
+https://wiki.duraspace.org/display/samvera/Samvera+Community+Intellectual+Property+Licensing+and+Ownership
+
+You should also add yourself to the `CONTRIBUTORS.md` file in the root of the project.
+
+## Contribution Tasks
+
+* Reporting Issues
+* Making Changes
+* Documenting Code
+* Committing Changes
+* Submitting Changes
+* Reviewing and Merging Changes
+
+### Reporting Issues
+
+* Make sure you have a [GitHub account](https://github.com/signup/free)
+* Submit a [Github issue](https://github.com/samvera/bixby/issues/) by:
+  * Clearly describing the issue
+    * Provide a descriptive summary
+    * Explain the expected behavior
+    * Explain the actual behavior
+    * Provide steps to reproduce the actual behavior
+
+### Making Changes
+
+* Fork the repository on GitHub
+* Create a topic branch from where you want to base your work.
+  * This is usually the master branch.
+  * To quickly create a topic branch based on master; `git branch fix/master/my_contribution master`
+  * Then checkout the new branch with `git checkout fix/master/my_contribution`.
+  * Please avoid working directly on the `master` branch.
+  * You may find the [hub suite of commands](https://github.com/defunkt/hub) helpful
+* Make sure you have added sufficient tests and documentation for your changes.
+  * Test functionality with RSpec; Test features / UI with Capybara.
+* Run _all_ the tests to assure nothing else was accidentally broken.
+
+### Documenting Code
+
+* All new public methods, modules, and classes should include inline documentation in [YARD](http://yardoc.org/).
+  * Documentation should seek to answer the question "why does this code exist?"
+* Document private / protected methods as desired.
+* If you are working in a file with no prior documentation, do try to document as you gain understanding of the code.
+  * If you don't know exactly what a bit of code does, it is extra likely that it needs to be documented. Take a stab at it and ask for feedback in your pull request. You can use the 'blame' button on GitHub to identify the original developer of the code and @mention them in your comment.
+  * This work greatly increases the usability of the code base and supports the on-ramping of new committers.
+  * We will all be understanding of one another's time constraints in this area.
+* [Getting started with YARD](http://www.rubydoc.info/gems/yard/file/docs/GettingStarted.md)
+
+### Committing changes
+
+* Make commits of logical units.
+* Check for unnecessary whitespace with `git diff --check` before committing.
+* Make sure your commit messages are [well formed](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
+* If you created an issue, you can close it by including "Closes #issue" in your commit message. See [Github's blog post for more details](https://github.com/blog/1386-closing-issues-via-commit-messages)
+
+```
+    Present tense short summary (50 characters or less)
+
+    More detailed description, if necessary. It should be wrapped to 72
+    characters. Try to be as descriptive as you can, even if you think that
+    the commit content is obvious, it may not be obvious to others. You
+    should add such description also if it's already present in bug tracker,
+    it should not be necessary to visit a webpage to check the history.
+
+    Include Closes #<issue-number> when relavent.
+
+    Description can have multiple paragraphs and you can use code examples
+    inside, just indent it with 4 spaces:
+
+        class PostsController
+          def index
+            respond_to do |wants|
+              wants.html { render 'index' }
+            end
+          end
+        end
+
+    You can also add bullet points:
+
+    - you can use dashes or asterisks
+
+    - also, try to indent next line of a point for readability, if it's too
+      long to fit in 72 characters
+```
+
+* Make sure you have added the necessary tests for your changes.
+* Run _all_ the tests to assure nothing else was accidentally broken.
+* When you are ready to submit a pull request
+
+### Submitting Changes
+
+* Read the article ["Using Pull Requests"](https://help.github.com/articles/using-pull-requests) on GitHub.
+* Make sure your branch is up to date with its parent branch (i.e. master)
+  * `git checkout master`
+  * `git pull --rebase`
+  * `git checkout <your-branch>`
+  * `git rebase master`
+  * It is a good idea to run your tests again.
+* If you've made more than one commit take a moment to consider whether squashing commits together would help improve their logical grouping.
+  * [Detailed Walkthrough of One Pull Request per Commit](http://ndlib.github.io/practices/one-commit-per-pull-request/)
+  * `git rebase --interactive master` ([See Github help](https://help.github.com/articles/interactive-rebase))
+  * Squashing your branch's changes into one commit is "good form" and helps the person merging your request to see everything that is going on.
+* Push your changes to a topic branch in your fork of the repository.
+* Submit a pull request from your fork to the project.
+
+### Reviewing and Merging Changes
+
+We adopted [Github's Pull Request Review](https://help.github.com/articles/about-pull-request-reviews/) for our repositories.
+Common checks that may occur in our repositories:
+
+1. Travis CI - where our automated tests are running
+2. Approval Required - Github enforces at least one person approve a pull request. Also, all reviewers that have chimed in must approve.
+
+If one or more of the required checks failed (or are incomplete), the code should not be merged (and the UI will not allow it). If all of the checks have passed, then anyone on the project (including the pull request submitter) may merge the code.
+
+*Example: Carolyn submits a pull request, Justin reviews the pull request and approves. However, Justin is still waiting on other checks (Travis CI is usually the culprit), so he does not merge the pull request. Eventually, all of the checks pass. At this point, Carolyn or anyone else may merge the pull request.*
+
+#### Things to Consider When Reviewing
+
+First, the person contributing the code is putting themselves out there. Be mindful of what you say in a review.
+
+* Ask clarifying questions
+* State your understanding and expectations
+* Provide example code or alternate solutions, and explain why
+
+This is your chance for a mentoring moment of another developer. Take time to give an honest and thorough review of what has changed. Things to consider:
+
+  * Does the commit message explain what is going on?
+  * Does the code changes have tests? _Not all changes need new tests, some changes are refactorings_
+  * Do new or changed methods, modules, and classes have documentation?
+  * Does the commit contain more than it should? Are two separate concerns being addressed in one commit?
+  * Does the description of the new/changed specs match your understanding of what the spec is doing?
+  * Did the Travis tests complete successfully?
+
+If you are uncertain, bring other contributors into the conversation by assigning them as a reviewer.
+
+# Additional Resources
+
+* [General GitHub documentation](http://help.github.com/)
+* [GitHub pull request documentation](https://help.github.com/articles/about-pull-requests/)
+* [Pro Git](http://git-scm.com/book) is both a free and excellent book about Git.
+* [A Git Config for Contributing](http://ndlib.github.io/practices/my-typical-per-project-git-config/)

data/Gemfile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

data/README.md

@@ -4,6 +4,7 @@ Bixby: I'd buy that for a dollar!
 [![Apache 2.0 License](http://img.shields.io/badge/APACHE2-license-blue.svg)](./LICENSE)
 [![Gem Version](https://badge.fury.io/rb/bixby.svg)](https://badge.fury.io/rb/bixby)
 
+
 <p align="left">
   <img src="https://raw.githubusercontent.com/curationexperts/hycop/master/logo/murphy.jpg" alt="Murphy Sketch"/>
 </p>

data/Rakefile

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'

data/SUPPORT.md

@@ -0,0 +1,5 @@
+If you would like to report an issue, first search [the list of issues](https://github.com/samvera/bixby/issues/) to see if someone else has already reported it, and then feel free to [create a new issue](https://github.com/samvera/bixby/issues/new).
+
+If you have questions or need help, please email [the Samvera community tech list](https://groups.google.com/forum/#!forum/samvera-tech) or stop by the #dev channel in [the Samvera community Slack team](https://wiki.duraspace.org/pages/viewpage.action?pageId=87460391#Getintouch!-Slack).
+
+You can learn more about the various Samvera communication channels on the [Get in touch!](https://wiki.duraspace.org/pages/viewpage.action?pageId=87460391) wiki page.

data/bixby.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Gem::Specification.new do |spec|
   spec.authors       = ['Tom Johnson']
   spec.email         = ['johnson.tom@gmail.com']
@@ -10,11 +12,13 @@ Gem::Specification.new do |spec|
   spec.name          = 'bixby'
   spec.require_paths = ['lib']
 
-  spec.version       = '2.0.0'
+  spec.version       = '3.0.1'
   spec.license       = 'Apache-2.0'
 
-  spec.add_dependency 'rubocop',       '0.63.1'
-  spec.add_dependency 'rubocop-rspec', '1.31.0'
+  spec.add_dependency 'rubocop', '0.85.1'
+  spec.add_dependency 'rubocop-performance'
+  spec.add_dependency 'rubocop-rails'
+  spec.add_dependency 'rubocop-rspec'
 
   spec.add_development_dependency 'github_changelog_generator'
 end

data/bixby_default.yml

@@ -1,5 +1,7 @@
+require: rubocop-performance
+
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.6
   DisabledByDefault: true
   DisplayCopNames: true
   Exclude:
@@ -22,9 +24,6 @@ Style/AndOr:
 Style/ArrayJoin:
   Enabled: true
 
-Style/AsciiComments:
-  Enabled: true
-
 Style/Attr:
   Enabled: true
 
@@ -40,9 +39,6 @@ Style/BlockComments:
 Style/BlockDelimiters:
   Enabled: true
 
-Style/BracesAroundHashParameters:
-  Enabled: true
-
 Style/CaseEquality:
   Enabled: true
 
@@ -281,9 +277,15 @@ Style/RedundantReturn:
 Style/RedundantSelf:
   Enabled: true
 
+Style/RedundantSortBy:
+  Enabled: true
+
 Style/RescueModifier:
   Enabled: true
 
+Style/Sample:
+  Enabled: true
+
 Style/SafeNavigation:
   Enabled: true
 
@@ -336,13 +338,13 @@ Style/TrivialAccessors:
 Style/UnlessElse:
   Enabled: true
 
-Style/UnneededCapitalW:
+Style/RedundantCapitalW:
   Enabled: true
 
-Style/UnneededInterpolation:
+Style/RedundantInterpolation:
   Enabled: true
 
-Style/UnneededPercentQ:
+Style/RedundantPercentQ:
   Enabled: true
 
 Style/TrailingUnderscoreVariable:
@@ -366,13 +368,13 @@ Style/ZeroLengthPredicate:
 
 #################### Layout ###############################
 
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Enabled: true
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: true
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   Enabled: true
 
 Layout/BlockAlignment:
@@ -432,6 +434,9 @@ Layout/EndOfLine:
 Layout/ExtraSpacing:
   Enabled: true
 
+Layout/IndentationStyle:
+  Enabled: true
+
 Layout/InitialIndentation:
   Enabled: true
 
@@ -439,21 +444,19 @@ Layout/FirstParameterIndentation:
   Enabled: true
 
 Layout/IndentationConsistency:
-  SupportedStyles:
-    - normal
-    - rails
-  EnforcedStyle: rails
+  Enabled: true
+  EnforcedStyle: normal
 
 Layout/IndentationWidth:
   Enabled: true
 
-Layout/IndentArray:
+Layout/FirstArrayElementIndentation:
   Enabled: true
 
-Layout/IndentAssignment:
+Layout/AssignmentIndentation:
   Enabled: true
 
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   Enabled: true
 
 Layout/SpaceInLambdaLiteral:
@@ -462,6 +465,12 @@ Layout/SpaceInLambdaLiteral:
 Layout/LeadingCommentSpace:
   Enabled: true
 
+Layout/LineLength:
+  Enabled: true
+  Max: 200
+  Exclude:
+    - '**/*.gemspec'
+
 Layout/MultilineArrayBraceLayout:
   Enabled: true
 
@@ -555,10 +564,7 @@ Layout/SpaceInsideRangeLiteral:
 Layout/SpaceInsideStringInterpolation:
   Enabled: true
 
-Layout/Tab:
-  Enabled: true
-
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Enabled: true
 
 Layout/TrailingWhitespace:
@@ -621,12 +627,6 @@ Metrics/ModuleLength:
 Metrics/CyclomaticComplexity:
   Enabled: true
 
-Metrics/LineLength:
-  Enabled: true
-  Max: 200
-  Exclude:
-    - '**/*.gemspec'
-
 Metrics/MethodLength:
   Enabled: true
   Max: 14
@@ -671,7 +671,7 @@ Lint/DuplicateCaseCondition:
 Lint/DuplicateMethods:
   Enabled: true
 
-Lint/DuplicatedKey:
+Lint/DuplicateHashKey:
   Enabled: true
 
 Lint/EachWithObjectArgument:
@@ -693,9 +693,6 @@ Lint/EmptyInterpolation:
 Lint/EmptyWhen:
   Enabled: true
 
-Lint/EndInMethod:
-  Enabled: true
-
 Lint/EnsureReturn:
   Enabled: true
 
@@ -708,7 +705,7 @@ Lint/FloatOutOfRange:
 Lint/FormatParameterMismatch:
   Enabled: true
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Enabled: true
 
 Lint/ImplicitStringConcatenation:
@@ -729,7 +726,7 @@ Lint/LiteralInInterpolation:
 Lint/Loop:
   Enabled: true
 
-Lint/MultipleCompare:
+Lint/MultipleComparison:
   Enabled: true
 
 Lint/NestedMethodDefinition:
@@ -769,7 +766,7 @@ Lint/ShadowedException:
 Lint/ShadowingOuterLocalVariable:
   Enabled: true
 
-Lint/StringConversionInInterpolation:
+Lint/RedundantStringCoercion:
   Enabled: true
 
 Lint/UnderscorePrefixedVariableName:
@@ -778,7 +775,7 @@ Lint/UnderscorePrefixedVariableName:
 Lint/UnifiedInteger:
   Enabled: true
 
-Lint/UnneededSplatExpansion:
+Lint/RedundantSplatExpansion:
   Enabled: true
 
 Lint/UnusedBlockArgument:
@@ -822,8 +819,8 @@ Performance/Count:
   # This cop has known compatibility issues with `ActiveRecord` and other
   # frameworks. ActiveRecord's `count` ignores the block that is passed to it.
   # For more information, see the documentation in the cop itself.
-  # If you understand the known risk, you can disable `SafeMode`.
-  SafeMode: true
+  # If you understand the known risk, you can disable `SafeAutoCorrect`.
+  SafeAutoCorrect: true
   Enabled: true
 
 Performance/Detect:
@@ -831,7 +828,7 @@ Performance/Detect:
   # frameworks. `ActiveRecord` does not implement a `detect` method and `find`
   # has its own meaning. Correcting `ActiveRecord` methods with this cop
   # should be considered unsafe.
-  SafeMode: true
+  SafeAutoCorrect: true
   Enabled: true
 
 Performance/DoubleStartEndWith:
@@ -855,9 +852,6 @@ Performance/FlatMap:
   # This can be dangerous since `flat_map` will only flatten 1 level, and
   # `flatten` without any parameters can flatten multiple levels.
 
-Performance/LstripRstrip:
-  Enabled: true
-
 Performance/RangeInclude:
   Enabled: true
 
@@ -870,18 +864,12 @@ Performance/RedundantMatch:
 Performance/RedundantMerge:
   Enabled: true
 
-Performance/RedundantSortBy:
-  Enabled: true
-
 Performance/RegexpMatch:
   Enabled: true
 
 Performance/ReverseEach:
   Enabled: true
 
-Performance/Sample:
-  Enabled: true
-
 Performance/Size:
   Enabled: true
 

data/bixby_rails_enabled.yml

@@ -1,4 +1,6 @@
 ---
+require: rubocop-rails
+
 Rails:
   Enabled: true
 
@@ -14,6 +16,12 @@ Rails/Delegate:
 Rails/DelegateAllowBlank:
   Enabled: true
 
+# This one breaks things unexpectedly.
+# E.g., it changes ISO_639.find_by_code(language_code) to ISO_639.find_by(code: language_code)
+# which results in an error. 
+Rails/DynamicFindBy:
+  Enabled: false
+
 Rails/EnumUniqueness:
   Enabled: true
 
@@ -22,6 +30,7 @@ Rails/Exit:
 
 Rails/FilePath:
   Enabled: true
+  EnforcedStyle: arguments
 
 Rails/FindBy:
   Enabled: true
@@ -32,12 +41,21 @@ Rails/FindEach:
 Rails/HasAndBelongsToMany:
   Enabled: true
 
+Rails/HelperInstanceVariable:
+  Enabled: false
+
 Rails/HttpPositionalArguments:
   Enabled: true
   Include:
     - 'spec/**/*'
     - 'test/**/*'
 
+Rails/InverseOf:
+  Enabled: false
+
+Rails/LexicallyScopedActionFilter:
+  Enabled: false
+
 Rails/NotNullColumn:
   Enabled: true
 
@@ -76,4 +94,3 @@ Rails/SkipsModelValidations:
 
 Rails/Validation:
   Enabled: true
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bixby
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Tom Johnson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-10 00:00:00.000000000 Z
+date: 2020-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.63.1
+        version: 0.85.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.63.1
+        version: 0.85.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.31.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.31.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: github_changelog_generator
   requirement: !ruby/object:Gem::Requirement
@@ -59,13 +87,17 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".github_changelog_generator"
 - ".gitignore"
 - CHANGELOG.md
+- CODE_OF_CONDUCT.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
+- SUPPORT.md
 - bixby.gemspec
 - bixby_default.yml
 - bixby_rails_enabled.yml
@@ -90,7 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: This is the recommended style configuration for use by Samvera Community