bixby 2.0.0 → 3.0.0.pre1

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 98071ddaf1aae7fa578581301c5c0e633dbdcb347bf20119a598f99a4d134b87
4
- data.tar.gz: 6e1404ed5873453783a7050215a9cfd57b378b16d249e1da61b092aea6a8e6f1
3
+ metadata.gz: 4f07da8056fc98d1f17ee4d58e4dc3e12e2e2fa529438ec727d7a6de51f8d736
4
+ data.tar.gz: 8ca94962b168caea3563cc9227ea17916a7c16100dc85d05ae3fa0bf1b8fad55
5
5
  SHA512:
6
- metadata.gz: c36a71ff3335fd24e72773a636030943f1a1782d643d6d3a57e5b69c8038a6a7b90a337222f54952f375f3938ea433160f484010c25eade5824c1e174d0fdbba
7
- data.tar.gz: cc4f54449fdf1457c93d376cf3d224fd1c1a4b8965d7916b92418b74680aac319ceb3745114d84d8ef54197870c3465fab2b3662a603dd7a71c26a1c118231e0
6
+ metadata.gz: b25c624142a5a960c0681076e7c075217ee940d20701d4dfc57c528f2a2a46e53e218ad7ccd7eb202a6113d5bc1de119991129691292f4c72ac46a05bfd90d5f
7
+ data.tar.gz: 607d7530ff3f51ab54553d47e5c40aa8128a5a9b8aa8223b3912b6d96d0efa95e8de72f741d8b02227be109e7bac1ddae630621d9b6807eaf9aa6388778bd672
@@ -0,0 +1,55 @@
1
+ version: 2.1
2
+
3
+ orbs:
4
+ samvera: samvera/circleci-orb@0
5
+
6
+ jobs:
7
+ bundle_lint_test:
8
+ parameters:
9
+ ruby_version:
10
+ type: string
11
+ project:
12
+ type: string
13
+ bundler_version:
14
+ type: string
15
+ default: 1.17.3
16
+
17
+ executor:
18
+ name: 'samvera/ruby'
19
+ ruby_version: << parameters.ruby_version >>
20
+
21
+ steps:
22
+ - samvera/cached_checkout
23
+
24
+ - samvera/bundle_for_gem:
25
+ ruby_version: << parameters.ruby_version >>
26
+ bundler_version: << parameters.bundler_version >>
27
+ project: << parameters.project >>
28
+ cache_version: '2'
29
+
30
+ - samvera/rubocop
31
+
32
+ workflows:
33
+ version: 2
34
+ ci:
35
+ jobs:
36
+ - bundle_lint_test:
37
+ project: bixby
38
+ name: ruby2-4
39
+ ruby_version: 2.4.10
40
+
41
+ - bundle_lint_test:
42
+ project: bixby
43
+ name: ruby2-5
44
+ ruby_version: 2.5.8
45
+
46
+ - bundle_lint_test:
47
+ project: bixby
48
+ name: ruby2-6
49
+ ruby_version: 2.6.6
50
+
51
+ - bundle_lint_test:
52
+ project: bixby
53
+ name: ruby2-7
54
+ ruby_version: 2.7.1
55
+
@@ -1,2 +1,2 @@
1
1
  unreleased=true
2
- future-release=2.0.0
2
+ future-release=3.0.0
@@ -1,19 +1,29 @@
1
1
  # Changelog
2
2
 
3
- ## [2.0.0](https://github.com/samvera-labs/bixby/tree/2.0.0) (2019-12-10)
3
+ ## [v2.1.0](https://github.com/samvera-labs/bixby/tree/v2.1.0) (2020-06-09)
4
4
 
5
- [Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.0.0.pre.beta1...2.0.0)
5
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.0.0...v2.1.0)
6
+
7
+ **Merged pull requests:**
8
+
9
+ - Prep for 2.1.0 release [#36](https://github.com/samvera-labs/bixby/pull/36) ([bess](https://github.com/bess))
10
+ - Upgrade rubocop and dependencies [#35](https://github.com/samvera-labs/bixby/pull/35) ([bess](https://github.com/bess))
11
+ - Prep for 2.0 release [#31](https://github.com/samvera-labs/bixby/pull/31) ([bess](https://github.com/bess))
12
+
13
+ ## [v2.0.0](https://github.com/samvera-labs/bixby/tree/v2.0.0) (2019-12-10)
14
+
15
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.0.0.pre.beta1...v2.0.0)
6
16
 
7
17
  **Closed issues:**
8
18
 
9
- - Upgrade for new rubocop [\#26](https://github.com/samvera-labs/bixby/issues/26)
10
- - Update rubocop-rspec [\#25](https://github.com/samvera-labs/bixby/issues/25)
11
- - Lint/BlockAlignment has the wrong namespace - should be Layout [\#24](https://github.com/samvera-labs/bixby/issues/24)
12
- - Add Lint/RescueWithoutErrorClass [\#23](https://github.com/samvera-labs/bixby/issues/23)
19
+ - Upgrade for new rubocop [#26](https://github.com/samvera-labs/bixby/issues/26)
20
+ - Update rubocop-rspec [#25](https://github.com/samvera-labs/bixby/issues/25)
21
+ - Lint/BlockAlignment has the wrong namespace - should be Layout [#24](https://github.com/samvera-labs/bixby/issues/24)
22
+ - Add Lint/RescueWithoutErrorClass [#23](https://github.com/samvera-labs/bixby/issues/23)
13
23
 
14
24
  **Merged pull requests:**
15
25
 
16
- - Skipping node\_modules directory when running cops [\#30](https://github.com/samvera-labs/bixby/pull/30) ([cgalarza](https://github.com/cgalarza))
26
+ - Skipping node_modules directory when running cops [#30](https://github.com/samvera-labs/bixby/pull/30) ([cgalarza](https://github.com/cgalarza))
17
27
 
18
28
  ## [v2.0.0.pre.beta1](https://github.com/samvera-labs/bixby/tree/v2.0.0.pre.beta1) (2019-02-14)
19
29
 
@@ -21,7 +31,7 @@
21
31
 
22
32
  **Merged pull requests:**
23
33
 
24
- - Bixby 2.0 [\#28](https://github.com/samvera-labs/bixby/pull/28) ([no-reply](https://github.com/no-reply))
34
+ - Bixby 2.0 [#28](https://github.com/samvera-labs/bixby/pull/28) ([no-reply](https://github.com/no-reply))
25
35
 
26
36
  ## [1.0.0](https://github.com/samvera-labs/bixby/tree/1.0.0) (2018-02-13)
27
37
 
@@ -29,7 +39,7 @@
29
39
 
30
40
  **Merged pull requests:**
31
41
 
32
- - Prepare Release 1.0.0 [\#22](https://github.com/samvera-labs/bixby/pull/22) ([no-reply](https://github.com/no-reply))
42
+ - Prepare Release 1.0.0 [#22](https://github.com/samvera-labs/bixby/pull/22) ([no-reply](https://github.com/no-reply))
33
43
 
34
44
  ## [v1.0.0-rc1](https://github.com/samvera-labs/bixby/tree/v1.0.0-rc1) (2018-02-09)
35
45
 
@@ -37,20 +47,19 @@
37
47
 
38
48
  **Closed issues:**
39
49
 
40
- - Disable `RSpec/MulitpleExpectations` [\#19](https://github.com/samvera-labs/bixby/issues/19)
41
- - Add tmp dir to AllCops exclusion [\#18](https://github.com/samvera-labs/bixby/issues/18)
42
- - Warning: unrecognized cop Naming/BinaryOperatorParameter found in ~/.gem/ruby/2.4.2/gems/bixby-0.3.0/bixby\_default.yml [\#14](https://github.com/samvera-labs/bixby/issues/14)
43
- - Resolve new cops/changes is in rubocop-rspec 0.18.0. [\#11](https://github.com/samvera-labs/bixby/issues/11)
44
- - Resolve new cops/changes in RuboCop 0.50.0 [\#10](https://github.com/samvera-labs/bixby/issues/10)
45
- - Bixby not compatible with latest Rubocop [\#6](https://github.com/samvera-labs/bixby/issues/6)
50
+ - Disable `RSpec/MulitpleExpectations` [#19](https://github.com/samvera-labs/bixby/issues/19)
51
+ - Add tmp dir to AllCops exclusion [#18](https://github.com/samvera-labs/bixby/issues/18)
52
+ - Warning: unrecognized cop Naming/BinaryOperatorParameter found in ~/.gem/ruby/2.4.2/gems/bixby-0.3.0/bixby_default.yml [#14](https://github.com/samvera-labs/bixby/issues/14)
53
+ - Resolve new cops/changes is in rubocop-rspec 0.18.0\. [#11](https://github.com/samvera-labs/bixby/issues/11)
54
+ - Resolve new cops/changes in RuboCop 0.50.0 [#10](https://github.com/samvera-labs/bixby/issues/10)
55
+ - Bixby not compatible with latest Rubocop [#6](https://github.com/samvera-labs/bixby/issues/6)
46
56
 
47
57
  **Merged pull requests:**
48
58
 
49
- - Bump version to 1.0.0-rc1 [\#21](https://github.com/samvera-labs/bixby/pull/21) ([no-reply](https://github.com/no-reply))
50
- - Support newer versions of `rubocop`, `rubocop-rspec`, and Ruby [\#20](https://github.com/samvera-labs/bixby/pull/20) ([no-reply](https://github.com/no-reply))
51
- - Remove Lint/InvalidCharacterLiteral, fixes \#15 [\#16](https://github.com/samvera-labs/bixby/pull/16) ([hackmastera](https://github.com/hackmastera))
52
- - Update READEME.md to discuss versioning strategy [\#13](https://github.com/samvera-labs/bixby/pull/13) ([no-reply](https://github.com/no-reply))
53
- - Lock versions to `rubocop` 0.50.0 and `rubocop-rspec` 1.18.0 [\#12](https://github.com/samvera-labs/bixby/pull/12) ([no-reply](https://github.com/no-reply))
59
+ - Bump version to 1.0.0-rc1 [#21](https://github.com/samvera-labs/bixby/pull/21) ([no-reply](https://github.com/no-reply))
60
+ - Support newer versions of `rubocop`, `rubocop-rspec`, and Ruby [#20](https://github.com/samvera-labs/bixby/pull/20) ([no-reply](https://github.com/no-reply))
61
+ - Remove Lint/InvalidCharacterLiteral, fixes #15 [#16](https://github.com/samvera-labs/bixby/pull/16) ([hackmastera](https://github.com/hackmastera))
62
+ - Lock versions to `rubocop` 0.50.0 and `rubocop-rspec` 1.18.0 [#12](https://github.com/samvera-labs/bixby/pull/12) ([no-reply](https://github.com/no-reply))
54
63
 
55
64
  ## [v0.3.1](https://github.com/samvera-labs/bixby/tree/v0.3.1) (2017-10-04)
56
65
 
@@ -58,11 +67,11 @@
58
67
 
59
68
  **Closed issues:**
60
69
 
61
- - Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. \(obsolete configuration found in /home/ubuntu/valkyrie/valkyrie/vendor/valk\_bundle/ruby/2.3.0/gems/bixby-0.3.0/bixby\_default.yml, please update it\) [\#15](https://github.com/samvera-labs/bixby/issues/15)
70
+ - Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in /home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.3.0/bixby_default.yml, please update it) [#15](https://github.com/samvera-labs/bixby/issues/15)
62
71
 
63
72
  **Merged pull requests:**
64
73
 
65
- - Remove Lint/InvalidCharacterLiteral, fixes \#15 [\#17](https://github.com/samvera-labs/bixby/pull/17) ([hackmastera](https://github.com/hackmastera))
74
+ - Remove Lint/InvalidCharacterLiteral, fixes #15 [#17](https://github.com/samvera-labs/bixby/pull/17) ([hackmastera](https://github.com/hackmastera))
66
75
 
67
76
  ## [v0.3.0](https://github.com/samvera-labs/bixby/tree/v0.3.0) (2017-10-03)
68
77
 
@@ -70,9 +79,10 @@
70
79
 
71
80
  **Merged pull requests:**
72
81
 
73
- - Prepare Release v0.3.0 [\#9](https://github.com/samvera-labs/bixby/pull/9) ([no-reply](https://github.com/no-reply))
74
- - Upgrade for RuboCop 0.50.0 compatibility [\#8](https://github.com/samvera-labs/bixby/pull/8) ([no-reply](https://github.com/no-reply))
75
- - Allow deeper group nesting in RSpec [\#7](https://github.com/samvera-labs/bixby/pull/7) ([no-reply](https://github.com/no-reply))
82
+ - Update READEME.md to discuss versioning strategy [#13](https://github.com/samvera-labs/bixby/pull/13) ([no-reply](https://github.com/no-reply))
83
+ - Prepare Release v0.3.0 [#9](https://github.com/samvera-labs/bixby/pull/9) ([no-reply](https://github.com/no-reply))
84
+ - Upgrade for RuboCop 0.50.0 compatibility [#8](https://github.com/samvera-labs/bixby/pull/8) ([no-reply](https://github.com/no-reply))
85
+ - Allow deeper group nesting in RSpec [#7](https://github.com/samvera-labs/bixby/pull/7) ([no-reply](https://github.com/no-reply))
76
86
 
77
87
  ## [v0.2.2](https://github.com/samvera-labs/bixby/tree/v0.2.2) (2017-08-07)
78
88
 
@@ -80,12 +90,12 @@
80
90
 
81
91
  **Closed issues:**
82
92
 
83
- - Should we allow long blocks in CatalogController? [\#3](https://github.com/samvera-labs/bixby/issues/3)
93
+ - Should we allow long blocks in CatalogController? [#3](https://github.com/samvera-labs/bixby/issues/3)
84
94
 
85
95
  **Merged pull requests:**
86
96
 
87
- - Ignore block and class length on CatalogController [\#5](https://github.com/samvera-labs/bixby/pull/5) ([no-reply](https://github.com/no-reply))
88
- - Include 'Capfile' in excluded filenames [\#4](https://github.com/samvera-labs/bixby/pull/4) ([mark-dce](https://github.com/mark-dce))
97
+ - Ignore block and class length on CatalogController [#5](https://github.com/samvera-labs/bixby/pull/5) ([no-reply](https://github.com/no-reply))
98
+ - Include 'Capfile' in excluded filenames [#4](https://github.com/samvera-labs/bixby/pull/4) ([mark-dce](https://github.com/mark-dce))
89
99
 
90
100
  ## [v0.2.1](https://github.com/samvera-labs/bixby/tree/v0.2.1) (2017-06-01)
91
101
 
@@ -93,13 +103,11 @@
93
103
 
94
104
  **Merged pull requests:**
95
105
 
96
- - Add bundler release tasks for easier gem management [\#2](https://github.com/samvera-labs/bixby/pull/2) ([bess](https://github.com/bess))
97
- - Rubocop 0 49 fixes [\#1](https://github.com/samvera-labs/bixby/pull/1) ([bess](https://github.com/bess))
106
+ - Add bundler release tasks for easier gem management [#2](https://github.com/samvera-labs/bixby/pull/2) ([bess](https://github.com/bess))
107
+ - Rubocop 0 49 fixes [#1](https://github.com/samvera-labs/bixby/pull/1) ([bess](https://github.com/bess))
98
108
 
99
109
  ## [v0.2.0](https://github.com/samvera-labs/bixby/tree/v0.2.0) (2017-03-30)
100
110
 
101
111
  [Full Changelog](https://github.com/samvera-labs/bixby/compare/8f95541b23cfda44c8a89704127696262284215a...v0.2.0)
102
112
 
103
-
104
-
105
- \* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*
113
+ * _This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)_
@@ -0,0 +1,36 @@
1
+ The Samvera community is dedicated to providing a welcoming and
2
+ positive experience for all its members, whether they are at a formal
3
+ gathering, in a social setting, or taking part in activities online.
4
+ The Samvera community welcomes participation from people all over the
5
+ world and these members bring with them a wide variety of
6
+ professional, personal and social backgrounds; whatever these may be,
7
+ we treat colleagues with dignity and respect.
8
+
9
+ Community members communicate primarily in English, though for many of
10
+ them this is not their native language. We therefore strive to express
11
+ ourselves simply and clearly remembering that unnecessary use of
12
+ jargon and slang will be a barrier to understanding for many of our
13
+ colleagues. We are sensitive to the fact that the international
14
+ nature of the community means that we span many different social norms
15
+ around language and behaviour and we strive to conduct ourselves,
16
+ online and in person, in ways that are unlikely to cause offence.
17
+
18
+ Samvera conversations are often information-rich and intended to
19
+ generate discussion and debate. We discuss ideas from a standpoint of
20
+ mutual respect and reasoned argument.
21
+
22
+ Community members work together to promote a respectful and safe
23
+ community. In the event that someone’s conduct is causing offence or
24
+ distress, Samvera has a detailed
25
+ [Anti-Harassment Policy and Protocol](https://wiki.duraspace.org/display/samvera/Anti-Harassment+Policy)
26
+ which can be applied to address the problem. The first step in dealing
27
+ with any serious misconduct is to contact a local meeting organizer,
28
+ the
29
+ [Samvera community helpers](https://wiki.duraspace.org/display/samvera/Samvera+Community+Helpers)
30
+ ([email](mailto:helpers@samvera.org)), a community member you
31
+ trust, or the
32
+ [Samvera Steering Group](https://wiki.duraspace.org/display/samvera/Samvera+Steering+Group+membership)
33
+ immediately; at Samvera events, these people can be identified by
34
+ distinctive name badges. The
35
+ [Policy and Protocol](https://wiki.duraspace.org/display/samvera/Anti-Harassment+Policy)
36
+ should be consulted for fuller details.
@@ -0,0 +1,161 @@
1
+ # How to Contribute
2
+
3
+ We want your help to make the Samvera community great. There are a few guidelines
4
+ that we need contributors to follow so that we can have a chance of
5
+ keeping on top of things.
6
+
7
+ ## Code of Conduct
8
+
9
+ The Samvera Community is dedicated to providing a welcoming and positive
10
+ experience for all its members, whether they are at a formal gathering, in
11
+ a social setting, or taking part in activities online. Please see our
12
+ [Code of Conduct](CODE_OF_CONDUCT.md) for more information.
13
+
14
+ ## Samvera Community Intellectual Property Licensing and Ownership
15
+
16
+ All code contributors must have an Individual Contributor License Agreement
17
+ (iCLA) on file with the Samvera Steering Group. If the contributor works for
18
+ an institution, the institution must have a Corporate Contributor License
19
+ Agreement (cCLA) on file.
20
+
21
+ https://wiki.duraspace.org/display/samvera/Samvera+Community+Intellectual+Property+Licensing+and+Ownership
22
+
23
+ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the project.
24
+
25
+ ## Contribution Tasks
26
+
27
+ * Reporting Issues
28
+ * Making Changes
29
+ * Documenting Code
30
+ * Committing Changes
31
+ * Submitting Changes
32
+ * Reviewing and Merging Changes
33
+
34
+ ### Reporting Issues
35
+
36
+ * Make sure you have a [GitHub account](https://github.com/signup/free)
37
+ * Submit a [Github issue](https://github.com/samvera/bixby/issues/) by:
38
+ * Clearly describing the issue
39
+ * Provide a descriptive summary
40
+ * Explain the expected behavior
41
+ * Explain the actual behavior
42
+ * Provide steps to reproduce the actual behavior
43
+
44
+ ### Making Changes
45
+
46
+ * Fork the repository on GitHub
47
+ * Create a topic branch from where you want to base your work.
48
+ * This is usually the master branch.
49
+ * To quickly create a topic branch based on master; `git branch fix/master/my_contribution master`
50
+ * Then checkout the new branch with `git checkout fix/master/my_contribution`.
51
+ * Please avoid working directly on the `master` branch.
52
+ * You may find the [hub suite of commands](https://github.com/defunkt/hub) helpful
53
+ * Make sure you have added sufficient tests and documentation for your changes.
54
+ * Test functionality with RSpec; Test features / UI with Capybara.
55
+ * Run _all_ the tests to assure nothing else was accidentally broken.
56
+
57
+ ### Documenting Code
58
+
59
+ * All new public methods, modules, and classes should include inline documentation in [YARD](http://yardoc.org/).
60
+ * Documentation should seek to answer the question "why does this code exist?"
61
+ * Document private / protected methods as desired.
62
+ * If you are working in a file with no prior documentation, do try to document as you gain understanding of the code.
63
+ * If you don't know exactly what a bit of code does, it is extra likely that it needs to be documented. Take a stab at it and ask for feedback in your pull request. You can use the 'blame' button on GitHub to identify the original developer of the code and @mention them in your comment.
64
+ * This work greatly increases the usability of the code base and supports the on-ramping of new committers.
65
+ * We will all be understanding of one another's time constraints in this area.
66
+ * [Getting started with YARD](http://www.rubydoc.info/gems/yard/file/docs/GettingStarted.md)
67
+
68
+ ### Committing changes
69
+
70
+ * Make commits of logical units.
71
+ * Check for unnecessary whitespace with `git diff --check` before committing.
72
+ * Make sure your commit messages are [well formed](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
73
+ * If you created an issue, you can close it by including "Closes #issue" in your commit message. See [Github's blog post for more details](https://github.com/blog/1386-closing-issues-via-commit-messages)
74
+
75
+ ```
76
+ Present tense short summary (50 characters or less)
77
+
78
+ More detailed description, if necessary. It should be wrapped to 72
79
+ characters. Try to be as descriptive as you can, even if you think that
80
+ the commit content is obvious, it may not be obvious to others. You
81
+ should add such description also if it's already present in bug tracker,
82
+ it should not be necessary to visit a webpage to check the history.
83
+
84
+ Include Closes #<issue-number> when relavent.
85
+
86
+ Description can have multiple paragraphs and you can use code examples
87
+ inside, just indent it with 4 spaces:
88
+
89
+ class PostsController
90
+ def index
91
+ respond_to do |wants|
92
+ wants.html { render 'index' }
93
+ end
94
+ end
95
+ end
96
+
97
+ You can also add bullet points:
98
+
99
+ - you can use dashes or asterisks
100
+
101
+ - also, try to indent next line of a point for readability, if it's too
102
+ long to fit in 72 characters
103
+ ```
104
+
105
+ * Make sure you have added the necessary tests for your changes.
106
+ * Run _all_ the tests to assure nothing else was accidentally broken.
107
+ * When you are ready to submit a pull request
108
+
109
+ ### Submitting Changes
110
+
111
+ * Read the article ["Using Pull Requests"](https://help.github.com/articles/using-pull-requests) on GitHub.
112
+ * Make sure your branch is up to date with its parent branch (i.e. master)
113
+ * `git checkout master`
114
+ * `git pull --rebase`
115
+ * `git checkout <your-branch>`
116
+ * `git rebase master`
117
+ * It is a good idea to run your tests again.
118
+ * If you've made more than one commit take a moment to consider whether squashing commits together would help improve their logical grouping.
119
+ * [Detailed Walkthrough of One Pull Request per Commit](http://ndlib.github.io/practices/one-commit-per-pull-request/)
120
+ * `git rebase --interactive master` ([See Github help](https://help.github.com/articles/interactive-rebase))
121
+ * Squashing your branch's changes into one commit is "good form" and helps the person merging your request to see everything that is going on.
122
+ * Push your changes to a topic branch in your fork of the repository.
123
+ * Submit a pull request from your fork to the project.
124
+
125
+ ### Reviewing and Merging Changes
126
+
127
+ We adopted [Github's Pull Request Review](https://help.github.com/articles/about-pull-request-reviews/) for our repositories.
128
+ Common checks that may occur in our repositories:
129
+
130
+ 1. Travis CI - where our automated tests are running
131
+ 2. Approval Required - Github enforces at least one person approve a pull request. Also, all reviewers that have chimed in must approve.
132
+
133
+ If one or more of the required checks failed (or are incomplete), the code should not be merged (and the UI will not allow it). If all of the checks have passed, then anyone on the project (including the pull request submitter) may merge the code.
134
+
135
+ *Example: Carolyn submits a pull request, Justin reviews the pull request and approves. However, Justin is still waiting on other checks (Travis CI is usually the culprit), so he does not merge the pull request. Eventually, all of the checks pass. At this point, Carolyn or anyone else may merge the pull request.*
136
+
137
+ #### Things to Consider When Reviewing
138
+
139
+ First, the person contributing the code is putting themselves out there. Be mindful of what you say in a review.
140
+
141
+ * Ask clarifying questions
142
+ * State your understanding and expectations
143
+ * Provide example code or alternate solutions, and explain why
144
+
145
+ This is your chance for a mentoring moment of another developer. Take time to give an honest and thorough review of what has changed. Things to consider:
146
+
147
+ * Does the commit message explain what is going on?
148
+ * Does the code changes have tests? _Not all changes need new tests, some changes are refactorings_
149
+ * Do new or changed methods, modules, and classes have documentation?
150
+ * Does the commit contain more than it should? Are two separate concerns being addressed in one commit?
151
+ * Does the description of the new/changed specs match your understanding of what the spec is doing?
152
+ * Did the Travis tests complete successfully?
153
+
154
+ If you are uncertain, bring other contributors into the conversation by assigning them as a reviewer.
155
+
156
+ # Additional Resources
157
+
158
+ * [General GitHub documentation](http://help.github.com/)
159
+ * [GitHub pull request documentation](https://help.github.com/articles/about-pull-requests/)
160
+ * [Pro Git](http://git-scm.com/book) is both a free and excellent book about Git.
161
+ * [A Git Config for Contributing](http://ndlib.github.io/practices/my-typical-per-project-git-config/)
data/Gemfile CHANGED
@@ -1,4 +1,5 @@
1
1
  # frozen_string_literal: true
2
+
2
3
  source 'https://rubygems.org'
3
4
 
4
5
  gemspec
data/README.md CHANGED
@@ -4,6 +4,7 @@ Bixby: I'd buy that for a dollar!
4
4
  [![Apache 2.0 License](http://img.shields.io/badge/APACHE2-license-blue.svg)](./LICENSE)
5
5
  [![Gem Version](https://badge.fury.io/rb/bixby.svg)](https://badge.fury.io/rb/bixby)
6
6
 
7
+
7
8
  <p align="left">
8
9
  <img src="https://raw.githubusercontent.com/curationexperts/hycop/master/logo/murphy.jpg" alt="Murphy Sketch"/>
9
10
  </p>
data/Rakefile CHANGED
@@ -1 +1,3 @@
1
+ # frozen_string_literal: true
2
+
1
3
  require 'bundler/gem_tasks'
@@ -0,0 +1,5 @@
1
+ If you would like to report an issue, first search [the list of issues](https://github.com/samvera/bixby/issues/) to see if someone else has already reported it, and then feel free to [create a new issue](https://github.com/samvera/bixby/issues/new).
2
+
3
+ If you have questions or need help, please email [the Samvera community tech list](https://groups.google.com/forum/#!forum/samvera-tech) or stop by the #dev channel in [the Samvera community Slack team](https://wiki.duraspace.org/pages/viewpage.action?pageId=87460391#Getintouch!-Slack).
4
+
5
+ You can learn more about the various Samvera communication channels on the [Get in touch!](https://wiki.duraspace.org/pages/viewpage.action?pageId=87460391) wiki page.
@@ -1,3 +1,5 @@
1
+ # frozen_string_literal: true
2
+
1
3
  Gem::Specification.new do |spec|
2
4
  spec.authors = ['Tom Johnson']
3
5
  spec.email = ['johnson.tom@gmail.com']
@@ -10,11 +12,13 @@ Gem::Specification.new do |spec|
10
12
  spec.name = 'bixby'
11
13
  spec.require_paths = ['lib']
12
14
 
13
- spec.version = '2.0.0'
15
+ spec.version = '3.0.0.pre1'
14
16
  spec.license = 'Apache-2.0'
15
17
 
16
- spec.add_dependency 'rubocop', '0.63.1'
17
- spec.add_dependency 'rubocop-rspec', '1.31.0'
18
+ spec.add_dependency 'rubocop', '0.85.1'
19
+ spec.add_dependency 'rubocop-performance'
20
+ spec.add_dependency 'rubocop-rails'
21
+ spec.add_dependency 'rubocop-rspec'
18
22
 
19
23
  spec.add_development_dependency 'github_changelog_generator'
20
24
  end
@@ -1,5 +1,7 @@
1
+ require: rubocop-performance
2
+
1
3
  AllCops:
2
- TargetRubyVersion: 2.3
4
+ TargetRubyVersion: 2.6
3
5
  DisabledByDefault: true
4
6
  DisplayCopNames: true
5
7
  Exclude:
@@ -40,9 +42,6 @@ Style/BlockComments:
40
42
  Style/BlockDelimiters:
41
43
  Enabled: true
42
44
 
43
- Style/BracesAroundHashParameters:
44
- Enabled: true
45
-
46
45
  Style/CaseEquality:
47
46
  Enabled: true
48
47
 
@@ -281,9 +280,15 @@ Style/RedundantReturn:
281
280
  Style/RedundantSelf:
282
281
  Enabled: true
283
282
 
283
+ Style/RedundantSortBy:
284
+ Enabled: true
285
+
284
286
  Style/RescueModifier:
285
287
  Enabled: true
286
288
 
289
+ Style/Sample:
290
+ Enabled: true
291
+
287
292
  Style/SafeNavigation:
288
293
  Enabled: true
289
294
 
@@ -336,13 +341,13 @@ Style/TrivialAccessors:
336
341
  Style/UnlessElse:
337
342
  Enabled: true
338
343
 
339
- Style/UnneededCapitalW:
344
+ Style/RedundantCapitalW:
340
345
  Enabled: true
341
346
 
342
- Style/UnneededInterpolation:
347
+ Style/RedundantInterpolation:
343
348
  Enabled: true
344
349
 
345
- Style/UnneededPercentQ:
350
+ Style/RedundantPercentQ:
346
351
  Enabled: true
347
352
 
348
353
  Style/TrailingUnderscoreVariable:
@@ -366,13 +371,13 @@ Style/ZeroLengthPredicate:
366
371
 
367
372
  #################### Layout ###############################
368
373
 
369
- Layout/AlignArray:
374
+ Layout/ArrayAlignment:
370
375
  Enabled: true
371
376
 
372
- Layout/AlignHash:
377
+ Layout/HashAlignment:
373
378
  Enabled: true
374
379
 
375
- Layout/AlignParameters:
380
+ Layout/ParameterAlignment:
376
381
  Enabled: true
377
382
 
378
383
  Layout/BlockAlignment:
@@ -432,6 +437,9 @@ Layout/EndOfLine:
432
437
  Layout/ExtraSpacing:
433
438
  Enabled: true
434
439
 
440
+ Layout/IndentationStyle:
441
+ Enabled: true
442
+
435
443
  Layout/InitialIndentation:
436
444
  Enabled: true
437
445
 
@@ -442,18 +450,18 @@ Layout/IndentationConsistency:
442
450
  SupportedStyles:
443
451
  - normal
444
452
  - rails
445
- EnforcedStyle: rails
453
+ EnforcedStyle: normal
446
454
 
447
455
  Layout/IndentationWidth:
448
456
  Enabled: true
449
457
 
450
- Layout/IndentArray:
458
+ Layout/FirstArrayElementIndentation:
451
459
  Enabled: true
452
460
 
453
- Layout/IndentAssignment:
461
+ Layout/AssignmentIndentation:
454
462
  Enabled: true
455
463
 
456
- Layout/IndentHash:
464
+ Layout/FirstHashElementIndentation:
457
465
  Enabled: true
458
466
 
459
467
  Layout/SpaceInLambdaLiteral:
@@ -462,6 +470,12 @@ Layout/SpaceInLambdaLiteral:
462
470
  Layout/LeadingCommentSpace:
463
471
  Enabled: true
464
472
 
473
+ Layout/LineLength:
474
+ Enabled: true
475
+ Max: 200
476
+ Exclude:
477
+ - '**/*.gemspec'
478
+
465
479
  Layout/MultilineArrayBraceLayout:
466
480
  Enabled: true
467
481
 
@@ -555,10 +569,7 @@ Layout/SpaceInsideRangeLiteral:
555
569
  Layout/SpaceInsideStringInterpolation:
556
570
  Enabled: true
557
571
 
558
- Layout/Tab:
559
- Enabled: true
560
-
561
- Layout/TrailingBlankLines:
572
+ Layout/TrailingEmptyLines:
562
573
  Enabled: true
563
574
 
564
575
  Layout/TrailingWhitespace:
@@ -621,12 +632,6 @@ Metrics/ModuleLength:
621
632
  Metrics/CyclomaticComplexity:
622
633
  Enabled: true
623
634
 
624
- Metrics/LineLength:
625
- Enabled: true
626
- Max: 200
627
- Exclude:
628
- - '**/*.gemspec'
629
-
630
635
  Metrics/MethodLength:
631
636
  Enabled: true
632
637
  Max: 14
@@ -671,7 +676,7 @@ Lint/DuplicateCaseCondition:
671
676
  Lint/DuplicateMethods:
672
677
  Enabled: true
673
678
 
674
- Lint/DuplicatedKey:
679
+ Lint/DuplicateHashKey:
675
680
  Enabled: true
676
681
 
677
682
  Lint/EachWithObjectArgument:
@@ -693,7 +698,7 @@ Lint/EmptyInterpolation:
693
698
  Lint/EmptyWhen:
694
699
  Enabled: true
695
700
 
696
- Lint/EndInMethod:
701
+ Style/EndBlock:
697
702
  Enabled: true
698
703
 
699
704
  Lint/EnsureReturn:
@@ -708,7 +713,7 @@ Lint/FloatOutOfRange:
708
713
  Lint/FormatParameterMismatch:
709
714
  Enabled: true
710
715
 
711
- Lint/HandleExceptions:
716
+ Lint/SuppressedException:
712
717
  Enabled: true
713
718
 
714
719
  Lint/ImplicitStringConcatenation:
@@ -729,7 +734,7 @@ Lint/LiteralInInterpolation:
729
734
  Lint/Loop:
730
735
  Enabled: true
731
736
 
732
- Lint/MultipleCompare:
737
+ Lint/MultipleComparison:
733
738
  Enabled: true
734
739
 
735
740
  Lint/NestedMethodDefinition:
@@ -769,7 +774,7 @@ Lint/ShadowedException:
769
774
  Lint/ShadowingOuterLocalVariable:
770
775
  Enabled: true
771
776
 
772
- Lint/StringConversionInInterpolation:
777
+ Lint/RedundantStringCoercion:
773
778
  Enabled: true
774
779
 
775
780
  Lint/UnderscorePrefixedVariableName:
@@ -778,7 +783,7 @@ Lint/UnderscorePrefixedVariableName:
778
783
  Lint/UnifiedInteger:
779
784
  Enabled: true
780
785
 
781
- Lint/UnneededSplatExpansion:
786
+ Lint/RedundantSplatExpansion:
782
787
  Enabled: true
783
788
 
784
789
  Lint/UnusedBlockArgument:
@@ -822,8 +827,8 @@ Performance/Count:
822
827
  # This cop has known compatibility issues with `ActiveRecord` and other
823
828
  # frameworks. ActiveRecord's `count` ignores the block that is passed to it.
824
829
  # For more information, see the documentation in the cop itself.
825
- # If you understand the known risk, you can disable `SafeMode`.
826
- SafeMode: true
830
+ # If you understand the known risk, you can disable `SafeAutoCorrect`.
831
+ SafeAutoCorrect: true
827
832
  Enabled: true
828
833
 
829
834
  Performance/Detect:
@@ -831,7 +836,7 @@ Performance/Detect:
831
836
  # frameworks. `ActiveRecord` does not implement a `detect` method and `find`
832
837
  # has its own meaning. Correcting `ActiveRecord` methods with this cop
833
838
  # should be considered unsafe.
834
- SafeMode: true
839
+ SafeAutoCorrect: true
835
840
  Enabled: true
836
841
 
837
842
  Performance/DoubleStartEndWith:
@@ -855,9 +860,6 @@ Performance/FlatMap:
855
860
  # This can be dangerous since `flat_map` will only flatten 1 level, and
856
861
  # `flatten` without any parameters can flatten multiple levels.
857
862
 
858
- Performance/LstripRstrip:
859
- Enabled: true
860
-
861
863
  Performance/RangeInclude:
862
864
  Enabled: true
863
865
 
@@ -870,18 +872,12 @@ Performance/RedundantMatch:
870
872
  Performance/RedundantMerge:
871
873
  Enabled: true
872
874
 
873
- Performance/RedundantSortBy:
874
- Enabled: true
875
-
876
875
  Performance/RegexpMatch:
877
876
  Enabled: true
878
877
 
879
878
  Performance/ReverseEach:
880
879
  Enabled: true
881
880
 
882
- Performance/Sample:
883
- Enabled: true
884
-
885
881
  Performance/Size:
886
882
  Enabled: true
887
883
 
@@ -1,4 +1,6 @@
1
1
  ---
2
+ require: rubocop-rails
3
+
2
4
  Rails:
3
5
  Enabled: true
4
6
 
@@ -76,4 +78,3 @@ Rails/SkipsModelValidations:
76
78
 
77
79
  Rails/Validation:
78
80
  Enabled: true
79
-
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: bixby
3
3
  version: !ruby/object:Gem::Version
4
- version: 2.0.0
4
+ version: 3.0.0.pre1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Tom Johnson
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2019-12-10 00:00:00.000000000 Z
11
+ date: 2020-06-10 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
@@ -16,28 +16,56 @@ dependencies:
16
16
  requirements:
17
17
  - - '='
18
18
  - !ruby/object:Gem::Version
19
- version: 0.63.1
19
+ version: 0.85.1
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - '='
25
25
  - !ruby/object:Gem::Version
26
- version: 0.63.1
26
+ version: 0.85.1
27
+ - !ruby/object:Gem::Dependency
28
+ name: rubocop-performance
29
+ requirement: !ruby/object:Gem::Requirement
30
+ requirements:
31
+ - - ">="
32
+ - !ruby/object:Gem::Version
33
+ version: '0'
34
+ type: :runtime
35
+ prerelease: false
36
+ version_requirements: !ruby/object:Gem::Requirement
37
+ requirements:
38
+ - - ">="
39
+ - !ruby/object:Gem::Version
40
+ version: '0'
41
+ - !ruby/object:Gem::Dependency
42
+ name: rubocop-rails
43
+ requirement: !ruby/object:Gem::Requirement
44
+ requirements:
45
+ - - ">="
46
+ - !ruby/object:Gem::Version
47
+ version: '0'
48
+ type: :runtime
49
+ prerelease: false
50
+ version_requirements: !ruby/object:Gem::Requirement
51
+ requirements:
52
+ - - ">="
53
+ - !ruby/object:Gem::Version
54
+ version: '0'
27
55
  - !ruby/object:Gem::Dependency
28
56
  name: rubocop-rspec
29
57
  requirement: !ruby/object:Gem::Requirement
30
58
  requirements:
31
- - - '='
59
+ - - ">="
32
60
  - !ruby/object:Gem::Version
33
- version: 1.31.0
61
+ version: '0'
34
62
  type: :runtime
35
63
  prerelease: false
36
64
  version_requirements: !ruby/object:Gem::Requirement
37
65
  requirements:
38
- - - '='
66
+ - - ">="
39
67
  - !ruby/object:Gem::Version
40
- version: 1.31.0
68
+ version: '0'
41
69
  - !ruby/object:Gem::Dependency
42
70
  name: github_changelog_generator
43
71
  requirement: !ruby/object:Gem::Requirement
@@ -59,13 +87,17 @@ executables: []
59
87
  extensions: []
60
88
  extra_rdoc_files: []
61
89
  files:
90
+ - ".circleci/config.yml"
62
91
  - ".github_changelog_generator"
63
92
  - ".gitignore"
64
93
  - CHANGELOG.md
94
+ - CODE_OF_CONDUCT.md
95
+ - CONTRIBUTING.md
65
96
  - Gemfile
66
97
  - LICENSE
67
98
  - README.md
68
99
  - Rakefile
100
+ - SUPPORT.md
69
101
  - bixby.gemspec
70
102
  - bixby_default.yml
71
103
  - bixby_rails_enabled.yml
@@ -86,11 +118,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
86
118
  version: '0'
87
119
  required_rubygems_version: !ruby/object:Gem::Requirement
88
120
  requirements:
89
- - - ">="
121
+ - - ">"
90
122
  - !ruby/object:Gem::Version
91
- version: '0'
123
+ version: 1.3.1
92
124
  requirements: []
93
- rubygems_version: 3.0.6
125
+ rubygems_version: 3.1.4
94
126
  signing_key:
95
127
  specification_version: 4
96
128
  summary: This is the recommended style configuration for use by Samvera Community