bixby 0.3.1 → 3.0.0.pre1

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
- SHA1:
3
- metadata.gz: 8a95d4383b393877f7bcf83f3d0f9e080204f85b
4
- data.tar.gz: 2aa050e4c18c4c9728e4ebb0874607654cdde042
2
+ SHA256:
3
+ metadata.gz: 4f07da8056fc98d1f17ee4d58e4dc3e12e2e2fa529438ec727d7a6de51f8d736
4
+ data.tar.gz: 8ca94962b168caea3563cc9227ea17916a7c16100dc85d05ae3fa0bf1b8fad55
5
5
  SHA512:
6
- metadata.gz: 5ed8f5d68cd266767628d0a091e581577077f20744df2bd355a9eb617c575c5980432fddd47ea93367321e9357a53aced6eebcb7def2e4d8354dc7168ba51fad
7
- data.tar.gz: 9ae7e3ccffaf51e7e0d3823f7e19a90407b62064c8b95bb9078ce76e4721139a52da23c7d5bb445ff0a416b443797379e97ea28d8564dacc2916af74656c7e4c
6
+ metadata.gz: b25c624142a5a960c0681076e7c075217ee940d20701d4dfc57c528f2a2a46e53e218ad7ccd7eb202a6113d5bc1de119991129691292f4c72ac46a05bfd90d5f
7
+ data.tar.gz: 607d7530ff3f51ab54553d47e5c40aa8128a5a9b8aa8223b3912b6d96d0efa95e8de72f741d8b02227be109e7bac1ddae630621d9b6807eaf9aa6388778bd672
@@ -0,0 +1,55 @@
1
+ version: 2.1
2
+
3
+ orbs:
4
+ samvera: samvera/circleci-orb@0
5
+
6
+ jobs:
7
+ bundle_lint_test:
8
+ parameters:
9
+ ruby_version:
10
+ type: string
11
+ project:
12
+ type: string
13
+ bundler_version:
14
+ type: string
15
+ default: 1.17.3
16
+
17
+ executor:
18
+ name: 'samvera/ruby'
19
+ ruby_version: << parameters.ruby_version >>
20
+
21
+ steps:
22
+ - samvera/cached_checkout
23
+
24
+ - samvera/bundle_for_gem:
25
+ ruby_version: << parameters.ruby_version >>
26
+ bundler_version: << parameters.bundler_version >>
27
+ project: << parameters.project >>
28
+ cache_version: '2'
29
+
30
+ - samvera/rubocop
31
+
32
+ workflows:
33
+ version: 2
34
+ ci:
35
+ jobs:
36
+ - bundle_lint_test:
37
+ project: bixby
38
+ name: ruby2-4
39
+ ruby_version: 2.4.10
40
+
41
+ - bundle_lint_test:
42
+ project: bixby
43
+ name: ruby2-5
44
+ ruby_version: 2.5.8
45
+
46
+ - bundle_lint_test:
47
+ project: bixby
48
+ name: ruby2-6
49
+ ruby_version: 2.6.6
50
+
51
+ - bundle_lint_test:
52
+ project: bixby
53
+ name: ruby2-7
54
+ ruby_version: 2.7.1
55
+
@@ -0,0 +1,2 @@
1
+ unreleased=true
2
+ future-release=3.0.0
data/.gitignore CHANGED
@@ -48,3 +48,4 @@ build-iPhoneSimulator/
48
48
 
49
49
  # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
50
50
  .rvmrc
51
+ Gemfile.lock
@@ -0,0 +1,113 @@
1
+ # Changelog
2
+
3
+ ## [v2.1.0](https://github.com/samvera-labs/bixby/tree/v2.1.0) (2020-06-09)
4
+
5
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.0.0...v2.1.0)
6
+
7
+ **Merged pull requests:**
8
+
9
+ - Prep for 2.1.0 release [#36](https://github.com/samvera-labs/bixby/pull/36) ([bess](https://github.com/bess))
10
+ - Upgrade rubocop and dependencies [#35](https://github.com/samvera-labs/bixby/pull/35) ([bess](https://github.com/bess))
11
+ - Prep for 2.0 release [#31](https://github.com/samvera-labs/bixby/pull/31) ([bess](https://github.com/bess))
12
+
13
+ ## [v2.0.0](https://github.com/samvera-labs/bixby/tree/v2.0.0) (2019-12-10)
14
+
15
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.0.0.pre.beta1...v2.0.0)
16
+
17
+ **Closed issues:**
18
+
19
+ - Upgrade for new rubocop [#26](https://github.com/samvera-labs/bixby/issues/26)
20
+ - Update rubocop-rspec [#25](https://github.com/samvera-labs/bixby/issues/25)
21
+ - Lint/BlockAlignment has the wrong namespace - should be Layout [#24](https://github.com/samvera-labs/bixby/issues/24)
22
+ - Add Lint/RescueWithoutErrorClass [#23](https://github.com/samvera-labs/bixby/issues/23)
23
+
24
+ **Merged pull requests:**
25
+
26
+ - Skipping node_modules directory when running cops [#30](https://github.com/samvera-labs/bixby/pull/30) ([cgalarza](https://github.com/cgalarza))
27
+
28
+ ## [v2.0.0.pre.beta1](https://github.com/samvera-labs/bixby/tree/v2.0.0.pre.beta1) (2019-02-14)
29
+
30
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/1.0.0...v2.0.0.pre.beta1)
31
+
32
+ **Merged pull requests:**
33
+
34
+ - Bixby 2.0 [#28](https://github.com/samvera-labs/bixby/pull/28) ([no-reply](https://github.com/no-reply))
35
+
36
+ ## [1.0.0](https://github.com/samvera-labs/bixby/tree/1.0.0) (2018-02-13)
37
+
38
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v1.0.0-rc1...1.0.0)
39
+
40
+ **Merged pull requests:**
41
+
42
+ - Prepare Release 1.0.0 [#22](https://github.com/samvera-labs/bixby/pull/22) ([no-reply](https://github.com/no-reply))
43
+
44
+ ## [v1.0.0-rc1](https://github.com/samvera-labs/bixby/tree/v1.0.0-rc1) (2018-02-09)
45
+
46
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v0.3.1...v1.0.0-rc1)
47
+
48
+ **Closed issues:**
49
+
50
+ - Disable `RSpec/MulitpleExpectations` [#19](https://github.com/samvera-labs/bixby/issues/19)
51
+ - Add tmp dir to AllCops exclusion [#18](https://github.com/samvera-labs/bixby/issues/18)
52
+ - Warning: unrecognized cop Naming/BinaryOperatorParameter found in ~/.gem/ruby/2.4.2/gems/bixby-0.3.0/bixby_default.yml [#14](https://github.com/samvera-labs/bixby/issues/14)
53
+ - Resolve new cops/changes is in rubocop-rspec 0.18.0\. [#11](https://github.com/samvera-labs/bixby/issues/11)
54
+ - Resolve new cops/changes in RuboCop 0.50.0 [#10](https://github.com/samvera-labs/bixby/issues/10)
55
+ - Bixby not compatible with latest Rubocop [#6](https://github.com/samvera-labs/bixby/issues/6)
56
+
57
+ **Merged pull requests:**
58
+
59
+ - Bump version to 1.0.0-rc1 [#21](https://github.com/samvera-labs/bixby/pull/21) ([no-reply](https://github.com/no-reply))
60
+ - Support newer versions of `rubocop`, `rubocop-rspec`, and Ruby [#20](https://github.com/samvera-labs/bixby/pull/20) ([no-reply](https://github.com/no-reply))
61
+ - Remove Lint/InvalidCharacterLiteral, fixes #15 [#16](https://github.com/samvera-labs/bixby/pull/16) ([hackmastera](https://github.com/hackmastera))
62
+ - Lock versions to `rubocop` 0.50.0 and `rubocop-rspec` 1.18.0 [#12](https://github.com/samvera-labs/bixby/pull/12) ([no-reply](https://github.com/no-reply))
63
+
64
+ ## [v0.3.1](https://github.com/samvera-labs/bixby/tree/v0.3.1) (2017-10-04)
65
+
66
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v0.3.0...v0.3.1)
67
+
68
+ **Closed issues:**
69
+
70
+ - Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in /home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.3.0/bixby_default.yml, please update it) [#15](https://github.com/samvera-labs/bixby/issues/15)
71
+
72
+ **Merged pull requests:**
73
+
74
+ - Remove Lint/InvalidCharacterLiteral, fixes #15 [#17](https://github.com/samvera-labs/bixby/pull/17) ([hackmastera](https://github.com/hackmastera))
75
+
76
+ ## [v0.3.0](https://github.com/samvera-labs/bixby/tree/v0.3.0) (2017-10-03)
77
+
78
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v0.2.2...v0.3.0)
79
+
80
+ **Merged pull requests:**
81
+
82
+ - Update READEME.md to discuss versioning strategy [#13](https://github.com/samvera-labs/bixby/pull/13) ([no-reply](https://github.com/no-reply))
83
+ - Prepare Release v0.3.0 [#9](https://github.com/samvera-labs/bixby/pull/9) ([no-reply](https://github.com/no-reply))
84
+ - Upgrade for RuboCop 0.50.0 compatibility [#8](https://github.com/samvera-labs/bixby/pull/8) ([no-reply](https://github.com/no-reply))
85
+ - Allow deeper group nesting in RSpec [#7](https://github.com/samvera-labs/bixby/pull/7) ([no-reply](https://github.com/no-reply))
86
+
87
+ ## [v0.2.2](https://github.com/samvera-labs/bixby/tree/v0.2.2) (2017-08-07)
88
+
89
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v0.2.1...v0.2.2)
90
+
91
+ **Closed issues:**
92
+
93
+ - Should we allow long blocks in CatalogController? [#3](https://github.com/samvera-labs/bixby/issues/3)
94
+
95
+ **Merged pull requests:**
96
+
97
+ - Ignore block and class length on CatalogController [#5](https://github.com/samvera-labs/bixby/pull/5) ([no-reply](https://github.com/no-reply))
98
+ - Include 'Capfile' in excluded filenames [#4](https://github.com/samvera-labs/bixby/pull/4) ([mark-dce](https://github.com/mark-dce))
99
+
100
+ ## [v0.2.1](https://github.com/samvera-labs/bixby/tree/v0.2.1) (2017-06-01)
101
+
102
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v0.2.0...v0.2.1)
103
+
104
+ **Merged pull requests:**
105
+
106
+ - Add bundler release tasks for easier gem management [#2](https://github.com/samvera-labs/bixby/pull/2) ([bess](https://github.com/bess))
107
+ - Rubocop 0 49 fixes [#1](https://github.com/samvera-labs/bixby/pull/1) ([bess](https://github.com/bess))
108
+
109
+ ## [v0.2.0](https://github.com/samvera-labs/bixby/tree/v0.2.0) (2017-03-30)
110
+
111
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/8f95541b23cfda44c8a89704127696262284215a...v0.2.0)
112
+
113
+ * _This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)_
@@ -0,0 +1,36 @@
1
+ The Samvera community is dedicated to providing a welcoming and
2
+ positive experience for all its members, whether they are at a formal
3
+ gathering, in a social setting, or taking part in activities online.
4
+ The Samvera community welcomes participation from people all over the
5
+ world and these members bring with them a wide variety of
6
+ professional, personal and social backgrounds; whatever these may be,
7
+ we treat colleagues with dignity and respect.
8
+
9
+ Community members communicate primarily in English, though for many of
10
+ them this is not their native language. We therefore strive to express
11
+ ourselves simply and clearly remembering that unnecessary use of
12
+ jargon and slang will be a barrier to understanding for many of our
13
+ colleagues. We are sensitive to the fact that the international
14
+ nature of the community means that we span many different social norms
15
+ around language and behaviour and we strive to conduct ourselves,
16
+ online and in person, in ways that are unlikely to cause offence.
17
+
18
+ Samvera conversations are often information-rich and intended to
19
+ generate discussion and debate. We discuss ideas from a standpoint of
20
+ mutual respect and reasoned argument.
21
+
22
+ Community members work together to promote a respectful and safe
23
+ community. In the event that someone’s conduct is causing offence or
24
+ distress, Samvera has a detailed
25
+ [Anti-Harassment Policy and Protocol](https://wiki.duraspace.org/display/samvera/Anti-Harassment+Policy)
26
+ which can be applied to address the problem. The first step in dealing
27
+ with any serious misconduct is to contact a local meeting organizer,
28
+ the
29
+ [Samvera community helpers](https://wiki.duraspace.org/display/samvera/Samvera+Community+Helpers)
30
+ ([email](mailto:helpers@samvera.org)), a community member you
31
+ trust, or the
32
+ [Samvera Steering Group](https://wiki.duraspace.org/display/samvera/Samvera+Steering+Group+membership)
33
+ immediately; at Samvera events, these people can be identified by
34
+ distinctive name badges. The
35
+ [Policy and Protocol](https://wiki.duraspace.org/display/samvera/Anti-Harassment+Policy)
36
+ should be consulted for fuller details.
@@ -0,0 +1,161 @@
1
+ # How to Contribute
2
+
3
+ We want your help to make the Samvera community great. There are a few guidelines
4
+ that we need contributors to follow so that we can have a chance of
5
+ keeping on top of things.
6
+
7
+ ## Code of Conduct
8
+
9
+ The Samvera Community is dedicated to providing a welcoming and positive
10
+ experience for all its members, whether they are at a formal gathering, in
11
+ a social setting, or taking part in activities online. Please see our
12
+ [Code of Conduct](CODE_OF_CONDUCT.md) for more information.
13
+
14
+ ## Samvera Community Intellectual Property Licensing and Ownership
15
+
16
+ All code contributors must have an Individual Contributor License Agreement
17
+ (iCLA) on file with the Samvera Steering Group. If the contributor works for
18
+ an institution, the institution must have a Corporate Contributor License
19
+ Agreement (cCLA) on file.
20
+
21
+ https://wiki.duraspace.org/display/samvera/Samvera+Community+Intellectual+Property+Licensing+and+Ownership
22
+
23
+ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the project.
24
+
25
+ ## Contribution Tasks
26
+
27
+ * Reporting Issues
28
+ * Making Changes
29
+ * Documenting Code
30
+ * Committing Changes
31
+ * Submitting Changes
32
+ * Reviewing and Merging Changes
33
+
34
+ ### Reporting Issues
35
+
36
+ * Make sure you have a [GitHub account](https://github.com/signup/free)
37
+ * Submit a [Github issue](https://github.com/samvera/bixby/issues/) by:
38
+ * Clearly describing the issue
39
+ * Provide a descriptive summary
40
+ * Explain the expected behavior
41
+ * Explain the actual behavior
42
+ * Provide steps to reproduce the actual behavior
43
+
44
+ ### Making Changes
45
+
46
+ * Fork the repository on GitHub
47
+ * Create a topic branch from where you want to base your work.
48
+ * This is usually the master branch.
49
+ * To quickly create a topic branch based on master; `git branch fix/master/my_contribution master`
50
+ * Then checkout the new branch with `git checkout fix/master/my_contribution`.
51
+ * Please avoid working directly on the `master` branch.
52
+ * You may find the [hub suite of commands](https://github.com/defunkt/hub) helpful
53
+ * Make sure you have added sufficient tests and documentation for your changes.
54
+ * Test functionality with RSpec; Test features / UI with Capybara.
55
+ * Run _all_ the tests to assure nothing else was accidentally broken.
56
+
57
+ ### Documenting Code
58
+
59
+ * All new public methods, modules, and classes should include inline documentation in [YARD](http://yardoc.org/).
60
+ * Documentation should seek to answer the question "why does this code exist?"
61
+ * Document private / protected methods as desired.
62
+ * If you are working in a file with no prior documentation, do try to document as you gain understanding of the code.
63
+ * If you don't know exactly what a bit of code does, it is extra likely that it needs to be documented. Take a stab at it and ask for feedback in your pull request. You can use the 'blame' button on GitHub to identify the original developer of the code and @mention them in your comment.
64
+ * This work greatly increases the usability of the code base and supports the on-ramping of new committers.
65
+ * We will all be understanding of one another's time constraints in this area.
66
+ * [Getting started with YARD](http://www.rubydoc.info/gems/yard/file/docs/GettingStarted.md)
67
+
68
+ ### Committing changes
69
+
70
+ * Make commits of logical units.
71
+ * Check for unnecessary whitespace with `git diff --check` before committing.
72
+ * Make sure your commit messages are [well formed](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
73
+ * If you created an issue, you can close it by including "Closes #issue" in your commit message. See [Github's blog post for more details](https://github.com/blog/1386-closing-issues-via-commit-messages)
74
+
75
+ ```
76
+ Present tense short summary (50 characters or less)
77
+
78
+ More detailed description, if necessary. It should be wrapped to 72
79
+ characters. Try to be as descriptive as you can, even if you think that
80
+ the commit content is obvious, it may not be obvious to others. You
81
+ should add such description also if it's already present in bug tracker,
82
+ it should not be necessary to visit a webpage to check the history.
83
+
84
+ Include Closes #<issue-number> when relavent.
85
+
86
+ Description can have multiple paragraphs and you can use code examples
87
+ inside, just indent it with 4 spaces:
88
+
89
+ class PostsController
90
+ def index
91
+ respond_to do |wants|
92
+ wants.html { render 'index' }
93
+ end
94
+ end
95
+ end
96
+
97
+ You can also add bullet points:
98
+
99
+ - you can use dashes or asterisks
100
+
101
+ - also, try to indent next line of a point for readability, if it's too
102
+ long to fit in 72 characters
103
+ ```
104
+
105
+ * Make sure you have added the necessary tests for your changes.
106
+ * Run _all_ the tests to assure nothing else was accidentally broken.
107
+ * When you are ready to submit a pull request
108
+
109
+ ### Submitting Changes
110
+
111
+ * Read the article ["Using Pull Requests"](https://help.github.com/articles/using-pull-requests) on GitHub.
112
+ * Make sure your branch is up to date with its parent branch (i.e. master)
113
+ * `git checkout master`
114
+ * `git pull --rebase`
115
+ * `git checkout <your-branch>`
116
+ * `git rebase master`
117
+ * It is a good idea to run your tests again.
118
+ * If you've made more than one commit take a moment to consider whether squashing commits together would help improve their logical grouping.
119
+ * [Detailed Walkthrough of One Pull Request per Commit](http://ndlib.github.io/practices/one-commit-per-pull-request/)
120
+ * `git rebase --interactive master` ([See Github help](https://help.github.com/articles/interactive-rebase))
121
+ * Squashing your branch's changes into one commit is "good form" and helps the person merging your request to see everything that is going on.
122
+ * Push your changes to a topic branch in your fork of the repository.
123
+ * Submit a pull request from your fork to the project.
124
+
125
+ ### Reviewing and Merging Changes
126
+
127
+ We adopted [Github's Pull Request Review](https://help.github.com/articles/about-pull-request-reviews/) for our repositories.
128
+ Common checks that may occur in our repositories:
129
+
130
+ 1. Travis CI - where our automated tests are running
131
+ 2. Approval Required - Github enforces at least one person approve a pull request. Also, all reviewers that have chimed in must approve.
132
+
133
+ If one or more of the required checks failed (or are incomplete), the code should not be merged (and the UI will not allow it). If all of the checks have passed, then anyone on the project (including the pull request submitter) may merge the code.
134
+
135
+ *Example: Carolyn submits a pull request, Justin reviews the pull request and approves. However, Justin is still waiting on other checks (Travis CI is usually the culprit), so he does not merge the pull request. Eventually, all of the checks pass. At this point, Carolyn or anyone else may merge the pull request.*
136
+
137
+ #### Things to Consider When Reviewing
138
+
139
+ First, the person contributing the code is putting themselves out there. Be mindful of what you say in a review.
140
+
141
+ * Ask clarifying questions
142
+ * State your understanding and expectations
143
+ * Provide example code or alternate solutions, and explain why
144
+
145
+ This is your chance for a mentoring moment of another developer. Take time to give an honest and thorough review of what has changed. Things to consider:
146
+
147
+ * Does the commit message explain what is going on?
148
+ * Does the code changes have tests? _Not all changes need new tests, some changes are refactorings_
149
+ * Do new or changed methods, modules, and classes have documentation?
150
+ * Does the commit contain more than it should? Are two separate concerns being addressed in one commit?
151
+ * Does the description of the new/changed specs match your understanding of what the spec is doing?
152
+ * Did the Travis tests complete successfully?
153
+
154
+ If you are uncertain, bring other contributors into the conversation by assigning them as a reviewer.
155
+
156
+ # Additional Resources
157
+
158
+ * [General GitHub documentation](http://help.github.com/)
159
+ * [GitHub pull request documentation](https://help.github.com/articles/about-pull-requests/)
160
+ * [Pro Git](http://git-scm.com/book) is both a free and excellent book about Git.
161
+ * [A Git Config for Contributing](http://ndlib.github.io/practices/my-typical-per-project-git-config/)
data/Gemfile ADDED
@@ -0,0 +1,5 @@
1
+ # frozen_string_literal: true
2
+
3
+ source 'https://rubygems.org'
4
+
5
+ gemspec
data/README.md CHANGED
@@ -4,6 +4,7 @@ Bixby: I'd buy that for a dollar!
4
4
  [![Apache 2.0 License](http://img.shields.io/badge/APACHE2-license-blue.svg)](./LICENSE)
5
5
  [![Gem Version](https://badge.fury.io/rb/bixby.svg)](https://badge.fury.io/rb/bixby)
6
6
 
7
+
7
8
  <p align="left">
8
9
  <img src="https://raw.githubusercontent.com/curationexperts/hycop/master/logo/murphy.jpg" alt="Murphy Sketch"/>
9
10
  </p>
@@ -25,10 +26,28 @@ inherit_gem:
25
26
  bixby: bixby_default.yml
26
27
  ```
27
28
 
29
+ ## Versioning & Dependencies
30
+
31
+ This project depends on `rubocop` and `rubocop-rspec`. It supports versions of those gems pessimistically. Beginning with release `1.0.0`, we will periodically add support for new versions of the dependencies and manage the included cops. When compatibility breaks, the major version of `bixby` will be bumped.
32
+
33
+ Our goal is to insulate downstream projects from breakage due to pre-1.0 version updates in `rubocop`.
34
+
28
35
  ## License
29
36
 
30
37
  Bixby is available under [the Apache 2.0 license](LICENSE.md).
31
38
 
39
+ ## Releasing
40
+
41
+ 1. `bundle install`
42
+ 1. Increase the version number in `bixby.gemspec`
43
+ 1. Increase the same version number in `.github_changelog_generator`
44
+ 1. Update `CHANGELOG.md` by running this command:
45
+ ```
46
+ github_changelog_generator --user samvera-labs --project bixby --token YOUR_GITHUB_TOKEN_HERE
47
+ ```
48
+ 1. Commit these changes to the master branch
49
+ 1. Run `rake release`
50
+
32
51
  ## Acknowledgments
33
52
 
34
53
  This software has been developed by and is brought to you by the Samvera community. Learn more at the
data/Rakefile CHANGED
@@ -1 +1,3 @@
1
+ # frozen_string_literal: true
2
+
1
3
  require 'bundler/gem_tasks'
@@ -0,0 +1,5 @@
1
+ If you would like to report an issue, first search [the list of issues](https://github.com/samvera/bixby/issues/) to see if someone else has already reported it, and then feel free to [create a new issue](https://github.com/samvera/bixby/issues/new).
2
+
3
+ If you have questions or need help, please email [the Samvera community tech list](https://groups.google.com/forum/#!forum/samvera-tech) or stop by the #dev channel in [the Samvera community Slack team](https://wiki.duraspace.org/pages/viewpage.action?pageId=87460391#Getintouch!-Slack).
4
+
5
+ You can learn more about the various Samvera communication channels on the [Get in touch!](https://wiki.duraspace.org/pages/viewpage.action?pageId=87460391) wiki page.
@@ -1,8 +1,8 @@
1
- # -*- encoding: utf-8 -*-
1
+ # frozen_string_literal: true
2
2
 
3
3
  Gem::Specification.new do |spec|
4
4
  spec.authors = ['Tom Johnson']
5
- spec.email = ['tom@curationexperts.com']
5
+ spec.email = ['johnson.tom@gmail.com']
6
6
  spec.description = 'A Style Configuration for RuboCop'
7
7
  spec.summary = 'This is the recommended style configuration for use ' \
8
8
  'by Samvera Community projects.'
@@ -12,9 +12,13 @@ Gem::Specification.new do |spec|
12
12
  spec.name = 'bixby'
13
13
  spec.require_paths = ['lib']
14
14
 
15
- spec.version = '0.3.1'
15
+ spec.version = '3.0.0.pre1'
16
16
  spec.license = 'Apache-2.0'
17
17
 
18
- spec.add_dependency 'rubocop', '~> 0.49', '<= 0.50.0'
19
- spec.add_dependency 'rubocop-rspec', '~> 1.15', '<= 1.18.0'
18
+ spec.add_dependency 'rubocop', '0.85.1'
19
+ spec.add_dependency 'rubocop-performance'
20
+ spec.add_dependency 'rubocop-rails'
21
+ spec.add_dependency 'rubocop-rspec'
22
+
23
+ spec.add_development_dependency 'github_changelog_generator'
20
24
  end
@@ -1,21 +1,20 @@
1
+ require: rubocop-performance
2
+
1
3
  AllCops:
2
- TargetRubyVersion: 2.1
4
+ TargetRubyVersion: 2.6
3
5
  DisabledByDefault: true
4
6
  DisplayCopNames: true
5
- Include:
6
- - '**/Rakefile'
7
- - '**/config.ru'
8
7
  Exclude:
9
8
  - 'db/**/*'
10
9
  - 'script/**/*'
10
+ - 'tmp/**/*'
11
11
  - 'vendor/**/*'
12
+ - 'node_modules/**/*'
12
13
 
13
14
  inherit_from:
14
15
  - bixby_rails_enabled.yml
15
16
  - bixby_rspec_enabled.yml
16
17
 
17
- # These are all the cops that are enabled in the default configuration.
18
-
19
18
  Style/Alias:
20
19
  Enabled: true
21
20
 
@@ -43,9 +42,6 @@ Style/BlockComments:
43
42
  Style/BlockDelimiters:
44
43
  Enabled: true
45
44
 
46
- Style/BracesAroundHashParameters:
47
- Enabled: true
48
-
49
45
  Style/CaseEquality:
50
46
  Enabled: true
51
47
 
@@ -121,9 +117,6 @@ Style/EvenOdd:
121
117
  Style/FrozenStringLiteralComment:
122
118
  Enabled: true
123
119
 
124
- Style/FlipFlop:
125
- Enabled: true
126
-
127
120
  Style/For:
128
121
  Enabled: true
129
122
 
@@ -172,7 +165,10 @@ Style/MethodCallWithoutArgsParentheses:
172
165
  Style/MethodDefParentheses:
173
166
  Enabled: true
174
167
 
175
- Style/MethodMissing:
168
+ Style/MethodMissingSuper:
169
+ Enabled: true
170
+
171
+ Style/MissingRespondToMissing:
176
172
  Enabled: true
177
173
 
178
174
  Style/ModuleFunction:
@@ -284,9 +280,15 @@ Style/RedundantReturn:
284
280
  Style/RedundantSelf:
285
281
  Enabled: true
286
282
 
283
+ Style/RedundantSortBy:
284
+ Enabled: true
285
+
287
286
  Style/RescueModifier:
288
287
  Enabled: true
289
288
 
289
+ Style/Sample:
290
+ Enabled: true
291
+
290
292
  Style/SafeNavigation:
291
293
  Enabled: true
292
294
 
@@ -327,7 +329,10 @@ Style/TernaryParentheses:
327
329
  Style/TrailingCommaInArguments:
328
330
  Enabled: true
329
331
 
330
- Style/TrailingCommaInLiteral:
332
+ Style/TrailingCommaInArrayLiteral:
333
+ Enabled: true
334
+
335
+ Style/TrailingCommaInHashLiteral:
331
336
  Enabled: true
332
337
 
333
338
  Style/TrivialAccessors:
@@ -336,13 +341,13 @@ Style/TrivialAccessors:
336
341
  Style/UnlessElse:
337
342
  Enabled: true
338
343
 
339
- Style/UnneededCapitalW:
344
+ Style/RedundantCapitalW:
340
345
  Enabled: true
341
346
 
342
- Style/UnneededInterpolation:
347
+ Style/RedundantInterpolation:
343
348
  Enabled: true
344
349
 
345
- Style/UnneededPercentQ:
350
+ Style/RedundantPercentQ:
346
351
  Enabled: true
347
352
 
348
353
  Style/TrailingUnderscoreVariable:
@@ -366,13 +371,16 @@ Style/ZeroLengthPredicate:
366
371
 
367
372
  #################### Layout ###############################
368
373
 
369
- Layout/AlignArray:
374
+ Layout/ArrayAlignment:
370
375
  Enabled: true
371
376
 
372
- Layout/AlignHash:
377
+ Layout/HashAlignment:
373
378
  Enabled: true
374
379
 
375
- Layout/AlignParameters:
380
+ Layout/ParameterAlignment:
381
+ Enabled: true
382
+
383
+ Layout/BlockAlignment:
376
384
  Enabled: true
377
385
 
378
386
  Layout/BlockEndNewline:
@@ -384,15 +392,24 @@ Layout/CaseIndentation:
384
392
  Layout/ClosingParenthesisIndentation:
385
393
  Enabled: true
386
394
 
395
+ Layout/ConditionPosition:
396
+ Enabled: true
397
+
387
398
  Layout/CommentIndentation:
388
399
  Enabled: true
389
400
 
401
+ Layout/DefEndAlignment:
402
+ Enabled: true
403
+
390
404
  Layout/DotPosition:
391
405
  Enabled: true
392
406
 
393
407
  Layout/ElseAlignment:
394
408
  Enabled: true
395
409
 
410
+ Layout/EndAlignment:
411
+ Enabled: true
412
+
396
413
  Layout/EmptyLineBetweenDefs:
397
414
  Enabled: true
398
415
 
@@ -420,6 +437,9 @@ Layout/EndOfLine:
420
437
  Layout/ExtraSpacing:
421
438
  Enabled: true
422
439
 
440
+ Layout/IndentationStyle:
441
+ Enabled: true
442
+
423
443
  Layout/InitialIndentation:
424
444
  Enabled: true
425
445
 
@@ -430,18 +450,18 @@ Layout/IndentationConsistency:
430
450
  SupportedStyles:
431
451
  - normal
432
452
  - rails
433
- EnforcedStyle: rails
453
+ EnforcedStyle: normal
434
454
 
435
455
  Layout/IndentationWidth:
436
456
  Enabled: true
437
457
 
438
- Layout/IndentArray:
458
+ Layout/FirstArrayElementIndentation:
439
459
  Enabled: true
440
460
 
441
- Layout/IndentAssignment:
461
+ Layout/AssignmentIndentation:
442
462
  Enabled: true
443
463
 
444
- Layout/IndentHash:
464
+ Layout/FirstHashElementIndentation:
445
465
  Enabled: true
446
466
 
447
467
  Layout/SpaceInLambdaLiteral:
@@ -450,6 +470,12 @@ Layout/SpaceInLambdaLiteral:
450
470
  Layout/LeadingCommentSpace:
451
471
  Enabled: true
452
472
 
473
+ Layout/LineLength:
474
+ Enabled: true
475
+ Max: 200
476
+ Exclude:
477
+ - '**/*.gemspec'
478
+
453
479
  Layout/MultilineArrayBraceLayout:
454
480
  Enabled: true
455
481
 
@@ -525,7 +551,10 @@ Layout/SpaceInsideArrayPercentLiteral:
525
551
  Layout/SpaceInsidePercentLiteralDelimiters:
526
552
  Enabled: true
527
553
 
528
- Layout/SpaceInsideBrackets:
554
+ Layout/SpaceInsideReferenceBrackets:
555
+ Enabled: true
556
+
557
+ Layout/SpaceInsideArrayLiteralBrackets:
529
558
  Enabled: true
530
559
 
531
560
  Layout/SpaceInsideHashLiteralBraces:
@@ -540,10 +569,7 @@ Layout/SpaceInsideRangeLiteral:
540
569
  Layout/SpaceInsideStringInterpolation:
541
570
  Enabled: true
542
571
 
543
- Layout/Tab:
544
- Enabled: true
545
-
546
- Layout/TrailingBlankLines:
572
+ Layout/TrailingEmptyLines:
547
573
  Enabled: true
548
574
 
549
575
  Layout/TrailingWhitespace:
@@ -557,7 +583,7 @@ Naming/AccessorMethodName:
557
583
  Naming/AsciiIdentifiers:
558
584
  Enabled: true
559
585
 
560
- Naming/BinaryOperatorParameter:
586
+ Naming/BinaryOperatorParameterName:
561
587
  Enabled: true
562
588
 
563
589
  Naming/ClassAndModuleCamelCase:
@@ -606,12 +632,6 @@ Metrics/ModuleLength:
606
632
  Metrics/CyclomaticComplexity:
607
633
  Enabled: true
608
634
 
609
- Metrics/LineLength:
610
- Enabled: true
611
- Max: 200
612
- Exclude:
613
- - '**/*.gemspec'
614
-
615
635
  Metrics/MethodLength:
616
636
  Enabled: true
617
637
  Max: 14
@@ -641,21 +661,12 @@ Lint/AmbiguousRegexpLiteral:
641
661
  Lint/AssignmentInCondition:
642
662
  Enabled: true
643
663
 
644
- Lint/BlockAlignment:
645
- Enabled: true
646
-
647
664
  Lint/CircularArgumentReference:
648
665
  Enabled: true
649
666
 
650
- Lint/ConditionPosition:
651
- Enabled: true
652
-
653
667
  Lint/Debugger:
654
668
  Enabled: true
655
669
 
656
- Lint/DefEndAlignment:
657
- Enabled: true
658
-
659
670
  Lint/DeprecatedClassMethods:
660
671
  Enabled: true
661
672
 
@@ -665,7 +676,7 @@ Lint/DuplicateCaseCondition:
665
676
  Lint/DuplicateMethods:
666
677
  Enabled: true
667
678
 
668
- Lint/DuplicatedKey:
679
+ Lint/DuplicateHashKey:
669
680
  Enabled: true
670
681
 
671
682
  Lint/EachWithObjectArgument:
@@ -687,13 +698,13 @@ Lint/EmptyInterpolation:
687
698
  Lint/EmptyWhen:
688
699
  Enabled: true
689
700
 
690
- Lint/EndAlignment:
701
+ Style/EndBlock:
691
702
  Enabled: true
692
703
 
693
- Lint/EndInMethod:
704
+ Lint/EnsureReturn:
694
705
  Enabled: true
695
706
 
696
- Lint/EnsureReturn:
707
+ Lint/FlipFlop:
697
708
  Enabled: true
698
709
 
699
710
  Lint/FloatOutOfRange:
@@ -702,7 +713,7 @@ Lint/FloatOutOfRange:
702
713
  Lint/FormatParameterMismatch:
703
714
  Enabled: true
704
715
 
705
- Lint/HandleExceptions:
716
+ Lint/SuppressedException:
706
717
  Enabled: true
707
718
 
708
719
  Lint/ImplicitStringConcatenation:
@@ -714,7 +725,7 @@ Lint/IneffectiveAccessModifier:
714
725
  Lint/InheritException:
715
726
  Enabled: true
716
727
 
717
- Lint/LiteralInCondition:
728
+ Lint/LiteralAsCondition:
718
729
  Enabled: true
719
730
 
720
731
  Lint/LiteralInInterpolation:
@@ -723,7 +734,7 @@ Lint/LiteralInInterpolation:
723
734
  Lint/Loop:
724
735
  Enabled: true
725
736
 
726
- Lint/MultipleCompare:
737
+ Lint/MultipleComparison:
727
738
  Enabled: true
728
739
 
729
740
  Lint/NestedMethodDefinition:
@@ -763,7 +774,7 @@ Lint/ShadowedException:
763
774
  Lint/ShadowingOuterLocalVariable:
764
775
  Enabled: true
765
776
 
766
- Lint/StringConversionInInterpolation:
777
+ Lint/RedundantStringCoercion:
767
778
  Enabled: true
768
779
 
769
780
  Lint/UnderscorePrefixedVariableName:
@@ -772,10 +783,7 @@ Lint/UnderscorePrefixedVariableName:
772
783
  Lint/UnifiedInteger:
773
784
  Enabled: true
774
785
 
775
- Lint/UnneededDisable:
776
- Enabled: true
777
-
778
- Lint/UnneededSplatExpansion:
786
+ Lint/RedundantSplatExpansion:
779
787
  Enabled: true
780
788
 
781
789
  Lint/UnusedBlockArgument:
@@ -819,8 +827,8 @@ Performance/Count:
819
827
  # This cop has known compatibility issues with `ActiveRecord` and other
820
828
  # frameworks. ActiveRecord's `count` ignores the block that is passed to it.
821
829
  # For more information, see the documentation in the cop itself.
822
- # If you understand the known risk, you can disable `SafeMode`.
823
- SafeMode: true
830
+ # If you understand the known risk, you can disable `SafeAutoCorrect`.
831
+ SafeAutoCorrect: true
824
832
  Enabled: true
825
833
 
826
834
  Performance/Detect:
@@ -828,7 +836,7 @@ Performance/Detect:
828
836
  # frameworks. `ActiveRecord` does not implement a `detect` method and `find`
829
837
  # has its own meaning. Correcting `ActiveRecord` methods with this cop
830
838
  # should be considered unsafe.
831
- SafeMode: true
839
+ SafeAutoCorrect: true
832
840
  Enabled: true
833
841
 
834
842
  Performance/DoubleStartEndWith:
@@ -852,13 +860,6 @@ Performance/FlatMap:
852
860
  # This can be dangerous since `flat_map` will only flatten 1 level, and
853
861
  # `flatten` without any parameters can flatten multiple levels.
854
862
 
855
- Performance/HashEachMethods:
856
- Enabled: true
857
- AutoCorrect: false
858
-
859
- Performance/LstripRstrip:
860
- Enabled: true
861
-
862
863
  Performance/RangeInclude:
863
864
  Enabled: true
864
865
 
@@ -871,18 +872,12 @@ Performance/RedundantMatch:
871
872
  Performance/RedundantMerge:
872
873
  Enabled: true
873
874
 
874
- Performance/RedundantSortBy:
875
- Enabled: true
876
-
877
875
  Performance/RegexpMatch:
878
876
  Enabled: true
879
877
 
880
878
  Performance/ReverseEach:
881
879
  Enabled: true
882
880
 
883
- Performance/Sample:
884
- Enabled: true
885
-
886
881
  Performance/Size:
887
882
  Enabled: true
888
883
 
@@ -1,4 +1,6 @@
1
1
  ---
2
+ require: rubocop-rails
3
+
2
4
  Rails:
3
5
  Enabled: true
4
6
 
@@ -76,4 +78,3 @@ Rails/SkipsModelValidations:
76
78
 
77
79
  Rails/Validation:
78
80
  Enabled: true
79
-
@@ -45,13 +45,6 @@ RSpec/ExpectActual:
45
45
  RSpec/ExpectOutput:
46
46
  Enabled: true
47
47
 
48
- RSpec/FilePath:
49
- Enabled: true
50
- CustomTransform:
51
- RuboCop: rubocop
52
- RSpec: rspec
53
- IgnoreMethods: false
54
-
55
48
  RSpec/Focus:
56
49
  Enabled: true
57
50
 
@@ -100,10 +93,6 @@ RSpec/MessageSpies:
100
93
  RSpec/MultipleDescribes:
101
94
  Enabled: true
102
95
 
103
- RSpec/MultipleExpectations:
104
- Enabled: true
105
- Max: 1
106
-
107
96
  RSpec/NamedSubject:
108
97
  Enabled: true
109
98
 
metadata CHANGED
@@ -1,66 +1,103 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: bixby
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.3.1
4
+ version: 3.0.0.pre1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Tom Johnson
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2017-10-04 00:00:00.000000000 Z
11
+ date: 2020-06-10 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
15
15
  requirement: !ruby/object:Gem::Requirement
16
16
  requirements:
17
- - - "~>"
17
+ - - '='
18
18
  - !ruby/object:Gem::Version
19
- version: '0.49'
20
- - - "<="
19
+ version: 0.85.1
20
+ type: :runtime
21
+ prerelease: false
22
+ version_requirements: !ruby/object:Gem::Requirement
23
+ requirements:
24
+ - - '='
21
25
  - !ruby/object:Gem::Version
22
- version: 0.50.0
26
+ version: 0.85.1
27
+ - !ruby/object:Gem::Dependency
28
+ name: rubocop-performance
29
+ requirement: !ruby/object:Gem::Requirement
30
+ requirements:
31
+ - - ">="
32
+ - !ruby/object:Gem::Version
33
+ version: '0'
23
34
  type: :runtime
24
35
  prerelease: false
25
36
  version_requirements: !ruby/object:Gem::Requirement
26
37
  requirements:
27
- - - "~>"
38
+ - - ">="
39
+ - !ruby/object:Gem::Version
40
+ version: '0'
41
+ - !ruby/object:Gem::Dependency
42
+ name: rubocop-rails
43
+ requirement: !ruby/object:Gem::Requirement
44
+ requirements:
45
+ - - ">="
28
46
  - !ruby/object:Gem::Version
29
- version: '0.49'
30
- - - "<="
47
+ version: '0'
48
+ type: :runtime
49
+ prerelease: false
50
+ version_requirements: !ruby/object:Gem::Requirement
51
+ requirements:
52
+ - - ">="
31
53
  - !ruby/object:Gem::Version
32
- version: 0.50.0
54
+ version: '0'
33
55
  - !ruby/object:Gem::Dependency
34
56
  name: rubocop-rspec
35
57
  requirement: !ruby/object:Gem::Requirement
36
58
  requirements:
37
- - - "~>"
38
- - !ruby/object:Gem::Version
39
- version: '1.15'
40
- - - "<="
59
+ - - ">="
41
60
  - !ruby/object:Gem::Version
42
- version: 1.18.0
61
+ version: '0'
43
62
  type: :runtime
44
63
  prerelease: false
45
64
  version_requirements: !ruby/object:Gem::Requirement
46
65
  requirements:
47
- - - "~>"
66
+ - - ">="
48
67
  - !ruby/object:Gem::Version
49
- version: '1.15'
50
- - - "<="
68
+ version: '0'
69
+ - !ruby/object:Gem::Dependency
70
+ name: github_changelog_generator
71
+ requirement: !ruby/object:Gem::Requirement
72
+ requirements:
73
+ - - ">="
51
74
  - !ruby/object:Gem::Version
52
- version: 1.18.0
75
+ version: '0'
76
+ type: :development
77
+ prerelease: false
78
+ version_requirements: !ruby/object:Gem::Requirement
79
+ requirements:
80
+ - - ">="
81
+ - !ruby/object:Gem::Version
82
+ version: '0'
53
83
  description: A Style Configuration for RuboCop
54
84
  email:
55
- - tom@curationexperts.com
85
+ - johnson.tom@gmail.com
56
86
  executables: []
57
87
  extensions: []
58
88
  extra_rdoc_files: []
59
89
  files:
90
+ - ".circleci/config.yml"
91
+ - ".github_changelog_generator"
60
92
  - ".gitignore"
93
+ - CHANGELOG.md
94
+ - CODE_OF_CONDUCT.md
95
+ - CONTRIBUTING.md
96
+ - Gemfile
61
97
  - LICENSE
62
98
  - README.md
63
99
  - Rakefile
100
+ - SUPPORT.md
64
101
  - bixby.gemspec
65
102
  - bixby_default.yml
66
103
  - bixby_rails_enabled.yml
@@ -81,12 +118,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
81
118
  version: '0'
82
119
  required_rubygems_version: !ruby/object:Gem::Requirement
83
120
  requirements:
84
- - - ">="
121
+ - - ">"
85
122
  - !ruby/object:Gem::Version
86
- version: '0'
123
+ version: 1.3.1
87
124
  requirements: []
88
- rubyforge_project:
89
- rubygems_version: 2.6.13
125
+ rubygems_version: 3.1.4
90
126
  signing_key:
91
127
  specification_version: 4
92
128
  summary: This is the recommended style configuration for use by Samvera Community