bittrex 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3deff4d67afa6d177474b50f61c96555e01d4237
-  data.tar.gz: 0a0b94bf9f4577c679da4a52a8c0c85d7c4064a1
+  metadata.gz: 8dad1b17f535502441708ef65e4c5b83b7d8d6cb
+  data.tar.gz: 2d7a5d84190b5b8778a70164335e623181121a7e
 SHA512:
-  metadata.gz: 9139ad753901cc960de237d182ee302023fa37c0d4aabca9f3654d085012869fe9a5dd720952ab68163154e95361dbd7f70e159cf4e8a12abc4e724c6b9518aa
-  data.tar.gz: 81491a2f5d641e957287ec4341b4adee5a2919f2b548da9f9cab0a18aa1028a131c8223f54329a479c2674e82fcbdb10545d3b0d05035ba19b8345d504ebfdb6
+  metadata.gz: 7a1b15f16822ebd7e88d089c212f5d4562a7cbb04528b8cc15074008c0c83c91fab631b38a7adee526c4576958d8854cbbb5352fb646b8a2ff1fa95b8708ecfa
+  data.tar.gz: 1bfb9206a91e60559a5f8362400529a6999be713e7f6617270fe73f679e8b0bcc5539b5dfb7e799c1f5208fc243932da056a321cad6ecf3b97135b4727beec45

data/.circleci/config.yml

@@ -0,0 +1,57 @@
+# Ruby CircleCI 2.0 configuration file
+#
+# Check https://circleci.com/docs/2.0/language-ruby/ for more details
+#
+version: 2
+jobs:
+  build:
+    docker:
+      # specify the version you desire here
+       - image: circleci/ruby:2.3.3-node-browsers
+
+      # Specify service dependencies here if necessary
+      # CircleCI maintains a library of pre-built images
+      # documented at https://circleci.com/docs/2.0/circleci-images/
+      # - image: circleci/postgres:9.4
+
+    working_directory: ~/repo
+
+    steps:
+      - checkout
+
+      # Download and cache dependencies
+      - restore_cache:
+          keys:
+          - v1-dependencies-{{ checksum "Gemfile.lock" }}
+          # fallback to using the latest cache if no exact match is found
+          - v1-dependencies-
+
+      - run:
+          name: install dependencies
+          command: |
+            bundle install --jobs=4 --retry=3 --path vendor/bundle
+
+      - save_cache:
+          paths:
+            - ./vendor/bundle
+          key: v1-dependencies-{{ checksum "Gemfile.lock" }}
+
+      # run tests!
+      - run:
+          name: run tests
+          command: |
+            mkdir /tmp/test-results
+            TEST_FILES="$(circleci tests glob "spec/**/*_spec.rb" | circleci tests split --split-by=timings)"
+
+            bundle exec rspec --format progress \
+                            --format RspecJunitFormatter \
+                            --out /tmp/test-results/rspec.xml \
+                            --format progress \
+                            "${TEST_FILES}"
+
+      # collect reports
+      - store_test_results:
+          path: /tmp/test-results
+      - store_artifacts:
+          path: /tmp/test-results
+          destination: test-results

data/.ruby-version

@@ -1 +1 @@
-2.3.3
+2.3.4

data/bittrex.gemspec

@@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rspec_junit_formatter"
   spec.add_development_dependency "simplecov"
   spec.add_development_dependency "mocha"
   spec.add_development_dependency "figaro"

data/lib/bittrex.rb

@@ -1,6 +1,7 @@
 require "bittrex/version"
 
 module Bittrex
+  autoload :Helpers,       'bittrex/helpers'
   autoload :Market,        'bittrex/market'
   autoload :Client,        'bittrex/client'
   autoload :Configuration, 'bittrex/configuration'

data/lib/bittrex/deposit.rb

@@ -1,5 +1,7 @@
 module Bittrex
   class Deposit
+    include Helpers
+
     attr_reader :id, :transaction_id, :address, :quantity, :currency, :confirmations, :executed_at
 
     def initialize(attrs = {})
@@ -9,7 +11,7 @@ module Bittrex
       @quantity = attrs['Amount']
       @currency = attrs['Currency']
       @confirmations = attrs['Confirmations']
-      @executed_at = Time.parse(attrs['LastUpdated'])
+      @executed_at = extract_timestamp(attrs['LastUpdated'])
     end
 
     def self.all

data/lib/bittrex/helpers.rb

@@ -0,0 +1,8 @@
+module Bittrex
+  module Helpers
+    def extract_timestamp(value)
+      return if value.nil? or value.strip.empty?
+      Time.parse value
+    end
+  end
+end

data/lib/bittrex/market.rb

@@ -2,6 +2,8 @@ require 'time'
 
 module Bittrex
   class Market
+    include Helpers
+
     attr_reader :name, :currency, :base, :currency_name, :base_name, :minimum_trade, :active, :created_at, :raw
 
     def initialize(attrs = {})
@@ -12,7 +14,7 @@ module Bittrex
       @base_name = attrs['BaseCurrencyLong']
       @minimum_trade = attrs['MinTradeSize']
       @active = attrs['IsActive']
-      @created_at = Time.parse(attrs['Created'])
+      @created_at = extract_timestamp(attrs['Created'])
       @raw = attrs
     end
 

data/lib/bittrex/order.rb

@@ -1,7 +1,9 @@
 module Bittrex
   class Order
-    attr_reader :type, :id, :limit,
-                :exchange, :price, :quantity, :remaining,
+    include Helpers
+
+    attr_reader :type, :id, :limit, :opened_at, :closed_at,
+                :exchange, :price, :quantity, :remaining, :commission,
                 :total, :fill, :executed_at, :raw
 
     def initialize(attrs = {})
@@ -14,9 +16,11 @@ module Bittrex
       @total = attrs['Total']
       @fill = attrs['FillType']
       @limit = attrs['Limit']
-      @commission = attrs['Commission']
+      @commission = (attrs['Commission'] || attrs['CommissionPaid']).to_f
       @raw = attrs
-      @executed_at = Time.parse(attrs['TimeStamp'])
+      @opened_at = extract_timestamp(attrs['Opened'])
+      @executed_at = extract_timestamp(attrs['TimeStamp'])
+      @closed_at = extract_timestamp(attrs['Closed'])
     end
 
     def self.book(market, type, depth = 50)

data/lib/bittrex/quote.rb

@@ -4,6 +4,7 @@ module Bittrex
 
     def initialize(market, attrs = {})
       @market = market
+      return if attrs.nil?
       @bid = attrs['Bid']
       @ask = attrs['Ask']
       @last = attrs['Last']

data/lib/bittrex/summary.rb

@@ -1,5 +1,7 @@
 module Bittrex
   class Summary
+    include Helpers
+
     attr_reader :name, :high, :low, :volume, :last, :base_volume, :raw, :created_at
 
     alias_method :vol, :volume
@@ -13,7 +15,7 @@ module Bittrex
       @last        = attrs['Last']
       @base_volume = attrs['BaseVolume']
       @raw         = attrs
-      @created_at  = Time.parse(attrs['TimeStamp'])
+      @created_at  = extract_timestamp(attrs['TimeStamp'])
     end
 
     def self.all

data/lib/bittrex/version.rb

@@ -1,3 +1,3 @@
 module Bittrex
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/bittrex/withdrawal.rb

@@ -1,5 +1,7 @@
 module Bittrex
   class Withdrawal
+    include Helpers
+
     attr_reader :id, :currency, :quantity, :address, :authorized,
                 :pending, :canceled, :invalid_address,
                 :transaction_cost, :transaction_id, :executed_at
@@ -15,7 +17,7 @@ module Bittrex
       @invalid_address = attrs['Canceled']
       @transaction_cost = attrs['TxCost']
       @transaction_id = attrs['TxId']
-      @executed_at = Time.parse(attrs['Opened'])
+      @executed_at = extract_timestamp(attrs['Opened'])
     end
 
     def self.all

data/spec/fixtures/open_order.json

@@ -0,0 +1,17 @@
+{
+  "OrderUuid": "1af0399d-e845-4xxx-9d85-aa332d831e95",
+  "Exchange": "BTC-HPY",
+  "Opened": "2014-06-21T04:08:08.75",
+  "Closed": "2014-06-22T04:08:08.75",
+  "OrderType": "LIMIT_SELL",
+  "Limit": 1.6E-7,
+  "Quantity": 371810.26006413,
+  "QuantityRemaining": 371810.26006413,
+  "Price": 0.0,
+  "PricePerUnit": null,
+  "CancelInitiated": false,
+  "IsConditional": false,
+  "Condition": "NONE",
+  "ConditionTarget": null,
+  "ImmediateOrCancel": false
+}

data/spec/models/order_spec.rb

@@ -4,18 +4,42 @@ describe Bittrex::Order do
   let(:data){ fixture(:order) }
   let(:subject){ Bittrex::Order.new(data) }
 
-  attr_reader :type, :id, :quantity, :rate, :total, :fill, :raw, :executed_at
+  attr_reader :type, :id, :quantity, :rate, :total, :fill, :raw, :executed_at, :commission, :opened_at, :closed_at
 
-  context '#initialization' do
-    it { should_assign_attribute(subject, :id, '1af0399d-e845-4xxx-9d85-aa332d831e95') }
-    it { should_assign_attribute(subject, :type, 'Limit_sell') }
-    it { should_assign_attribute(subject, :exchange, 'BTC-HPY') }
-    it { should_assign_attribute(subject, :quantity, 371810.26006413) }
-    it { should_assign_attribute(subject, :remaining, 371810.26006413) }
-    it { should_assign_attribute(subject, :limit, 0.00000016) }
-    it { should_assign_attribute(subject, :price, 0.0) }
-    it { should_assign_attribute(subject, :total, nil) }
-    it { should_assign_attribute(subject, :fill, nil) }
-    it { should_assign_attribute(subject, :executed_at, Time.parse('2014-06-21T04:08:08.75')) }
+  describe "closed order" do
+    context '#initialization' do
+      it { should_assign_attribute(subject, :id, '1af0399d-e845-4xxx-9d85-aa332d831e95') }
+      it { should_assign_attribute(subject, :type, 'Limit_sell') }
+      it { should_assign_attribute(subject, :exchange, 'BTC-HPY') }
+      it { should_assign_attribute(subject, :quantity, 371810.26006413) }
+      it { should_assign_attribute(subject, :remaining, 371810.26006413) }
+      it { should_assign_attribute(subject, :limit, 0.00000016) }
+      it { should_assign_attribute(subject, :price, 0.0) }
+      it { should_assign_attribute(subject, :total, nil) }
+      it { should_assign_attribute(subject, :fill, nil) }
+      it { should_assign_attribute(subject, :executed_at, Time.parse('2014-06-21T04:08:08.75')) }
+      it { should_assign_attribute(subject, :opened_at, nil) }
+      it { should_assign_attribute(subject, :closed_at, nil) }
+    end
+  end
+
+  describe "open order" do
+    let(:data) { fixture(:open_order) }
+
+    context '#initialization' do
+      it { should_assign_attribute(subject, :id, '1af0399d-e845-4xxx-9d85-aa332d831e95') }
+      it { should_assign_attribute(subject, :type, 'Limit_sell') }
+      it { should_assign_attribute(subject, :exchange, 'BTC-HPY') }
+      it { should_assign_attribute(subject, :quantity, 371810.26006413) }
+      it { should_assign_attribute(subject, :remaining, 371810.26006413) }
+      it { should_assign_attribute(subject, :limit, 0.00000016) }
+      it { should_assign_attribute(subject, :commission, 0.0) }
+      it { should_assign_attribute(subject, :price, 0.0) }
+      it { should_assign_attribute(subject, :total, nil) }
+      it { should_assign_attribute(subject, :fill, nil) }
+      it { should_assign_attribute(subject, :executed_at, nil) }
+      it { should_assign_attribute(subject, :opened_at, Time.parse('2014-06-21T04:08:08.75')) }
+      it { should_assign_attribute(subject, :closed_at, Time.parse('2014-06-22T04:08:08.75')) }
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bittrex
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Matthew Werner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-04 00:00:00.000000000 Z
+date: 2017-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -115,6 +129,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".gitignore"
 - ".ruby-version"
 - Gemfile
@@ -128,6 +143,7 @@ files:
 - lib/bittrex/configuration.rb
 - lib/bittrex/currency.rb
 - lib/bittrex/deposit.rb
+- lib/bittrex/helpers.rb
 - lib/bittrex/market.rb
 - lib/bittrex/order.rb
 - lib/bittrex/quote.rb
@@ -138,6 +154,7 @@ files:
 - spec/fixtures/currency.json
 - spec/fixtures/deposit.json
 - spec/fixtures/market.json
+- spec/fixtures/open_order.json
 - spec/fixtures/order.json
 - spec/fixtures/quote.json
 - spec/fixtures/summary.json
@@ -182,6 +199,7 @@ test_files:
 - spec/fixtures/currency.json
 - spec/fixtures/deposit.json
 - spec/fixtures/market.json
+- spec/fixtures/open_order.json
 - spec/fixtures/order.json
 - spec/fixtures/quote.json
 - spec/fixtures/summary.json