bitpay-sdk 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b8fa092d5243a1f4759ce3735f53b892ffd70741
-  data.tar.gz: 2befc033218ad775ecada44facf7836498e86371
+  metadata.gz: 9f62c21b534bf518ba18041a4ef0035c1b0813da
+  data.tar.gz: 1464d4971a9dc7d3d83bf52db905f3fe88a389bb
 SHA512:
-  metadata.gz: 93fd95f0d1533ef5cf48eed9e964a03b2320409b6ee6fc3fbb66a75012f94a23c8568742bab6e2086994d1eae99635acac70c0b94254bbb2c7a8fb5448b29f9c
-  data.tar.gz: 5196595d3e0d36c58c1a3481d2a4924b848583e417e9418954c3f66921255fa0369cc37d3143afaf9d0a3b1fce138fdf551990a48182289cb153b9e7733da19f
+  metadata.gz: 8f6fcbd6e1b24b51d11eef2c951de9d06106aa39d14136ede7e6829de8b8afa2c6865968de62de0f37b60e151a2e5dd9712a0be628c50fe4073a505179339629
+  data.tar.gz: 9d7d03a789872bea2474f12eb96472e64fd7ed69f25c1a05390fd645363e9c62041860fe7c835ffcc506989f5238714076a166abcab977ae2257f9ed21a891ef

data/.gitignore

@@ -5,3 +5,5 @@ pkg
 .c9
 .ruby-version
 .ruby-gemset
+*.swo
+*.swp

data/.travis.yml

@@ -1,2 +1,3 @@
 rvm:
   - 2.1.0
+

data/lib/bitpay.rb

@@ -22,8 +22,7 @@ module BitPay
   # User agent reported to API
   USER_AGENT = 'ruby-bitpay-client '+VERSION
   
-  MISSING_KEY = 'No Private Key specified.  Pass priv_key or set ENV variable PRIV_KEY'
-  MISSING_PEM = 'No pem file specified. Pass pem or set ENV variable BITPAY_PEM'
+  MISSING_PEM = 'No pem file specified. Pass pem string'
   
   class BitPayError < StandardError; end
   class ArgumentError < ArgumentError; end

data/lib/bitpay/key_utils.rb

@@ -37,12 +37,6 @@ module BitPay
         key
       end
 
-      ## Gets private key from ENV variable or local FS
-      #
-      def get_local_pem_file
-        ENV['BITPAY_PEM'] || (raise BitPayError, MISSING_KEY)
-      end
-    
       def get_private_key key
         key.private_key.to_int.to_s(16)
       end
@@ -53,18 +47,18 @@ module BitPay
       end
 
       def get_private_key_from_pem pem
-        raise BitPayError, "Missing key" unless pem
+        raise BitPayError, MISSING_PEM
         key = OpenSSL::PKey::EC.new(pem)
         get_private_key key
       end
 
       def get_public_key_from_pem pem
-        raise BitPayError, MISSING_KEY unless pem
+        raise BitPayError, MISSING_PEM unless pem
         key = OpenSSL::PKey::EC.new(pem)
         get_public_key key
       end
 
-      def generate_sin_from_pem(pem = nil)
+      def generate_sin_from_pem pem
         #http://blog.bitpay.com/2014/07/01/bitauth-for-decentralized-authentication.html
         #https://en.bitcoin.it/wiki/Identity_protocol_v1
 
@@ -72,7 +66,7 @@ module BitPay
         # hence the requirement to use [].pack("H*") to convert to binary for each step
         
         #Generate Private Key
-        key = OpenSSL::PKey::EC.new(pem ||= get_local_pem_file)
+        key = OpenSSL::PKey::EC.new pem
         key.public_key.group.point_conversion_form = :compressed
         public_key = key.public_key.to_bn.to_s(2)
         step_one = Digest::SHA256.hexdigest(public_key)

data/lib/bitpay/version.rb

@@ -3,5 +3,5 @@
 # or https://github.com/bitpay/php-bitpay-client/blob/master/LICENSE
 
 module BitPay
-  VERSION = '2.1.0'
+  VERSION = '2.1.1'
 end

data/spec/key_utils_spec.rb

@@ -3,19 +3,6 @@ require 'spec_helper'
 describe BitPay::KeyUtils do
   let(:key_utils) {BitPay::KeyUtils}
 
-
-  describe '.get_local_private_key' do
-    it "should get the key from the ENV['PRIV_KEY'] variable" do
-      stub_const('ENV', {'BITPAY_PEM' => PEM})
-      expect(key_utils.get_local_pem_file).to eq(PEM)
-    end
-    
-    it "should throw an error if the ENV['PRIV_KEY'] variable is not set" do
-      expect {key_utils.get_local_pem_file}.to raise_error( BitPay::BitPayError )
-    end
-
-  end
-
   describe '.generate_pem' do
     it 'should generate a pem string' do
       regex = /BEGIN\ EC\ PRIVATE\ KEY/
@@ -42,11 +29,6 @@ describe BitPay::KeyUtils do
       expect(key_utils.generate_sin_from_pem(pem)).to eq sin
     end
 
-    it 'will attempt to use an env variable if no key is provided' do
-      stub_const('ENV', {'BITPAY_PEM' => PEM})
-      expect(key_utils.generate_sin_from_pem(nil)).to eq sin
-    end
-
   end
 
   context "errors when priv_key is not provided" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bitpay-sdk
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Bitpay, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-05 00:00:00.000000000 Z
+date: 2015-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json