bitpay-client 2.0.1 → 2.2.0

data/spec/key_utils_spec.rb

@@ -5,11 +5,6 @@ describe BitPay::KeyUtils do
 
 
   describe '.get_local_private_key' do
-    it "should get the key from the ENV['PRIV_KEY'] variable" do
-      stub_const('ENV', {'BITPAY_PEM' => PEM})
-      expect(key_utils.get_local_pem_file).to eq(PEM)
-    end
-    
     it 'should get the key from ~/.bitpay/bitpay.pem if env variable is not set' do
       allow(File).to receive(:read).with(BitPay::PRIVATE_KEY_PATH) {PEM}
       expect(key_utils.get_local_pem_file).to eq(PEM)
@@ -17,17 +12,6 @@ describe BitPay::KeyUtils do
 
   end
 
-  describe '.generate_pem' do
-    it 'should write a new key to ~/.bitpay/bitpay.pem' do
-      file = class_double("File").as_stubbed_const
-      fileutils = class_double("FileUtils").as_stubbed_const
-      allow(fileutils).to receive(:mkdir_p).with(BitPay::BITPAY_CREDENTIALS_DIR).and_return(nil)
-      expect(file).to receive(:open).with(BitPay::PRIVATE_KEY_PATH, 'w')
-      key_utils.generate_pem
-    end
-
-  end
-  
   describe '.retrieve_or_generate_pem' do
     it 'should write a new key to ~/.bitpay/bitpay.pem if there is no existing file' do
       file = class_double("File").as_stubbed_const
@@ -37,51 +21,6 @@ describe BitPay::KeyUtils do
       expect(file).to receive(:open).with(BitPay::PRIVATE_KEY_PATH, 'w')
       key_utils.retrieve_or_generate_pem
     end
-
-    it 'should retrieve the pem if there is an existing file' do
-      file = class_double("File").as_stubbed_const
-      fileutils = class_double("FileUtils").as_stubbed_const
-      allow(fileutils).to receive(:mkdir_p).with(BitPay::BITPAY_CREDENTIALS_DIR).and_return(nil)
-      expect(file).to receive(:open).with(BitPay::PRIVATE_KEY_PATH, 'w')
-      key_utils.generate_pem
-    end
-  end
-
-  describe '.get_public_key_from_pem' do
-    it 'should generate the right public key' do
-      expect(key_utils.get_public_key_from_pem(PEM)).to eq(PUB_KEY)
-    end
-    
-    it 'should get pem from the env if none is passed' do
-      expect(key_utils.get_public_key_from_pem(PEM)).to eq(PUB_KEY)
-    end
-
-  end
-
-  describe '.generate_sin_from_pem' do
-    let(:pem){PEM}
-    let(:sin){CLIENT_ID}
-
-    it 'will return the right sin for the right pem' do
-      expect(key_utils.generate_sin_from_pem(pem)).to eq sin
-    end
-
-    it 'will retrieve the locally stored PEM if one is not provided' do
-      allow(File).to receive(:read).with(BitPay::PRIVATE_KEY_PATH) {PEM}
-      expect(key_utils.generate_sin_from_pem(nil)).to eq sin
-    end
-
   end
 
-  context "errors when priv_key is not provided" do
-    before :each do
-      allow(File).to receive(:read).with(BitPay::PRIVATE_KEY_PATH) {nil}
-    end
-
-    it 'will not retrieve public key' do 
-      expect{key_utils.get_public_key_from_pem(nil)}.to raise_error(BitPay::BitPayError) 
-    end
-
-  end 
-  
 end

data/spec/spec_helper.rb

@@ -3,12 +3,10 @@ require 'pry'
 require 'capybara/rspec'
 require 'capybara/poltergeist'
 
-require File.join File.dirname(__FILE__), '..', 'lib', 'bitpay', 'client.rb'
-require File.join File.dirname(__FILE__), '..', 'lib', 'bitpay', 'key_utils.rb'
 require File.join File.dirname(__FILE__), '..', 'lib', 'bitpay.rb'
+
 require_relative '../config/constants.rb'
 require_relative '../config/capybara.rb'
-
 #
 ## Test Variables
 #
@@ -22,4 +20,17 @@ RSpec.configure do |config|
   config.before :each do |example|
     WebMock.allow_net_connect! if example.metadata[:type] == :feature 
   end
+
+  config.before :all do |example|
+    FileUtils.mkdir_p(BitPay::BITPAY_CREDENTIALS_DIR)
+  end
+end
+
+def an_illegal_claim_code
+  legal_map = [*'A'..'Z'] + [*'a'..'z'] + [*0..9]
+  first_length = rand(6)
+  short_code = (0..first_length).map{legal_map.sample}.join
+  second_length = [*8..25].sample
+  long_code = [*8..25].sample.times.inject([]){|arr| arr << legal_map.sample}.join
+  [nil, short_code, long_code].sample
 end

metadata

@@ -1,57 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: bitpay-client
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.2.0
 platform: ruby
 authors:
 - Bitpay, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-02 00:00:00.000000000 Z
+date: 2015-01-07 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: bitpay-sdk
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.8.1
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.2
 - !ruby/object:Gem::Dependency
   name: ecdsa
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.2.0
 - !ruby/object:Gem::Dependency
   name: commander
   requirement: !ruby/object:Gem::Requirement
@@ -70,142 +84,156 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 10.3.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 10.3.2
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.18.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.18.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.10.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.10.1
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: pry-rescue
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.4.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.4.1
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.4.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.4.3
+- !ruby/object:Gem::Dependency
+  name: cucumber
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.17
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.17
 - !ruby/object:Gem::Dependency
   name: poltergeist
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.1
 - !ruby/object:Gem::Dependency
   name: airborne
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.0.20
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.0.20
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: mongo
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.11.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.11.1
 description: Powerful, flexible, lightweight, thread-safe interface to the BitPay
   developers API
 email: info@bitpay.com
@@ -224,13 +252,18 @@ files:
 - bitpay-client.gemspec
 - config/capybara.rb
 - config/constants.rb
+- features/creating_invoices.feature
+- features/pairing.feature
+- features/retrieving_invoices.feature
+- features/step_definitions/invoice_steps.rb
+- features/step_definitions/keygen_steps.rb
+- features/step_definitions/step_helpers.rb
 - lib/bitpay.rb
 - lib/bitpay/cacert.pem
 - lib/bitpay/cli.rb
-- lib/bitpay/client.rb
-- lib/bitpay/key_utils.rb
+- lib/bitpay/cli_client.rb
+- lib/bitpay/cli_key_utils.rb
 - lib/bitpay/version.rb
-- lib/harness.rb
 - spec/client_spec.rb
 - spec/features/pair_spec.rb
 - spec/features/pos_spec.rb
@@ -263,4 +296,3 @@ signing_key:
 specification_version: 4
 summary: Official ruby client library for the BitPay API
 test_files: []
-has_rdoc: 

data/lib/bitpay/client.rb

@@ -1,160 +0,0 @@
-# license Copyright 2011-2014 BitPay, Inc., MIT License
-# see http://opensource.org/licenses/MIT
-# or https://github.com/bitpay/php-bitpay-client/blob/master/LICENSE
-
-require 'uri'
-require 'net/https'
-require 'json'
-
-require_relative 'key_utils'
-
-module BitPay
-  # This class is used to instantiate a BitPay Client object. It is expected to be thread safe.
-  #
-  class Client
-    
-
-    # @return [Client]
-    # @example
-    #  # Create a client with a pem file created by the bitpay client:
-    #  client = BitPay::Client.new
-    def initialize(opts={})
-      @pem               = opts[:pem] || ENV['BITPAY_PEM'] || KeyUtils.retrieve_or_generate_pem 
-      @key               = KeyUtils.create_key @pem
-      @priv_key          = KeyUtils.get_private_key @key
-      @pub_key           = KeyUtils.get_public_key @key
-      @client_id         = KeyUtils.generate_sin_from_pem @pem
-      @uri               = URI.parse opts[:api_uri] || API_URI
-      @user_agent        = opts[:user_agent] || USER_AGENT
-      @https             = Net::HTTP.new @uri.host, @uri.port
-      @https.use_ssl     = true
-      @https.ca_file     = CA_FILE
-      @tokens            = {}
-
-      # Option to disable certificate validation in extraordinary circumstance.  NOT recommended for production use
-      @https.verify_mode = opts[:insecure] == true ? OpenSSL::SSL::VERIFY_NONE : OpenSSL::SSL::VERIFY_PEER
-      
-      # Option to enable http request debugging
-      @https.set_debug_output($stdout) if opts[:debug] == true
-
-    end
-
-    def pair_pos_client(claimCode)
-      response = set_pos_token(claimCode)
-      get_token 'pos'
-      response
-    end
-
-    def create_invoice(id:, price:, currency:, facade: 'pos', params:{})
-      params.merge!({price: price, currency: currency})
-      response = send_request("POST", "invoices", facade: facade, params: params)
-      response["data"]
-    end
-
-    def get_public_invoice(id:)
-      request = Net::HTTP::Get.new("/invoices/#{id}")
-      response = process_request(request)
-      response["data"]
-    end
-    
-    ## Generates REST request to api endpoint
-    def send_request(verb, path, facade: 'merchant', params: {}, token: nil)
-      token ||= get_token(facade)
-
-      # Verb-specific logic
-      case verb.upcase
-        when "GET"
-          urlpath = '/' + path + '?nonce=' + KeyUtils.nonce + '&token=' + token
-          request = Net::HTTP::Get.new urlpath
-          request['X-Signature'] = KeyUtils.sign(@uri.to_s + urlpath, @priv_key)
-
-        when "PUT"
-
-        when "POST"  # Requires a GUID
-
-          urlpath = '/' + path
-          request = Net::HTTP::Post.new urlpath
-          params[:token] = token
-          params[:nonce] = KeyUtils.nonce
-          params[:guid]  = SecureRandom.uuid
-          params[:id] = @client_id
-          request.body = params.to_json
-          request['X-Signature'] = KeyUtils.sign(@uri.to_s + urlpath + request.body, @priv_key)
-
-        when "DELETE"
-       
-          raise(BitPayError, "Invalid HTTP verb: #{verb.upcase}")
-      end
-
-      # Build request headers and submit
-      request['X-Identity'] = @pub_key
- 
-      response = process_request(request)
-    end
-
-##### PRIVATE METHODS #####
-    private
-
-    ## Processes HTTP Request and returns parsed response
-    # Otherwise throws error
-    #
-    def process_request(request)
-
-      request['User-Agent'] = @user_agent
-      request['Content-Type'] = 'application/json'
-      request['X-BitPay-Plugin-Info'] = 'Rubylib' + VERSION
-
-      response = @https.request request
-
-      if response.kind_of? Net::HTTPSuccess
-        return JSON.parse(response.body)
-      elsif JSON.parse(response.body)["error"]
-        raise(BitPayError, "#{response.code}: #{JSON.parse(response.body)['error']}")
-      else
-        raise BitPayError, "#{response.code}: #{JSON.parse(response.body)}"
-      end
-        
-    end
-
-    ## Requests token by appending nonce and signing URL
-    #  Returns a hash of available tokens
-    #
-    def load_tokens
-
-      urlpath = '/tokens?nonce=' + KeyUtils.nonce
-
-      request = Net::HTTP::Get.new(urlpath)
-      request['x-identity'] = @pub_key
-      request['x-signature'] = KeyUtils.sign(@uri.to_s + urlpath, @priv_key)
-
-      response = process_request(request)
-
-      token_array = response["data"] || {}
-
-      tokens = {}
-      token_array.each do |t|
-        tokens[t.keys.first] = t.values.first
-      end
-
-      @tokens = tokens
-      return tokens
-
-    end
-
-    ## Retrieves specified token from hash, otherwise tries to refresh @tokens and retry
-    def set_pos_token(claim_code)
-      params = {pairingCode: claim_code}
-      urlpath = '/tokens'
-      request = Net::HTTP::Post.new urlpath
-      params[:guid] = SecureRandom.uuid
-      params[:id] = @client_id
-      request.body = params.to_json
-      process_request(request)
-    end
-
-    def get_token(facade)
-      token = @tokens[facade] || load_tokens[facade] || raise(BitPayError, "Not authorized for facade: #{facade}")
-    end
-
-  end
-end