bitfab 0.64.10 → 0.64.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 695e945332f1eacd1d33b085bd44c83d585b22d53d93b1a51c197b8196956a38
-  data.tar.gz: 12a2f0eb5193b336faa19cefea2b6d3e947de60925f3014fa5626665360403ce
+  metadata.gz: 0230d80db2a1be11423ea398d2e948cad51571ff1e539f4837557c409f6bfe5f
+  data.tar.gz: 44fce3d40aa1e12945fed6a2b5b88707f04bf5533abcadd13a361442fd174c1a
 SHA512:
-  metadata.gz: 66d420f41c8da030c87b6ca7aa6ec3c8bbb04c18362b51792f34288802486238f8dad71ef50888394024ee2b7c5651f352b90a0055f39d985fbaa4ed42824a75
-  data.tar.gz: 0fc406caf9c0c37c89690fe711fe90299ff6b4bc7f1d89a47fc20e5b2052258ef2aa269015d0fcbf5b4254aecbfd55d07367d0cc8c57a346f3e202a5693b9da2
+  metadata.gz: 8c483c3c65d9d50049901c5d0e9769a85502fdf082ecd7b95dfc0f55904fb9cdd98948d1e9d166678f12e74fac73cb33763d2571bbea647502b1d0a776859ff2
+  data.tar.gz: 0ae1075d5dfb6a0efae6841c87d4f0f4cccbebd27f83e0561fe2a4498b2e42aed4f895d3c2be8d444aa4d9013bbc00385e52a957cf783e142da3ebef3574bdfe

data/lib/bitfab/client.rb

@@ -393,6 +393,12 @@ module Bitfab
       @http_client.get_trace_span(trace_id, id:, name:, occurrence:)
     end
 
+    def get_span(span_id)
+      raise ArgumentError, "span_id must be a non-empty string" unless span_id.is_a?(String) && !span_id.strip.empty?
+
+      @http_client.get_span(span_id)
+    end
+
     # Execute a block inside a span context, sending trace data on completion.
     # Called by Traceable, not intended for direct use.
     def execute_span(trace_function_key:, span_name:, span_type:, function_name:, args:, kwargs:,

data/lib/bitfab/http_client.rb

@@ -334,6 +334,11 @@ module Bitfab
       )["span"]
     end
 
+    def get_span(span_id)
+      encoded_span_id = URI.encode_www_form_component(span_id).gsub("+", "%20")
+      get("/api/sdk/spans/#{encoded_span_id}", timeout: 30)["span"]
+    end
+
     # Fetch the span tree rooted at an external span. Blocking GET request.
     # Used by replay when a mock strategy is active so child spans can be
     # matched against their historical outputs.

data/lib/bitfab/replay.rb

@@ -464,7 +464,8 @@ module Bitfab
       # trace-ID mapping complete_replay builds would otherwise race the
       # in-flight batches and hand back nil for every item.
       delivered_trace_ids = preserve_replay_failure(result_items, experiment_id, full_experiment_url) do
-        wait_for_replay_persistence(http_client, experiment_id, result_items.map { |item| item[:_sdk_trace_id] })
+        wait_for_replay_persistence(http_client, experiment_id, result_items.map { |item| item[:_sdk_trace_id] },
+          labels: replay_labels(result_items))
       end
 
       # Primary source for item[:trace_id]: the server's assigned traces.id, read
@@ -1243,7 +1244,7 @@ module Bitfab
     # repeat itself. Acks cannot settle a request that timed out client-side
     # after the server committed, so anything short of fully delivered falls
     # through to the server poll, which stays the authority there.
-    def wait_for_replay_persistence(http_client, experiment_id, sdk_trace_ids, timeout: nil)
+    def wait_for_replay_persistence(http_client, experiment_id, sdk_trace_ids, timeout: nil, labels: {})
       timeout ||= PERSISTENCE_TIMEOUT_SECONDS
       trace_ids = sdk_trace_ids.compact
 
@@ -1286,15 +1287,29 @@ module Bitfab
         sleep((deadline - Otel.monotonic_now).clamp(0, PERSISTENCE_POLL_SECONDS))
       end
 
-      cause = if flushed
-        ""
-      else
-        " Delivery was also not confirmed before the flush deadline, so the " \
-          "spans likely never reached the server."
+      missing.each do |trace_id|
+        warn_unconfirmed_replay(unconfirmed_replay_warning(labels.fetch(trace_id, trace_id), timeout, flushed))
+      end
+      read_back_trace_ids
+    end
+
+    def unconfirmed_replay_warning(label, seconds, flushed)
+      "[bitfab] replay #{label} could not confirm all spans reached Bitfab within #{format("%g", seconds)}s. " \
+        "The run continues; Bitfab will show this replay as capture incomplete." \
+        "#{" Some spans likely never left this process." unless flushed}"
+    end
+
+    def warn_unconfirmed_replay(message)
+      Bitfab.count_delivery_problem(message)
+      warn message
+    rescue Exception # rubocop:disable Lint/RescueException
+      nil
+    end
+
+    def replay_labels(items)
+      items.each_with_object({}) do |item, labels|
+        labels[item[:_sdk_trace_id]] = "#{item[:original_trace_id]}##{item[:attempt]}" if item[:_sdk_trace_id]
       end
-      raise "Replay traces were not fully persisted before the delivery deadline " \
-        "(experiment #{experiment_id}, missing #{missing.length} of " \
-        "#{expected_span_counts.length} trace(s)).#{cause}"
     end
 
     # Normalize a complete-replay tokens hash (string-keyed JSON) into the

data/lib/bitfab/replay_processes.rb

@@ -51,13 +51,13 @@ module Bitfab
           mock_overrides: overrides, dry_run: assignment.fetch("dry_run"))
         unless assignment["dry_run"]
           begin
-            mapped = Replay.wait_for_replay_persistence(http, assignment.fetch("experiment_id"), [result[:_sdk_trace_id]], timeout: delivery_timeout)
+            mapped = Replay.wait_for_replay_persistence(http, assignment.fetch("experiment_id"), [result[:_sdk_trace_id]],
+              timeout: delivery_timeout, labels: Replay.replay_labels([result]))
             result[:trace_id] = mapped[result[:_sdk_trace_id]] || result[:trace_id]
             if result[:_sdk_trace_id] && result[:trace_id].nil?
               status = http.get_replay_status(assignment.fetch("experiment_id"), {result[:_sdk_trace_id] => 1})
               result[:trace_id] = status.fetch("traceIds", {})[result[:_sdk_trace_id]]
             end
-            raise "Child replay trace persistence could not be confirmed" if result[:error].nil? && result[:trace_id].nil?
           rescue => error
             result[:replay_error] = error
             result[:error] = error.message

data/lib/bitfab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bitfab
-  VERSION = "0.64.10"
+  VERSION = "0.64.12"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bitfab
 version: !ruby/object:Gem::Version
-  version: 0.64.10
+  version: 0.64.12
 platform: ruby
 authors:
 - Harvest Team