bitfab 0.62.4 → 0.62.6

data/lib/bitfab/cloud_replay_cli.rb

@@ -6,7 +6,7 @@ require "tempfile"
 
 module Bitfab
   module CloudReplayCli
-    HELP = "Direct GitHub replay: --cloud PIPELINE --trace-ids UUID[,UUID] [--registry PATH] [--max-concurrency 1..32] [--cloud-include FILE] [--cloud-dry-run] [--cloud-detach] [--cloud-request-id UUID]. Lifecycle: --cloud-status|--cloud-watch|--cloud-cancel|--cloud-cleanup UUID. Setup: --cloud-init --config FILE, --cloud-secrets --env-file FILE [NAME ...]. Requires git, gh auth login, Python 3.10+, and bitfab:setup cloud."
+    HELP = "Direct GitHub replay: --cloud PIPELINE --trace-ids UUID[,UUID] [--registry PATH] [--max-concurrency 1..32] [--cloud-include FILE] [--cloud-dry-run] [--cloud-detach] [--cloud-request-id UUID] [--cloud-timeout MINUTES] [--cloud-check] [--fail-on-error] [replay options such as --name, --dataset-ids, --attempts, or --resume, passed to the replay on the runner]. Lifecycle: --cloud-status|--cloud-watch|--cloud-cancel|--cloud-cleanup UUID. Setup: --cloud-init [--config FILE] (creates a setup or updates it in place), --cloud-secrets --env-file FILE [NAME ...]. Requires git, gh auth login, Python 3.10+, and bitfab:setup cloud."
 
     HELPER = File.expand_path("cloudReplay.py", __dir__)
 

data/lib/bitfab/replay_registry.rb

@@ -89,6 +89,8 @@ module Bitfab
   module ReplayCli
     MAX_PINNED_TRACE_IDS = 100
 
+    class ItemsErroredError < StandardError; end
+
     module_function
 
     # get_assertions returns every state so a reviewer can see drafts, but only an
@@ -266,9 +268,20 @@ module Bitfab
         render_summary(args.fetch(:pipeline), result, stderr)
       end
       stdout.puts Bitfab.serialize_replay_result(result)
+      fail_if_items_errored(result, dry_run: options[:dry_run]) if args[:fail_on_error]
       result
     end
 
+    def fail_if_items_errored(result, dry_run:)
+      items = result[:items].reject { |item| item[:carried_over] }
+      errored = items.count { |item| item[:error] }
+      return if errored.zero?
+
+      noun = dry_run ? "resolved" : "replayed"
+      raise ItemsErroredError,
+        "[replay] #{errored} of #{items.length} #{noun} items errored; exiting 1 because of --fail-on-error"
+    end
+
     def parse(registry, argv)
       if argv.include?("--db-branch") && argv.include?("--no-db-branch")
         raise OptionParser::InvalidArgument, "--db-branch and --no-db-branch cannot be used together"
@@ -315,6 +328,9 @@ module Bitfab
         options.on("--judge-assertions",
           "Judge each replay's approved assertions as it finishes (costs model calls)") { args[:judge_assertions] = true }
         options.on("--dry-run") { args[:dry_run] = true }
+        options.on("--fail-on-error",
+          "Exit 1 after printing the result when any replayed item errored. " \
+            "Under --dry-run, items whose inputs failed to resolve count.") { args[:fail_on_error] = true }
         options.on("--primitive TYPE", %w[async process]) { |value| args[:primitive] = value }
         options.on("--[no-]memory-throttle") { |value| args[:memory_throttle] = value }
         options.on("--mock STRATEGY", %w[none all marked]) { |value| args[:mock] = value }

data/lib/bitfab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bitfab
-  VERSION = "0.62.4"
+  VERSION = "0.62.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bitfab
 version: !ruby/object:Gem::Version
-  version: 0.62.4
+  version: 0.62.6
 platform: ruby
 authors:
 - Harvest Team