bitex_bot 0.6.1 → 0.9.0

data/spec/models/buy_opening_flow_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe BitexBot::BuyOpeningFlow do
-  before(:each) { Bitex.api_key = 'valid_key' }
+  before(:each) { BitexBot::Robot.setup }
 
   let(:store) { BitexBot::Store.create }
 
@@ -13,19 +13,23 @@ describe BitexBot::BuyOpeningFlow do
 
   describe 'when creating a buying flow' do
     it 'spends 50 usd' do
-      stub_bitex_orders
-      BitexBot::Settings.stub(time_to_live: 3,
-        buying: double(amount_to_spend_per_order: 50, profit: 0))
-
-      flow = BitexBot::BuyOpeningFlow.create_for_market(100,
-        bitstamp_api_wrapper_order_book.bids, bitstamp_api_wrapper_transactions_stub, 0.5, 0.25,
-        store)
+      stub_bitex_active_orders
+      BitexBot::Settings.stub(time_to_live: 3, buying: double(amount_to_spend_per_order: 50, profit: 0))
+
+      flow = BitexBot::BuyOpeningFlow.create_for_market(
+        100,
+        bitstamp_api_wrapper_order_book.bids,
+        bitstamp_api_wrapper_transactions_stub,
+        0.5,
+        0.25,
+        store
+      )
 
       flow.order_id.should == 12345
       flow.value_to_use.should == 50
+      flow.suggested_closing_price.should == 20
       flow.price.should <= flow.suggested_closing_price
       flow.price.round(14).should == '19.85074626865672'.to_d
-      flow.suggested_closing_price.should == 20
     end
 
     let(:order_id) { 12_345 }
@@ -39,49 +43,44 @@ describe BitexBot::BuyOpeningFlow do
     it 'spends 100 usd' do
       suggested_closing_price = 15.to_d
 
-      BitexBot::Settings.stub(
-        time_to_live: 3,
-        buying: double(amount_to_spend_per_order: amount_to_spend, profit: 0)
+      BitexBot::Settings.stub(time_to_live: 3, buying: double(amount_to_spend_per_order: amount_to_spend, profit: 0))
+      stub_bitex_active_orders
+
+      flow = BitexBot::BuyOpeningFlow.create_for_market(
+        btc_balance,
+        order_book,
+        transactions,
+        maker_fee,
+        taker_fee,
+        store
       )
-      stub_bitex_orders
-
-      flow =
-        BitexBot::BuyOpeningFlow.create_for_market(
-          btc_balance,
-          order_book,
-          transactions,
-          maker_fee,
-          taker_fee,
-          store
-        )
 
       flow.order_id.should eq order_id
       flow.value_to_use.should eq amount_to_spend
-      flow.price.should <= suggested_closing_price
       flow.suggested_closing_price.should eq suggested_closing_price
+      flow.price.should <= suggested_closing_price
     end
 
     let(:other_fx_rate) { 10.to_d }
 
     it 'spends 100 usd with other fx_rate' do
-      suggested_closing_price = 25.to_d
+      suggested_closing_price = 15.to_d
 
       BitexBot::Settings.stub(
         buying_foreign_exchange_rate: other_fx_rate,
         time_to_live: 3,
         buying: double(amount_to_spend_per_order: amount_to_spend, profit: 0)
       )
-      stub_bitex_orders
-
-      flow =
-        BitexBot::BuyOpeningFlow.create_for_market(
-          btc_balance,
-          order_book,
-          transactions,
-          maker_fee,
-          taker_fee,
-          store
-        )
+      stub_bitex_active_orders
+
+      flow = BitexBot::BuyOpeningFlow.create_for_market(
+        btc_balance,
+        order_book,
+        transactions,
+        maker_fee,
+        taker_fee,
+        store
+      )
 
       flow.order_id.should eq order_id
       flow.value_to_use.should eq amount_to_spend
@@ -90,13 +89,17 @@ describe BitexBot::BuyOpeningFlow do
     end
 
     it 'lowers the price to pay on bitex to take a profit' do
-      stub_bitex_orders
-      BitexBot::Settings.stub(time_to_live: 3,
-        buying: double(amount_to_spend_per_order: 100, profit: 50.to_d))
-
-      flow = BitexBot::BuyOpeningFlow.create_for_market(100000,
-        bitstamp_api_wrapper_order_book.bids, bitstamp_api_wrapper_transactions_stub, 0.5, 0.25,
-        store)
+      stub_bitex_active_orders
+      BitexBot::Settings.stub(time_to_live: 3, buying: double(amount_to_spend_per_order: 100, profit: 50.to_d))
+
+      flow = BitexBot::BuyOpeningFlow.create_for_market(
+        100_000,
+        bitstamp_api_wrapper_order_book.bids,
+        bitstamp_api_wrapper_transactions_stub,
+        0.5,
+        0.25,
+        store
+      )
 
       flow.order_id.should == 12345
       flow.value_to_use.should == 100
@@ -108,13 +111,17 @@ describe BitexBot::BuyOpeningFlow do
     it 'fails when there is a problem placing the bid on bitex' do
       Bitex::Bid.stub(:create!) { raise StandardError.new('Cannot Create') }
 
-      BitexBot::Settings.stub(time_to_live: 3,
-        buying: double(amount_to_spend_per_order: 100, profit: 0))
+      BitexBot::Settings.stub(time_to_live: 3, buying: double(amount_to_spend_per_order: 100, profit: 0))
 
       expect do
-        flow = BitexBot::BuyOpeningFlow.create_for_market(100000,
-          bitstamp_api_wrapper_order_book.bids, bitstamp_api_wrapper_transactions_stub, 0.5, 0.25,
-          store)
+        flow = BitexBot::BuyOpeningFlow.create_for_market(
+          100_000,
+          bitstamp_api_wrapper_order_book.bids,
+          bitstamp_api_wrapper_transactions_stub,
+          0.5,
+          0.25,
+          store
+        )
 
         flow.should be_nil
         BitexBot::BuyOpeningFlow.count.should == 0
@@ -122,14 +129,18 @@ describe BitexBot::BuyOpeningFlow do
     end
 
     it 'fails when there are not enough bitcoin to sell in the other exchange' do
-      stub_bitex_orders
-      BitexBot::Settings.stub(time_to_live: 3,
-        buying: double(amount_to_spend_per_order: 100, profit: 0))
+      stub_bitex_active_orders
+      BitexBot::Settings.stub(time_to_live: 3, buying: double(amount_to_spend_per_order: 100, profit: 0))
 
       expect do
-        flow = BitexBot::BuyOpeningFlow.create_for_market(1,
-          bitstamp_api_wrapper_order_book.bids, bitstamp_api_wrapper_transactions_stub, 0.5, 0.25,
-          store)
+        flow = BitexBot::BuyOpeningFlow.create_for_market(
+          1,
+          bitstamp_api_wrapper_order_book.bids,
+          bitstamp_api_wrapper_transactions_stub,
+          0.5,
+          0.25,
+          store
+        )
 
         flow.should be_nil
         BitexBot::BuyOpeningFlow.count.should == 0
@@ -138,13 +149,17 @@ describe BitexBot::BuyOpeningFlow do
 
     it 'prioritizes profit from store' do
       store = BitexBot::Store.new(buying_profit: 0.5)
-      stub_bitex_orders
-      BitexBot::Settings.stub(time_to_live: 3,
-        buying: double(amount_to_spend_per_order: 50, profit: 0))
-
-      flow = BitexBot::BuyOpeningFlow.create_for_market(100,
-        bitstamp_api_wrapper_order_book.bids, bitstamp_api_wrapper_transactions_stub, 0.5, 0.25,
-        store)
+      stub_bitex_active_orders
+      BitexBot::Settings.stub(time_to_live: 3, buying: double(amount_to_spend_per_order: 50, profit: 0))
+
+      flow = BitexBot::BuyOpeningFlow.create_for_market(
+        100,
+        bitstamp_api_wrapper_order_book.bids,
+        bitstamp_api_wrapper_transactions_stub,
+        0.5,
+        0.25,
+        store
+      )
 
       flow.price.round(13).should == '19.7514925373134'.to_d
     end
@@ -186,32 +201,32 @@ describe BitexBot::BuyOpeningFlow do
     end
 
     it 'does not register buys from another order book' do
-      flow.order_id.should == 12345
       Bitex::Trade.stub(all: [build(:bitex_buy, id: 23456, order_book: :btc_ars)])
 
-      expect do
-        BitexBot::BuyOpeningFlow.sync_open_positions.should be_empty
-      end.not_to change { BitexBot::OpenBuy.count }
+      flow.order_id.should == 12345
+      expect { BitexBot::BuyOpeningFlow.sync_open_positions.should be_empty }.not_to change { BitexBot::OpenBuy.count }
       BitexBot::OpenBuy.count.should == 0
     end
 
     it 'does not register buys from unknown bids' do
       stub_bitex_transactions
 
-      expect do
-        BitexBot::BuyOpeningFlow.sync_open_positions.should be_empty
-      end.not_to change { BitexBot::OpenBuy.count }
+      expect { BitexBot::BuyOpeningFlow.sync_open_positions.should be_empty }.not_to change { BitexBot::OpenBuy.count }
     end
   end
 
   it 'cancels the associated bitex bid' do
-    stub_bitex_orders
-    BitexBot::Settings.stub(time_to_live: 3,
-      buying: double(amount_to_spend_per_order: 50, profit: 0))
-
-    flow = BitexBot::BuyOpeningFlow.create_for_market(100,
-      bitstamp_api_wrapper_order_book.bids, bitstamp_api_wrapper_transactions_stub, 0.5, 0.25,
-      store)
+    stub_bitex_active_orders
+    BitexBot::Settings.stub(time_to_live: 3, buying: double(amount_to_spend_per_order: 50, profit: 0))
+
+    flow = BitexBot::BuyOpeningFlow.create_for_market(
+      100,
+      bitstamp_api_wrapper_order_book.bids,
+      bitstamp_api_wrapper_transactions_stub,
+      0.5,
+      0.25,
+      store
+    )
 
     flow.finalise!
     flow.should be_settling
@@ -220,15 +235,19 @@ describe BitexBot::BuyOpeningFlow do
   end
 
   it 'order has expected order book' do
-    stub_bitex_orders
-    BitexBot::Settings.stub(time_to_live: 3,
-      buying: double(amount_to_spend_per_order: 50, profit: 0))
-
-    flow = subject.class.create_for_market(100,
-      bitstamp_api_wrapper_order_book.bids, bitstamp_api_wrapper_transactions_stub, 0.5, 0.25,
-      store)
+    stub_bitex_active_orders
+    BitexBot::Settings.stub(time_to_live: 3, buying: double(amount_to_spend_per_order: 50, profit: 0))
+
+    flow = subject.class.create_for_market(
+      100,
+      bitstamp_api_wrapper_order_book.bids,
+      bitstamp_api_wrapper_transactions_stub,
+      0.5,
+      0.25,
+      store
+    )
 
     order = subject.class.order_class.find(flow.order_id)
-    order.order_book.should eq BitexBot::Settings.maker_settings.order_book
+    order.order_book.should eq BitexBot::Robot.maker.base_quote.to_sym
   end
 end

data/spec/models/order_book_simulator_spec.rb

@@ -1,6 +1,11 @@
 require 'spec_helper'
 
 describe BitexBot::OrderBookSimulator do
+  before(:each) do
+    BitexBot::Robot.taker = double(base: 'btc', quote: 'usd')
+    BitexBot::Robot.maker = double(base: 'btc', quote: 'usd')
+  end
+
   describe 'when buying on bitex to sell somewhere else' do
     def simulate(volatility, amount)
       BitexBot::OrderBookSimulator.run(volatility, bitstamp_api_wrapper_transactions_stub,

data/spec/models/robot_spec.rb

@@ -4,7 +4,10 @@ describe BitexBot::Robot do
   let(:taker_settings) do
     BitexBot::SettingsClass.new(
       bitstamp: {
-        api_key: 'YOUR_API_KEY', secret: 'YOUR_API_SECRET', client_id: 'YOUR_BITSTAMP_USERNAME'
+        api_key: 'YOUR_API_KEY',
+        secret: 'YOUR_API_SECRET',
+        client_id: 'YOUR_BITSTAMP_USERNAME',
+        order_book: 'btcusd'
       }
     )
   end
@@ -35,7 +38,7 @@ describe BitexBot::Robot do
       ltc_reserved:  100.00000000,   # LTC reserved in open orders
       ltc_available: 150.00000000    # LTC available for trading
     })
-    stub_bitex_orders
+    stub_bitex_active_orders
     stub_bitstamp_sell
     stub_bitstamp_buy
     stub_bitstamp_api_wrapper_balance
@@ -47,7 +50,7 @@ describe BitexBot::Robot do
   let(:bot) { BitexBot::Robot.new }
 
   it 'Starts out by creating opening flows that timeout' do
-    stub_bitex_orders
+    stub_bitex_active_orders
     stub_bitstamp_api_wrapper_order_book
     bot.trade!
 
@@ -187,7 +190,7 @@ describe BitexBot::Robot do
   end
 
   it 'notifies exceptions and sleeps' do
-    BitstampApiWrapper.stub(:balance) { raise StandardError.new('oh moova') }
+    BitstampApiWrapper.any_instance.stub(:balance) { raise StandardError.new('oh moova') }
 
     expect { bot.trade! }.to change { Mail::TestMailer.deliveries.count }.by(1)
   end

data/spec/models/sell_closing_flow_spec.rb

@@ -4,7 +4,10 @@ describe BitexBot::SellClosingFlow do
   let(:taker_settings) do
     BitexBot::SettingsClass.new(
       bitstamp: {
-        api_key: 'YOUR_API_KEY', secret: 'YOUR_API_SECRET', client_id: 'YOUR_BITSTAMP_USERNAME'
+        api_key: 'YOUR_API_KEY',
+        secret: 'YOUR_API_SECRET',
+        client_id: 'YOUR_BITSTAMP_USERNAME',
+        order_book: 'btcusd'
       }
     )
   end
@@ -61,8 +64,8 @@ describe BitexBot::SellClosingFlow do
 
   describe 'when there are errors placing the closing order' do
     it 'keeps trying to place a closed position on bitstamp errors' do
-      BitstampApiWrapper.stub(send_order: nil)
-      BitstampApiWrapper.stub(find_lost: nil)
+      BitstampApiWrapper.any_instance.stub(send_order: nil)
+      BitstampApiWrapper.any_instance.stub(find_lost: nil)
 
       open = create :open_sell
       expect do
@@ -81,9 +84,9 @@ describe BitexBot::SellClosingFlow do
     end
 
     it 'retries until it finds the lost order' do
-      BitstampApiWrapper.stub(send_order: nil)
-      BitstampApiWrapper.stub(:orders) do
-        [BitstampApiWrapper::Order.new(1, :buy, 290, 2, 1.minute.ago.to_i)]
+      BitstampApiWrapper.any_instance.stub(send_order: nil)
+      BitstampApiWrapper.any_instance.stub(:orders) do
+        [ApiWrapper::Order.new(1, :buy, 290, 2, 1.minute.ago.to_i)]
       end
 
       open = create(:open_sell)
@@ -126,7 +129,7 @@ describe BitexBot::SellClosingFlow do
       flow = BitexBot::SellClosingFlow.last
       stub_bitstamp_orders_into_transactions
 
-      flow.sync_closed_positions(Bitstamp.orders.all, Bitstamp.user_transactions.all)
+      flow.sync_closed_positions
 
       close = flow.close_positions.last
       close.amount.should == '583.905'.to_d
@@ -147,7 +150,7 @@ describe BitexBot::SellClosingFlow do
         subject.class.close_open_positions
 
         stub_bitstamp_orders_into_transactions
-        flow.sync_closed_positions(Bitstamp.orders.all, Bitstamp.user_transactions.all)
+        flow.sync_closed_positions
       end
 
       it 'syncs the executed orders, calculates profit with other fx rate' do
@@ -161,13 +164,11 @@ describe BitexBot::SellClosingFlow do
       BitexBot::SellClosingFlow.close_open_positions
       flow = BitexBot::SellClosingFlow.last
 
-      expect do
-        flow.sync_closed_positions(Bitstamp.orders.all, Bitstamp.user_transactions.all)
-      end.not_to change{ BitexBot::CloseSell.count }
+      expect { flow.sync_closed_positions }.not_to change{ BitexBot::CloseSell.count }
       flow.should_not be_done
 
       # Immediately calling sync again does not try to cancel the ask.
-      flow.sync_closed_positions(Bitstamp.orders.all, Bitstamp.user_transactions.all)
+      flow.sync_closed_positions
       Bitstamp.orders.all.size.should == 1
 
       # Partially executes order, and 61 seconds after that
@@ -175,18 +176,15 @@ describe BitexBot::SellClosingFlow do
       stub_bitstamp_orders_into_transactions(ratio: 0.5)
       Timecop.travel 61.seconds.from_now
       Bitstamp.orders.all.size.should == 1
-      expect do
-        flow.sync_closed_positions(Bitstamp.orders.all, Bitstamp.user_transactions.all)
-      end.not_to change{ BitexBot::CloseSell.count }
+      expect { flow.sync_closed_positions }.not_to change{ BitexBot::CloseSell.count }
+
       Bitstamp.orders.all.size.should == 0
       flow.should_not be_done
 
       # Next time we try to sync_closed_positions the flow
       # detects the previous close_buy was cancelled correctly so
       # it syncs it's total amounts and tries to place a new one.
-      expect do
-        flow.sync_closed_positions(Bitstamp.orders.all, Bitstamp.user_transactions.all)
-      end.to change{ BitexBot::CloseSell.count }.by(1)
+      expect { flow.sync_closed_positions }.to change{ BitexBot::CloseSell.count }.by(1)
 
       flow.close_positions.first.tap do |close|
         close.amount.should == '291.9525'.to_d
@@ -197,7 +195,7 @@ describe BitexBot::SellClosingFlow do
       # this closing flow done.
       stub_bitstamp_orders_into_transactions
 
-      flow.sync_closed_positions(Bitstamp.orders.all, Bitstamp.user_transactions.all)
+      flow.sync_closed_positions
       flow.close_positions.last.tap do |close|
         close.amount.should == '291.953597'.to_d
         close.quantity.should == '1.0049'.to_d
@@ -213,15 +211,13 @@ describe BitexBot::SellClosingFlow do
 
       20.times do
         Timecop.travel 60.seconds.from_now
-        flow.sync_closed_positions(Bitstamp.orders.all, Bitstamp.user_transactions.all)
+        flow.sync_closed_positions
       end
 
       stub_bitstamp_orders_into_transactions(ratio: 0.999)
       Bitstamp.orders.all.first.cancel!
 
-      expect do
-        flow.sync_closed_positions(Bitstamp.orders.all, Bitstamp.user_transactions.all)
-      end.not_to change{ BitexBot::CloseSell.count }
+      expect { flow.sync_closed_positions }.not_to change{ BitexBot::CloseSell.count }
 
       flow.should be_done
       flow.crypto_profit.should == '-0.0224895'.to_d
@@ -236,12 +232,12 @@ describe BitexBot::SellClosingFlow do
 
       60.times do
         Timecop.travel 60.seconds.from_now
-        flow.sync_closed_positions(Bitstamp.orders.all, Bitstamp.user_transactions.all)
+        flow.sync_closed_positions
       end
 
       stub_bitstamp_orders_into_transactions
 
-      flow.sync_closed_positions(Bitstamp.orders.all, Bitstamp.user_transactions.all)
+      flow.sync_closed_positions
       flow.reload.should be_done
       flow.crypto_profit.should == '-0.1709'.to_d
       flow.fiat_profit.should == '20.08575'.to_d