bitex 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '03555559d3d82a4f379a04f62d31c8ffaf2ab223'
-  data.tar.gz: 067a8204a071250238538d2b027bc98acc7a8174
+  metadata.gz: 7504b1d05131be725c8c685085de3dd783cd6c19
+  data.tar.gz: 015ab1434b6fb8fc3fb6723293d4c3251a652ac6
 SHA512:
-  metadata.gz: 8ff84068e327879b35f21bdb4eebc3ad1a2b23234f482b4705527b748e2184558b6f44c40e4ce0922daefdcd9e2f2b8be63765068b551167d9b1953555bfc56b
-  data.tar.gz: be63b22da048ff45b8048ceb613150d8f0e731ee0182d700038c9fd6fb73ba5e7e4fe6762c9c48011073801924595fff9bfcecdb0eaf68280035a7b37fd13d29
+  metadata.gz: d2ac3d5ac05de9bb8edd92ab6d4c96aacc7c890d714949f1b65bf52f09ec9350887f9abe6566c087c3396eecb93ccf157a65cd8937f792dbc38c77898c56962e
+  data.tar.gz: 8cfac85e42a66e6a53744ebfdc478612801fb745703e13db5bc3222a623cb89451785dd246fed03361bd53da8e84900d1befc21b8f6cd721de0fa9dec3ea1793

data/lib/bitex.rb

@@ -17,4 +17,8 @@ module Bitex
   mattr_accessor :sandbox
   mattr_accessor :debug
   mattr_accessor :ssl_version
+
+  ORDER_BOOKS = { btc_usd: 1, btc_ars: 5, btc_pyg: 10, btc_clp: 11, btc_uyu: 12 }.freeze
+  class UnknownOrderBook < StandardError
+  end
 end

data/lib/bitex/base_order.rb

@@ -53,7 +53,10 @@ module Bitex
 
     # @visibility private
     def self.create!(order_book, amount, price, wait = false)
-      params = { amount: amount, price: price, orderbook: { btc_usd: 1, btc_ars: 5 }[order_book] }
+      order_book_id = ORDER_BOOKS[order_book]
+      raise UnknownOrderBook, "Could not find order book #{order_book}" unless order_book_id
+
+      params = { amount: amount, price: price, orderbook: order_book_id }
 
       order = from_json(Api.private(:post, "/private#{base_path}", params))
       retries = 0
@@ -83,8 +86,6 @@ module Bitex
       end
     end
 
-    private_class_method
-
     def self.find_order(order)
       find(order.id)
     rescue StandardError
@@ -92,7 +93,7 @@ module Bitex
     end
 
     def self.order_books
-      { 1 => :btc_usd, 5 => :btc_ars }
+      ORDER_BOOKS.invert
     end
 
     def self.reasons
@@ -102,5 +103,7 @@ module Bitex
     def self.statuses
       { 1 => :received, 2 => :executing, 3 => :cancelling, 4 => :cancelled, 5 => :completed }
     end
+
+    private_class_method :find_order, :order_books, :reasons, :statuses
   end
 end

data/lib/bitex/kyc_profile.rb

@@ -113,8 +113,6 @@ module Bitex
       Api.private(:get, '/private/kyc_profiles').map { |kyc| from_json(kyc) }
     end
 
-    private_class_method
-
     def self.sanitize(params)
       params.merge(birth_date: params[:birth_date].strftime('%Y/%m/%d'))
     end

data/lib/bitex/match.rb

@@ -18,12 +18,12 @@ module Bitex
     end
     # rubocop:enable Metrics/AbcSize
 
-    private_class_method
-
     def self.order_books
-      { 1 => :btc_usd, 5 => :btc_ars }
+      ORDER_BOOKS.invert
     end
 
+    private_class_method :order_books
+
     def base_currency
       base_quote[0]
     end

data/lib/bitex/payment.rb

@@ -52,10 +52,10 @@ module Bitex
       Api.private(:post, "#{base_uri}/pos_setup", params)
     end
 
-    private_class_method
-
     def self.base_uri
       '/private/payments'
     end
+
+    private_class_method :base_uri
   end
 end

data/lib/bitex/version.rb

@@ -1,3 +1,3 @@
 module Bitex
-  VERSION = '0.5.0'.freeze
+  VERSION = '0.6.0'.freeze
 end

data/spec/support/order_shared_examples.rb

@@ -35,4 +35,10 @@ shared_examples_for 'Order' do |api_path|
     order.cancel!
     order.status.should == :cancelling
   end
+
+  it 'blows up when unknown order book is requested' do
+    expect do
+      subject.class.create!(:bogus_order_book, 100.50, 1_000.00)
+    end.to raise_error Bitex::UnknownOrderBook
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bitex
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Nubis
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-23 00:00:00.000000000 Z
+date: 2018-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport