bitcoinrb 1.15.0 → 1.16.0

data/lib/bitcoin.rb

@@ -38,6 +38,7 @@ module Bitcoin
   autoload :Base58, 'bitcoin/base58'
   autoload :Secp256k1, 'bitcoin/secp256k1'
   autoload :Mnemonic, 'bitcoin/mnemonic'
+  autoload :Validation, 'bitcoin/validation'
   autoload :ValidationState, 'bitcoin/validation'
   autoload :RPC, 'bitcoin/rpc'
   autoload :Wallet, 'bitcoin/wallet'
@@ -50,7 +51,6 @@ module Bitcoin
   autoload :KeyPath, 'bitcoin/key_path'
   autoload :Descriptor, 'bitcoin/descriptor'
   autoload :SLIP39, 'bitcoin/slip39'
-  autoload :Aezeed, 'bitcoin/aezeed'
   autoload :PaymentCode, 'bitcoin/payment_code'
   autoload :BIP85Entropy, 'bitcoin/bip85_entropy'
   autoload :Errors, 'bitcoin/errors'
@@ -121,7 +121,11 @@ module Bitcoin
     end
 
     # hex string convert to binary
+    # @raise [ArgumentError] If this is not a hex string of even length. An odd length would be padded
+    # with a zero nibble and a character which is not a hex digit would be read as one, so that for
+    # example a 63 character private key would silently become a different key.
     def htb
+      raise ArgumentError, 'Not a hex string of even length.' unless valid_hex?
       [self].pack('H*')
     end
 
@@ -164,7 +168,7 @@ module Bitcoin
       when Bitcoin::Opcodes::OP_PUSHDATA4
         offset += 4
       end
-      self[offset..-1]
+      self[offset..-1] || '' # A length field cut short leaves no data.
     end
 
     def valid_pushdata_length?
@@ -185,19 +189,27 @@ module Bitcoin
             else
               opcode
             end
+      return false if len.nil? # The length field itself is cut short.
       self.bytesize == len + offset
     end
 
     # whether value is hex or not hex
-    # @return [Boolean] return true if data is hex
+    # @return [Boolean] return true if data is hex of even length, including an empty string. A string
+    # which is not valid in its encoding, e.g. binary data labelled as UTF-8, is not hex either.
     def valid_hex?
-      !self[/\H/]
+      # Matching the bytes does not raise for an invalid byte sequence. A valid ASCII compatible string
+      # is matched as it is, to avoid a copy.
+      bytes = valid_encoding? && encoding.ascii_compatible? ? self : b
+      bytes.bytesize.even? && !bytes.match?(/[^0-9a-fA-F]/)
     end
 
   end
 
   class ::Integer
+    # @return [String] the hex string of this integer, padded to an even length.
+    # @raise [ArgumentError] If this is negative, which has no such hex string: to_s(16) gives it a '-' sign.
     def to_even_length_hex
+      raise ArgumentError, 'A negative integer has no even length hex string.' if negative?
       hex = to_s(16)
       hex.rjust((hex.length / 2.0).ceil * 2, '0')
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bitcoinrb
 version: !ruby/object:Gem::Version
-  version: 1.15.0
+  version: 1.16.0
 platform: ruby
 authors:
 - azuchi
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: murmurhash3
   requirement: !ruby/object:Gem::Requirement
@@ -43,14 +43,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.6.0
 - !ruby/object:Gem::Dependency
   name: siphash
   requirement: !ruby/object:Gem::Requirement
@@ -71,14 +71,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: 0.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: 0.8.0
 - !ruby/object:Gem::Dependency
   name: base32
   requirement: !ruby/object:Gem::Requirement
@@ -107,20 +107,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.2.0
+- !ruby/object:Gem::Dependency
+  name: bigdecimal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: secp256k1rb
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 0.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 0.8.1
 - !ruby/object:Gem::Dependency
   name: logger
   requirement: !ruby/object:Gem::Requirement
@@ -307,6 +321,7 @@ files:
 - lib/bitcoin/psbt/tx.rb
 - lib/bitcoin/rpc.rb
 - lib/bitcoin/rpc/bitcoin_core_client.rb
+- lib/bitcoin/rpc/error.rb
 - lib/bitcoin/script/multisig.rb
 - lib/bitcoin/script/script.rb
 - lib/bitcoin/script/script_error.rb