bitcoin-ruby 0.0.11 → 0.0.12

data/spec/bitcoin/key_spec.rb

@@ -252,6 +252,13 @@ describe "Bitcoin::Key" do
     k.to_base58.should == "5JBAonQ4iGKFJxENExZghDtAS6YB8BsCw5mwpHSvZvP3Q2UxmT1"
   end
 
+  it "should raise error for private key out of range." do
+    proc{Bitcoin::Key.new('FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFEBAAEDCE6AF48A03BBFD25E8CD0364141')}.should.raise(Exception)
+    proc{Bitcoin::Key.new('00')}.should.raise(Exception)
+    proc{Bitcoin::Key.new('FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFEBAAEDCE6AF48A03BBFD25E8CD0364140')}.should.not.raise(Exception)
+    proc{Bitcoin::Key.new('01')}.should.not.raise(Exception)
+  end
+
 end
 
 begin

data/spec/bitcoin/protocol/tx_spec.rb

@@ -30,6 +30,9 @@ describe 'Tx' do
     proc{
       Tx.new( @payload[0][0..20] )
     }.should.raise Exception
+
+    # Deserializing a new, empty transaction works
+    Tx.new(Tx.new.to_payload)
   end
 
   it '#parse_data' do
@@ -38,18 +41,22 @@ describe 'Tx' do
     tx.hash.should == nil
     tx.parse_data( @payload[0] ).should == true
     tx.hash.size.should == 64
+    tx.payload.should == @payload[0]
 
     tx = Tx.new( nil )
     tx.parse_data( @payload[0] + "AAAA" ).should == "AAAA"
     tx.hash.size.should == 64
+    tx.payload.should == @payload[0]
   end
 
   it '#parse_witness_data' do
     tx = Tx.new( @payload[3] )
     tx.hash.size.should == 64
+    tx.payload.should == @payload[3]
 
     tx = Tx.new( @payload[3] + "AAAA" )
     tx.hash.size.should == 64
+    tx.payload.should == @payload[3]
   end
 
   it '#hash' do
@@ -110,6 +117,7 @@ describe 'Tx' do
   it 'Tx.from_hash' do
     orig_tx = Tx.new( @payload[0] )
     tx = Tx.from_hash( orig_tx.to_hash )
+    tx.payload.should == @payload[0]
     tx.to_payload.size.should == @payload[0].size
     tx.to_payload.should      == @payload[0]
     tx.to_hash.should == orig_tx.to_hash
@@ -122,6 +130,7 @@ describe 'Tx' do
     # witness tx(P2WPKH)
     orig_tx = Tx.new( @payload[3] )
     tx = Tx.from_hash( orig_tx.to_hash )
+    tx.payload.should == @payload[3]
     tx.to_witness_payload.size.should == @payload[3].size
     tx.to_witness_payload.should == @payload[3]
     tx.to_hash == orig_tx.to_hash
@@ -463,64 +472,80 @@ describe 'Tx' do
     tx.verify_witness_input_signature(0, 'a9149993a429037b5d912407a71c252019287b8d27a587'.htb, 987654321).should == true
   end
 
-  it '#sign_input_signature' do
-    prev_tx = Tx.new( fixtures_file('rawtx-2f4a2717ec8c9f077a87dde6cbe0274d5238793a3f3f492b63c744837285e58a.bin') )
-    prev_tx.hash.should == "2f4a2717ec8c9f077a87dde6cbe0274d5238793a3f3f492b63c744837285e58a"
+  describe '#signature_hash_for_input' do
+    it 'sighash_all' do
+      prev_tx = Tx.new( fixtures_file('rawtx-2f4a2717ec8c9f077a87dde6cbe0274d5238793a3f3f492b63c744837285e58a.bin') )
+      prev_tx.hash.should == "2f4a2717ec8c9f077a87dde6cbe0274d5238793a3f3f492b63c744837285e58a"
 
-    key = Bitcoin.open_key("56e28a425a7b588973b5db962a09b1aca7bdc4a7268cdd671d03c52a997255dc",
-      pubkey="04324c6ebdcf079db6c9209a6b715b955622561262cde13a8a1df8ae0ef030eaa1552e31f8be90c385e27883a9d82780283d19507d7fa2e1e71a1d11bc3a52caf3")
-    new_tx = Tx.new(nil)
-    new_tx.add_in( TxIn.new(prev_tx.binary_hash, 0, 0) )
-    new_tx.add_out( TxOut.value_to_address(1000000, "1BVJWLTCtjA8wRivvrCiwjNdL6KjdMUCTZ") )
-    signature_hash = new_tx.signature_hash_for_input(0, prev_tx)
-    sig = Bitcoin.sign_data(key, signature_hash)
-    new_tx.in[0].script_sig = Bitcoin::Script.to_pubkey_script_sig(sig, [pubkey].pack("H*"))
+      key = Bitcoin.open_key("56e28a425a7b588973b5db962a09b1aca7bdc4a7268cdd671d03c52a997255dc",
+                             pubkey="04324c6ebdcf079db6c9209a6b715b955622561262cde13a8a1df8ae0ef030eaa1552e31f8be90c385e27883a9d82780283d19507d7fa2e1e71a1d11bc3a52caf3")
+      new_tx = Tx.new(nil)
+      new_tx.add_in( TxIn.new(prev_tx.binary_hash, 0, 0) )
+      new_tx.add_out( TxOut.value_to_address(1000000, "1BVJWLTCtjA8wRivvrCiwjNdL6KjdMUCTZ") )
+      signature_hash = new_tx.signature_hash_for_input(0, prev_tx)
+      sig = Bitcoin.sign_data(key, signature_hash)
+      new_tx.in[0].script_sig = Bitcoin::Script.to_pubkey_script_sig(sig, [pubkey].pack("H*"))
 
-    new_tx = Tx.new( new_tx.to_payload )
-    new_tx.hash.should != nil
-    new_tx.verify_input_signature(0, prev_tx).should == true
+      new_tx = Tx.new( new_tx.to_payload )
+      new_tx.hash.should != nil
+      new_tx.verify_input_signature(0, prev_tx).should == true
 
 
 
-    prev_tx = Tx.new( fixtures_file('rawtx-14be6fff8c6014f7c9493b4a6e4a741699173f39d74431b6b844fcb41ebb9984.bin') )
-    prev_tx.hash.should == "14be6fff8c6014f7c9493b4a6e4a741699173f39d74431b6b844fcb41ebb9984"
+      prev_tx = Tx.new( fixtures_file('rawtx-14be6fff8c6014f7c9493b4a6e4a741699173f39d74431b6b844fcb41ebb9984.bin') )
+      prev_tx.hash.should == "14be6fff8c6014f7c9493b4a6e4a741699173f39d74431b6b844fcb41ebb9984"
 
-    key = Bitcoin.open_key("115ceda6c1e02d41ce65c35a30e82fb325fe3f815898a09e1a5d28bb1cc92c6e",
-            pubkey="0409d103127d26ce93ee41f1b9b1ed4c1c243acf48e31eb5c4d88ad0342ccc010a1a8d838846cf7337f2b44bc73986c0a3cb0568fa93d068b2c8296ce8d47b1545")
-    new_tx = Tx.new(nil)
-    new_tx.add_in( TxIn.new(prev_tx.binary_hash, 0, 0) )
-    pk_script = Bitcoin::Script.to_address_script("1FEYAh1x5jeKQMPPuv3bKnKvbgVAqXvqjW")
-    new_tx.add_out( TxOut.new(1000000, pk_script) )
-    signature_hash = new_tx.signature_hash_for_input(0, prev_tx)
-    sig = Bitcoin.sign_data(key, signature_hash)
-    new_tx.in[0].script_sig = Bitcoin::Script.to_pubkey_script_sig(sig, [pubkey].pack("H*"))
+      key = Bitcoin.open_key("115ceda6c1e02d41ce65c35a30e82fb325fe3f815898a09e1a5d28bb1cc92c6e",
+                             pubkey="0409d103127d26ce93ee41f1b9b1ed4c1c243acf48e31eb5c4d88ad0342ccc010a1a8d838846cf7337f2b44bc73986c0a3cb0568fa93d068b2c8296ce8d47b1545")
+      new_tx = Tx.new(nil)
+      new_tx.add_in( TxIn.new(prev_tx.binary_hash, 0, 0) )
+      pk_script = Bitcoin::Script.to_address_script("1FEYAh1x5jeKQMPPuv3bKnKvbgVAqXvqjW")
+      new_tx.add_out( TxOut.new(1000000, pk_script) )
+      signature_hash = new_tx.signature_hash_for_input(0, prev_tx)
+      sig = Bitcoin.sign_data(key, signature_hash)
+      new_tx.in[0].script_sig = Bitcoin::Script.to_pubkey_script_sig(sig, [pubkey].pack("H*"))
 
-    new_tx = Tx.new( new_tx.to_payload )
-    new_tx.hash.should != nil
-    new_tx.verify_input_signature(0, prev_tx).should == true
+      new_tx = Tx.new( new_tx.to_payload )
+      new_tx.hash.should != nil
+      new_tx.verify_input_signature(0, prev_tx).should == true
 
 
 
-    prev_tx = Tx.new( fixtures_file('rawtx-b5d4e8883533f99e5903ea2cf001a133a322fa6b1370b18a16c57c946a40823d.bin') )
-    prev_tx.hash.should == "b5d4e8883533f99e5903ea2cf001a133a322fa6b1370b18a16c57c946a40823d"
+      prev_tx = Tx.new( fixtures_file('rawtx-b5d4e8883533f99e5903ea2cf001a133a322fa6b1370b18a16c57c946a40823d.bin') )
+      prev_tx.hash.should == "b5d4e8883533f99e5903ea2cf001a133a322fa6b1370b18a16c57c946a40823d"
 
-    key = Bitcoin.open_key("56e28a425a7b588973b5db962a09b1aca7bdc4a7268cdd671d03c52a997255dc",
-      pubkey="04324c6ebdcf079db6c9209a6b715b955622561262cde13a8a1df8ae0ef030eaa1552e31f8be90c385e27883a9d82780283d19507d7fa2e1e71a1d11bc3a52caf3")
-    new_tx = Tx.new(nil)
-    new_tx.add_in( TxIn.new(prev_tx.binary_hash, 0, 0) )
-    new_tx.add_out( TxOut.value_to_address(1000000, "14yz7fob6Q16hZu4nXfmv1kRJpSYaFtet5") )
-    signature_hash = new_tx.signature_hash_for_input(0, prev_tx)
-    sig = Bitcoin.sign_data(key, signature_hash)
-    new_tx.in[0].script_sig = Bitcoin::Script.to_pubkey_script_sig(sig, [pubkey].pack("H*"))
+      key = Bitcoin.open_key("56e28a425a7b588973b5db962a09b1aca7bdc4a7268cdd671d03c52a997255dc",
+                             pubkey="04324c6ebdcf079db6c9209a6b715b955622561262cde13a8a1df8ae0ef030eaa1552e31f8be90c385e27883a9d82780283d19507d7fa2e1e71a1d11bc3a52caf3")
+      new_tx = Tx.new(nil)
+      new_tx.add_in( TxIn.new(prev_tx.binary_hash, 0, 0) )
+      new_tx.add_out( TxOut.value_to_address(1000000, "14yz7fob6Q16hZu4nXfmv1kRJpSYaFtet5") )
+      signature_hash = new_tx.signature_hash_for_input(0, prev_tx)
+      sig = Bitcoin.sign_data(key, signature_hash)
+      new_tx.in[0].script_sig = Bitcoin::Script.to_pubkey_script_sig(sig, [pubkey].pack("H*"))
 
-    new_tx = Tx.new( new_tx.to_payload )
-    new_tx.hash.should != nil
-    new_tx.verify_input_signature(0, prev_tx).should == true
+      new_tx = Tx.new( new_tx.to_payload )
+      new_tx.hash.should != nil
+      new_tx.verify_input_signature(0, prev_tx).should == true
+    end
 
-    #File.open("rawtx-#{new_tx.hash}.bin",'wb'){|f| f.print new_tx.to_payload }
-    prev_tx = Tx.new( fixtures_file('rawtx-52250a162c7d03d2e1fbc5ebd1801a88612463314b55102171c5b5d817d2d7b2.bin') )
-    prev_tx.hash.should == "52250a162c7d03d2e1fbc5ebd1801a88612463314b55102171c5b5d817d2d7b2"
-    #File.open("rawtx-#{prev_tx.hash}.json",'wb'){|f| f.print prev_tx.to_json }
+    it 'sighash JSON tests' do
+      test_cases = JSON.parse(fixtures_file('sighash.json'))
+      test_cases.each do |test_case|
+        # Single element arrays in tests are comments.
+        next if test_case.length == 1
+
+        transaction = Bitcoin::Protocol::Tx.new(test_case[0].htb)
+        subscript = test_case[1].htb
+        input_index = test_case[2].to_i
+        hash_type = test_case[3]
+        amount = 0
+        expected_sighash = test_case[4].htb_reverse
+
+        actual_sighash = transaction.signature_hash_for_input(
+          input_index, subscript, hash_type, amount, 0)
+        actual_sighash.should == expected_sighash
+      end
+    end
   end
 
   it '#signature_hash_for_witness_input' do
@@ -758,5 +783,109 @@ describe 'Tx' do
     tx.out[1].pk_script.bth.should == 'bbbbbbbb'
     tx.out[2].pk_script.bth.should == 'cccccccc'
   end
-  
+
+  describe 'verify_input_signature' do
+    def parse_script(script_str)
+      script = Bitcoin::Script.new('')
+
+      buf = ""
+      script_str.split.each do |token|
+        opcode = Bitcoin::Script::OPCODES_PARSE_STRING[token] ||
+                 Bitcoin::Script::OPCODES_PARSE_STRING['OP_' + token]
+        if opcode
+          buf << [opcode].pack('C')
+          next
+        end
+
+        data =
+          case token
+          when /\A-?\d+\z/
+            i = token.to_i
+            opcode =
+              case i
+              when -1 then Bitcoin::Script::OP_1NEGATE
+              when 0 then Bitcoin::Script::OP_0
+              when 1 then Bitcoin::Script::OP_1
+              when 2..16 then Bitcoin::Script::OP_2 + i - 2
+              end
+
+            if opcode
+              [opcode].pack('C')
+            else
+              Bitcoin::Script.pack_pushdata(script.cast_to_string(i))
+            end
+          when /\A'(.*)'\z/ then Bitcoin::Script.pack_pushdata($1)
+          when /\A0x([0-9a-fA-F]+)\z/ then $1.htb
+          else raise "Unexpected token #{token}"
+          end
+        buf << data
+      end
+      buf
+    end
+
+    def parse_flags(flags_str)
+      flags_str.split(',').each_with_object({}) do |flag_str, opts|
+        case flag_str.to_sym
+        when :STRICTENC then opts[:verify_strictenc] = true
+        when :DERSIG then opts[:verify_dersig] = true
+        when :LOW_S then opts[:verify_low_s] = true
+        when :SIGPUSHONLY then opts[:verify_sigpushonly] = true
+        when :MINIMALDATA then opts[:verify_minimaldata] = true
+        when :CLEANSTACK then opts[:verify_cleanstack] = true
+        when :SIGHASH_FORKID then opts[:fork_id] = 0
+        end
+      end
+    end
+
+    it 'script JSON tests' do
+      test_cases = JSON.parse(fixtures_file('script_tests.json'))
+      test_cases.each_with_index do |test_case, i|
+        # Single element arrays in tests are comments.
+        next if test_case.length == 1
+
+        value =
+          if test_case[0].is_a?(Array)
+            (test_case.shift[0] * 10**8).to_i
+          else
+            0
+          end
+
+        # TODO: Implement these opcodes correctly
+        next if test_case[0].match(/CHECKLOCKTIMEVERIFY|CHECKSEQUENCEVERIFY|RESERVED|0x50|VERIF|VERNOTIF/)
+        next if test_case[1].match(/CHECKLOCKTIMEVERIFY|CHECKSEQUENCEVERIFY|RESERVED|0x50|VERIF|VERNOTIF/)
+
+        script_sig = parse_script(test_case[0])
+        script_pubkey = parse_script(test_case[1])
+        opts = parse_flags(test_case[2])
+        expect_success = test_case[3] == 'OK'
+
+        # A lot of the test cases are failing, so for now we only test the SIGHASH_FORKID ones.
+        # TODO: Get this spec passing without this line.
+        next unless opts[:fork_id]
+
+        crediting_tx = Tx.new
+        crediting_tx.add_in(TxIn.new)
+        crediting_tx.in[0].prev_out_hash = TxIn::NULL_HASH
+        crediting_tx.in[0].prev_out_index = TxIn::COINBASE_INDEX
+        crediting_tx.in[0].script_sig = parse_script('0 0')
+        crediting_tx.add_out(TxOut.new)
+        crediting_tx.out[0].value = value
+        crediting_tx.out[0].pk_script = script_pubkey
+        crediting_tx.refresh_hash
+
+        spending_tx = Tx.new
+        spending_tx.add_in(TxIn.new)
+        spending_tx.in[0].prev_out_hash = crediting_tx.binary_hash
+        spending_tx.in[0].prev_out_index = 0
+        spending_tx.in[0].script_sig = script_sig
+        spending_tx.add_out(TxOut.new)
+        spending_tx.out[0].value = value
+        spending_tx.out[0].pk_script = ''
+        spending_tx.refresh_hash
+
+        success = spending_tx.verify_input_signature(0, crediting_tx, Time.now.to_i, opts)
+        success.should == expect_success
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bitcoin-ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - lian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-05 00:00:00.000000000 Z
+date: 2017-10-24 00:00:00.000000000 Z
 dependencies: []
 description: This is a ruby library for interacting with the bitcoin protocol/network
 email:
@@ -155,6 +155,8 @@ files:
 - spec/bitcoin/fixtures/reorg/blk_3A.dat
 - spec/bitcoin/fixtures/reorg/blk_4A.dat
 - spec/bitcoin/fixtures/reorg/blk_5A.dat
+- spec/bitcoin/fixtures/script_tests.json
+- spec/bitcoin/fixtures/sighash.json
 - spec/bitcoin/fixtures/testnet/block_0.bin
 - spec/bitcoin/fixtures/testnet/block_1.bin
 - spec/bitcoin/fixtures/testnet/block_2.bin
@@ -259,7 +261,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: bitcoin-ruby
-rubygems_version: 2.6.11
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: bitcoin utils and protocol in ruby
@@ -356,6 +358,8 @@ test_files:
 - spec/bitcoin/fixtures/reorg/blk_3A.dat
 - spec/bitcoin/fixtures/reorg/blk_4A.dat
 - spec/bitcoin/fixtures/reorg/blk_5A.dat
+- spec/bitcoin/fixtures/script_tests.json
+- spec/bitcoin/fixtures/sighash.json
 - spec/bitcoin/fixtures/testnet/block_0.bin
 - spec/bitcoin/fixtures/testnet/block_1.bin
 - spec/bitcoin/fixtures/testnet/block_2.bin