bisu 1.7.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bed28be32f24a03d0e812b3ad88980911bd4d13a
-  data.tar.gz: 13f1165c2bf416965c75e24553f5f2672a91f1ec
+SHA256:
+  metadata.gz: 14ce8b0b059747d79f5a63fc910129774a634d015bf02563ac888dc80c735ed0
+  data.tar.gz: 5158d8f04815351d0850c52d948a2dcebb5bb267a8154e716c31d01334fdd379
 SHA512:
-  metadata.gz: 2e4ebf64ac0b36be4fa1f058347a7029a676986289a216120bc22f680c9bbcdca545660017f2da39a2a6a05f822c3cf110820ce579d8c20f149fb16257e3adc3
-  data.tar.gz: fb3ce272578ae914ca44b785a456dec185c87435a0abba11c1debb328e2dec1909bdf2d2648b40dda9b0030d63283b28120d16ac22db95f3b2347c84e3da181f
+  metadata.gz: 2773ab4e5ea6f8b0f419650e2cd4f551dacfb43d438e892a98bb9ca317774a82c61122ad232de1cd1ede184178ac502352bc356702144b70f73b7912a23adcba
+  data.tar.gz: 1bae10ebc6fb6a915d2c2122b4ceff3341b426eb47543b9e1502242e47804aa9599ef3c22f4abd62b915177d83d4a0b6a3cf08f8e7fa4aaa5ae505a8c3538429

data/.rspec

@@ -1,5 +1,4 @@
 --color
 --format documentation
 --profile
---drb
 --require spec_helper

data/.ruby-version

@@ -0,0 +1 @@
+2.7.3

data/.travis.yml

@@ -0,0 +1 @@
+language: ruby

data/CHANGELOG.md

@@ -2,6 +2,36 @@
 All notable changes to this project will be documented in this file.
 `Bisu` adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.9.0](https://github.com/hole19/bisu/releases/tag/v1.9.0)
+Released on 2021/05/21
+
+#### Added
+- Adds a new option to surpress missing params when that's intentional: add "//ignore-params" to the end of the translation key
+
+## [1.8.0](https://github.com/hole19/bisu/releases/tag/v1.8.0)
+Released on 2020/04/30
+
+#### Added
+- Adds a new option: allows a single translation to have a specific fallback language (example: "es-MX" fallback to "es")
+
+## [1.7.3](https://github.com/hole19/bisu/releases/tag/v1.7.3)
+Released on 2020/03/09
+
+#### Added
+- Correctly handles percentage sign on iOS platform
+
+## [1.7.2](https://github.com/hole19/bisu/releases/tag/v1.7.2)
+Released on 2020/03/09
+
+#### Added
+- Correctly handles percentage sign on Android platform
+
+## [1.7.1](https://github.com/hole19/bisu/releases/tag/v1.7.1)
+Released on 2019/03/04
+
+#### Added
+- Applies the same new line behaviour in every platform
+
 ## [1.7.0](https://github.com/hole19/bisu/releases/tag/v1.7.0)
 Released on 2019/02/18
 

data/Gemfile

@@ -1,10 +1,13 @@
 source 'https://rubygems.org'
-ruby '2.3.1'
+ruby '2.7.3'
 
 gem 'safe_yaml',  '~> 1.0'
 gem 'colorize',   '~> 0.7'
 gem 'xml-simple', '~> 1.1'
 
-gem 'webmock',    '~> 1.20'
-gem 'rspec'
-gem 'rspec-its'
+group :test do
+  gem 'rake'
+  gem 'webmock',    '~> 1.20'
+  gem 'rspec'
+  gem 'rspec-its'
+end

data/Gemfile.lock

@@ -1,40 +1,45 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.4.0)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
     colorize (0.8.1)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
-    diff-lcs (1.2.5)
-    hashdiff (0.3.0)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    crack (0.4.5)
+      rexml
+    diff-lcs (1.4.4)
+    hashdiff (1.0.1)
+    public_suffix (4.0.6)
+    rake (13.0.3)
+    rexml (3.2.5)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-its (1.2.0)
+      rspec-support (~> 3.10.0)
+    rspec-its (1.3.0)
       rspec-core (>= 3.0.0)
       rspec-expectations (>= 3.0.0)
-    rspec-mocks (3.5.0)
+    rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    safe_yaml (1.0.4)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
+    safe_yaml (1.0.5)
     webmock (1.24.6)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff
-    xml-simple (1.1.5)
+    xml-simple (1.1.8)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   colorize (~> 0.7)
+  rake
   rspec
   rspec-its
   safe_yaml (~> 1.0)
@@ -42,7 +47,7 @@ DEPENDENCIES
   xml-simple (~> 1.1)
 
 RUBY VERSION
-   ruby 2.3.1p112
+   ruby 2.7.3p183
 
 BUNDLED WITH
-   1.14.3
+   2.1.4

data/README.md

@@ -1,9 +1,14 @@
 Bisu 홀
 ========
 
+[![Status](https://travis-ci.org/hole19/bisu.svg?branch=master)](https://travis-ci.org/hole19/bisu?branch=master)
+[![Gem](https://img.shields.io/gem/v/bisu.svg?style=flat)](http://rubygems.org/gems/bisu "View this project in Rubygems")
+
 Bisu manages your app iOS, Android and RoR localization files for you. No more copy+paste induced errors!
 
----
+<p align="center">
+  <img src="https://raw.githubusercontent.com/hole19/bisu/master/README_explanation.png" width="500">
+</p>
 
 Instalation
 -----
@@ -19,9 +24,9 @@ Usage
 1. Run: `bisu`
 1. That's it!*
 
-*given that someone already configured Bisu
+\*_given that someone already configured Bisu_
 
-Configuration
+Setup your configuration file
 -----
 
 1. Create in your project base folder a translatable.yml:
@@ -30,9 +35,7 @@ Configuration
   type: <iOS|Android|RoR>
 
   dictionary:
-    type: google_sheet
-    sheet_id: <GOOGLE-DRIVE-SHEET-ID>
-    keys_column: <GOOGLE-DRIVE-KEY-COLUMN-TITLE>
+    (see options below)
 
   translate:
     - in: path/to/1st/file.translatable
@@ -42,22 +45,39 @@ Configuration
       out: path/to/2nd-%{locale}/strings.xml
 
   languages:
-    - locale:   en
-      language: en
-    - locale:   en-US
-      language: en
-    - locale:   pt
+    - locale: en
+      language: en # the language as it appears in the dictionary
+    - locale: en-US
+      language: en-us
+      fallback_language: en
+    - locale: pt
       language: pt
   ```
 
-  Also available generic URL source:
+##### Dictionary from a URL source:
+
   ```
   dictionary:
     type: url
     url: <A-GET-URL>
   ```
 
-  Also available [OneSky](https://www.oneskyapp.com) integration:
+##### Google Sheets Dictionary:
+
+1. First ["Publish to the web"](https://www.google.com/search?q=google+sheets+publish+to+web) your Google Sheet
+1. Share only the sheet that contains the translations
+1. First column should contain the translation keys
+1. First row should contain the locale for each language
+
+  ```
+  dictionary:
+    type: google_sheet
+    sheet_id: <GOOGLE-DRIVE-SHEET-ID>
+    keys_column: <GOOGLE-DRIVE-KEY-COLUMN-TITLE>
+  ```
+
+##### OneSky integration:
+
   ```
   dictionary:
     type: one_sky
@@ -67,7 +87,13 @@ Configuration
     file_name: <ONE-SKY-FILE-NAME>
   ```
 
-1. Create a \*.translatable version for your **iOS** localization files:
+Create translation templates
+-----
+
+Create a \*.translatable version for your platform specific localization files:
+
+##### iOS
+*example: Localizable.strings.translatable*
 
   ```
   // $specialKComment1$
@@ -82,10 +108,11 @@ Configuration
   "klGeneral_Delete" = "$kDelete$";
   "klGeneral_Cancel" = "$kCancel$";
   "klGeneral_Close"  = "$kClose$";
-  "klRequestName"    = "$kRequestName%{user_name: %@}$";
+  "klRequestName"    = "$kRequestName{user_name: %@}$";
   ```
 
-1. Create a \*.translatable version for your **Android** localization files:
+##### Android
+*example: strings.xml.translatable*
 
   ```
   <?xml version="1.0" encoding="utf-8"?>
@@ -98,11 +125,12 @@ Configuration
       <string name="delete">$kDelete$</string>
       <string name="cancel">$kCancel$</string>
       <string name="close">$kClose$</string>
-      <string name="request_name">$kRequestName%{user_name: %s}$</string>
+      <string name="request_name">$kRequestName{user_name: %s}$</string>
   </resources>
   ```
 
-1. Create a \*.translatable version for your **RoR** localization files:
+##### Ruby on Rails
+*example: config/locales/yml.translatable*
 
   ```
   $specialKLocale$:

data/Rakefile

@@ -1,8 +1,9 @@
-require 'rake/testtask'
+require "rake"
+require "rspec/core/rake_task"
 
-Rake::TestTask.new do |t|
-  t.libs << 'test'
+RSpec::Core::RakeTask.new(:spec) do |t|
+  t.pattern = Dir.glob("spec/**/*_spec.rb")
+  t.rspec_opts = "--format documentation"
 end
 
-desc "Run tests"
-task :default => :test
+task default: :spec

data/lib/bisu.rb

@@ -23,13 +23,15 @@ module Bisu
       dictionary   = dictionary_for(config: config.dictionary, options: options)
       localizer    = Bisu::Localizer.new(dictionary, config.type)
 
-      config.localize_files do |in_path, out_path, language, locale|
+      config.localize_files do |in_path, out_path, locale, language, fallback_language|
         unless dictionary.has_language?(language)
           Logger.error("Unknown language #{language}")
           return false
         end
 
-        localize_file(localizer, locale, language, options[:default_language], in_path, out_path)
+        fallback_languages = ([fallback_language] + [options[:default_language]]).compact
+
+        localize_file(localizer, locale, language, fallback_languages, in_path, out_path)
       end
     end
 
@@ -131,14 +133,14 @@ module Bisu
     File.open(File.expand_path(file_name), method)
   end
 
-  def localize_file(localizer, locale, language, default_language, in_path, out_path)
+  def localize_file(localizer, locale, language, fallback_languages, in_path, out_path)
     Logger.info("Translating #{in_path} to #{language} > #{out_path}...")
 
     return false unless in_file  = open_file(in_path,  "r", true)
     return false unless out_file = open_file(out_path, "w", false)
 
     in_file.each_line do |line|
-      out_file.write(localizer.localize(line, language, locale, default_language))
+      out_file.write(localizer.localize(line, language, locale, fallback_languages))
     end
 
     out_file.flush

data/lib/bisu/config.rb

@@ -27,7 +27,7 @@ module Bisu
       @hash[:translate].each do |t|
         @hash[:languages].each do |l|
           downcase_locale = l[:locale].downcase.gsub("-", "_").gsub(" ", "_")
-          yield(t[:in], (t[:"out_#{downcase_locale}"] || t[:out]) % l, l[:language], l[:locale])
+          yield(t[:in], (t[:"out_#{downcase_locale}"] || t[:out]) % l, l[:locale], l[:language], l[:fallback_language])
         end
       end
     end
@@ -50,7 +50,8 @@ module Bisu
         languages: { type: Array, elements: {
           type: Hash, elements: {
             locale: { type: String },
-            language: { type: String }
+            language: { type: String },
+            fallback_language: { type: String, optional: true }
           }
         } }
       }

data/lib/bisu/localizer.rb

@@ -10,7 +10,7 @@ module Bisu
       end
     end
 
-    def localize(text, language, locale, fallback_language=nil)
+    def localize(text, language, locale, fallback_languages=[])
       t = text
       t = t.gsub("$specialKLanguage$", language)
       t = t.gsub("$specialKLocale$", locale)
@@ -18,7 +18,9 @@ module Bisu
       t = t.gsub("$specialKComment2$", "Remember to CHANGE THE TEMPLATE and not this file!")
 
       to_localize(t).map do |l|
-        if localized = @dict.localize(language, l[:key]) || @dict.localize(fallback_language, l[:key])
+        if localized = localize_key(l[:key], [language] + fallback_languages)
+          localized = process(localized)
+
           l[:params].each do |param, value|
             if localized.match("%{#{param}}")
               localized = localized.gsub("%{#{param}}", value)
@@ -27,25 +29,35 @@ module Bisu
             end
           end
 
-          unless t.gsub!(l[:match], process(localized))
+          unless t.gsub!(l[:match], localized)
             Logger.warn("Could not find translation for #{l[:match]} in #{language}")
           end
+
+          unless @type.eql?(:ror) || l[:ignore_param_warn] == true
+            localized.scan(/%{[^}]+}/) { |match| Logger.error("Could not find translation param for #{match} in #{language}") }
+          end
         else
           Logger.warn("Could not find translation for #{l[:match]} in #{language}")
         end
       end
 
-      unless @type.eql?(:ror)
-        t.scan(/%{[^}]+}/) { |match| Logger.error("Could not find translation param for #{match} in #{language}") }
+      t
+    end
+
+    def localize_key(key, ordered_languages)
+      ordered_languages.each do |language|
+        if localized = @dict.localize(language, key)
+          return localized
+        end
       end
 
-      t
+      nil
     end
 
     private
 
     def to_localize(text)
-      all_matches = text.to_enum(:scan, /\$([^\$\{]+)(?:\{(.+)\})?\$/).map { Regexp.last_match }
+      all_matches = text.to_enum(:scan, /\$([^\$\{\/]+)(?:\{(.+)\})?(\/\/ignore-params)?\$/).map { Regexp.last_match }
       all_matches.map do |match|
         params = if match[2]
           params = match[2].split(",").map(&:strip).map do |param|
@@ -55,21 +67,28 @@ module Bisu
           Hash[params]
         end
 
-        { match:  match[0],
+        {
+          match:  match[0],
           key:    match[1],
-          params: params || {} }
+          params: params || {},
+          ignore_param_warn: text.include?("//ignore-params")
+        }
       end
     end
 
     def process(text)
+      text = text.gsub("\n", "\\n")
+
       if @type.eql?(:android)
         text = text.gsub(/[']/, "\\\\\\\\'")
         text = text.gsub("...", "…")
         text = text.gsub("& ", "& ")
         text = text.gsub("@", "\\\\@")
+        text = text.gsub(/%(?!{)/, "\\\\%%")
 
       elsif @type.eql?(:ios)
         text = text.gsub(/\"/, "\\\\\"")
+        text = text.gsub(/%(?!{)/, "%%")
       end
 
       text

data/lib/bisu/version.rb

@@ -1,4 +1,4 @@
 module Bisu
-  VERSION = '1.7.0'
-  VERSION_UPDATED_AT = '2019-02-18'
+  VERSION = '1.9.0'
+  VERSION_UPDATED_AT = '2021-05-21'
 end

data/spec/fixtures/sample.translatable.yml

@@ -15,4 +15,5 @@ languages:
   - locale: en
     language: english
   - locale: en-US
-    language: english
+    language: english-us
+    fallback_language: english

data/spec/lib/bisu/config_spec.rb

@@ -22,7 +22,7 @@ describe Bisu::Config do
       { locale: "en-US",      language: "english"    },
       { locale: "pt",         language: "portuguese" },
       { locale: "pt-PT",      language: "portuguese" },
-      { locale: "pt-Batatas", language: "portuguese" }
+      { locale: "pt-Batatas", language: "portuguese-bt", fallback_language: "portuguese" }
     ]
   } }
 
@@ -75,14 +75,14 @@ describe Bisu::Config do
       expect { |b|
         config.localize_files(&b)
       }.to yield_successive_args(
-        ["path/to/file/to/1.ext.translatable", "path/to/default/1.ext",          "english",    "en-US"     ],
-        ["path/to/file/to/1.ext.translatable", "path/to/final-pt/1.ext",         "portuguese", "pt"        ],
-        ["path/to/file/to/1.ext.translatable", "path/to/final-pt-PT/1.ext",      "portuguese", "pt-PT"     ],
-        ["path/to/file/to/1.ext.translatable", "path/to/final-pt-Batatas/1.ext", "portuguese", "pt-Batatas"],
-        ["path/to/file/to/2.ext.translatable", "path/to/default/2.ext",          "english",    "en-US"     ],
-        ["path/to/file/to/2.ext.translatable", "path/to/final-pt/2.ext",         "portuguese", "pt"        ],
-        ["path/to/file/to/2.ext.translatable", "path/to/final-pt-PT/2.ext",      "portuguese", "pt-PT"     ],
-        ["path/to/file/to/2.ext.translatable", "path/to/final-pt-Batatas/2.ext", "portuguese", "pt-Batatas"]
+        ["path/to/file/to/1.ext.translatable", "path/to/default/1.ext",          "en-US",      "english",       nil         ],
+        ["path/to/file/to/1.ext.translatable", "path/to/final-pt/1.ext",         "pt",         "portuguese",    nil         ],
+        ["path/to/file/to/1.ext.translatable", "path/to/final-pt-PT/1.ext",      "pt-PT",      "portuguese",    nil         ],
+        ["path/to/file/to/1.ext.translatable", "path/to/final-pt-Batatas/1.ext", "pt-Batatas", "portuguese-bt", "portuguese"],
+        ["path/to/file/to/2.ext.translatable", "path/to/default/2.ext",          "en-US",      "english",       nil         ],
+        ["path/to/file/to/2.ext.translatable", "path/to/final-pt/2.ext",         "pt",         "portuguese",    nil         ],
+        ["path/to/file/to/2.ext.translatable", "path/to/final-pt-PT/2.ext",      "pt-PT",      "portuguese",    nil         ],
+        ["path/to/file/to/2.ext.translatable", "path/to/final-pt-Batatas/2.ext", "pt-Batatas", "portuguese-bt", "portuguese"]
       )
     end
   end

data/spec/lib/bisu/localizer_spec.rb

@@ -1,4 +1,9 @@
 describe Bisu::Localizer do
+  def translates(text, fallbacks: [], to:, lang: nil)
+    translation = localizer.localize(text, lang || language, locale, fallbacks)
+    expect(translation).to eq to
+  end
+
   let(:language) { "Portuguese" }
   let(:locale)   { "pt-PT" }
 
@@ -8,13 +13,19 @@ describe Bisu::Localizer do
       "kTranslationKey2" => "Naaada!",
       "k1ParameterKey"   => "Não sabes nada %{name}",
       "k2ParametersKey"  => "Sabes %{perc} por cento %{name}",
+      "kNewLineSingle"   => "Não sabes nada\nJoão das Neves",
+      "kNewLineMultiple" => "Não sabes nada\\nJoão das Neves",
 
       # type dependent translations
       "kDoubleQuoted"    => "Não sabes nada \"João das Neves\"",
       "kSingleQuoted"    => "Não sabes nada 'João das Neves'",
       "kEllipsis"        => "Não sabes nada João das Neves...",
       "kAmpersand"       => "Não sabes nada João das Neves & Pícaros",
-      "kAtSign"          => "\@johnsnow sabes alguma coisa?"
+      "kAtSign"          => "\@johnsnow sabes alguma coisa?",
+      "kPercentage"      => "Sabes 0% João das Neves."
+    },
+    "Spanish" => {
+      "kMissingTransKey" => "Sabes poco John Snow"
     },
     "English" => {
       "kMissingTransKey" => "You know little John Snow"
@@ -27,11 +38,6 @@ describe Bisu::Localizer do
   shared_examples_for "a localizer" do
     it { expect { localizer }.not_to raise_error }
 
-    def translates(text, fallback: nil, to:, lang: nil)
-      translation = localizer.localize(text, lang || language, locale, fallback)
-      expect(translation).to eq to
-    end
-
     it { translates("a line with no key", to: "a line with no key") }
 
     it { translates("this special key: $specialKComment1$", to: "this special key: This file was automatically generated based on a translation template.") }
@@ -43,7 +49,8 @@ describe Bisu::Localizer do
     it { translates("this key: $kTranslationKey$", to: "this key: Não sabes nada João das Neves", lang: "portuguese") }
     it { translates("this unknown key: $kUnknownKey$", to: "this unknown key: $kUnknownKey$") }
     it { translates("this key with missing translations: $kMissingTransKey$", to: "this key with missing translations: $kMissingTransKey$") }
-    it { translates("this key with missing translations: $kMissingTransKey$", fallback: "English", to: "this key with missing translations: You know little John Snow") }
+    it { translates("this key with missing translations: $kMissingTransKey$", fallbacks: ["English"], to: "this key with missing translations: You know little John Snow") }
+    it { translates("this key with missing translations: $kMissingTransKey$", fallbacks: ["Spanish", "English"], to: "this key with missing translations: Sabes poco John Snow") }
     it { translates("these 2 keys: $kTranslationKey$, $kTranslationKey2$", to: "these 2 keys: Não sabes nada João das Neves, Naaada!") }
 
     it { translates("1 parameter: $k1ParameterKey$",                         to: "1 parameter: Não sabes nada %{name}") }
@@ -52,6 +59,9 @@ describe Bisu::Localizer do
     it { translates("2 parameters: $k2ParametersKey{perc:%2$d, name:%1$s}$", to: "2 parameters: Sabes %2$d por cento %1$s") }
     it { translates("2 parameters: $k2ParametersKey{name:%1$s, perc:%2$d}$", to: "2 parameters: Sabes %2$d por cento %1$s") }
 
+    it { translates("$kNewLineSingle$",   to: "Não sabes nada\\nJoão das Neves") }
+    it { translates("$kNewLineMultiple$", to: "Não sabes nada\\nJoão das Neves") }
+
     # type dependent translations
 
     it { translates("$kDoubleQuoted$", to: expected[:double_quoted]) }
@@ -59,6 +69,7 @@ describe Bisu::Localizer do
     it { translates("$kEllipsis$",     to: expected[:ellipsis]) }
     it { translates("$kAmpersand$",    to: expected[:ampersand]) }
     it { translates("$kAtSign$",       to: expected[:at_sign]) }
+    it { translates("$kPercentage$",   to: expected[:percentage]) }
 
     # error handling
 
@@ -76,7 +87,7 @@ describe Bisu::Localizer do
        .and not_change { Bisu::Logger.summary[:error] }
     end
 
-    it "throws an error when missing key parameters (expect on ruby on rails)" do
+    it "throws a error when missing key parameters (expect on ruby on rails)" do
       if type == :ror
         expect {
           localizer.localize("$k1ParameterKey$", language, locale)
@@ -103,6 +114,17 @@ describe Bisu::Localizer do
       }.to not_change { Bisu::Logger.summary[:warn] }
        .and change { Bisu::Logger.summary[:error] }.by(1)
     end
+
+    # non localizable text with params
+
+    it "does not try to translate params outside $$" do
+      translates("%{some_text}", to: "%{some_text}")
+
+      expect {
+        localizer.localize("%{some_text}", language, locale)
+      }.to not_change { Bisu::Logger.summary[:warn] }
+       .and not_change { Bisu::Logger.summary[:error] }
+    end
   end
 
   let(:type_dependent_defaults) { {
@@ -110,17 +132,46 @@ describe Bisu::Localizer do
     single_quoted: keys[language]["kSingleQuoted"],
     ellipsis:      keys[language]["kEllipsis"],
     ampersand:     keys[language]["kAmpersand"],
-    at_sign:       keys[language]["kAtSign"]
+    at_sign:       keys[language]["kAtSign"],
+    percentage:    keys[language]["kPercentage"]
   } }
 
   describe "of type iOS" do
     let(:type) { :ios }
 
     let(:expected) { type_dependent_defaults.merge(
-      double_quoted: "Não sabes nada \\\"João das Neves\\\""
+      double_quoted: "Não sabes nada \\\"João das Neves\\\"",
+      percentage: "Sabes 0%% João das Neves."
     ) }
 
     it_behaves_like "a localizer"
+
+    context "when a parameter replacemnt was not defined" do
+      let(:line) { "1 parameter: $k1ParameterKey$" }
+      let(:expected) { "1 parameter: Não sabes nada %{name}" }
+
+      it { translates(line, to: expected) }
+
+      it "returns an error" do
+        expect {
+          localizer.localize(line, language, locale)
+        }.to not_change { Bisu::Logger.summary[:warn] }
+         .and change { Bisu::Logger.summary[:error] }.by(1)
+      end
+
+      context "when passing //ignore-params" do
+        let(:line) { "1 parameter: $k1ParameterKey//ignore-params$" }
+
+        it { translates(line, to: expected) }
+
+        it "does not return an error" do
+          expect {
+            localizer.localize(line, language, locale)
+          }.to not_change { Bisu::Logger.summary[:warn] }
+           .and not_change { Bisu::Logger.summary[:error] }
+        end
+      end
+    end
   end
 
   describe "of type Android" do
@@ -130,7 +181,8 @@ describe Bisu::Localizer do
       single_quoted: "Não sabes nada \\'João das Neves\\'",
       ellipsis: "Não sabes nada João das Neves…",
       ampersand: "Não sabes nada João das Neves & Pícaros",
-      at_sign: "\\@johnsnow sabes alguma coisa?"
+      at_sign: "\\@johnsnow sabes alguma coisa?",
+      percentage: "Sabes 0\\%% João das Neves."
     ) }
 
     it_behaves_like "a localizer"

data/spec/lib/bisu/source/one_sky_spec.rb

@@ -45,7 +45,7 @@ describe Bisu::Source::OneSky do
       expect(to_i18).to eq({
         "en" => {
           "kRegularNewLine" => "This is the first line\\nthis is the second line",
-          "kErrorNewLine" => "This is the first line\\nthis is the second line"
+          "kErrorNewLine"   => "This is the first line\\nthis is the second line"
         }
       })
     end

data/spec/lib/bisu_spec.rb

@@ -7,7 +7,8 @@ describe Bisu do
     before do
       allow(Bisu).to receive(:open_file).and_return(file)
       allow_any_instance_of(Bisu::Source::GoogleSheet).to receive(:to_i18).and_return({
-        "english" => { "kKey" => "Value" }
+        "english" => { "kKey" => "Value" },
+        "english-us" => { "kKey" => "Value" }
       })
       allow(Bisu).to receive(:localize_file)
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bisu
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.9.0
 platform: ruby
 authors:
 - joaoffcosta
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-18 00:00:00.000000000 Z
+date: 2021-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: safe_yaml
@@ -74,12 +74,14 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
 - ".rspec"
+- ".ruby-version"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - README.md
+- README_explanation.png
 - Rakefile
 - bin/bisu
 - bisu.gemspec
@@ -129,8 +131,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: A localization automation service

data/.gitignore

@@ -1 +0,0 @@
-.ruby-version