bisu 1.4.2 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 99d4468262164cad922609d84154ed59b2886ce9
-  data.tar.gz: 3d8c75a9fd72a75041d481cbaed00033e9b19a83
+  metadata.gz: 446a726b593e73b165a48ac438000b7599964496
+  data.tar.gz: 8dcf59ab1e303d41eaf2d748e52d62faa1fe8fe4
 SHA512:
-  metadata.gz: c392b28a1c3fbefcdb027fd4fbc5ed752949c5e18b072a379966ab3086b089bc9b0877c40da575664a5f6a470fe260d54b30ae0a385817afad96c84870c6bfda
-  data.tar.gz: 24b2b02a51a114e09bcd01eb1a3b0f50b17b751b804b66b49ff21c497460ec802f501ab56ba27662de12c9a35864bacd4a4278298e43e7d9952495bb89cc996b
+  metadata.gz: e0da63cddc2297390bf8a3e3d6d292946f4c59fd82ed50d3d4e86f87a99ceee26d443921d77d2d876c9863352b5470f9affa30e882e42366f4927b8b7d57cc3a
+  data.tar.gz: d9c5b5038f8068379fd06a6e320e504903014e99d2bc129c27da2fa8ff2c51f971bc89376350feb11e78b26c1146bae5a2f0de846138b8dbc800aee03aca9c0b

data/bisu.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'safe_yaml',  '~> 1.0'
   s.add_runtime_dependency 'colorize',   '~> 0.7'
   s.add_runtime_dependency 'xml-simple', '~> 1.1'
-  s.add_runtime_dependency 'onesky-ruby', '~> 1.0.1'
+  s.add_runtime_dependency 'onesky-ruby', '~> 1.0'
 
   s.add_development_dependency 'webmock', '~> 1.20'
 end

data/lib/bisu/one_sky.rb

@@ -18,7 +18,8 @@ module Bisu
       hash.each do |lang, v|
         hash[lang] = v["translation"]
         hash[lang].each do |key, text|
-          hash[lang][key] = hash[lang][key].join("\n") if hash[lang][key].is_a? Array
+          hash[lang][key] = hash[lang][key].join("\\n") if hash[lang][key].is_a? Array
+          hash[lang][key] = hash[lang][key].gsub("\n", "\\n") # fixes the 'stupid newline bug'
         end
       end
 

data/lib/bisu/version.rb

@@ -1,4 +1,4 @@
 module Bisu
-  VERSION = '1.4.2'
-  VERSION_UPDATED_AT = '2016-12-12'
+  VERSION = '1.4.3'
+  VERSION_UPDATED_AT = '2016-12-22'
 end

data/spec/fixtures/sample_one_sky_response_with_bug.txt

@@ -0,0 +1,8 @@
+{
+    "en": {
+        "translation": {
+            "kRegularNewLine": "This is the first line\\nthis is the second line",
+            "kErrorNewLine": "This is the first line\nthis is the second line"
+        }
+    }
+}

data/spec/lib/bisu/one_sky_spec.rb

@@ -22,7 +22,7 @@ describe Bisu::OneSky do
       "ja" => { "kConnectFacebook" => "フェイスブックへ接続" },
       "fr" => { "kConnectFacebook" => "Connexion par Facebook" },
       "de" => { "kConnectFacebook" => "Mit Facebook verbinden" },
-      "ko" => { "kConnectFacebook" => "페이스북으로 접속", "kTwitterServer" => "트위터 서버연결 실패. \n잠시 후 재시도." }
+      "ko" => { "kConnectFacebook" => "페이스북으로 접속", "kTwitterServer" => "트위터 서버연결 실패. \\n잠시 후 재시도." }
     })
   end
 
@@ -33,4 +33,19 @@ describe Bisu::OneSky do
       expect { to_i18 }.to raise_error /not allowed/
     end
   end
+
+  context "when OneSky returns the newline bug" do
+    let(:os_response) { File.read("spec/fixtures/sample_one_sky_response_with_bug.txt") }
+
+    it { expect { to_i18 }.not_to raise_error }
+
+    it "returns an hash in i18 format with the newline bug fixed" do
+      expect(to_i18).to eq({
+        "en" => {
+          "kRegularNewLine" => "This is the first line\\nthis is the second line",
+          "kErrorNewLine" => "This is the first line\\nthis is the second line"
+        }
+      })
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bisu
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.4.3
 platform: ruby
 authors:
 - joaoffcosta
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-12 00:00:00.000000000 Z
+date: 2016-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: safe_yaml
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -111,6 +111,7 @@ files:
 - spec/fixtures/sample_kb_public_info.html
 - spec/fixtures/sample_kb_public_sheet.html
 - spec/fixtures/sample_one_sky_response.txt
+- spec/fixtures/sample_one_sky_response_with_bug.txt
 - spec/lib/bisu/config_spec.rb
 - spec/lib/bisu/dictionary_spec.rb
 - spec/lib/bisu/google_sheet_spec.rb