biryani 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62514e8d943c7f5b5c21f863faabb9e45ec813225f6b5f0b60f2afb5c784c1ce
-  data.tar.gz: 9767186d0fbef80e454f7e5a5fb3183cf36637160bb73c969bf9ce20075764d0
+  metadata.gz: 33f21fe89774fbe47cfaa0f36bb1eaaabc333701ffce568c410818aa86c6441d
+  data.tar.gz: 290247cccbfbf21eb1d6d4e93b1f39a4cfb5dbe26fcef278f9804f95221e7ec1
 SHA512:
-  metadata.gz: 3127dc1a2ac8bd3b7c46c7cb6bab33f62a3f74aee3a9a645a1e3afe08705ceee7c35365f7e3d4374c08f80c473fc6dd712ff4cdc0713d1cc9e0da17605294a19
-  data.tar.gz: 2af8f94e69c662da0b69a39fa8c41adcc506352a9db81bc4c469283f457fd724a5d56cd966916648a44d3a12bd8f392f9fb816010d28c141b0a7d611d7070ba7
+  metadata.gz: eed8eb6993bdc77026e12b52836a0970bc6ed6ba024f05bb278049e38ddf9528dadea31c8d42660f0d0c38da08295ac7343702436512d0de148f4f6d82205811
+  data.tar.gz: abffb2767adcddc3556a22367a7a67c78cbc636de1dfa794b65f421c5ac15c30a546e3641edf607bce8119c3c2420856700bbc19439883fc0a74b4fcb3623bc6

data/biryani.gemspec

@@ -13,8 +13,11 @@ Gem::Specification.new do |spec|
   spec.license       = 'MIT'
   spec.required_ruby_version = '>=4.0'
 
-  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
+    `git ls-files -z`.split("\x0").reject do |f|
+      (f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
+    end
+  end
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler'

data/lib/biryani/connection.rb

@@ -71,10 +71,9 @@ module Biryani
     # rubocop: disable Metrics/PerceivedComplexity
     def send_loop(io)
       loop do
-        ports = @streams_ctx.txs
-        break if ports.empty? && @sock.closed?
+        break if @sock.closed? && @streams_ctx.empty?
 
-        port, obj = Ractor.select(@sock, *ports)
+        port, obj = Ractor.select(@sock, @streams_ctx.tx)
         if port == @sock
           if Biryani.err?(obj)
             reply_frame = Biryani.unwrap(obj, @streams_ctx.last_stream_id)
@@ -104,7 +103,6 @@ module Biryani
           self.class.send_data(io, stream_id, data, @send_window, max_frame_size, @streams_ctx, @data_buffer) unless data.empty?
         end
 
-        @streams_ctx.remove_closed(@data_buffer)
         break if closed?
       end
     end
@@ -182,7 +180,7 @@ module Biryani
       max_streams = @peer_settings[SettingsID::SETTINGS_MAX_CONCURRENT_STREAMS]
       send_initial_window_size = @peer_settings[SettingsID::SETTINGS_INITIAL_WINDOW_SIZE]
       recv_initial_window_size = @settings[SettingsID::SETTINGS_INITIAL_WINDOW_SIZE]
-      obj = self.class.transition_stream_state_recv(frame, @streams_ctx, stream_id, max_streams, send_initial_window_size, recv_initial_window_size)
+      obj = self.class.transition_stream_state_recv(frame, @streams_ctx, @data_buffer, stream_id, max_streams, send_initial_window_size, recv_initial_window_size)
       return [obj] if Biryani.err?(obj)
 
       ctx = obj
@@ -237,6 +235,7 @@ module Biryani
     # @param recv_frame [Object]
     # @param streams_ctx [StreamsContext]
     # @param stream_id [Integer]
+    # @param data_buffer [DataBuffer]
     # @param max_streams [Integer]
     # @param send_initial_window_size [Integer]
     # @param recv_initial_window_size [Integer]
@@ -244,13 +243,18 @@ module Biryani
     # @return [StreamContext, StreamError, ConnectionError]
     # rubocop: disable Metrics/CyclomaticComplexity
     # rubocop: disable Metrics/PerceivedComplexity
-    def self.transition_stream_state_recv(recv_frame, streams_ctx, stream_id, max_streams, send_initial_window_size, recv_initial_window_size)
+    def self.transition_stream_state_recv(recv_frame, streams_ctx, data_buffer, stream_id, max_streams, send_initial_window_size, recv_initial_window_size)
       ctx = streams_ctx[stream_id]
       return StreamError.new(ErrorCode::PROTOCOL_ERROR, stream_id, 'exceed max concurrent streams') if ctx.nil? && streams_ctx.count_active + 1 > max_streams
       return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'even-numbered stream identifier') if ctx.nil? && stream_id.even?
       return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'new stream identifier is less than the existing stream identifiers') if ctx.nil? && streams_ctx.last_stream_id > stream_id
 
-      ctx = streams_ctx.new_context(stream_id, send_initial_window_size, recv_initial_window_size) if ctx.nil?
+      if ctx.nil?
+        ctx = streams_ctx.new_context(stream_id, send_initial_window_size, recv_initial_window_size)
+        # An ideal implementation would wait the RTT before removing the stream.
+        streams_ctx.remove_closed(data_buffer)
+      end
+
       obj = ctx.state_transition!(recv_frame, :recv)
       return obj if Biryani.err?(obj)
 

data/lib/biryani/hpack/field.rb

@@ -9,7 +9,7 @@ module Biryani
       # @return [String]
       def self.encode(name, value, dynamic_table)
         case find(name, value, dynamic_table)
-        in Some(index, v) if v.nil?
+        in Some(index, nil)
           res = encode_indexed(index)
         in Some(index, v)
           res = encode_literal_value(index, v)
@@ -145,8 +145,7 @@ module Biryani
       # @return [Integer]
       def self.decode_indexed(io, cursor, dynamic_table)
         index, c = Integer.decode(io, 7, cursor)
-        raise Error::HPACKDecodeError if index.zero?
-        raise Error::HPACKDecodeError if index > STATIC_TABLE_SIZE + dynamic_table.count_entries
+        raise Error::HPACKDecodeError if index.zero? || index > STATIC_TABLE_SIZE + dynamic_table.count_entries
 
         field = if index <= STATIC_TABLE_SIZE
                   STATIC_TABLE[index - 1]
@@ -203,8 +202,7 @@ module Biryani
       # @return [Integer]
       def self.decode_literal_value_incremental_indexing(io, cursor, dynamic_table)
         index, c = Integer.decode(io, 6, cursor)
-        raise Error::HPACKDecodeError if index.zero?
-        raise Error::HPACKDecodeError if index > STATIC_TABLE_SIZE + dynamic_table.count_entries
+        raise Error::HPACKDecodeError if index.zero? || index > STATIC_TABLE_SIZE + dynamic_table.count_entries
 
         name = if index <= STATIC_TABLE_SIZE
                  STATIC_TABLE[index - 1][0]
@@ -283,8 +281,7 @@ module Biryani
       # @return [Integer]
       def self.decode_literal_value_never_indexed(io, cursor, dynamic_table)
         index, c = Integer.decode(io, 4, cursor)
-        raise Error::HPACKDecodeError if index.zero?
-        raise Error::HPACKDecodeError if index > STATIC_TABLE_SIZE + dynamic_table.count_entries
+        raise Error::HPACKDecodeError if index.zero? || index > STATIC_TABLE_SIZE + dynamic_table.count_entries
 
         name = if index <= STATIC_TABLE_SIZE
                  STATIC_TABLE[index - 1][0]
@@ -339,8 +336,7 @@ module Biryani
       # @return [Integer]
       def self.decode_literal_value_without_indexing(io, cursor, dynamic_table)
         index, c = Integer.decode(io, 4, cursor)
-        raise Error::HPACKDecodeError if index.zero?
-        raise Error::HPACKDecodeError if index > STATIC_TABLE_SIZE + dynamic_table.count_entries
+        raise Error::HPACKDecodeError if index.zero? || index > STATIC_TABLE_SIZE + dynamic_table.count_entries
 
         name = if index <= STATIC_TABLE_SIZE
                  STATIC_TABLE[index - 1][0]

data/lib/biryani/state.rb

@@ -255,7 +255,7 @@ module Biryani
 
     # @return [Boolean]
     def receiving_continuation?
-      %i[receiving_continuation receiving_continuation_and_data].include?(@state)
+      %i[receiving_continuation receiving_continuation_and_data receiving_trailer_continuation].include?(@state)
     end
   end
 end

data/lib/biryani/streams_context.rb

@@ -1,8 +1,11 @@
 module Biryani
   class StreamsContext
+    attr_accessor :tx
+
     def initialize(proc)
       @h = {} # Hash<Integer, StreamContext>
       @proc = proc
+      @tx = Ractor::Port.new
     end
 
     # @param stream_id [Integer]
@@ -11,7 +14,7 @@ module Biryani
     #
     # @return [StreamContext]
     def new_context(stream_id, send_initial_window_size, recv_initial_window_size)
-      ctx = StreamContext.new(stream_id, send_initial_window_size, recv_initial_window_size, @proc)
+      ctx = StreamContext.new(stream_id, send_initial_window_size, recv_initial_window_size, @proc, @tx)
       @h[stream_id] = ctx
       ctx
     end
@@ -33,13 +36,13 @@ module Biryani
       @h.length
     end
 
-    def each(&block)
-      @h.each_value(&block)
+    # @return [Boolean]
+    def empty?
+      @h.empty?
     end
 
-    # @return [Array<Port>]
-    def txs
-      @h.values.filter { |ctx| !ctx.closed? }.map(&:tx)
+    def each(&block)
+      @h.each_value(&block)
     end
 
     # @return [Integer]
@@ -88,28 +91,25 @@ module Biryani
     def remove_closed(data_buffer)
       closed_ids = closed_stream_ids.filter { |id| !data_buffer.has?(id) }
       closed_ids.each do |id|
-        @h[id].tx.close
+        @h.delete(id)
       end
     end
 
     def close_all
-      each do |ctx|
-        ctx.tx.close
-        ctx.close
-      end
+      each(&:close)
     end
   end
 
   class StreamContext
-    attr_accessor :tx, :send_window, :recv_window, :fragment, :content
+    attr_accessor :send_window, :recv_window, :fragment, :content
 
     # @param stream_id [Integer]
     # @param send_initial_window_size [Integer]
     # @param recv_initial_window_size [Integer]
     # @param proc [Proc]
-    def initialize(stream_id, send_initial_window_size, recv_initial_window_size, proc)
-      @tx = Ractor::Port.new
-      @stream = Stream.new(@tx, stream_id, proc)
+    # @param tx [Ractor::Port]
+    def initialize(stream_id, send_initial_window_size, recv_initial_window_size, proc, tx)
+      @stream = Stream.new(tx, stream_id, proc)
       @send_window = Window.new(send_initial_window_size)
       @recv_window = Window.new(recv_initial_window_size)
       @fragment = ''.b

data/lib/biryani/version.rb

@@ -1,3 +1,3 @@
 module Biryani
-  VERSION = '0.0.8'.freeze
+  VERSION = '0.0.9'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: biryani
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - thekuwayama
@@ -30,9 +30,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/workflows/ci.yml"
-- ".github/workflows/conformance.yml"
-- ".gitignore"
 - ".rubocop.yml"
 - ".ruby-version"
 - Gemfile
@@ -83,40 +80,6 @@ files:
 - lib/biryani/utils.rb
 - lib/biryani/version.rb
 - lib/biryani/window.rb
-- spec/connection/handle_connection_window_update_spec.rb
-- spec/connection/handle_data_spec.rb
-- spec/connection/handle_headers_spec.rb
-- spec/connection/handle_ping_spec.rb
-- spec/connection/handle_rst_stream_spec.rb
-- spec/connection/handle_settings_spec.rb
-- spec/connection/handle_stream_window_update_spec.rb
-- spec/connection/read_http2_magic_spec.rb
-- spec/connection/send_spec.rb
-- spec/connection/transition_stream_state_send_spec.rb
-- spec/data_buffer_spec.rb
-- spec/frame/continuation_spec.rb
-- spec/frame/data_spec.rb
-- spec/frame/goaway_spec.rb
-- spec/frame/headers_spec.rb
-- spec/frame/ping_spec.rb
-- spec/frame/priority_spec.rb
-- spec/frame/push_promise_spec.rb
-- spec/frame/read_spec.rb
-- spec/frame/rst_stream_spec.rb
-- spec/frame/settings_spec.rb
-- spec/frame/window_update_spec.rb
-- spec/hpack/decoder_spec.rb
-- spec/hpack/encoder_spec.rb
-- spec/hpack/field_spec.rb
-- spec/hpack/fields_spec.rb
-- spec/hpack/huffman_spec.rb
-- spec/hpack/integer_spec.rb
-- spec/hpack/string_spec.rb
-- spec/http_request_spec.rb
-- spec/http_response_spec.rb
-- spec/spec_helper.rb
-- spec/streams_context_spec.rb
-- spec/utils_spec.rb
 homepage: https://github.com/thekuwayama/biryani
 licenses:
 - MIT
@@ -138,38 +101,4 @@ requirements: []
 rubygems_version: 4.0.6
 specification_version: 4
 summary: An HTTP/2 server implemented using Ruby Ractor
-test_files:
-- spec/connection/handle_connection_window_update_spec.rb
-- spec/connection/handle_data_spec.rb
-- spec/connection/handle_headers_spec.rb
-- spec/connection/handle_ping_spec.rb
-- spec/connection/handle_rst_stream_spec.rb
-- spec/connection/handle_settings_spec.rb
-- spec/connection/handle_stream_window_update_spec.rb
-- spec/connection/read_http2_magic_spec.rb
-- spec/connection/send_spec.rb
-- spec/connection/transition_stream_state_send_spec.rb
-- spec/data_buffer_spec.rb
-- spec/frame/continuation_spec.rb
-- spec/frame/data_spec.rb
-- spec/frame/goaway_spec.rb
-- spec/frame/headers_spec.rb
-- spec/frame/ping_spec.rb
-- spec/frame/priority_spec.rb
-- spec/frame/push_promise_spec.rb
-- spec/frame/read_spec.rb
-- spec/frame/rst_stream_spec.rb
-- spec/frame/settings_spec.rb
-- spec/frame/window_update_spec.rb
-- spec/hpack/decoder_spec.rb
-- spec/hpack/encoder_spec.rb
-- spec/hpack/field_spec.rb
-- spec/hpack/fields_spec.rb
-- spec/hpack/huffman_spec.rb
-- spec/hpack/integer_spec.rb
-- spec/hpack/string_spec.rb
-- spec/http_request_spec.rb
-- spec/http_response_spec.rb
-- spec/spec_helper.rb
-- spec/streams_context_spec.rb
-- spec/utils_spec.rb
+test_files: []

data/.github/workflows/ci.yml

@@ -1,30 +0,0 @@
-name: lint & test
-
-on:
-  push:
-    branches:
-      - main
-  pull_request:
-    branches:
-      - '*'
-
-jobs:
-  ci:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        ruby-version: ['4.0']
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - name: Set up Ruby
-        uses: ruby/setup-ruby@ae195bbe749a7cef685ac729197124a48305c1cb # v1.276.0
-        with:
-          ruby-version: ${{ matrix.ruby-version }}
-      - name: Install dependencies
-        run: |
-          gem --version
-          gem install bundler
-          bundle --version
-          bundle install
-      - name: Run rubocop & rspec
-        run: bundle exec rake

data/.github/workflows/conformance.yml

@@ -1,46 +0,0 @@
-name: h2spec
-
-on:
-  push:
-    branches:
-      - main
-  pull_request:
-    branches:
-      - '*'
-
-jobs:
-  conformance:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      checks: write
-    strategy:
-      matrix:
-        ruby-version: ['4.0']
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - name: Set up Ruby
-        uses: ruby/setup-ruby@ae195bbe749a7cef685ac729197124a48305c1cb # v1.276.0
-        with:
-          ruby-version: ${{ matrix.ruby-version }}
-      - name: Install dependencies
-        run: |
-          gem --version
-          gem install bundler
-          bundle --version
-          bundle install
-      - name: Install h2spec
-        run: |
-          set -eu
-          curl -Ls https://github.com/summerwind/h2spec/releases/download/v2.6.0/h2spec_linux_amd64.tar.gz | tar xz
-          mkdir -p $GITHUB_WORKSPACE/bin
-          mv h2spec $GITHUB_WORKSPACE/bin/h2spec
-          chmod +x $GITHUB_WORKSPACE/bin/h2spec
-          echo $GITHUB_WORKSPACE/bin >> $GITHUB_PATH
-      - name: Run conformance test
-        run: bundle exec rake conformance
-      - uses: mikepenz/action-junit-report@a294a61c909bd8a4b563024a2faa28897fd53ebc # v6.1.0
-        if: success()
-        with:
-          report_paths: conformance/reports/h2spec.xml
-          detailed_summary: true

data/.gitignore

@@ -1,18 +0,0 @@
-*.gem
-*.rbc
-.config
-.rvmrc
-/.bundle/
-/vendor/
-/lib/bundler/man/
-/pkg/
-/.yardoc/
-/_yardoc/
-/doc/
-/rdoc/
-/coverage/
-/spec/reports/
-/conformance/reports/
-/tmp/
-.DS_Store
-Gemfile.lock

data/spec/connection/handle_connection_window_update_spec.rb

@@ -1,16 +0,0 @@
-require_relative '../spec_helper'
-
-RSpec.describe Connection do
-  context 'handle_connection_window_update' do
-    let(:window_update) do
-      Frame::WindowUpdate.new(0, 1000)
-    end
-    let(:send_window) do
-      Window.new(65_535)
-    end
-    it 'should handle' do
-      expect { Connection.handle_connection_window_update(window_update, send_window) }.not_to raise_error
-      expect(send_window.length).to eq 2**16 - 1 + 1000
-    end
-  end
-end

data/spec/connection/handle_data_spec.rb

@@ -1,58 +0,0 @@
-require_relative '../spec_helper'
-
-RSpec.describe Connection do
-  context 'handle_data' do
-    let(:decoder) do
-      HPACK::Decoder.new(4_096)
-    end
-
-    let(:recv_window1) do
-      Window.new(65_535)
-    end
-    let(:streams_ctx1) do
-      streams_ctx = StreamsContext.new(do_nothing_proc)
-      streams_ctx.new_context(1, 65_535, 65_535)
-      streams_ctx.new_context(2, 65_535, 65_535)
-      streams_ctx
-    end
-    it 'should handle' do
-      expect(Connection.handle_data(2, 'Hello, world!', recv_window1, streams_ctx1, decoder)).to eq []
-      expect(streams_ctx1[2].content).to eq 'Hello, world!'
-    end
-
-    let(:recv_window2) do
-      recv_window = Window.new(65_535)
-      recv_window.consume!(65_535 / 2)
-      recv_window
-    end
-    let(:streams_ctx2) do
-      streams_ctx = StreamsContext.new(do_nothing_proc)
-      streams_ctx.new_context(1, 65_535, 65_535)
-      streams_ctx.new_context(2, 65_535, 65_535)
-      streams_ctx[2].recv_window.consume!(65_535 / 2)
-      streams_ctx
-    end
-    it 'should handle' do
-      frames = Connection.handle_data(2, 'Hello, world!', recv_window2, streams_ctx2, decoder)
-      expect(frames.map(&:f_type)).to eq [FrameType::WINDOW_UPDATE, FrameType::WINDOW_UPDATE]
-      expect(frames.map(&:stream_id)).to eq [0, 2]
-      expect(frames.map(&:window_size_increment)).to eq [65_535 / 2 + 13, 65_535 / 2 + 13]
-      expect(streams_ctx2[2].content).to eq 'Hello, world!'
-    end
-
-    let(:recv_window3) do
-      recv_window = Window.new(65_535)
-      recv_window.consume!(65_535)
-      recv_window
-    end
-    let(:streams_ctx3) do
-      streams_ctx = StreamsContext.new(do_nothing_proc)
-      streams_ctx.new_context(1, 65_535, 65_535)
-      streams_ctx.new_context(2, 65_535, 65_535)
-      streams_ctx
-    end
-    it 'should not handle' do
-      expect(Connection.handle_data(2, 'Hello, world!', recv_window3, streams_ctx3, decoder)).to be_kind_of ConnectionError
-    end
-  end
-end

data/spec/connection/handle_headers_spec.rb

@@ -1,19 +0,0 @@
-require_relative '../spec_helper'
-
-RSpec.describe Connection do
-  context 'handle_headers' do
-    let(:headers) do
-      Frame::Headers.new(true, false, 2, nil, nil, 'this is dummy', nil)
-    end
-    let(:ctx) do
-      StreamContext.new(2, 65_535, 65_535, do_nothing_proc)
-    end
-    let(:decoder) do
-      HPACK::Decoder.new(4_096)
-    end
-    it 'should handle' do
-      expect(Connection.handle_headers(headers, ctx, decoder)).to eq nil
-      expect(ctx.fragment).to eq 'this is dummy'
-    end
-  end
-end

data/spec/connection/handle_ping_spec.rb

@@ -1,21 +0,0 @@
-require_relative '../spec_helper'
-
-RSpec.describe Connection do
-  context 'handle_ping' do
-    let(:ping1) do
-      Frame::Ping.new(true, 0, "\x00" * 8)
-    end
-    it 'should handle' do
-      expect(Connection.handle_ping(ping1)).to eq nil
-    end
-
-    let(:ping2) do
-      Frame::Ping.new(false, 0, "\x00" * 8)
-    end
-    it 'should handle' do
-      expect(Connection.handle_ping(ping2)).to_not eq nil
-      expect(Connection.handle_ping(ping2).ack?).to eq true
-      expect(Connection.handle_ping(ping2).opaque).to eq "\x00" * 8
-    end
-  end
-end

data/spec/connection/handle_rst_stream_spec.rb

@@ -1,16 +0,0 @@
-require_relative '../spec_helper'
-
-RSpec.describe Connection do
-  context 'handle_rst_stream' do
-    let(:rst_stream) do
-      Frame::RstStream.new(2, 0)
-    end
-    let(:ctx) do
-      StreamContext.new(2, 65_535, 65_535, do_nothing_proc)
-    end
-    it 'should handle' do
-      Connection.handle_rst_stream(rst_stream, ctx)
-      expect(ctx.closed?).to eq true
-    end
-  end
-end

data/spec/connection/handle_settings_spec.rb

@@ -1,37 +0,0 @@
-require_relative '../spec_helper'
-
-RSpec.describe Connection do
-  context 'handle_settings' do
-    let(:send_settings) do
-      Connection.default_settings
-    end
-    let(:decoder) do
-      HPACK::Decoder.new(4_096)
-    end
-    let(:streams_ctx) do
-      streams_ctx = StreamsContext.new(do_nothing_proc)
-      streams_ctx.new_context(1, 65_535, 65_535)
-      streams_ctx.new_context(2, 65_535, 65_535)
-      streams_ctx
-    end
-
-    let(:settings1) do
-      Frame::Settings.new(false, 0, { SettingsID::SETTINGS_HEADER_TABLE_SIZE => 8_192 })
-    end
-    it 'should handle' do
-      reply_settings = Connection.handle_settings(settings1, send_settings, decoder, streams_ctx)
-      expect(reply_settings.ack?).to eq true
-      expect(reply_settings.setting.empty?).to eq true
-      expect(send_settings[SettingsID::SETTINGS_MAX_CONCURRENT_STREAMS]).to eq 0xffffffff
-      expect(send_settings[SettingsID::SETTINGS_MAX_FRAME_SIZE]).to eq 16_384
-      expect(send_settings[SettingsID::SETTINGS_HEADER_TABLE_SIZE]).to eq 8_192
-    end
-
-    let(:settings2) do
-      Frame::Settings.new(true, 0, {})
-    end
-    it 'should handle' do
-      expect(Connection.handle_settings(settings2, send_settings, decoder, streams_ctx)).to eq nil
-    end
-  end
-end

data/spec/connection/handle_stream_window_update_spec.rb

@@ -1,20 +0,0 @@
-require_relative '../spec_helper'
-
-RSpec.describe Connection do
-  context 'handle_stream_window_update' do
-    let(:window_update) do
-      Frame::WindowUpdate.new(1, 1000)
-    end
-    let(:streams_ctx) do
-      streams_ctx = StreamsContext.new(do_nothing_proc)
-      streams_ctx.new_context(1, 65_535, 65_535)
-      streams_ctx.new_context(2, 65_535, 65_535)
-      streams_ctx
-    end
-    it 'should handle' do
-      expect { Connection.handle_stream_window_update(window_update, streams_ctx) }.not_to raise_error
-      expect(streams_ctx[1].send_window.length).to eq 65_535 + 1000
-      expect(streams_ctx[2].send_window.length).to eq 65_535
-    end
-  end
-end

data/spec/connection/read_http2_magic_spec.rb

@@ -1,26 +0,0 @@
-require_relative '../spec_helper'
-
-RSpec.describe Connection do
-  context 'read_http2_magic' do
-    let(:io1) do
-      StringIO.new("PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n")
-    end
-    it 'should read' do
-      expect(Connection.read_http2_magic(io1)).to eq nil
-    end
-
-    let(:io2) do
-      StringIO.new("PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n\x00xff")
-    end
-    it 'should read' do
-      expect(Connection.read_http2_magic(io2)).to eq nil
-    end
-
-    let(:io3) do
-      StringIO.new("\x00xffPRI * HTTP/2.0\r\n\r\nSM\r\n\r\n")
-    end
-    it 'should not read' do
-      expect(Connection.read_http2_magic(io3)).to be_kind_of ConnectionError
-    end
-  end
-end