biryani 0.0.4 → 0.0.6

data/lib/biryani/http_response.rb

@@ -1,15 +1,37 @@
 module Biryani
   class HTTPResponse
+    FORBIDDEN_KEY_CHARS = (0x00..0x20).chain([0x3a]).chain(0x41..0x5a).chain(0x7f..0xff).to_a.freeze
+    FORBIDDEN_VALUE_CHARS = [0x00, 0x0a, 0x0d].freeze
+
     attr_accessor :status, :fields, :content
 
     # @param status [Integer]
     # @param fields [Hash]
-    # @param content [String]
+    # @param content [String, nil]
     def initialize(status, fields, content)
       @status = status
       @fields = fields
       @content = content
     end
+
+    # @raise [InvalidHTTPResponseError]
+    # rubocop: disable Metrics/CyclomaticComplexity
+    def validate
+      # https://datatracker.ietf.org/doc/html/rfc9113#section-8.2.1
+      raise Error::InvalidHTTPResponseError, 'invalid HTTP status' if @status < 100 || @status >= 600
+      raise Error::InvalidHTTPResponseError, 'HTTP field name contains invalid characters' if (@fields.keys.join.downcase.bytes.uniq & FORBIDDEN_KEY_CHARS).any?
+      raise Error::InvalidHTTPResponseError, 'HTTP field value contains NUL, LF or CR' if (@fields.values.join.bytes.uniq & FORBIDDEN_VALUE_CHARS).any?
+      raise Error::InvalidHTTPResponseError, 'HTTP field value starts/ends with SP or HTAB' if @fields.values.filter { |s| s.start_with?("\t", ' ') || s.end_with?("\t", ' ') }.any?
+    end
+    # rubocop: enable Metrics/CyclomaticComplexity
+
+    def self.default
+      HTTPResponse.new(0, {}, nil)
+    end
+
+    def self.internal_server_error
+      HTTPResponse.new(500, {}, 'Internal Server Error')
+    end
   end
 
   class HTTPResponseParser
@@ -22,7 +44,6 @@ module Biryani
     def fields
       fields = [[':status', @res.status.to_s]]
       @res.fields.each do |name, value|
-        # TODO: validate fields
         fields << [name.to_s.downcase, value.to_s]
       end
 

data/lib/biryani/server.rb

@@ -11,7 +11,7 @@ module Biryani
         Ractor.new(socket.accept, @proc) do |io, proc|
           conn = Connection.new(proc)
           conn.serve(io)
-          io&.close
+          io.close
         end
       end
     end

data/lib/biryani/state.rb

@@ -65,7 +65,7 @@ module Biryani
       in [:idle, FrameType::HEADERS, :recv] if frame.end_stream?
         :receiving_continuation
       in [:idle, FrameType::HEADERS, :recv]
-        :receiving_continuation_data
+        :receiving_continuation_and_data
       in [:idle, FrameType::PRIORITY, :recv]
         state
       in [:idle, FrameType::PUSH_PROMISE, :send]
@@ -73,16 +73,16 @@ module Biryani
       in [:idle, _, _]
         unexpected(ErrorCode::PROTOCOL_ERROR, state, typ, direction)
 
-      # receiving_continuation_data
-      in [:receiving_continuation_data, FrameType::RST_STREAM, _]
+      # receiving_continuation_and_data
+      in [:receiving_continuation_and_data, FrameType::RST_STREAM, _]
         :closed
-      in [:receiving_continuation_data, FrameType::WINDOW_UPDATE, :recv]
+      in [:receiving_continuation_and_data, FrameType::WINDOW_UPDATE, :recv]
         state
-      in [:receiving_continuation_data, FrameType::CONTINUATION, :recv] if frame.end_headers?
+      in [:receiving_continuation_and_data, FrameType::CONTINUATION, :recv] if frame.end_headers?
         :receiving_data
-      in [:receiving_continuation_data, FrameType::CONTINUATION, :recv]
+      in [:receiving_continuation_and_data, FrameType::CONTINUATION, :recv]
         state
-      in [:receiving_continuation_data, _, _]
+      in [:receiving_continuation_and_data, _, _]
         unexpected(ErrorCode::PROTOCOL_ERROR, state, typ, direction)
 
       # receiving_continuation
@@ -182,6 +182,8 @@ module Biryani
         unexpected(ErrorCode::PROTOCOL_ERROR, state, typ, direction)
 
       # closed
+      in [:closed, FrameType::PRIORITY, :recv]
+        state
       in [:closed, FrameType::RST_STREAM, :recv]
         state
       in [:closed, _, :send]
@@ -232,5 +234,10 @@ module Biryani
     def half_closed_remote?
       @state == :half_closed_remote
     end
+
+    # @return [Boolean]
+    def receiving_continuation?
+      %i[receiving_continuation receiving_continuation_and_data].include?(@state)
+    end
   end
 end

data/lib/biryani/stream.rb

@@ -8,10 +8,17 @@ module Biryani
     def initialize(tx, stream_id, proc)
       @rx = Ractor.new(tx, stream_id, proc) do |tx, stream_id, proc|
         unless (req = Ractor.recv).nil?
-          res = HTTPResponse.new(0, {}, '')
+          res = HTTPResponse.default
 
-          proc.call(req, res)
-          tx << [res, stream_id]
+          begin
+            proc.call(req, res)
+            res.validate
+          rescue StandardError => e
+            puts e.backtrace
+            res = HTTPResponse.internal_server_error
+          end
+
+          tx.send([res, stream_id], move: true)
         end
       end
     end

data/lib/biryani/streams_context.rb

@@ -47,6 +47,11 @@ module Biryani
       @h.values.filter(&:active?).length
     end
 
+    # @return [Boolean]
+    def receiving_continuation?
+      @h.values.any?(&:receiving_continuation?)
+    end
+
     # @return [Array<Integer>]
     def closed_stream_ids
       @h.filter { |_, ctx| ctx.closed? }.keys
@@ -84,16 +89,12 @@ module Biryani
       closed_ids = closed_stream_ids.filter { |id| !data_buffer.has?(id) }
       closed_ids.each do |id|
         @h[id].tx.close
-        @h[id].fragment.close
-        @h[id].content.close
       end
     end
 
     def close_all
       each do |ctx|
         ctx.tx.close
-        ctx.fragment.close
-        ctx.content.close
         ctx.state.close
       end
     end
@@ -111,8 +112,8 @@ module Biryani
       @stream = Stream.new(@tx, stream_id, proc)
       @send_window = Window.new(send_initial_window_size)
       @recv_window = Window.new(recv_initial_window_size)
-      @fragment = StringIO.new
-      @content = StringIO.new
+      @fragment = ''.b
+      @content = ''.b
       @state = State.new
     end
 
@@ -135,5 +136,10 @@ module Biryani
     def half_closed_remote?
       @state.half_closed_remote?
     end
+
+    # @return [Boolean]
+    def receiving_continuation?
+      @state.receiving_continuation?
+    end
   end
 end

data/lib/biryani/version.rb

@@ -1,3 +1,3 @@
 module Biryani
-  VERSION = '0.0.4'.freeze
+  VERSION = '0.0.6'.freeze
 end

data/lib/biryani.rb

@@ -1,9 +1,9 @@
-require 'stringio'
 require 'uri'
 
 require_relative 'biryani/connection_error'
 require_relative 'biryani/connection'
 require_relative 'biryani/data_buffer'
+require_relative 'biryani/error'
 require_relative 'biryani/frame'
 require_relative 'biryani/hpack'
 require_relative 'biryani/http_request'

data/spec/connection/handle_data_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe Connection do
     end
     it 'should handle' do
       expect(Connection.handle_data(2, 'Hello, world!', recv_window1, streams_ctx1, decoder)).to eq []
-      expect(streams_ctx1[2].content.string).to eq 'Hello, world!'
+      expect(streams_ctx1[2].content).to eq 'Hello, world!'
     end
 
     let(:recv_window2) do
@@ -37,7 +37,7 @@ RSpec.describe Connection do
       expect(frames.map(&:f_type)).to eq [FrameType::WINDOW_UPDATE, FrameType::WINDOW_UPDATE]
       expect(frames.map(&:stream_id)).to eq [0, 2]
       expect(frames.map(&:window_size_increment)).to eq [65_535 / 2 + 13, 65_535 / 2 + 13]
-      expect(streams_ctx2[2].content.string).to eq 'Hello, world!'
+      expect(streams_ctx2[2].content).to eq 'Hello, world!'
     end
 
     let(:recv_window3) do

data/spec/connection/handle_headers_spec.rb

@@ -13,7 +13,7 @@ RSpec.describe Connection do
     end
     it 'should handle' do
       expect(Connection.handle_headers(headers, ctx, decoder)).to eq nil
-      expect(ctx.fragment.string).to eq 'this is dummy'
+      expect(ctx.fragment).to eq 'this is dummy'
     end
   end
 end

data/spec/connection/{transition_state_send_spec.rb → transition_stream_state_send_spec.rb}

@@ -1,7 +1,7 @@
 require_relative '../spec_helper'
 
 RSpec.describe Connection do
-  context 'transition_state_send' do
+  context 'transition_stream_state_send' do
     let(:streams_ctx) do
       streams_ctx = StreamsContext.new(do_nothing_proc)
       streams_ctx.new_context(1, 65_535, 65_535)
@@ -14,7 +14,7 @@ RSpec.describe Connection do
     end
     it 'should transition' do
       streams_ctx[2].state.transition!(headers, :recv)
-      Connection.transition_state_send(headers, streams_ctx)
+      Connection.transition_stream_state_send(headers, streams_ctx)
       expect(streams_ctx.length).to eq 2
     end
 
@@ -31,7 +31,7 @@ RSpec.describe Connection do
     end
     it 'should transition' do
       streams_ctx[2].state.transition!(headers, :recv)
-      Connection.transition_state_send(rst_stream, streams_ctx)
+      Connection.transition_stream_state_send(rst_stream, streams_ctx)
       expect { streams_ctx[1].tx << nil }.to_not raise_error
       expect { streams_ctx[2].tx << nil }.to_not raise_error
     end

data/spec/frame/continuation_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe Frame::Continuation do
     end
 
     let(:continuation3) do
-      Frame::Continuation.read("\x00\x00\x00\x09\x00\x00\x00\x00\x32".b)
+      Frame::Continuation.read(''.b, 0, 50)
     end
     it 'should decode' do
       expect(continuation3.f_type).to eq FrameType::CONTINUATION
@@ -27,7 +27,7 @@ RSpec.describe Frame::Continuation do
     end
 
     let(:continuation4) do
-      Frame::Continuation.read("\x00\x00\x0d\x09\x00\x00\x00\x00\x32\x74\x68\x69\x73\x20\x69\x73\x20\x64\x75\x6d\x6d\x79".b)
+      Frame::Continuation.read("\x74\x68\x69\x73\x20\x69\x73\x20\x64\x75\x6d\x6d\x79".b, 9, 50)
     end
     it 'should decode' do
       expect(continuation4.f_type).to eq FrameType::CONTINUATION

data/spec/frame/data_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe Frame::Data do
     end
 
     let(:data2) do
-      Frame::Data.read("\x00\x00\x14\x00\x08\x00\x00\x00\x02\x06\x48\x65\x6c\x6c\x6f\x2c\x20\x77\x6f\x72\x6c\x64\x21\x48\x6f\x77\x64\x79\x21".b)
+      Frame::Data.read("\x06\x48\x65\x6c\x6c\x6f\x2c\x20\x77\x6f\x72\x6c\x64\x21\x48\x6f\x77\x64\x79\x21".b, 8, 2)
     end
     it 'should decode' do
       expect(data2.f_type).to eq FrameType::DATA

data/spec/frame/goaway_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe Frame::Goaway do
     end
 
     let(:goaway2) do
-      Frame::Goaway.read("\x00\x00\x17\x07\x00\x00\x00\x00\x00\x00\x00\x00\x1e\x00\x00\x00\x09\x68\x70\x61\x63\x6b\x20\x69\x73\x20\x62\x72\x6f\x6b\x65\x6e".b)
+      Frame::Goaway.read("\x00\x00\x00\x1e\x00\x00\x00\x09\x68\x70\x61\x63\x6b\x20\x69\x73\x20\x62\x72\x6f\x6b\x65\x6e".b, 7, 0)
     end
     it 'should decode' do
       expect(goaway2.f_type).to eq FrameType::GOAWAY

data/spec/frame/headers_spec.rb

@@ -18,7 +18,7 @@ RSpec.describe Frame::Headers do
     end
 
     let(:headers3) do
-      Frame::Headers.read("\x00\x00\x0d\x01\x04\x00\x00\x00\x01\x74\x68\x69\x73\x20\x69\x73\x20\x64\x75\x6d\x6d\x79".b)
+      Frame::Headers.read("\x74\x68\x69\x73\x20\x69\x73\x20\x64\x75\x6d\x6d\x79".b, 4, 1)
     end
     it 'should decode' do
       expect(headers3.f_type).to eq FrameType::HEADERS
@@ -34,7 +34,7 @@ RSpec.describe Frame::Headers do
     end
 
     let(:headers4) do
-      Frame::Headers.read("\x00\x00\x23\x01\x2c\x00\x00\x00\x03\x10\x00\x00\x00\x14\x0a\x74\x68\x69\x73\x20\x69\x73\x20\x64\x75\x6d\x6d\x79\x54\x68\x69\x73\x20\x69\x73\x20\x70\x61\x64\x64\x69\x6e\x67\x2e".b)
+      Frame::Headers.read("\x10\x00\x00\x00\x14\x0a\x74\x68\x69\x73\x20\x69\x73\x20\x64\x75\x6d\x6d\x79\x54\x68\x69\x73\x20\x69\x73\x20\x70\x61\x64\x64\x69\x6e\x67\x2e".b, 44, 3)
     end
     it 'should decode' do
       expect(headers4.f_type).to eq FrameType::HEADERS

data/spec/frame/ping_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe Frame::Ping do
     end
 
     let(:ping2) do
-      Frame::Ping.read("\x00\x00\x08\x06\x00\x00\x00\x00\x00\x64\x65\x61\x64\x62\x65\x65\x66".b)
+      Frame::Ping.read("\x64\x65\x61\x64\x62\x65\x65\x66".b, 0, 0)
     end
     it 'should decode' do
       expect(ping2.f_type).to eq FrameType::PING

data/spec/frame/priority_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe Frame::Priority do
     end
 
     let(:priority2) do
-      Frame::Priority.read("\x00\x00\x05\x02\x00\x00\x00\x00\x09\x00\x00\x00\x0b\x08".b)
+      Frame::Priority.read("\x00\x00\x00\x0b\x08".b, 0, 9)
     end
     it 'should decode' do
       expect(priority2.f_type).to eq FrameType::PRIORITY

data/spec/frame/push_promise_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe Frame::PushPromise do
     end
 
     let(:push_promise2) do
-      Frame::PushPromise.read("\x00\x00\x18\x05\x0c\x00\x00\x00\x0a\x06\x00\x00\x00\x0c\x74\x68\x69\x73\x20\x69\x73\x20\x64\x75\x6d\x6d\x79\x48\x6f\x77\x64\x79\x21".b)
+      Frame::PushPromise.read("\x06\x00\x00\x00\x0c\x74\x68\x69\x73\x20\x69\x73\x20\x64\x75\x6d\x6d\x79\x48\x6f\x77\x64\x79\x21".b, 12, 10)
     end
     it 'should decode' do
       expect(push_promise2.f_type).to eq FrameType::PUSH_PROMISE

data/spec/frame/rst_stream_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe Frame::RstStream do
     end
 
     let(:rst_stream2) do
-      Frame::RstStream.read("\x00\x00\x04\x03\x00\x00\x00\x00\x05\x00\x00\x00\x08".b)
+      Frame::RstStream.read("\x00\x00\x00\x08".b, 0, 5)
     end
     it 'should decode' do
       expect(rst_stream2.f_type).to eq FrameType::RST_STREAM

data/spec/frame/settings_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe Frame::Settings do
     end
 
     let(:settings2) do
-      Frame::Settings.read("\x00\x00\x0c\x04\x00\x00\x00\x00\x00\x00\x01\x00\x00\x20\x00\x00\x03\x00\x00\x13\x88".b)
+      Frame::Settings.read("\x00\x01\x00\x00\x20\x00\x00\x03\x00\x00\x13\x88".b, 0, 0)
     end
     it 'should decode' do
       expect(settings2.f_type).to eq FrameType::SETTINGS

data/spec/frame/window_update_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe Frame::WindowUpdate do
     end
 
     let(:window_update2) do
-      Frame::WindowUpdate.read("\x00\x00\x04\x08\x00\x00\x00\x00\x32\x00\x00\x03\xe8".b)
+      Frame::WindowUpdate.read("\x00\x00\x03\xe8".b, 0, 50)
     end
     it 'should decode' do
       expect(window_update2.f_type).to eq FrameType::WINDOW_UPDATE

data/spec/hpack/field_spec.rb

@@ -18,25 +18,26 @@ RSpec.describe HPACK::Field do
     end
 
     it 'should decode' do
-      expect(HPACK::Field.decode("\x82".b, cursor, dynamic_table)).to eq [%w[:method GET], 1]
-      expect(HPACK::Field.decode("\x48\x82\x64\x02".b, cursor, dynamic_table)).to eq [%w[:status 302], 4]
-      expect(HPACK::Field.decode("\x6e\x91\x9d\x29\xad\x17\x18\x63\xc7\x8f\x0b\x97\xc8\xe9\xae\x82\xae\x43\xd3".b, cursor, dynamic_table)).to eq [%w[location https://www.example.com], 19]
-      expect(HPACK::Field.decode("\x40\x88\x25\xa8\x49\xe9\x5b\xa9\x7d\x7f\x89\x25\xa8\x49\xe9\x5a\x72\x8e\x42\xd9".b, cursor, dynamic_table)).to eq [%w[custom-key custom-header], 20]
-      expect(HPACK::Field.decode("\x10\x08\x70\x61\x73\x73\x77\x6f\x72\x64\x06\x73\x65\x63\x72\x65\x74".b, cursor, dynamic_table)).to eq [%w[password secret], 17]
+      expect(HPACK::Field.decode(IO::Buffer.for("\x82".b), cursor, dynamic_table)).to eq [%w[:method GET], 1]
+      expect(HPACK::Field.decode(IO::Buffer.for("\x48\x82\x64\x02".b), cursor, dynamic_table)).to eq [%w[:status 302], 4]
+      expect(HPACK::Field.decode(IO::Buffer.for("\x6e\x91\x9d\x29\xad\x17\x18\x63\xc7\x8f\x0b\x97\xc8\xe9\xae\x82\xae\x43\xd3".b), cursor, dynamic_table))
+        .to eq [%w[location https://www.example.com], 19]
+      expect(HPACK::Field.decode(IO::Buffer.for("\x40\x88\x25\xa8\x49\xe9\x5b\xa9\x7d\x7f\x89\x25\xa8\x49\xe9\x5a\x72\x8e\x42\xd9".b), cursor, dynamic_table)).to eq [%w[custom-key custom-header], 20]
+      expect(HPACK::Field.decode(IO::Buffer.for("\x10\x08\x70\x61\x73\x73\x77\x6f\x72\x64\x06\x73\x65\x63\x72\x65\x74".b), cursor, dynamic_table)).to eq [%w[password secret], 17]
     end
 
     it 'should decode' do
-      expect(HPACK::Field.decode("\x40\x88\x25\xa8\x49\xe9\x5b\xa9\x7d\x7f\x89\x25\xa8\x49\xe9\x5a\x72\x8e\x42\xd9".b, cursor, dynamic_table)).to eq [%w[custom-key custom-header], 20]
+      expect(HPACK::Field.decode(IO::Buffer.for("\x40\x88\x25\xa8\x49\xe9\x5b\xa9\x7d\x7f\x89\x25\xa8\x49\xe9\x5a\x72\x8e\x42\xd9".b), cursor, dynamic_table)).to eq [%w[custom-key custom-header], 20]
       expect(dynamic_table.limit).to eq 4096
       expect(dynamic_table.size).to eq 'custom-keycustom-header'.bytesize + 32
-      expect(HPACK::Field.decode("\x20".b, cursor, dynamic_table)).to eq [nil, 1]
+      expect(HPACK::Field.decode(IO::Buffer.for("\x20".b), cursor, dynamic_table)).to eq [nil, 1]
       expect(dynamic_table.limit).to eq 4096
       expect(dynamic_table.size).to eq 0
     end
 
     it 'should not decode' do
-      expect { HPACK::Field.decode("\xbe".b, cursor, dynamic_table) }.to raise_error HPACK::Error::HPACKDecodeError
-      expect { HPACK::Field.decode("\x3f\xe2\x1f".b, cursor, dynamic_table) }.to raise_error HPACK::Error::HPACKDecodeError
+      expect { HPACK::Field.decode(IO::Buffer.for("\xbe".b), cursor, dynamic_table) }.to raise_error HPACK::Error::HPACKDecodeError
+      expect { HPACK::Field.decode(IO::Buffer.for("\x3f\xe2\x1f".b), cursor, dynamic_table) }.to raise_error HPACK::Error::HPACKDecodeError
     end
   end
 end

data/spec/hpack/huffman_spec.rb

@@ -8,13 +8,13 @@ RSpec.describe HPACK::Huffman do
     end
 
     it 'should decode' do
-      expect(HPACK::Huffman.decode("\xf1\xe3\xc2\xe5\xf2\x3a\x6b\xa0\xab\x90\xf4\xff".b)).to eq 'www.example.com'
-      expect(HPACK::Huffman.decode("\xa8\xeb\x10\x64\x9c\xbf".b)).to eq 'no-cache'
+      expect(HPACK::Huffman.decode(IO::Buffer.for("\xf1\xe3\xc2\xe5\xf2\x3a\x6b\xa0\xab\x90\xf4\xff".b), 0, 12)).to eq 'www.example.com'
+      expect(HPACK::Huffman.decode(IO::Buffer.for("\xa8\xeb\x10\x64\x9c\xbf".b), 0, 6)).to eq 'no-cache'
     end
 
     it 'should not decode' do
-      expect { HPACK::Huffman.decode("\xff\xff\xff\xff".b) }.to raise_error HPACK::Error::HuffmanDecodeError
-      expect { HPACK::Huffman.decode("\xf8\xff".b) }.to raise_error HPACK::Error::HuffmanDecodeError
+      expect { HPACK::Huffman.decode(IO::Buffer.for("\xff\xff\xff\xff".b), 0, 4) }.to raise_error HPACK::Error::HuffmanDecodeError
+      expect { HPACK::Huffman.decode(IO::Buffer.for("\xf8\xff".b), 0, 2) }.to raise_error HPACK::Error::HuffmanDecodeError
     end
   end
 end

data/spec/hpack/integer_spec.rb

@@ -17,11 +17,11 @@ RSpec.describe HPACK::Integer do
     end
 
     it 'should decode' do
-      expect(HPACK::Integer.decode("\x0a".b, 5, cursor)).to eq [10, 1]
-      expect(HPACK::Integer.decode("\x1f\x9a\x0a".b, 5, cursor)).to eq [1337, 3]
-      expect(HPACK::Integer.decode("\x2a".b, 8, cursor)).to eq [42, 1]
-      expect(HPACK::Integer.decode("\x8a".b, 5, cursor)).to eq [10, 1]
-      expect(HPACK::Integer.decode("\x0a\x0b".b, 5, 1)).to eq [11, 2]
+      expect(HPACK::Integer.decode(IO::Buffer.for("\x0a".b), 5, cursor)).to eq [10, 1]
+      expect(HPACK::Integer.decode(IO::Buffer.for("\x1f\x9a\x0a".b), 5, cursor)).to eq [1337, 3]
+      expect(HPACK::Integer.decode(IO::Buffer.for("\x2a".b), 8, cursor)).to eq [42, 1]
+      expect(HPACK::Integer.decode(IO::Buffer.for("\x8a".b), 5, cursor)).to eq [10, 1]
+      expect(HPACK::Integer.decode(IO::Buffer.for("\x0a\x0b".b), 5, 1)).to eq [11, 2]
     end
   end
 end

data/spec/hpack/string_spec.rb

@@ -12,8 +12,8 @@ RSpec.describe HPACK::String do
     end
 
     it 'should decode' do
-      expect(HPACK::String.decode("\x88\x25\xa8\x49\xe9\x5b\xa9\x7d\x7f".b, cursor)).to eq ['custom-key', 9]
-      expect(HPACK::String.decode("\x01\x5c".b, cursor)).to eq ['\\', 2]
+      expect(HPACK::String.decode(IO::Buffer.for("\x88\x25\xa8\x49\xe9\x5b\xa9\x7d\x7f".b), cursor)).to eq ['custom-key', 9]
+      expect(HPACK::String.decode(IO::Buffer.for("\x01\x5c".b), cursor)).to eq ['\\', 2]
     end
   end
 end

data/spec/http_response_spec.rb

@@ -0,0 +1,12 @@
+require_relative 'spec_helper'
+
+RSpec.describe HTTPResponse do
+  it 'should validate' do
+    expect { HTTPResponse.new(600, {}, nil).validate }.to raise_error Error::InvalidHTTPResponseError
+    expect { HTTPResponse.new(200, { "\x00key" => 'value' }, nil).validate }.to raise_error Error::InvalidHTTPResponseError
+    expect { HTTPResponse.new(200, { 'key:' => 'value' }, nil).validate }.to raise_error Error::InvalidHTTPResponseError
+    expect { HTTPResponse.new(200, { 'key' =>  "one\ntwo" }, nil).validate }.to raise_error Error::InvalidHTTPResponseError
+    expect { HTTPResponse.new(200, { 'key' =>  ' value' }, nil).validate }.to raise_error Error::InvalidHTTPResponseError
+    expect { HTTPResponse.new(200, { 'key' =>  "value\t" }, nil).validate }.to raise_error Error::InvalidHTTPResponseError
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: biryani
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.6
 platform: ruby
 authors:
 - thekuwayama
@@ -39,12 +39,16 @@ files:
 - README.md
 - Rakefile
 - biryani.gemspec
+- conformance/server_spec.rb
+- conformance/spec_helper.rb
 - example/echo.rb
 - example/hello_world.rb
+- example/raise_error.rb
 - lib/biryani.rb
 - lib/biryani/connection.rb
 - lib/biryani/connection_error.rb
 - lib/biryani/data_buffer.rb
+- lib/biryani/error.rb
 - lib/biryani/frame.rb
 - lib/biryani/frame/continuation.rb
 - lib/biryani/frame/data.rb
@@ -87,7 +91,7 @@ files:
 - spec/connection/handle_stream_window_update_spec.rb
 - spec/connection/read_http2_magic_spec.rb
 - spec/connection/send_spec.rb
-- spec/connection/transition_state_send_spec.rb
+- spec/connection/transition_stream_state_send_spec.rb
 - spec/data_buffer_spec.rb
 - spec/frame/continuation_spec.rb
 - spec/frame/data_spec.rb
@@ -108,6 +112,7 @@ files:
 - spec/hpack/integer_spec.rb
 - spec/hpack/string_spec.rb
 - spec/http_request_builder_spec.rb
+- spec/http_response_spec.rb
 - spec/spec_helper.rb
 - spec/streams_context_spec.rb
 - spec/utils_spec.rb
@@ -142,7 +147,7 @@ test_files:
 - spec/connection/handle_stream_window_update_spec.rb
 - spec/connection/read_http2_magic_spec.rb
 - spec/connection/send_spec.rb
-- spec/connection/transition_state_send_spec.rb
+- spec/connection/transition_stream_state_send_spec.rb
 - spec/data_buffer_spec.rb
 - spec/frame/continuation_spec.rb
 - spec/frame/data_spec.rb
@@ -163,6 +168,7 @@ test_files:
 - spec/hpack/integer_spec.rb
 - spec/hpack/string_spec.rb
 - spec/http_request_builder_spec.rb
+- spec/http_response_spec.rb
 - spec/spec_helper.rb
 - spec/streams_context_spec.rb
 - spec/utils_spec.rb