bing_ads_ruby_sdk 1.6 → 1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 10064130886df96745297db7c95d5482b3127563383425554e7ee722e36e17ff
-  data.tar.gz: ffd8833ecabc68e2d6ac7760891399070bbffb6f644f79b7f71275270e5e9c95
+  metadata.gz: 9ba09362c0df0c63b729b31a627ddd6708a1b187c37f392002471c4c05d6e448
+  data.tar.gz: 34db7cac452be374d8e4d305752b0fb5e0db09834710d17a718809c37733b3a7
 SHA512:
-  metadata.gz: 5dad795cb0dba423784ad86926c397740b083201bfb9c327f04763e94f34149860d857989b2e1386008ed19d96317a9ea91655b1267f39017b32fd14d34b9388
-  data.tar.gz: b5d31b8cd1fad4f64b91debaead3daf4878d427b5d5d17639247e732eedc125a406d16968a1dd5a3d1fc4402059268d5cffa05ee6a0c96ae153836246f232154
+  metadata.gz: 62ee362cbad60084db481253ea12e7baf3203773dffb59c2a47c6831cd6add07c15e489f1e4b1aa87ed2a488eb19d718dcf232237ee11062f5da91f727217368
+  data.tar.gz: 7c89d9dc0508449d20e14263534658115d1736f3a2cd7e82ac54dc0274a954228929296795f0c6098e1c95f3a868ff47beb12eb34090cf3ef4adeb7ec8c98e2b

data/Gemfile

@@ -3,4 +3,4 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in bing_ads_ruby_sdk.gemspec
 gemspec
 
-gem "standard", "1.31.1"
+gem "standard", "1.41.1"

data/changelog.md

@@ -1,3 +1,8 @@
+## V1.7 Release
+- Fixed a bug preventing all but the first ad extension associations to be fetched
+- All error messages are now returned instead of just the first one
+- Updated dependencies
+
 ## V1.6 Release
 - Updated documentation
 - Fixed an envkey/dotenv related bug preventing the gem from starting

data/lib/bing_ads_ruby_sdk/errors/errors.rb

@@ -29,7 +29,7 @@ module BingAdsRubySdk
 
     class ServerError < GeneralError
       def initialize(server_error)
-        super "Server raised error #{server_error}"
+        super("Server raised error #{server_error}")
       end
     end
 
@@ -45,19 +45,14 @@ module BingAdsRubySdk
         error_list = all_errors
         return @message if error_list.empty?
 
-        first_message = first_error_message(error_list)
-        if error_list.count > 1
-          "API raised #{error_list.count} errors, including: #{first_message}"
-        else
-          first_message
-        end
+        concatenated_error_messages(error_list)
       end
 
       private
 
       def populate_error_lists
         self.class.error_lists.each do |key|
-          instance_variable_set("@#{key}", array_wrap(fault_hash[key]))
+          instance_variable_set(:"@#{key}", array_wrap(fault_hash[key]))
         end
       end
 
@@ -85,9 +80,18 @@ module BingAdsRubySdk
         BingAdsRubySdk::StringUtils.snakize(class_name).to_sym
       end
 
-      def first_error_message(error_list)
-        error = error_list.first.values.first
-        format_message(error[:error_code], error[:message])
+      def concatenated_error_messages(error_list)
+        errors = error_list.map do |error|
+          if error.is_a?(Hash) && error[:error_code]
+            error
+          else
+            error.values
+          end
+        end.flatten.compact
+
+        errors.map do |error|
+          format_message(error[:error_code], error[:message])
+        end.uniq.join(", ")
       end
 
       def array_wrap(value)
@@ -123,13 +127,13 @@ module BingAdsRubySdk
         raw_response[fault_key] || {}
       end
 
-      # Gets the first error message in the list. This is
-      # overridden because partial errors are structured differently
+      # This is overridden because partial errors are structured differently
       # to application faults
       # @return [Hash] containing the details of the error
-      def first_error_message(error_list)
-        error = error_list.first
-        format_message(error[:error_code], error[:message])
+      def concatenated_error_messages(error_list)
+        error_list.map do |error|
+          format_message(error[:error_code], error[:message])
+        end.uniq.join(", ")
       end
     end
 

data/lib/bing_ads_ruby_sdk/services/campaign_management.rb

@@ -37,9 +37,8 @@ module BingAdsRubySdk
         wrap_array(
           call(__method__, message)
             .dig(:ad_extension_association_collection, :ad_extension_association_collection)
-            .first
-            .dig(:ad_extension_associations, :ad_extension_association)
-        )
+            .map { |entity_group| entity_group.dig(:ad_extension_associations, :ad_extension_association) }
+        ).flatten
       rescue
         []
       end

data/lib/bing_ads_ruby_sdk/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module BingAdsRubySdk
-  VERSION = "1.6"
+  VERSION = "1.7"
   DEFAULT_SDK_VERSION = :v13
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bing_ads_ruby_sdk
 version: !ruby/object:Gem::Version
-  version: '1.6'
+  version: '1.7'
 platform: ruby
 authors:
 - Effilab
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-09-14 00:00:00.000000000 Z
+date: 2024-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: signet
@@ -263,7 +263,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.5.22
 signing_key: 
 specification_version: 4
 summary: Bing Ads Ruby SDK