bing_ads_ruby_sdk 1.5.2 → 1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ee1dd6d1c423e271f716d5a8d71aea958a73126002eb777a765f10416a0aa095
-  data.tar.gz: d145e027e36d473eb849a06e5eac94641f85f4c427a96a76136841e1a70a7814
+  metadata.gz: 9ba09362c0df0c63b729b31a627ddd6708a1b187c37f392002471c4c05d6e448
+  data.tar.gz: 34db7cac452be374d8e4d305752b0fb5e0db09834710d17a718809c37733b3a7
 SHA512:
-  metadata.gz: 7b78346cc370f6c287987c32cab9f898051158b40070375d3ae9f33b29fce2538674d276b8917cf9ce6710897b8727bd43dce1ae56a2346facf0087867300d6a
-  data.tar.gz: b3fdebf99829b5d1dafa5d30197829dabeedb8960727d0c49b7ab8b1990304f3589873137becefdc9b7f03c1ac5953c8174b76f29ee35b8323a011ea7034e70a
+  metadata.gz: 62ee362cbad60084db481253ea12e7baf3203773dffb59c2a47c6831cd6add07c15e489f1e4b1aa87ed2a488eb19d718dcf232237ee11062f5da91f727217368
+  data.tar.gz: 7c89d9dc0508449d20e14263534658115d1736f3a2cd7e82ac54dc0274a954228929296795f0c6098e1c95f3a868ff47beb12eb34090cf3ef4adeb7ec8c98e2b

data/Gemfile

@@ -3,4 +3,4 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in bing_ads_ruby_sdk.gemspec
 gemspec
 
-gem "standard", "1.25.3"
+gem "standard", "1.41.1"

data/README.md

@@ -16,7 +16,8 @@ Or install it yourself as:
 
     $ gem install bing_ads_ruby_sdk
 
-## Getting Started
+## Usage
+### Getting Started
 
 In order to use Microsoft's advertising API you need to 
 [get your API credentials from MS](https://learn.microsoft.com/en-us/advertising/guides/get-started?view=bingads-13).
@@ -33,7 +34,6 @@ bin/rake bing_token:get['credentials.json',YOUR_DEVELOPER_TOKEN,YOUR_CLIENT_ID,Y
 bin/rake bing_token:get['credentials.json',ABC1234,3431b6d0-a2ac-48e1-a1c5-1d0b82f3187f,SECRETVALUEHERE]
 ```
 
-
 Then to use the api:
 ```ruby
 store = ::BingAdsRubySdk::OAuth2::FsStore.new('my_token.json')
@@ -44,6 +44,22 @@ api = BingAdsRubySdk::Api.new(
 )
 ```
 
+### Configuration
+```ruby
+BingAdsRubySdk.configure do |conf|
+  conf.log = true
+  conf.logger.level = Logger::DEBUG
+  conf.pretty_print_xml = true
+  # to filter sensitive data before logging
+  conf.filters = ["AuthenticationToken", "DeveloperToken"]
+  
+  # Optionally allow ActiveSupport::Notifications to be emitted by Excon.
+  # These notifications can then be sent on to your profiling system
+  # conf.instrumentor = ActiveSupport::Notifications 
+end
+```
+
+### Account creation and management
 If you want to create an account using the API:
 ```ruby
 api.customer_management.signup_customer(
@@ -54,7 +70,7 @@ api.customer_management.signup_customer(
 ```
 
 Otherwise you can [use existing account IDs as explained here](https://learn.microsoft.com/en-us/advertising/guides/get-started?view=bingads-13#get-ids),
-or use the `customer_management` endpoint as explained below.
+or use the `customer_management` endpoint as explained above.
 
 Once you have your MS Advertising customer and account ids:
 ```ruby
@@ -80,22 +96,76 @@ The methods implemented contain additional code to ease data manipulation but an
 
 ```
 
+### Reporting
+You can generate the report following the 
+[process recommended by Microsoft](https://learn.microsoft.com/en-us/advertising/guides/request-download-report?view=bingads-13):
+
+That would mean coding something like this:
 
-## Configure the gem
 ```ruby
-BingAdsRubySdk.configure do |conf|
-  conf.log = true
-  conf.logger.level = Logger::DEBUG
-  conf.pretty_print_xml = true
-  # to filter sensitive data before logging
-  conf.filters = ["AuthenticationToken", "DeveloperToken"]
-  
-  # Optionally allow ActiveSupport::Notifications to be emitted by Excon.
-  # These notifications can then be sent on to your profiling system
-  # conf.instrumentor = ActiveSupport::Notifications 
+submission_response = api.reporting
+  .call(:submit_generate_report,
+     account_performance_report_request: {
+       exclude_report_header: true,
+       exclude_report_footer: true,
+       exclude_column_headers: true,
+       format: "Csv",
+       aggregation: "Daily",
+       filter: nil,
+       columns: [
+         {
+           account_performance_report_column: "TimePeriod"
+         },
+         {
+           account_performance_report_column: "AccountId"
+         },
+         {
+           account_performance_report_column: "DeviceType"
+         },
+         {
+           account_performance_report_column: "Clicks"
+         }
+       ],
+       scope: {
+         # Your account ID here
+         account_ids: [{long: 1000000}]
+       },
+       time: {
+         custom_date_range_start: {
+           day: 7,
+           month: 5,
+           year: 2023
+         },
+         custom_date_range_end: {
+           day: 8,
+           month: 5,
+           year: 2023
+         }
+       }
+     }
+  )
+
+report_request_id = submission_response.fetch(:report_request_id)
+
+# Then you can poll the API to check the status of the report generation
+poll_response = api.reporting.call(:poll_generate_report, report_request_id: report_request_id)
+
+# When it is ready you can download it
+report_request_status = poll_response.fetch(:report_request_status)
+
+report_generation_status = report_request_status[:status].downcase.to_sym 
+# => One of these: :pending, :error, :success
+
+if report_generation_status == :success
+  url = report_request_status[:report_download_url]
+  # => The URL to download the report (with the library of your choice)
 end
 ```
 
+🛈 Report request example [here in the API docs](https://learn.microsoft.com/en-us/advertising/reporting-service/accountperformancereportrequest?view=bingads-13)
+
+🛈 Hint: convert parameter names from PascalCase to snake_case when consulting the API docs
+
 ## Development
 You can run `bin/console` for an interactive prompt that will allow you to experiment.
 

data/bing_ads_ruby_sdk.gemspec

@@ -4,7 +4,7 @@ require "bing_ads_ruby_sdk/version"
 
 Gem::Specification.new do |spec|
   spec.name = "bing_ads_ruby_sdk"
-  spec.required_ruby_version = ">= 2.3"
+  spec.required_ruby_version = ">= 3"
 
   spec.version = BingAdsRubySdk::VERSION
   spec.authors = %w[Effilab developers]

data/changelog.md

@@ -1,3 +1,13 @@
+## V1.7 Release
+- Fixed a bug preventing all but the first ad extension associations to be fetched
+- All error messages are now returned instead of just the first one
+- Updated dependencies
+
+## V1.6 Release
+- Updated documentation
+- Fixed an envkey/dotenv related bug preventing the gem from starting
+- Dropped support for Ruby 2
+
 ## V1.5.1 Release
 - Bug fix: Rake task missing
 

data/lib/bing_ads_ruby_sdk/errors/errors.rb

@@ -29,7 +29,7 @@ module BingAdsRubySdk
 
     class ServerError < GeneralError
       def initialize(server_error)
-        super "Server raised error #{server_error}"
+        super("Server raised error #{server_error}")
       end
     end
 
@@ -45,19 +45,14 @@ module BingAdsRubySdk
         error_list = all_errors
         return @message if error_list.empty?
 
-        first_message = first_error_message(error_list)
-        if error_list.count > 1
-          "API raised #{error_list.count} errors, including: #{first_message}"
-        else
-          first_message
-        end
+        concatenated_error_messages(error_list)
       end
 
       private
 
       def populate_error_lists
         self.class.error_lists.each do |key|
-          instance_variable_set("@#{key}", array_wrap(fault_hash[key]))
+          instance_variable_set(:"@#{key}", array_wrap(fault_hash[key]))
         end
       end
 
@@ -85,9 +80,18 @@ module BingAdsRubySdk
         BingAdsRubySdk::StringUtils.snakize(class_name).to_sym
       end
 
-      def first_error_message(error_list)
-        error = error_list.first.values.first
-        format_message(error[:error_code], error[:message])
+      def concatenated_error_messages(error_list)
+        errors = error_list.map do |error|
+          if error.is_a?(Hash) && error[:error_code]
+            error
+          else
+            error.values
+          end
+        end.flatten.compact
+
+        errors.map do |error|
+          format_message(error[:error_code], error[:message])
+        end.uniq.join(", ")
       end
 
       def array_wrap(value)
@@ -123,13 +127,13 @@ module BingAdsRubySdk
         raw_response[fault_key] || {}
       end
 
-      # Gets the first error message in the list. This is
-      # overridden because partial errors are structured differently
+      # This is overridden because partial errors are structured differently
       # to application faults
       # @return [Hash] containing the details of the error
-      def first_error_message(error_list)
-        error = error_list.first
-        format_message(error[:error_code], error[:message])
+      def concatenated_error_messages(error_list)
+        error_list.map do |error|
+          format_message(error[:error_code], error[:message])
+        end.uniq.join(", ")
       end
     end
 

data/lib/bing_ads_ruby_sdk/oauth2/fs_store.rb

@@ -23,7 +23,7 @@ module BingAdsRubySdk
       # @return [nil] if the file doesn't exist.
       def read
         return nil unless File.file?("./#{filename}")
-        JSON.parse(IO.read(filename))
+        JSON.parse(File.read(filename))
       end
 
       private

data/lib/bing_ads_ruby_sdk/services/campaign_management.rb

@@ -37,9 +37,8 @@ module BingAdsRubySdk
         wrap_array(
           call(__method__, message)
             .dig(:ad_extension_association_collection, :ad_extension_association_collection)
-            .first
-            .dig(:ad_extension_associations, :ad_extension_association)
-        )
+            .map { |entity_group| entity_group.dig(:ad_extension_associations, :ad_extension_association) }
+        ).flatten
       rescue
         []
       end

data/lib/bing_ads_ruby_sdk/string_utils.rb

@@ -7,6 +7,8 @@ module BingAdsRubySdk
     end
 
     def self.snakize(string)
+      raise "Unexpected string length : #{string.length} for string '#{string[0..200]}...'" if string.length > 1000
+
       string.gsub(MULTIPLE_CAPSREGEX, MATCHING_PATTERN)
         .gsub(SPLIT_REGEX, MATCHING_PATTERN)
         .tr("-", "_")

data/lib/bing_ads_ruby_sdk/tasks/bing_ads_ruby_sdk.rake

@@ -1,4 +1,8 @@
-require "dotenv/load"
+begin
+  require "dotenv/load"
+rescue LoadError
+  puts "Unable to load .env file, resuming..."
+end
 
 namespace :bing_token do
   desc "Gets OAuth token from MS and stores it in a JSON file defined by filename parameter"

data/lib/bing_ads_ruby_sdk/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module BingAdsRubySdk
-  VERSION = "1.5.2"
+  VERSION = "1.7"
   DEFAULT_SDK_VERSION = :v13
 end

data/lib/bing_ads_ruby_sdk.rb

@@ -10,6 +10,9 @@ require "bing_ads_ruby_sdk/string_utils"
 require "bing_ads_ruby_sdk/railtie" if defined?(Rails)
 
 module BingAdsRubySdk
+  TYPE_KEY = "@type"
+  ROOT_PATH = File.join(__dir__, "..")
+
   def self.config
     @configuration ||= BingAdsRubySdk::Configuration.new
   end
@@ -18,9 +21,9 @@ module BingAdsRubySdk
     yield(config)
   end
 
-  def self.log(level, *args, &block)
+  def self.log(level, ...)
     return unless config.log
-    config.logger.send(level, *args, &block)
+    config.logger.send(level, ...)
   end
 
   def self.root_path
@@ -30,7 +33,4 @@ module BingAdsRubySdk
   def self.type_key
     TYPE_KEY
   end
-
-  TYPE_KEY = "@type"
-  ROOT_PATH = File.join(__dir__, "..")
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bing_ads_ruby_sdk
 version: !ruby/object:Gem::Version
-  version: 1.5.2
+  version: '1.7'
 platform: ruby
 authors:
 - Effilab
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-03-27 00:00:00.000000000 Z
+date: 2024-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: signet
@@ -256,14 +256,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.9
+rubygems_version: 3.5.22
 signing_key: 
 specification_version: 4
 summary: Bing Ads Ruby SDK