bing_ads_ruby_sdk 1.1.1 → 1.3.3

data/spec/bing_ads_ruby_sdk/header_spec.rb

@@ -1,6 +1,14 @@
 RSpec.describe BingAdsRubySdk::Header do
   let(:oauth_store) { double(:oauth_store) }
-  let(:subject) { described_class.new(developer_token: '123abc', client_id: '1a-2b-3c', store: oauth_store) }
+  let(:client_secret) { 'pa$$w0rd' }
+  let(:subject) do
+    described_class.new(
+      developer_token: '123abc',
+      client_id: '1a-2b-3c',
+      client_secret: client_secret,
+      store: oauth_store,
+    )
+  end
   let(:auth_handler) do
     double(:auth_handler, fetch_or_refresh: 'yes/we/can')
   end
@@ -9,6 +17,7 @@ RSpec.describe BingAdsRubySdk::Header do
     expect(::BingAdsRubySdk::OAuth2::AuthorizationHandler).to receive(:new).with(
       developer_token: '123abc',
       client_id: '1a-2b-3c',
+      client_secret: client_secret,
       store: oauth_store
     ).and_return auth_handler
   end
@@ -19,10 +28,23 @@ RSpec.describe BingAdsRubySdk::Header do
         "AuthenticationToken" => 'yes/we/can',
         "DeveloperToken" =>      '123abc',
         "CustomerId" =>          nil,
-        "CustomerAccountId" =>   nil
+        "CustomerAccountId" =>   nil,
+        "ClientSecret" => client_secret
       )
     end
 
+    context "without client_secret" do
+      let(:client_secret) { nil }
+      it do
+        expect(subject.content).to eq(
+          "AuthenticationToken" => 'yes/we/can',
+          "DeveloperToken" =>      '123abc',
+          "CustomerId" =>          nil,
+          "CustomerAccountId" =>   nil
+        )
+      end
+    end
+
     it 'sets customer' do
       subject.set_customer(customer_id: 777, account_id: 666 )
 
@@ -30,7 +52,8 @@ RSpec.describe BingAdsRubySdk::Header do
         "AuthenticationToken" => 'yes/we/can',
         "DeveloperToken" =>      '123abc',
         "CustomerId" =>          777,
-        "CustomerAccountId" =>   666
+        "CustomerAccountId" =>   666,
+        "ClientSecret" => client_secret
       )
     end
   end

data/spec/bing_ads_ruby_sdk/services/campaign_management_spec.rb

@@ -285,4 +285,23 @@ RSpec.describe BingAdsRubySdk::Services::CampaignManagement do
       ])
     end
   end
+
+  describe "set_shared_entity_associations" do
+    let(:action) { 'set_shared_entity_associations' }
+    let(:filename) { 'standard' }
+
+    it "returns expected result" do
+      expect(
+        service.set_shared_entity_associations(
+          associations: [{
+                           shared_entity_association: {
+                             entity_id: "349704435",
+                             entity_type: "Account",
+                             shared_entity_id: "223200992903993",
+                             shared_entity_type: "PlacementExclusionList"
+                           },
+                         }]
+      )).to eq({ partial_errors: "" })
+    end
+  end
 end

data/spec/fixtures/campaign_management/set_shared_entity_associations/standard.xml

@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<soap:Envelope xmlns:ns0="https://bingads.microsoft.com/CampaignManagement/v13" xmlns:ns1="http://schemas.microsoft.com/2003/10/Serialization/Arrays" xmlns:ns2="http://schemas.datacontract.org/2004/07/System.Collections.Generic" xmlns:ns3="http://schemas.datacontract.org/2004/07/System" xmlns:ns4="https://adapi.microsoft.com" xmlns:ns5="http://schemas.microsoft.com/2003/10/Serialization/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">
+  <soap:Header>
+    <ns0:AuthenticationToken>***FILTERED***</ns0:AuthenticationToken>
+    <ns0:DeveloperToken>***FILTERED***</ns0:DeveloperToken>
+    <ns0:CustomerId>***FILTERED***</ns0:CustomerId>
+    <ns0:CustomerAccountId>***FILTERED***</ns0:CustomerAccountId>
+  </soap:Header>
+  <soap:Body>
+    <ns0:SetSharedEntityAssociationsRequest>
+      <ns0:Associations>
+        <ns0:SharedEntityAssociation>
+          <ns0:EntityId>349704435</ns0:EntityId>
+          <ns0:EntityType>Account</ns0:EntityType>
+          <ns0:SharedEntityId>223200992903993</ns0:SharedEntityId>
+          <ns0:SharedEntityType>PlacementExclusionList</ns0:SharedEntityType>
+        </ns0:SharedEntityAssociation>
+      </ns0:Associations>
+    </ns0:SetSharedEntityAssociationsRequest>
+  </soap:Body>
+</soap:Envelope>

data/spec/fixtures/campaign_management/set_shared_entity_associations/standard_response.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0"?>
+<s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/">
+  <s:Header>
+    <h:TrackingId xmlns:h="https://bingads.microsoft.com/CampaignManagement/v13">29921349-7ed0-43e9-b9d8-15246bee3651</h:TrackingId>
+  </s:Header>
+  <s:Body>
+    <SetSharedEntityAssociationsResponse xmlns="https://bingads.microsoft.com/CampaignManagement/v13">
+      <PartialErrors xmlns:i="http://www.w3.org/2001/XMLSchema-instance"/>
+    </SetSharedEntityAssociationsResponse>
+  </s:Body>
+</s:Envelope>

data/tasks/bing_ads_ruby_sdk.rake

@@ -2,16 +2,18 @@ require 'dotenv/load'
 
 namespace :bing_token do
   desc "Gets and stores Bing OAuth token in file"
-  task :get, [:filename, :bing_developer_token, :bing_client_id] do |task, args|
+  task :get, [:filename, :bing_developer_token, :bing_client_id, :bing_client_secret] do |task, args|
 
     filename = args[:filename] || ENV.fetch('BING_STORE_FILENAME')
     developer_token = args[:bing_developer_token] || ENV.fetch('BING_DEVELOPER_TOKEN')
     bing_client_id = args[:bing_client_id] || ENV.fetch('BING_CLIENT_ID')
+    bing_client_secret = args[:bing_client_secret] || ENV.fetch('BING_CLIENT_SECRET', nil)
 
     store = ::BingAdsRubySdk::OAuth2::FsStore.new(filename)
     auth = BingAdsRubySdk::OAuth2::AuthorizationHandler.new(
       developer_token: developer_token,
       client_id: bing_client_id,
+      client_secret: bing_client_secret,
       store: store
     )
     puts "Go to #{auth.code_url}",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bing_ads_ruby_sdk
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.3.3
 platform: ruby
 authors:
 - Effilab
@@ -9,22 +9,28 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-29 00:00:00.000000000 Z
+date: 2020-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: signet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.8.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.13.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.8.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.13.0
 - !ruby/object:Gem::Dependency
   name: excon
   requirement: !ruby/object:Gem::Requirement
@@ -306,6 +312,8 @@ files:
 - spec/fixtures/campaign_management/get_uet_tags_by_ids/standard_response.xml
 - spec/fixtures/campaign_management/set_ad_extensions_associations/standard.xml
 - spec/fixtures/campaign_management/set_ad_extensions_associations/standard_response.xml
+- spec/fixtures/campaign_management/set_shared_entity_associations/standard.xml
+- spec/fixtures/campaign_management/set_shared_entity_associations/standard_response.xml
 - spec/fixtures/campaign_management/update_conversion_goals/standard.xml
 - spec/fixtures/campaign_management/update_conversion_goals/standard_response.xml
 - spec/fixtures/campaign_management/update_uet_tags/standard.xml
@@ -340,8 +348,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Bing Ads Ruby SDK
@@ -406,6 +413,8 @@ test_files:
 - spec/fixtures/campaign_management/get_uet_tags_by_ids/standard_response.xml
 - spec/fixtures/campaign_management/set_ad_extensions_associations/standard.xml
 - spec/fixtures/campaign_management/set_ad_extensions_associations/standard_response.xml
+- spec/fixtures/campaign_management/set_shared_entity_associations/standard.xml
+- spec/fixtures/campaign_management/set_shared_entity_associations/standard_response.xml
 - spec/fixtures/campaign_management/update_conversion_goals/standard.xml
 - spec/fixtures/campaign_management/update_conversion_goals/standard_response.xml
 - spec/fixtures/campaign_management/update_uet_tags/standard.xml