bing-ads 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 07de1d1b77a390e2dbcf751a26ebd3d19ef24967
-  data.tar.gz: 209b2b9ad7bf5ff642140d5e95751ee98e63c873
+  metadata.gz: bc31748b139decf28fde91e23bf470f2074cdf58
+  data.tar.gz: 6bb1b477c35b26f665b29a9d293e524ad41b24ce
 SHA512:
-  metadata.gz: df9e01c278b7ef1c8ae34bd81370651f33179f33f779cb8db04322654b248cf527cddf6db8c13eb91f979a0dba265a2022fdd11def50937fa11ca79a21f583f9
-  data.tar.gz: 75a678422263eb8e8b8a5065e1eade82c9e4cbaad6f2b92e1374fcd4967cb56fe8f1d2d538190228f4d434283200d6865a1b9571f1f8f2c0454b8c229b782d45
+  metadata.gz: 6ae2cae5856504d061d40f7f584c333ecb2709668e324430dd97dc579d109cfe892723d04fbff208c1d4fd1afe8087af5d51484ac9a8a36ab02e68351b9a0019
+  data.tar.gz: 19e819791660d49b09686e2d06c2930ed4155e5d2fec351542a98a352e95a9535cbe10a980e85eece7b5aa0c4b4337f53664f8ef0f59d28c21e875825beac758

data/lib/bing/ads/api/v11.rb

@@ -6,7 +6,11 @@ module Bing
         NAMESPACE_IDENTIFIER = :v11
 
         def self.constants
-          Persey.config
+          @_config || fail('Error loading bing ads gem')
+        end
+
+        def self.constants=(config)
+          @_config = config
         end
       end
     end

data/lib/bing/ads/api/v11/constants.rb

@@ -21,6 +21,8 @@ module Bing
           source :yaml, wsdl_path, :wsdl
           env :default
         end
+
+        Bing::Ads::API::V11.constants = Persey.config
       end
     end
   end

data/lib/bing/ads/api/v11/services/campaign_management.rb

@@ -16,6 +16,17 @@ module Bing
               [response_body[:campaigns][:campaign]].flatten.compact
             end
 
+            def get_campaigns_by_ids(account_id, campaign_ids)
+              account_id ||= @account_id
+              payload = {
+               account_id: account_id,
+               campaign_ids: { 'ins1:long' => campaign_ids }
+              }
+              response = call(:get_campaigns_by_ids, payload)
+              response_body = response_body(response, __method__)
+              [response_body[:campaigns][:campaign]].flatten.compact
+            end
+
             def add_campaigns(account_id, campaigns)
               validate_limits!(:campaign, :add, campaigns)
               campaigns = campaigns.map { |campaign| prepare_campaign(campaign) }
@@ -251,7 +262,6 @@ module Bing
             # TODO get_budgets_by_ids
             # TODO get_campaign_criterions_by_ids
             # TODO get_campaign_ids_by_budget_ids
-            # TODO get_campaigns_by_ids
             # TODO get_campaign_sizes_by_account_id
             # TODO get_config_value
             # TODO get_conversion_goals_by_ids

data/lib/bing/ads/api/v11/services/customer_management.rb

@@ -12,7 +12,7 @@ module Bing
             def get_accounts_info(customer_id = @customer_id, only_parent_accounts = false)
               payload = {
                 customer_id: customer_id,
-                only_parent_accounts: only_parent_accounts
+                only_parent_accounts: (only_parent_accounts == true).to_s
               }
               response = call(:get_accounts_info, payload.compact)
               response_body = response_body(response, __method__)

data/lib/bing/ads/version.rb

@@ -1,5 +1,5 @@
 module Bing
   module Ads
-    VERSION = '0.1.3'
+    VERSION = '0.1.4'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bing-ads
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - oss92
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-08-16 00:00:00.000000000 Z
+date: 2017-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon