bing-ads 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9d2c1ad3927817aea14d5e9fbca74bc0fe8e215
-  data.tar.gz: 4164a03a0cc8d5c7b66cf617f9bed9199746f7ff
+  metadata.gz: 2089287da01bbb3bae3202c1f09f59d1b0c278c4
+  data.tar.gz: 487814f5d5585592fef4743e279fa12ddbc406c9
 SHA512:
-  metadata.gz: ee7c3c7677cb20105428728338d5cb5aab2e2fbc6362dca244566f9b02d05b50e178f4e7c7e9d190f2714e1d63baaf34bef4195c5bd7bdf487dcea992205b511
-  data.tar.gz: 984bd0bcd26fbe5372c03cf49f10aae4199142aea929872a4ef01f3a4e59933b094771d113cd98170562cde3722cb4b9e4cea947bd8e21d0f8e911ae7109e1d1
+  metadata.gz: 710a7812ad2196d8c5e64494388c47fc3ae9387f3b6fdb23eba7019069f3039f3a0eb660e93ba9ec69506c4214f5d8cf1448fdb144d3900852ae6628a120fba8
+  data.tar.gz: 197888a9dfd693655cd154315108ca7418c7298e1f4a2f07d80813bf6631049aefe7449b7e2eaf644e3c6351b797c48395a1527783c8afd20de32fdfd1e9d14d

data/README.md

@@ -1,3 +1,5 @@
+[![Gem Version](https://img.shields.io/gem/v/bing-ads.svg)](https://rubygems.org/gems/bing-ads)
+
 # Bing::Ads
 
 A Ruby client for Bing Ads API that includes a proxy to all Bing Ads API web services and abstracts low level details of authentication with OAuth.
@@ -38,7 +40,7 @@ options = {
 service = Bing::Ads::API::V11::Services::CampaignManagement.new(options)
 ```
 
-#### Getting campaigns in account
+#### Getting campaigns
 ```ruby
 account_id = 5278183
 response = service.get_campaigns_by_account_id(account_id)
@@ -92,20 +94,20 @@ response = service.delete_campaigns(account_id, campaign_ids_to_delete)
 
 ---
 
-#### Getting ad groups in campaign
+#### Getting ad groups in a campaign
 ```ruby
 campaign_id = 813721838
 response = service.get_ad_groups_by_campaign_id(campaign_id)
 ```
 
-#### Getting ad groups in campaign by ids
+#### Getting ad groups in a campaign by ids
 ```ruby
 campaign_id = 813721838
 ad_group_ids = [9866221838, 9866221813, 9866221911]
 response = service.get_ad_groups_by_ids(campaign_id, ad_group_ids)
 ```
 
-#### Adding ad groups to campaign
+#### Adding ad groups to a campaign
 ```ruby
 # You can add a maximum of 1,000 ad groups in a single call.
 # Each campaign can have up to 20,000 ad groups.
@@ -132,7 +134,7 @@ ad_groups = [
 response = service.add_ad_groups(campaign_id, ad_groups)
 ```
 
-#### Updating ad groups in campaign
+#### Updating ad groups in a campaign
 ```ruby
 # You can add a maximum of 1,000 ad groups in a single call.
 # Each campaign can have up to 20,000 ad groups.
@@ -148,22 +150,29 @@ ad_groups = [
 response = service.update_ad_groups(campaign_id, ad_groups)
 ```
 
+#### Deleting ad groups from a campaign
+```ruby
+campaign_id = 813721838
+ad_group_ids_to_delete = [9866221838, 9866221839, 9866221840]
+response = service.delete_ad_groups(campaign_id, ad_group_ids_to_delete)
+```
+
 ---
 
-#### Getting ads in ad group
+#### Getting ads in an ad group
 ```ruby
 ad_group_id = 9866221838
 response = service.get_ads_by_ad_group_id(ad_group_id)
 ```
 
-#### Getting ads in ad group by ids
+#### Getting ads in an ad group by ids
 ```ruby
 ad_group_id = 9866221838
 ad_ids = [454873284248, 454873284249, 454873284250]
 response = service.get_ads_by_ids(ad_group_id, ad_ids)
 ```
 
-#### Adding ads to ad group
+#### Adding ads to an ad group
 ```ruby
 # You can add a maximum of 50 ads in an ad group.
 ad_group_id = 9866221838
@@ -191,7 +200,7 @@ expanded_text_ads = [
 response = service.add_ads(ad_group_id, expanded_text_ads)
 ```
 
-#### Updating ads in ad group
+#### Updating ads in an ad group
 ```ruby
 ad_group_id = 9866221838
 updated_expanded_text_ads = [
@@ -207,22 +216,29 @@ updated_expanded_text_ads = [
 response = service.update_ads(ad_group_id, updated_expanded_text_ads)
 ```
 
+#### Deleting ads from an ad group
+```ruby
+ad_group_id = 9866221838
+ad_ids_to_delete = [454873284248, 454873284249, 454873284250]
+response = service.delete_ads(ad_group_id, ad_ids_to_delete)
+```
+
 ---
 
-#### Getting keywords in ad group
+#### Getting keywords in an ad group
 ```ruby
 ad_group_id = 9866221838
 response = service.get_keywords_by_ad_group_id(ad_group_id)
 ```
 
-#### Getting keywords in ad group by ids
+#### Getting keywords in an ad group by ids
 ```ruby
 ad_group_id = 9866221838
 keyword_ids = [234873284248, 234873284249, 234873284250]
 response = service.get_keywords_by_ids(ad_group_id, keyword_ids)
 ```
 
-#### Adding keywords to ad group
+#### Adding keywords to an ad group
 ```ruby
 ad_group_id = 9866221838
 keywords = [
@@ -247,7 +263,7 @@ keywords = [
 response = service.add_keywords(ad_group_id, keywords)
 ```
 
-#### Updating keywords in ad group
+#### Updating keywords in an ad group
 ```ruby
 ad_group_id = 9866221838
 updated_keywords = [
@@ -261,6 +277,13 @@ updated_keywords = [
 response = service.update_keywords(ad_group_id, updated_keywords)
 ```
 
+#### Deleting keywords from an ad group
+```ruby
+ad_group_id = 9866221838
+keyword_ids_to_delete = [234873284248, 234873284249, 234873284250]
+response = service.delete_keywords(ad_group_id, keyword_ids_to_delete)
+```
+
 ### Bulk Service
 Not yet supported
 
@@ -271,10 +294,11 @@ Not yet supported
 Not yet supported. Use: https://github.com/FindHotel/bing-ads-reporting
 
 ## Development
-
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 To install this gem onto your local machine, run `bundle exec rake install`.
 
-## Contributing
+## Tests
+Endpoints were manually tested but although RSpec is installed as a test framework, there are no tests written yet.
 
+## Contributing
 Bug reports and pull requests are welcome on GitHub at https://github.com/FindHotel/bing-ads.

data/lib/bing/ads/api/v11/services/campaign_management.rb

@@ -39,6 +39,7 @@ module Bing
             end
 
             def delete_campaigns(account_id, campaign_ids)
+              validate_limits!(:campaign, :delete, campaign_ids)
               payload = {
                 account_id: account_id,
                 campaign_ids: { 'ins1:long' => campaign_ids }
@@ -86,6 +87,16 @@ module Bing
               response_body(response, __method__)
             end
 
+            def delete_ad_groups(campaign_id, ad_group_ids)
+              validate_limits!(:ad_group, :delete, ad_group_ids)
+              payload = {
+                campaign_id: campaign_id,
+                ad_group_ids: { 'ins1:long' => ad_group_ids }
+              }
+              response = call(:delete_ad_groups, payload)
+              response_body(response, __method__)
+            end
+
             def get_ads_by_ad_group_id(ad_group_id)
               payload = {
                 ad_group_id: ad_group_id,
@@ -140,6 +151,16 @@ module Bing
               response_body(response, __method__)
             end
 
+            def delete_ads(ad_group_id, ad_ids)
+              validate_limits!(:ad, :delete, ad_ids)
+              payload = {
+                ad_group_id: ad_group_id,
+                ad_ids: { 'ins1:long' => ad_ids }
+              }
+              response = call(:delete_ads, payload)
+              response_body(response, __method__)
+            end
+
             def get_keywords_by_ad_group_id(ad_group_id)
               response = call(:get_keywords_by_ad_group_id, ad_group_id: ad_group_id)
               response_body = response_body(response, __method__)
@@ -178,6 +199,16 @@ module Bing
               response_body(response, __method__)
             end
 
+            def delete_keywords(ad_group_id, keyword_ids)
+              validate_limits!(:keyword, :delete, keyword_ids)
+              payload = {
+                ad_group_id: ad_group_id,
+                keyword_ids: { 'ins1:long' => keyword_ids }
+              }
+              response = call(:delete_keywords, payload)
+              response_body(response, __method__)
+            end
+
             # TODO add_ad_extensions
             # TODO add_ad_group_criterions
             # TODO add_audiences
@@ -195,8 +226,6 @@ module Bing
             # TODO apply_product_partition_actions
             # TODO delete_ad_extensions
             # TODO delete_ad_group_criterions
-            # TODO delete_ad_groups
-            # TODO delete_ads
             # TODO delete_audiences
             # TODO delete_budgets
             # TODO delete_campaign_criterions
@@ -314,7 +343,9 @@ module Bing
 
             def prepare_keyword(keyword)
               keyword = Bing::Ads::Utils.sort_keys(keyword)
-              keyword[:bid] = { amount: keyword[:bid] } if keyword[:bid]
+              # To use the AdGroup default match type bid,
+              # set the Amount element of the Bid object to null.
+              keyword[:bid] = { amount: keyword[:bid] }
               if keyword[:bidding_scheme]
                 # TODO support MaxClicksBiddingScheme, MaxConversionsBiddingScheme and TargetCpaBiddingScheme
                 keyword[:bidding_scheme] = {

data/lib/bing/ads/version.rb

@@ -1,5 +1,5 @@
 module Bing
   module Ads
-    VERSION = '0.1.0'
+    VERSION = '0.1.2'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bing-ads
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - oss92
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-08-07 00:00:00.000000000 Z
+date: 2017-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon