bindex 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 30c71c3e8372b14f944f36e0d4bbbbeef20afa73
-  data.tar.gz: d01dd1e87366ad5eabdc415890c0c8efee3bb5dc
+  metadata.gz: 8f3058f9c6ca15bbd05c8857a4c13b931c10855c
+  data.tar.gz: b0dc1e2b67f95cd838f427a11c03608161c03cd6
 SHA512:
-  metadata.gz: 38aa516e2594f473fcc7cdc4e412240d01a29da7866ca043fff5f1119bf7e70b54f04e7545b9225995a34934dab9c8a52579a27292e46a4a7c6d0a2d885a8db4
-  data.tar.gz: 8307b1fe43ca21e3bbd83dee6a69818d1c3a7f3fbccf7951d8861d13a5aae3bae6d1b353412f42a54cedaaf9fd61470ea887e4efe5c049adb7b5e75f69399507
+  metadata.gz: 3be4c3659396f2e68c9c3526bc5bd9c8e69325babb902d7bc4e0977bcf3c4b842e8c11a54af00169b926135672e28f836a4b41c88bfaa16b870ca010e41a47f2
+  data.tar.gz: f0a5337d9a0b35729f44b2d162e1c1e7028f147eaacfd270c10592e0ef8fd2d6f7bf7cf6ad1ef0e233c46b8379707cc06a2074956f6a74ab24b7f3dac1b34d3b

data/lib/bindex/rubinius.rb

@@ -19,13 +19,18 @@ module Bindex
 
     # Filters internal Rubinius locations.
     #
-    # The reason for this is that some methods, like ::Kernel.raise, are
-    # implemented in Ruby for Rubinius. Therefore, we will get a binding for
-    # them as well.
+    # There are a couple of reasons why we wanna filter out the locations.
     #
-    # To align the current_bindings implementation with the CRuby one, where
-    # the first binding will usually be binding of caller, we can use this
-    # object to clean bindings for internal Rubinius methods.
+    # * ::Kernel.raise, is implemented in Ruby for Rubinius. We don't wanna
+    #   have the frame for it to align with the CRuby and JRuby implementations.
+    #
+    # * For internal methods location variables can be nil. We can't create a
+    #   bindings for them.
+    #
+    # * Bindings from the current file are considered internal and ignored.
+    #
+    # We do that all that so we can align the bindings with the backtraces
+    # entries.
     class InternalLocationFilter
       def initialize(locations)
         @locations = locations
@@ -33,7 +38,9 @@ module Bindex
 
       def filter
         @locations.reject do |location|
-          location.file.start_with?('kernel/') || location.file == __FILE__
+          location.file.start_with?('kernel/delta/kernel.rb') ||
+            location.file == __FILE__ ||
+            location.variables.nil?
         end
       end
     end
@@ -50,7 +57,10 @@ end
   raise_exception = instance_method(:raise_exception)
 
   define_method(:raise_exception) do |exc|
-    exc.instance_variable_set(:@bindings, Bindex::Rubinius.current_bindings)
+    if exc.bindings.empty?
+      exc.instance_variable_set(:@bindings, Bindex::Rubinius.current_bindings)
+    end
+
     raise_exception.bind(self).call(exc)
   end
 end

data/lib/bindex/version.rb

@@ -1,3 +1,3 @@
 module Bindex
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/test/exception_test.rb

@@ -25,6 +25,12 @@ class ExceptionTest < BaseTest
     assert_equal 11, exc.bindings.first.eval('__LINE__')
   end
 
+  test "re-raising doesn't lose bindings information" do
+    exc = ReraisedFixture.new.call
+
+    assert_equal 3, exc.bindings.first.eval('__LINE__')
+  end
+
   test 'bindings is_empty_when_exception_is_still_not_raised' do
     exc = RuntimeError.new
 

data/test/fixtures/reraised_fixture.rb

@@ -0,0 +1,19 @@
+class ReraisedFixture
+  def call
+    reraise_an_error
+  rescue => exc
+    exc
+  end
+
+  private
+
+    def raise_an_error_in_eval
+      method_that_raises
+    rescue => exc
+      raise exc
+    end
+
+    def method_that_raises
+      raise
+    end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bindex
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Genadi Samokovarov
@@ -236,6 +236,7 @@ files:
 - test/fixtures/custom_error_fixture.rb
 - test/fixtures/eval_nested_fixture.rb
 - test/fixtures/flat_fixture.rb
+- test/fixtures/reraised_fixture.rb
 - test/test_helper.rb
 homepage: https://github.com/gsamokovarov/bindex
 licenses:
@@ -267,4 +268,5 @@ test_files:
 - test/fixtures/custom_error_fixture.rb
 - test/fixtures/eval_nested_fixture.rb
 - test/fixtures/flat_fixture.rb
+- test/fixtures/reraised_fixture.rb
 - test/test_helper.rb