bindata 2.4.7 → 2.4.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9be5b49e663e2525dfc786351b811954d2069d17796271f39dd2e6023b42b25b
-  data.tar.gz: d3f43e1edb07968d56ad0ae8afb6db509ac234670cd5695a8e6f3ea4ef1f24f0
+  metadata.gz: 930073ad9a50e67aa2d584a17c0138f3cb4008e4bd96851ceef305e16c7cadd2
+  data.tar.gz: ec59bb6fcff33192da1ee33952c69e1069c214c0f41f9b21786694ed7fa4c87c
 SHA512:
-  metadata.gz: 19f3a5d4f957c8136048df08132f3db8445e85c5cf894f046840724ff712ee656ecd1c0c40e962a90d00deae2af901b9aae7909e99ad68c91e9d1d133ead29dd
-  data.tar.gz: 162b363f3618ba5f89bdd5f8018e948d726ae52e153339fbd8071c9aefeedbd3a88146a987424871799949033047e02658eee8c0671bc17e5f9f0d8b9af3e9ae
+  metadata.gz: c2ebc4a2e56294d7b503d73cfee08fa165c37b96a4216e6ac17206b2566d3b5ea77adb188b819a8e63bf1a059ab79d068d1def5059d7b2b6811609f099a3656f
+  data.tar.gz: 96c38802d6197001dfbfb76a4a338bcc7dbf2e8f7ec685b5007cdc6a8917b502ad8bc1ca106323a52f3555cada27f1b90ba204a5c72253447983026af020c27f

data/ChangeLog.rdoc

@@ -1,5 +1,10 @@
 = BinData Changelog
 
+== Version 2.4.8 (2020-07-21)
+
+* Bug fix array self assignment.  Thanks to Spencer McIntyre.
+* Bug fix Stringz max_length.  Thanks to cdelafuente-r7.
+
 == Version 2.4.7 (2020-03-31)
 
 * Fix choice assignment inside arrays.  Reported by Spencer McIntyre.

data/lib/bindata/array.rb

@@ -80,6 +80,7 @@ module BinData
     end
 
     def assign(array)
+      return if self.equal?(array)  # prevent self assignment
       raise ArgumentError, "can't set a nil value for #{debug_name}" if array.nil?
 
       @element_list = []

data/lib/bindata/stringz.rb

@@ -80,7 +80,7 @@ module BinData
     def trim_to!(str, max_length = nil)
       if max_length
         max_length = 1 if max_length < 1
-        str.slice!(max_length)
+        str.slice!(max_length..-1)
         if str.length == max_length && str[-1, 1] != "\0"
           str[-1, 1] = "\0"
         end

data/lib/bindata/version.rb

@@ -1,3 +1,3 @@
 module BinData
-  VERSION = "2.4.7"
+  VERSION = "2.4.8"
 end

data/test/array_test.rb

@@ -266,6 +266,11 @@ describe BinData::Array, "when accessing elements" do
     lambda { obj["a"] }.must_raise TypeError
     lambda { obj[1, "a"] }.must_raise TypeError
   end
+
+  it "is unaffected by self assignment" do
+    obj.assign(obj)
+    obj.snapshot.must_equal [1, 2, 3, 4, 5]
+  end
 end
 
 describe BinData::Array, "with :read_until" do

data/test/stringz_test.rb

@@ -106,12 +106,12 @@ describe BinData::Stringz, "with max_length" do
   end
 
   it "trims values greater than max_length" do
-    obj.assign("abcde")
+    obj.assign("abcdefg")
     obj.must_equal "abcd"
   end
 
   it "writes values greater than max_length" do
-    obj.assign("abcde")
+    obj.assign("abcdefg")
     obj.to_binary_s.must_equal_binary "abcd\0"
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bindata
 version: !ruby/object:Gem::Version
-  version: 2.4.7
+  version: 2.4.8
 platform: ruby
 authors:
 - Dion Mendel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-30 00:00:00.000000000 Z
+date: 2020-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake