bindata 2.4.5 → 2.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a4db841bf592779a772cd1965118786c6004bb5460a51d5f4154207970f2016
-  data.tar.gz: dfebc39f1f2a3089d491050da6a58997401ac194f1cc3ef5602ff82a6a6554bb
+  metadata.gz: 2c4dad8d006c1df84f2f6e241e0309a6efdd41622e9d4469b72c5f4ab23c681f
+  data.tar.gz: 649973630d5544a6aa50185f20006d77ff75349d67448fe7b32b66417de87359
 SHA512:
-  metadata.gz: 9c0ef8d9c2bbbc39eee0c63c591097431b8cd428f5f3cfa03fedc15158f22fc05b6efab56bbad5990f967f45400af07a9c205da1c5953873dff9dcdc6ac24237
-  data.tar.gz: 03bcde0becfa611a100cb43c5d7982bfd3d156a264e817b9c01b1f4522fff7379a4279f25fa9f92d64535d411c597894adb7ba4004cc923c721721899cc9b99a
+  metadata.gz: 769971878d5575cb15cdab697ef7226f8e43c4a932e0f52fad91eaf32cbfeda2d8d027e10fb5be2498a6af2389b9bfe60aea0d1a11496303f0f5c55fdc582b0a
+  data.tar.gz: d623fe3a282df4a2fd68cc9235225ec56338ea0e02ffd6c659e797fd4369d651cd9087fc1457197546a2e05c149b9608f4686ebf58a850215be40588c76d69dd

data/ChangeLog.rdoc

@@ -1,5 +1,9 @@
 = BinData Changelog
 
+== Version 2.4.6 (2020-02-27)
+
+* More encoding fixes.  Thanks to Aaron Patterson.
+
 == Version 2.4.5 (2020-02-21)
 
 * Small typo fixes to examples.

data/lib/bindata/io.rb

@@ -213,7 +213,9 @@ module BinData
 
     # Creates a StringIO around +str+.
     def self.create_string_io(str = "")
-      StringIO.new(str.dup.force_encoding(Encoding::BINARY))
+      s = StringIO.new(str.dup.force_encoding(Encoding::BINARY))
+      s.binmode
+      s
     end
 
     # Create a new IO Read wrapper around +io+.  +io+ must provide #read,

data/lib/bindata/version.rb

@@ -1,3 +1,3 @@
 module BinData
-  VERSION = "2.4.5"
+  VERSION = "2.4.6"
 end

data/test/buffer_test.rb

@@ -52,25 +52,6 @@ describe BinData::Buffer, "subclassed with a single type" do
     obj.to_binary_s.must_equal_binary "\000\003\000\000\000"
   end
 
-  it "returns binary encoded data" do
-    obj = IntBuffer.new(3)
-    obj.to_binary_s.encoding.must_equal Encoding::ASCII_8BIT
-  end
-
-  it "returns binary encoded data despite Encoding.default_internal" do
-    w, $-w = $-w, false
-    before_enc = Encoding.default_internal
-
-    begin
-      Encoding.default_internal = Encoding::UTF_8
-      obj = IntBuffer.new(3)
-      obj.to_binary_s.encoding.must_equal Encoding::ASCII_8BIT
-    ensure
-      Encoding.default_internal = before_enc
-      $-w = w
-    end
-  end
-
   it "has total num_bytes" do
     obj = IntBuffer.new
     assert obj.clear?
@@ -172,4 +153,3 @@ describe BinData::Buffer, "nested buffers" do
     obj.to_binary_s.must_equal_binary "abcdeABCDE12345"
   end
 end
-

data/test/system_test.rb

@@ -360,3 +360,37 @@ describe BinData::Record, "with boolean parameters" do
     obj.a.must_equal 2
   end
 end
+
+describe BinData::Record, "encoding" do
+  class EncodingTestBufferRecord < BinData::Record
+    endian :big
+    default_parameter length: 5
+
+    uint16 :num
+    string :str, length: 10
+  end
+
+  it "returns binary encoded data" do
+    obj = EncodingTestBufferRecord.new(num: 3)
+    obj.to_binary_s.encoding.must_equal Encoding::ASCII_8BIT
+  end
+
+  it "returns binary encoded data with utf-8 string" do
+    obj = EncodingTestBufferRecord.new(num: 3, str: "日本語")
+    obj.to_binary_s.encoding.must_equal Encoding::ASCII_8BIT
+  end
+
+  it "returns binary encoded data despite Encoding.default_internal" do
+    w, $-w = $-w, false
+    before_enc = Encoding.default_internal
+
+    begin
+      Encoding.default_internal = Encoding::UTF_8
+      obj = EncodingTestBufferRecord.new(num: 3, str: "日本語")
+      obj.to_binary_s.encoding.must_equal Encoding::ASCII_8BIT
+    ensure
+      Encoding.default_internal = before_enc
+      $-w = w
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bindata
 version: !ruby/object:Gem::Version
-  version: 2.4.5
+  version: 2.4.6
 platform: ruby
 authors:
 - Dion Mendel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-21 00:00:00.000000000 Z
+date: 2020-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake