bindata 2.4.3 → 2.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dd9ce2f3336fc2e9f8e3250a278732351d6a1af220603fb62763b3ef83caaf5e
-  data.tar.gz: f8f15a3836564c6a51891231a276ed0848cc92bdb4663c5aca6d4eecd0f53ec4
+  metadata.gz: bc513e5824615b4b143e4a733bd6e8290bdfa831ab111267475a167f31125bb1
+  data.tar.gz: 93b4a5203a1d641dd1af806b769f92f8daf50644e9815d01fa2dbfec9f30bc8e
 SHA512:
-  metadata.gz: 5abcc6829c6b6ea410bc3c542d4b60d40a83e6ac883bb3a4b09dfefdc1e5a4ae1d37307d75e53cbbc1593a17dd327269974835a6f0936f2ab21f66fe69f120ba
-  data.tar.gz: ba8d7abcaac0ceb95acb6ffa8b24b7253495241fbd483ef887103a63d5c65c9649954a1998a70289e64823d0fb85bef1ba22a5bfb126b1cae9708a7412658220
+  metadata.gz: 88c701264083edfa92d193c33d394f7cb4bdc2f12722089ff27bb296bad28665f8e28a63158c98a8a45a189c68ce4792c027615ac0c9f1c61cacee1e02e817cc
+  data.tar.gz: dd1f06f1b17cbc005ca5399d86b62cfe420787d8a2f820d24f589f30dd58af99ed539eb5d5873f90b3877f986093a3bc5f176dcb7aaaeea176381809272b20ff

data/ChangeLog.rdoc

@@ -1,5 +1,11 @@
 = BinData Changelog
 
+== Version 2.4.4 (2018-10-03)
+
+* Display a hint when endian is omitted.  Requested by Tails.
+* Add thread safety to Integer/BitField creation.  Requested by jbpeirce.
+* Ensure windows sockets are unseekable.  Thanks to Brent Cook.
+
 == Version 2.4.3 (2018-03-10)
 
 * Add Uint8Arrays.  Requested by masarakki.

data/README.md

@@ -2,7 +2,6 @@
 
 [![Version     ](http://img.shields.io/gem/v/bindata.svg)                       ](https://rubygems.org/gems/bindata)
 [![Travis CI   ](http://img.shields.io/travis/dmendel/bindata/master.svg)     ](https://travis-ci.org/dmendel/bindata)
-[![Quality     ](http://img.shields.io/codeclimate/github/dmendel/bindata.svg)](https://codeclimate.com/github/dmendel/bindata)
 [![Coverage    ](http://img.shields.io/coveralls/dmendel/bindata.svg)         ](https://coveralls.io/r/dmendel/bindata)
 
 Do you ever find yourself writing code like this?

data/lib/bindata.rb

@@ -1,13 +1,5 @@
 # BinData -- Binary data manipulator.
-# Copyright (c) 2007 - 2016 Dion Mendel.
-
-if RUBY_VERSION <= "1.9"
-  fail "BinData requires ruby >= 1.9.3. Use BinData version 1.8.x instead"
-end
-
-if RUBY_VERSION == "2.1.0" and RUBY_PATCHLEVEL == "0"
-  fail "Ruby 2.1.0p0 has a bug that causes BinData to fail. Upgrade your ruby version"
-end
+# Copyright (c) 2007 - 2018 Dion Mendel.
 
 require 'bindata/version'
 require 'bindata/array'
@@ -36,10 +28,10 @@ require 'bindata/warnings'
 # A declarative way to read and write structured binary data.
 # 
 # A full reference manual is available online at
-# http://bindata.rubyforge.org/manual.html
+# https://github.com/dmendel/bindata/wiki
 #
 # == License
 #
 # BinData is released under the same license as Ruby.
 #
-# Copyright (c) 2007 - 2016 Dion Mendel.
+# Copyright (c) 2007 - 2018 Dion Mendel.

data/lib/bindata/bits.rb

@@ -1,3 +1,4 @@
+require 'thread'
 require 'bindata/base_primitive'
 
 module BinData
@@ -5,15 +6,18 @@ module BinData
   # The integer is defined by endian and number of bits.
 
   module BitField #:nodoc: all
+    @@mutex = Mutex.new
+
     class << self
       def define_class(name, nbits, endian, signed = :unsigned)
-        unless BinData.const_defined?(name)
-          BinData.module_eval <<-END
-            class #{name} < BinData::BasePrimitive
-              # nbits is either an integer or the symbol `:nbits`
-              BitField.define_methods(self, #{nbits.inspect}, :#{endian}, :#{signed})
-            end
-          END
+        @@mutex.synchronize do
+          unless BinData.const_defined?(name)
+            new_class = Class.new(BinData::BasePrimitive)
+            BitField.define_methods(new_class, nbits, endian.to_sym, signed.to_sym)
+            RegisteredClasses.register(name, new_class)
+
+            BinData.const_set(name, new_class)
+          end
         end
 
         BinData.const_get(name)

data/lib/bindata/int.rb

@@ -1,3 +1,4 @@
+require 'thread'
 require 'bindata/base_primitive'
 
 module BinData
@@ -5,14 +6,18 @@ module BinData
   # is defined by endian, signedness and number of bytes.
 
   module Int #:nodoc: all
+    @@mutex = Mutex.new
+
     class << self
       def define_class(name, nbits, endian, signed)
-        unless BinData.const_defined?(name)
-          BinData.module_eval <<-END
-            class #{name} < BinData::BasePrimitive
-              Int.define_methods(self, #{nbits}, :#{endian}, :#{signed})
-            end
-          END
+        @@mutex.synchronize do
+          unless BinData.const_defined?(name)
+            new_class = Class.new(BinData::BasePrimitive)
+            Int.define_methods(new_class, nbits, endian.to_sym, signed.to_sym)
+            RegisteredClasses.register(name, new_class)
+
+            BinData.const_set(name, new_class)
+          end
         end
 
         BinData.const_get(name)

data/lib/bindata/io.rb

@@ -29,7 +29,7 @@ module BinData
 
       def seekable?
         @raw_io.pos
-      rescue NoMethodError, Errno::ESPIPE, Errno::EPIPE
+      rescue NoMethodError, Errno::ESPIPE, Errno::EPIPE, Errno::EINVAL
         nil
       end
 

data/lib/bindata/registry.rb

@@ -24,7 +24,7 @@ module BinData
     end
 
     def register(name, class_to_register)
-      return if class_to_register.nil?
+      return if name.nil? || class_to_register.nil?
 
       formatted_name = underscore_name(name)
       warn_if_name_is_already_registered(formatted_name, class_to_register)
@@ -37,8 +37,14 @@ module BinData
     end
 
     def lookup(name, hints = {})
-      key = normalize_name(name, hints)
-      @registry[key] || raise(UnRegisteredTypeError, name.to_s)
+      the_class = @registry[normalize_name(name, hints)]
+      if the_class
+        the_class
+      elsif @registry[normalize_name(name, hints.merge(endian: :big))]
+        raise(UnRegisteredTypeError, "#{name}, do you need to specify endian?")
+      else
+        raise(UnRegisteredTypeError, name)
+      end
     end
 
     # Convert CamelCase +name+ to underscore style.

data/lib/bindata/version.rb

@@ -1,3 +1,3 @@
 module BinData
-  VERSION = "2.4.3"
+  VERSION = "2.4.4"
 end

data/test/registry_test.rb

@@ -71,6 +71,14 @@ describe BinData::Registry, "with numerics" do
     }.must_raise BinData::UnRegisteredTypeError
   end
 
+  it "provides a nice error message when endian is omitted" do
+    begin
+      r.lookup("int24")
+    rescue BinData::UnRegisteredTypeError => e
+      e.message.must_equal "int24, do you need to specify endian?"
+    end
+  end
+
   it "does not lookup non byte based integers" do
     lambda {
       r.lookup("int3")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bindata
 version: !ruby/object:Gem::Version
-  version: 2.4.3
+  version: 2.4.4
 platform: ruby
 authors:
 - Dion Mendel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-09 00:00:00.000000000 Z
+date: 2018-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -165,7 +165,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: bindata
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A declarative way to read and write binary file formats