binary_struct 1.0.0 → 1.0.1

data/README.md

@@ -1,5 +1,9 @@
 # BinaryStruct
 
+[![Build Status](https://travis-ci.org/ManageIQ/binary_struct.png)](https://travis-ci.org/ManageIQ/binary_struct)
+[![Code Climate](https://codeclimate.com/github/ManageIQ/binary_struct.png)](https://codeclimate.com/github/ManageIQ/binary_struct)
+[![Coverage Status](https://coveralls.io/repos/ManageIQ/binary_struct/badge.png?branch=master)](https://coveralls.io/r/ManageIQ/binary_struct)
+
 BinaryStruct is a class for dealing with binary structured data.  It simplifies
 expressing what the binary structure looks like, with the ability to name the
 parts.  Given this definition, it is easy to encode/decode the binary structure

data/Rakefile

@@ -2,4 +2,5 @@ require "bundler/gem_tasks"
 
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new('spec')
-task :test => :spec
+task :test => :spec
+task :default => :spec

data/binary_struct.gemspec

@@ -26,4 +26,5 @@ from/to a Hash.
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "coveralls"
 end

data/lib/binary_struct.rb

@@ -131,45 +131,52 @@ class BinaryStruct
   end
 
   def self.sizeof(definition)
-    d = @@structs_by_definition[definition]
-    d = @@structs_by_definition[definition] = definition.kind_of?(self) ? definition : self.new(definition) if d.nil?
-    d.size
+    struct_by_definition(definition).size
   end
 
   def self.decode(data, definition)
-    d = @@structs_by_definition[definition]
-    d = @@structs_by_definition[definition] = definition.kind_of?(self) ? definition : self.new(definition) if d.nil?
-    d.decode(data)
+    struct_by_definition(definition).decode(data)
   end
 
   def self.encode(hash, definition)
-    d = @@structs_by_definition[definition]
-    d = @@structs_by_definition[definition] = definition.kind_of?(self) ? definition : self.new(definition) if d.nil?
-    d.encode(hash)
+    struct_by_definition(definition).encode(hash)
   end
 
   private
 
+  def self.struct_by_definition(definition)
+    @@structs_by_definition[definition] ||= definition.kind_of?(self) ? definition : self.new(definition)
+  end
+
   def self.validate_definition(definition)
     raise "definition must be an array of format/name pairs" if definition.empty? || definition.length % 2 != 0
-    definition.each_slice(2) do |format, name|
+    definition.each_slice(2) do |format, _|
       type, count = format[0, 1], format[1..-1]
-      raise "unrecognized format: #{type}" unless SIZES.has_key?(type)
-      raise "unsupported format: #{type}" if SIZES[type].nil?
-      unless count.empty? || count == '*'
-        begin
-          count = Integer(count)
-        rescue
-          raise "unsupported count: #{count}"
-        end
-        raise "unsupported count: #{count}" if count < 0
-      end
+      validate_definition_entry_type(type)
+      validate_definition_entry_count(count)
     end
   end
 
+  def self.validate_definition_entry_type(type)
+    raise "unrecognized format: #{type}" unless SIZES.has_key?(type)
+    raise "unsupported format: #{type}" if SIZES[type].nil?
+    return true
+  end
+
+  def self.validate_definition_entry_count(count)
+    return true if count.empty? || count == '*'
+
+    begin
+      count = Integer(count)
+    rescue
+      raise "unsupported count: #{count}"
+    end
+    raise "unsupported count: #{count}" if count < 0
+  end
+
   def self.get_size(definition)
     size = 0
-    definition.each_slice(2) do |format, name|
+    definition.each_slice(2) do |format, _|
       type, count = format[0, 1], format[1..-1]
       count = count.empty? ? 1 : count.to_i
       size += (count * SIZES[type])

data/lib/binary_struct/version.rb

@@ -1,3 +1,3 @@
 class BinaryStruct
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/spec/spec_helper.rb

@@ -14,3 +14,6 @@ RSpec.configure do |config|
   #     --seed 1234
   config.order = 'random'
 end
+
+require 'coveralls'
+Coveralls.wear!

data/travis.yml

@@ -0,0 +1,9 @@
+language: ruby
+rvm:
+  - "1.8.7"
+  - "1.9.2"
+  - "1.9.3"
+  - jruby-18mode # JRuby in 1.8 mode
+  - jruby-19mode # JRuby in 1.9 mode
+  - rbx-18mode
+  - rbx-19mode

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: binary_struct
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-16 00:00:00.000000000 Z
+date: 2013-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -60,6 +60,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: ! '
 
   BinaryStruct is a class for dealing with binary structured data.  It simplifies
@@ -91,6 +107,7 @@ files:
 - spec/data/test.gif
 - spec/gif_spec.rb
 - spec/spec_helper.rb
+- travis.yml
 homepage: http://github.com/ManageIQ/binary_struct
 licenses:
 - MIT
@@ -106,7 +123,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1202061900940413800
+      hash: 944965749837137154
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -115,7 +132,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1202061900940413800
+      hash: 944965749837137154
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24