binary_search_tree 2.0 → 2.2

data/lib/{binary_search_tree_hash.rb → binary_search_tree/binary_search_tree_hash.rb}

@@ -16,7 +16,7 @@ class BinarySearchTreeHash
 
   def [] key
     node = @bst.find key
-    node.present?? node.value : nil
+    node.nil?? nil : node.value
   end
 
   def []=(key, value)
@@ -40,15 +40,15 @@ class BinarySearchTreeHash
   end
 
   def values
-    map{ |node| node.second }
+    map{ |node| node.last }
   end
 
   def to_a
-    map{ |node| [node.first, node.second] }
+    map{ |node| [node.first, node.last] }
   end
 
   def to_s
-    '{' + map{ |node| "#{node.first} => #{node.second}" }.join(', ') + '}'
+    '{' + map{ |node| "#{node.first} => #{node.last}" }.join(', ') + '}'
   end
 
   def min
@@ -113,7 +113,7 @@ class BinarySearchTreeHash
   alias :length :size
 
   def has_key? key
-    @bst.find(key).present?
+    !!@bst.find(key)
   end
 
   def include? key
@@ -129,7 +129,7 @@ class BinarySearchTreeHash
   end
 
   def has_value? value
-    @bst.find_value(value).present?
+    !!@bst.find_value(value)
   end
 
   def value? value
@@ -147,7 +147,7 @@ class BinarySearchTreeHash
 
   def shift
     deleted_node = @bst.remove_min
-    deleted_node.present?? [deleted_node.key, deleted_node.value] : nil
+    deleted_node.nil?? nil : [deleted_node.key, deleted_node.value]
   end
 
   def invert

data/lib/binary_search_tree/version.rb

@@ -0,0 +1,3 @@
+module BinarySearch
+  VERSION = "2.2"
+end

data/spec/binary_node_spec.rb

@@ -0,0 +1,84 @@
+require 'rspec'
+require 'binary_search_tree'
+
+describe BinaryNode do
+  subject(:node) { BinaryNode.new(5, "five", nil) }
+ # its(:key) { should be (5) }
+ # its(:value) { should eql ("five") }
+
+  describe "#is_leaf?" do
+    it "returns true when height is 0" do
+      expect(node.is_leaf?).to be true
+    end
+
+    it "returns false when height is not 0" do
+      node.height = 1
+      expect(node.is_leaf?).to be false
+    end
+  end
+
+  describe "#max_children_height" do
+
+    before(:each) do
+      @left = double('left_child', :present? => true, :height => 3)
+      @right = double('right_child', :present? => true, :height => 2)
+      node.left, node.right = @left, @right
+    end
+
+    context "when both children are present and the left has a greater height" do
+      it "returns the value of the left child's height" do
+        expect(node.max_children_height).to eql(3)
+      end
+    end
+
+    context "when both children are present and right has a greater height" do
+      it "returns the value of the right child's height" do
+        @right.stub(:height).and_return(4)
+        expect(node.max_children_height).to eql(4)
+      end
+    end
+
+    context "when only the left child is present" do
+      it "returns the value of the left child's height" do
+        node.right = nil
+
+        expect(node.max_children_height).to eql(3)
+      end
+    end
+
+    context "when only the right child is present" do
+      it "returns the value of the right child's height" do
+        node.left = nil
+        expect(node.max_children_height).to eql(2)
+      end
+    end
+  end
+
+  describe "#balance_factor" do
+    before(:each) do
+      @left = double('left_child', :present? => true, :height => 3)
+      @right = double('right_child', :present? => true, :height => 2)
+      node.left, node.right = @left, @right
+    end
+
+    it "returns the correct height when the left is greater" do 
+       expect(node.balance_factor).to eql(1)
+    end
+
+    it "returns the correct height when the right is greater" do 
+       @right.stub(:height).and_return(5)
+       expect(node.balance_factor).to eql(-2)
+    end
+
+    it "returns the correct height when both are zero" do 
+       @right.stub(:height).and_return(0)
+       @left.stub(:height).and_return(0)
+       expect(node.balance_factor).to eql(0)
+    end
+  end
+
+
+
+
+end
+

data/spec/binary_search_tree_spec.rb

@@ -0,0 +1,107 @@
+require 'rspec'
+require 'binary_search_tree'
+
+describe BinarySearchTree do
+  subject(:tree) { BinarySearchTree.new() }
+
+  before(:each) do
+    tree.insert(9, "nine")
+    tree.insert(5, "five")
+    tree.insert(10, "ten")
+  end
+
+  describe "#insert" do
+    it "remains balanced after insertion requiring an lrc rebalance" do
+      tree.insert(1, "one")
+      tree.insert(3, "three")
+      expect(tree.root.max_children_height).to eql(1)
+    end
+
+    it "remains balanced after insertion requiring an llc rebalance" do
+      tree.insert(1, "one")
+      tree.insert(0.5, "half")
+      expect(tree.root.max_children_height).to eql(1)
+    end
+
+    it "remains balanced after insertion requiring an rrc rebalance" do
+      tree.insert(11, "eleven")
+      tree.insert(12, "twelve")
+      expect(tree.root.max_children_height).to eql(1)
+    end
+
+    it "remains balanced after insertion requiring an rlc rebalance" do
+      tree.insert(15, "X")
+      tree.insert(14, "X")
+      expect(tree.root.max_children_height).to eql(1)
+    end
+  end
+
+  describe "#find" do
+    it "finds a value when a value is present" do
+      expect(tree.find(9).value).to eql("nine")
+    end
+
+    it "does not find a value that is not present" do
+      expect(tree.find(18)).to eql(nil)
+    end
+  end
+
+  describe "#min" do
+    it "finds the minimum value" do
+      expect(tree.min.key).to eql(5)
+    end
+
+    it "finds the minimum value after insert" do
+      tree.insert(0.5, "half")
+      expect(tree.min.key).to eql(0.5)
+    end
+  end
+
+  describe "#max" do
+    it "returns the maximum value" do
+      expect(tree.max.key).to eql(10)
+    end
+  end
+
+  describe "#remove_min" do
+    it "updates the minimum value after removing" do
+      expect(tree.min.key).to eql(5)
+      tree.remove_min
+      expect(tree.min.key).to eql(9)
+    end
+  end
+
+  describe "#remove" do
+    it "updates the number of nodes in the tree" do
+      tree.remove(5)
+      expect(tree.min.key).to eql(9)
+    end
+
+    it "doesn't corrupt tree" do
+      puts "about to remove 10"
+      tree.remove 10
+      expect(tree.balanced?).to eql(true)
+      expect(tree.nodes.size).to eql(tree.size)
+
+      puts "about to remove 9"
+      tree.remove 9
+      expect(tree.balanced?).to eql(true)
+      expect(tree.nodes.size).to eql(tree.size)
+    end
+  end
+
+  describe "#nodes" do
+    it "returns an array of nodes" do
+      expect(tree.nodes).to be_an(Array)
+      expect(tree.nodes[0]).to be_a(BinaryNode)
+    end
+
+    it "contains all the nodes that have been inserted" do
+       tree.nodes.count.should eql(3)
+       tree.insert(11, "eleven")
+       tree.nodes.count.should eql(4)
+    end
+  end
+
+end
+

metadata

@@ -1,23 +1,48 @@
 --- !ruby/object:Gem::Specification
 name: binary_search_tree
 version: !ruby/object:Gem::Version
-  version: '2.0'
+  version: '2.2'
 platform: ruby
 authors:
 - Misha Conway
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-29 00:00:00.000000000 Z
-dependencies: []
+date: 2016-01-29 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email: MishaAConway@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".gitignore"
+- Gemfile
+- Gemfile.lock
+- README
+- Rakefile
+- binary_search_tree.gemspec
 - lib/binary_search_tree.rb
-- lib/binary_search_tree_hash.rb
+- lib/binary_search_tree/binary_node.rb
+- lib/binary_search_tree/binary_search_tree.rb
+- lib/binary_search_tree/binary_search_tree_hash.rb
+- lib/binary_search_tree/version.rb
+- spec/binary_node_spec.rb
+- spec/binary_search_tree_spec.rb
 homepage: 
 licenses:
 - MIT
@@ -38,9 +63,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: nowarning
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: A self balancing avl binary search tree class. Also includes BinarySearchTreeHash
   which is a hash like class that internally uses binary search tree.
 test_files: []
+has_rdoc: