bima-shark-sdk 2.4.0 → 2.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5cd9e83af8c7d48a3ca87715aa3743e6195a3e85
-  data.tar.gz: 2fe2155fa9f5e1619791a6c988b7d77aaa22a61d
+  metadata.gz: a940bf61424a49baa7f04791ca42ba61bb145a97
+  data.tar.gz: 734da4e58e55397a983e31ac9e53aa372e664a7b
 SHA512:
-  metadata.gz: 96753859d7e2363bbadab88a43699da4c953c62289e2121a42486997aa35d5558496affc6ef478e94699df38c5508c0eac195e0d54641d92c4886a50ffd15d39
-  data.tar.gz: 309c64b4042225ef5f345bd48fbc573a0fb9daeaaf74f411b7994622786dbd3d93dfa0097ce1d4e32125da146f32b8385f3ccb9ce218efaefa9f2c92afb0dcb8
+  metadata.gz: 7c1ade4eaefb81ae08c8e799d29bd6caf4b4ff1f355df7f4382c9bd0cddb3dcc0b3b0022fb4c68ffeb6d3278a95cca50a04b3076002ff1d1e5a5e9688881b36a
+  data.tar.gz: 12186155c320e2254eed1d4e4dcfe47ac31b2f540e5d5470d15472c3b333d9915fc75347795762be86438c7d556e004d85d2f02235bd89d5913e32f62709d763

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 ## Changelog
 
-#### Unreleased
+#### 2.4.2
+- [fix] don't swallow connection errors
+
+#### 2.4.1
+- [fix] Form Service: Added missing `versions` association to `Form`
 
 #### 2.4.0
 - added `Shark::Contact#consents` and `Shark::Contact#create_contract`

data/lib/shark/error.rb

@@ -24,11 +24,7 @@ module Shark
     end
   end
 
-  class ConnectionError < ApiError
-    def initialize(env)
-      @env = env
-    end
-  end
+  class ConnectionError < Error; end
 
   class ClientError < ApiError; end
 

data/lib/shark/form_service/v2/form.rb

@@ -4,6 +4,8 @@ module Shark
   module FormService
     module V2
       class Form < V2::Base
+        has_many :versions
+
         # @example
         #   form = Shark::FormService::V2::Form.find(id)
         #   form.activate

data/lib/shark/middleware/status.rb

@@ -12,8 +12,8 @@ module Shark
             handle_status(status, env)
           end
         end
-      rescue Faraday::ConnectionFailed, Faraday::TimeoutError
-        raise ConnectionError, environment
+      rescue Faraday::ConnectionFailed, Faraday::TimeoutError => e
+        raise ConnectionError, e
       end
 
       private

data/lib/shark/rspec/fake_contact_service/request.rb

@@ -32,7 +32,7 @@ module Shark
             log_info '[Shark][ContactService] Faking GET request'
             log_info request.uri.to_s
 
-            type = request.uri.path.split('/')[2]
+            type = request.uri.path.split('/')[-1]
             params = query_params_to_object(request.uri)
 
             objects = if %w[contacts accounts].include?(type) && params['filter'].present?
@@ -52,8 +52,8 @@ module Shark
             log_info '[Shark][ContactService] Faking GET request with ID'
             log_info request.uri.to_s
 
-            type = request.uri.path.split('/')[2]
-            id = request.uri.path.split('/')[3]
+            type = request.uri.path.split('/')[-2]
+            id = request.uri.path.split('/')[-1]
             query = request.uri.query_values
 
             object = cache.find(type, id)
@@ -84,11 +84,10 @@ module Shark
             log_info '[Shark][ContactService] Faking GET memberships request'
             log_info request.uri.to_s
 
-            type = request.uri.path.split('/')[2]
-            group_id = request.uri.path.split('/')[3]
+            group_id = request.uri.path.split('/')[-2]
             contact_id = query_params_to_object(request.uri)['filter']['contact_id']
 
-            group = cache.find(type, group_id)
+            group = cache.find('groups', group_id)
 
             if group.present?
               contacts = group.dig('relationships', 'contacts', 'data')
@@ -107,8 +106,8 @@ module Shark
             log_info "[Shark][ContactService] Faking PATCH request with body: #{request.body}"
             log_info request.uri.to_s
 
-            type = request.uri.path.split('/')[2]
-            id = request.uri.path.split('/')[3]
+            type = request.uri.path.split('/')[-2]
+            id = request.uri.path.split('/')[-1]
             parsed_data = JSON.parse(request.body)['data']
 
             object = cache.find(type, id)
@@ -134,8 +133,8 @@ module Shark
             log_info '[Shark][ContactService] Faking DELETE request'
             log_info request.uri.to_s
 
-            type = request.uri.path.split('/')[2]
-            id = request.uri.path.split('/')[3]
+            type = request.uri.path.split('/')[-2]
+            id = request.uri.path.split('/')[-1]
 
             object = cache.find(type, id)
 

data/lib/shark/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Shark
-  VERSION = '2.4.0'
+  VERSION = '2.4.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bima-shark-sdk
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.2
 platform: ruby
 authors:
 - Huy Dinh
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-01-10 00:00:00.000000000 Z
+date: 2022-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport