billomat 1.4.1 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9285a437b3f48f934a29ba53fa604cb2e75c92f741f2d6a3efa5e6d66436faeb
-  data.tar.gz: fc53cadd50256ef7544af986467e95e53a4cc2fdf9921bf9f5902621068229c1
+  metadata.gz: 6ee6ebd2cbd53ca2dbd1dee24eae4635a8c59659eb9dd582a74ea653476fc92b
+  data.tar.gz: 63806bba355815bc2268fba35da890892aeafcbb1433495b277e720aeb3cf722
 SHA512:
-  metadata.gz: 7af2786d47172cc693d56979bb0edd737c13e2f314166b0a44c4f02d5115aff7f68a83d17607f010c8b5292987e67f1c101d576aaeb0951e865ca362e755c995
-  data.tar.gz: 7e9dfe58d19fc2eb391aa43683cd7ec4455931fd6b3392225d3d776eb25bef8fdb4845d8082d76ad9945e2a7f570069af13994106305e2498a239feecef3e03f
+  metadata.gz: 0111304b1914f53af9e8a309e61d7bcff6e1f5df88610f9862d684fbf1ae2e41eb49cd39735b890d26aa36508f90d63a59ddf0f7ef883545142b30968b8a0472
+  data.tar.gz: 3eb8e02713788b62695c9fb2484c75e174b4b8ef3262fd726dff6f641d9d0417e587a7967fb237aa0ab7e18b6bed90745673f948fc72a65a42668afb5dc195ee

data/.github/workflows/test.yml

@@ -18,7 +18,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['2.7', '3.0']
+        ruby: ['2.7', '3.0', '3.1', '3.2', '3.3', '3.4']
         rails: ['6.1', '7.1']
     env:
       BUNDLE_GEMFILE: 'gemfiles/rails_${{ matrix.rails }}.gemfile'

data/.rubocop.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-rspec
   - rubocop-rails
 
@@ -54,7 +54,7 @@ RSpec/NestedGroups:
   Max: 4
 
 # Disable regular Rails spec paths.
-RSpec/FilePath:
+Rails/FilePath:
   Enabled: false
 
 # Because we just implemented the ActiveRecord API.

data/CHANGELOG.md

@@ -2,17 +2,27 @@
 
 * TODO: Replace this bullet point with an actual description of a change.
 
+### 1.5.1 (9 May 2025)
+
+* Corrected some RuboCop glitches ([#30](https://github.com/hausgold/billomat/pull/30))
+* Upgraded the rubocop dependencies ([#31](https://github.com/hausgold/billomat/pull/31))
+* Gracefully deal with non-JSON gateway error bodies ([#32](https://github.com/hausgold/billomat/pull/32))
+
+### 1.5.0 (30 January 2025)
+
+* Added all versions up to Ruby 3.4 to the CI matrix ([#29](https://github.com/hausgold/billomat/pull/29))
+
 ### 1.4.1 (17 January 2025)
 
-* Added the logger dependency (#28)
+* Added the logger dependency ([#28](https://github.com/hausgold/billomat/pull/28))
 
 ### 1.4.0 (11 January 2025)
 
-* Switched to Zeitwerk as autoloader (#27)
+* Switched to Zeitwerk as autoloader ([#27](https://github.com/hausgold/billomat/pull/27))
 
 ### 1.3.0 (3 January 2025)
 
-* Raised minimum supported Ruby/Rails version to 2.7/6.1 (#26)
+* Raised minimum supported Ruby/Rails version to 2.7/6.1 ([#26](https://github.com/hausgold/billomat/pull/26))
 
 ### 1.2.5 (15 August 2024)
 
@@ -32,14 +42,14 @@
 
 ### 1.2.1 (9 August 2024)
 
-* Added API docs building to continuous integration (#25)
+* Added API docs building to continuous integration ([#25](https://github.com/hausgold/billomat/pull/25))
 
 ### 1.2.0 (8 July 2024)
 
-* Moved the development dependencies from the gemspec to the Gemfile (#19)
-* Introduce `after_response` callback (#22)
-* Fix response parsing for responses exceeding the page size (#23)
-* Dropped support for Ruby <2.7 (#24)
+* Moved the development dependencies from the gemspec to the Gemfile ([#19](https://github.com/hausgold/billomat/pull/19))
+* Introduce `after_response` callback ([#22](https://github.com/hausgold/billomat/pull/22))
+* Fix response parsing for responses exceeding the page size ([#23](https://github.com/hausgold/billomat/pull/23))
+* Dropped support for Ruby <2.7 ([#24](https://github.com/hausgold/billomat/pull/24))
 
 ### 1.1.0 (24 February 2023)
 
@@ -47,24 +57,24 @@
 
 ### 1.0.0 (18 January 2023)
 
-* Bundler >= 2.3 is from now on required as minimal version (#18)
-* Dropped support for Ruby < 2.5 (#18)
-* Dropped support for Rails < 5.2 (#18)
+* Bundler >= 2.3 is from now on required as minimal version ([#18](https://github.com/hausgold/billomat/pull/18))
+* Dropped support for Ruby < 2.5 ([#18](https://github.com/hausgold/billomat/pull/18))
+* Dropped support for Rails < 5.2 ([#18](https://github.com/hausgold/billomat/pull/18))
 * Updated all development/runtime gems to their latest
-  Ruby 2.5 compatible version (#18)
+  Ruby 2.5 compatible version ([#18](https://github.com/hausgold/billomat/pull/18))
 
 ### 0.4.1 (27 June 2022)
 
-* Added `InvoiceComment` models (#17)
+* Added `InvoiceComment` models ([#17](https://github.com/hausgold/billomat/pull/17))
 
 ### 0.3.0 (11 October 2021)
 
 * Improve error handling (breaking change, as we are now raising
   `Billomat::GatewayError`s rather than just the client's
-  `RestClient::Exception`) (#15)
+  `RestClient::Exception`) ([#15](https://github.com/hausgold/billomat/pull/15))
 * Added bang variants to API methods
-  (`Billomat::Models::Base#{save!,create!,update!,delete!}`) (#16)
-* Added `CreditNote` and `CreditNoteItem` models (#14)
+  (`Billomat::Models::Base#{save!,create!,update!,delete!}`) ([#16](https://github.com/hausgold/billomat/pull/16))
+* Added `CreditNote` and `CreditNoteItem` models ([#14](https://github.com/hausgold/billomat/pull/14))
 * Moved to GitHub Actions
 * Migrated to our own coverage reporting
 
@@ -73,14 +83,14 @@
 * Add codeclimate test runner
 * Update codeclimate reporter id
 * Switched to SVG project teasers
-* Updated Travis CI and Code Climate configs (#11)
+* Updated Travis CI and Code Climate configs ([#11](https://github.com/hausgold/billomat/pull/11))
 * Changed travis-ci.org to travis-ci.com links
-* Adds templates and tags to models (#13)
+* Adds templates and tags to models ([#13](https://github.com/hausgold/billomat/pull/13))
 
 ### 0.1.6 (16 May 2018)
 
 * Support registered apps
-* Added `app_id` and `app_secret` to configuration (#9)
+* Added `app_id` and `app_secret` to configuration ([#9](https://github.com/hausgold/billomat/pull/9))
 
 ### 0.1.5 (14 November 2017)
 

data/Dockerfile

@@ -1,5 +1,5 @@
 FROM hausgold/ruby:2.7
-MAINTAINER Hermann Mayer <hermann.mayer@hausgold.de>
+LABEL org.opencontainers.image.authors="containers@hausgold.de"
 
 # Update system gem
 RUN gem update --system '3.4.22'

data/Gemfile

@@ -13,9 +13,9 @@ gem 'guard-rspec', '~> 4.7'
 gem 'irb', '~> 1.2'
 gem 'rake', '~> 13.0'
 gem 'rspec', '~> 3.12'
-gem 'rubocop', '~> 1.28'
-gem 'rubocop-rails', '~> 2.14'
-gem 'rubocop-rspec', '~> 2.10'
+gem 'rubocop'
+gem 'rubocop-rails'
+gem 'rubocop-rspec'
 gem 'simplecov', '>= 0.22'
 gem 'yard', '>= 0.9.28'
 gem 'yard-activesupport-concern', '>= 0.0.1'

data/gemfiles/rails_6.1.gemfile

@@ -9,9 +9,9 @@ gem "guard-rspec", "~> 4.7"
 gem "irb", "~> 1.2"
 gem "rake", "~> 13.0"
 gem "rspec", "~> 3.12"
-gem "rubocop", "~> 1.28"
-gem "rubocop-rails", "~> 2.14"
-gem "rubocop-rspec", "~> 2.10"
+gem "rubocop"
+gem "rubocop-rails"
+gem "rubocop-rspec"
 gem "simplecov", ">= 0.22"
 gem "yard", ">= 0.9.28"
 gem "yard-activesupport-concern", ">= 0.0.1"

data/gemfiles/rails_7.1.gemfile

@@ -9,9 +9,9 @@ gem "guard-rspec", "~> 4.7"
 gem "irb", "~> 1.2"
 gem "rake", "~> 13.0"
 gem "rspec", "~> 3.12"
-gem "rubocop", "~> 1.28"
-gem "rubocop-rails", "~> 2.14"
-gem "rubocop-rspec", "~> 2.10"
+gem "rubocop"
+gem "rubocop-rails"
+gem "rubocop-rspec"
 gem "simplecov", ">= 0.22"
 gem "yard", ">= 0.9.28"
 gem "yard-activesupport-concern", ">= 0.0.1"

data/lib/billomat/gateway.rb

@@ -11,8 +11,7 @@ module Billomat
     def initialize(original_exception)
       # Extract the error from the response if it is present. If no error
       # could be extracted, use the whole body
-      body = original_exception.response&.body
-      response_error = JSON.parse(body).dig('errors', 'error') || body if body
+      response_error = unpack_error_message(original_exception)
 
       # Use the default message and append our detailed error
       message = original_exception.default_message
@@ -21,6 +20,21 @@ module Billomat
       super(message)
       @original_exception = original_exception
     end
+
+    private
+
+    # Extract an error message from the response. If json, parse and extract.
+    # Otherwise, extract the first 128 bytes from the body; it's probably
+    # generic error HTML generated by a LoadBalancer
+    #
+    # @param original_exception [RestClient::Exception] the original exception
+    # @return [String, nil] the extracted error message
+    def unpack_error_message(original_exception)
+      body = original_exception.response&.body
+      JSON.parse(body).dig('errors', 'error') || body if body
+    rescue JSON::ParserError
+      body[0, 127] # probably HTML, thus only take the first few bytes
+    end
   end
 
   # This class can be used by the gem to communicate with the API.

data/lib/billomat/models/base.rb

@@ -31,7 +31,7 @@ module Billomat
       # @param data [Hash] the attributes of the object
       # @return [Billomat::Models::Base] the record as an object
       #
-      # rubocop:disable Style/OpenStructUse because of the convenient
+      # rubocop:disable Style/OpenStructUse -- because of the convenient
       #   dynamic data access
       def initialize(data = {})
         @data = OpenStruct.new(data)
@@ -51,7 +51,7 @@ module Billomat
 
       # @return [TrueClass]
       #
-      # rubocop:disable Style/OpenStructUse because of the convenient
+      # rubocop:disable Style/OpenStructUse -- because of the convenient
       #   dynamic data access
       def create
         resp = Billomat::Gateway.new(

data/lib/billomat/version.rb

@@ -3,7 +3,7 @@
 # The gem version details.
 module Billomat
   # The version of the +billomat+ gem
-  VERSION = '1.4.1'
+  VERSION = '1.5.1'
 
   class << self
     # Returns the version of gem as a string.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: billomat
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.5.1
 platform: ruby
 authors:
 - Hermann Mayer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2025-01-17 00:00:00.000000000 Z
+date: 2025-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -135,7 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.4.22
 signing_key: 
 specification_version: 4
 summary: Wrapper for the Billomat API