bill_hicks 1.2.4 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d576d59a7255cc36e5c5f191c3008f019447a0a7
-  data.tar.gz: de1ea3509600b34de25bee0d26e3767af9b2d880
+  metadata.gz: e48de64ff5d527cc8f31b9566ca0d107528717fd
+  data.tar.gz: 9ba44e2e1ca079346a50fa276d27cbce5d970a49
 SHA512:
-  metadata.gz: 27072dfd0a92e2e7ba2653261b3d6a25ec17f1778c594c4e5a45b82cedb8c0e4e9973f702c6687d582b825ddb328a4dfc9534fd294b46c26bfaa9892c37e4986
-  data.tar.gz: b7279e8a9c67fad9d748d20f63e2bea2614470707ae1c27c26d58ad535266a43225a32989b496689c021414bc887e88ae61afad154bfbcb607a915a3dd3b1c25
+  metadata.gz: c92a2b46442174db39669efe922fb6d89c81a0e6b479a79666fea72d2f6c846e30bae0e5557676bc8570abd3fdba16bab8adb56f99c447b992a64b0f17da2a35
+  data.tar.gz: f00e75bf53fad3b5c29cae8a09f4610462db23cc7585ed312204c470a778bff267333e725516b3258580555a9fcb4c0a74716037d0bbd5f4208623109ff921af

data/lib/bill_hicks/brand_converter.rb

@@ -2,11 +2,13 @@ module BillHicks
   class BrandConverter
 
     def self.convert(value)
-      if brand = self.brands.detect { |brand| brand[:prefix] == value.split[0].upcase }
-        brand[:company].empty? ? value.split[0] : brand[:company]
-      else
-        value.split[0].upcase
+      # Strip out all non-word characters and upcase
+      normalized_value = value.gsub(/\W/, '').split[0].upcase
+      if brand = self.brands.detect { |brand| brand[:prefix] == normalized_value }
+        return brand[:company]
       end
+      # No brand matched with the given prefix
+      normalized_value
     end
 
     def self.brands

data/lib/bill_hicks/catalog.rb

@@ -73,10 +73,6 @@ module BillHicks
         ftp.getbinaryfile(CATALOG_FILENAME, tempfile.path)
 
         SmarterCSV.process(File.open(tempfile, "r:iso-8859-1"), { chunk_size: size, force_utf8: true, convert_values_to_numeric: false }) do |chunk|
-          chunk.each do |item|
-            item[:brand_name] = BillHicks::BrandConverter.convert(item[:product_name])
-          end
-
           yield(chunk)
         end
 

data/lib/bill_hicks/version.rb

@@ -1,3 +1,3 @@
 module BillHicks
-  VERSION = '1.2.4'
+  VERSION = '1.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bill_hicks
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.3.0
 platform: ruby
 authors:
 - Dale Campbell
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-04-26 00:00:00.000000000 Z
+date: 2017-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: smarter_csv