bill_forward 1.2014.296 → 1.2015.183

data/spec/component/billing_entity_spec.rb

@@ -1,153 +1,153 @@
-require File.join(File.expand_path(File.dirname(__FILE__)), "..", "spec_helper")
-
-describe BillForward::BillingEntity do
-	before :all do
-		@client = BillForwardTest::TEST_CLIENT
-		BillForward::Client.default_client = @client
-	end
-	before :each do
-  		# skip OAuth request
-		allow_any_instance_of(BillForward::Client).to receive(:get_token).and_return('fake token')
-	end
-	context 'upon getting entity' do
-		before :each do
-			response = double
-		    allow(response).to receive(:to_str).and_return(canned_entity)
-		    allow(RestClient::Request).to receive(:execute).and_return(response)
-
-		    @entity = BillForward::Account.get_by_id 'anything'
-		end
-		subject (:entity) { @entity }
-		context 'using dot syntax' do
-			it "can get property" do
-				expect(entity.id).to eq('74DA7D63-EAEB-431B-9745-76F9109FD842')
-			end
-			it "can change property" do
-				newid = 'whatever'
-				entity.id = newid
-				expect(entity.id).to eq(newid)
-			end
-			it "can add property" do
-				value = 'whatever'
-				entity.fun = value
-				expect(entity.fun).to eq(value)
-			end
-			describe 'nested array of entities' do
-				context 'once unserialized' do
-					subject :roles do
-						roles = entity.roles
-					end
-					subject :role do
-						roles.first
-					end
-					it 'is an array' do
-						expect(roles.class).to eq(Array)
-					end
-					describe 'some element' do
-						it 'is an entity' do
-							expect(role.class).to eq(BillForward::Role)
-						end
-						it 'has expected properties' do
-							expect(role.role).to eq('user')
-						end
-						it 'has mutable properties' do
-							expect(role.role).to eq('user')
-							new_role = 'abuser'
-							role.role = new_role
-							expect(role.role).to eq(new_role)
-						end
-					end
-				end
-			end
-			describe 'nested entity' do
-				context 'once unserialized' do
-					subject :profile do
-						profile = entity.profile
-					end
-					it 'is an entity' do
-						expect(profile.class).to eq(BillForward::Profile)
-					end
-					it 'has expected properties' do
-						expect(profile.firstName).to eq('Test')
-					end
-					it 'has mutable properties' do
-						expect(profile.firstName).to eq('Test')
-						new_name = 'Best'
-						profile.firstName = new_name
-						expect(profile.firstName).to eq(new_name)
-					end
-				end
-			end
-		end
-		context 'using array access syntax' do
-			it "can get property" do
-				expect(entity['@type']).to eq('account')
-			end
-			it "can change property" do
-				newid = 'notever'
-				entity['id'] = newid
-				expect(entity['id']).to eq(newid)
-			end
-		end
-	end
-end
-
-def canned_entity
-'{
-  "executionTime": 1070093,
-  "results": [
-    {
-      "successfulSubscriptions": 0,
-      "@type": "account",
-      "roles": [
-      	{
-	      "id": "B4E623C2-2CE0-11E3-894A-FA163E717A7F",
-	      "accountID": "74DA7D63-EAEB-431B-9745-76F9109FD842",
-	      "role": "user",
-	      "created": "2014-09-04T17:43:44Z",
-	      "changedBy": "7872F2F4-ED96-4038-BC82-39F7DDFECE60"
-	    }
-      ],
-      "profile": {
-        "firstName": "Test",
-        "addresses": [
-          {
-            "landline": "02000000000",
-            "addressLine3": "address line 3",
-            "addressLine2": "address line 2",
-            "addressLine1": "address line 1",
-            "country": "United Kingdom",
-            "deleted": false,
-            "city": "London",
-            "profileID": "1B07A310-8B0F-4CFA-B2CF-48D206DC79C3",
-            "id": "34B5A980-A133-4B5F-9045-F1A41F20F2D6",
-            "primaryAddress": true,
-            "province": "London",
-            "created": "2014-09-04T17:43:44Z",
-            "postcode": "SW1 1AS",
-            "changedBy": "7872F2F4-ED96-4038-BC82-39F7DDFECE60",
-            "organizationID": "F60667D7-583A-4A01-B4DC-F74CC45ACAE3"
-          }
-        ],
-        "id": "1B07A310-8B0F-4CFA-B2CF-48D206DC79C3",
-        "updated": "2014-09-04T17:43:44Z",
-        "email": "always@testing.is.moe",
-        "created": "2014-09-04T17:43:44Z",
-        "changedBy": "7872F2F4-ED96-4038-BC82-39F7DDFECE60",
-        "organizationID": "F60667D7-583A-4A01-B4DC-F74CC45ACAE3",
-        "accountID": "74DA7D63-EAEB-431B-9745-76F9109FD842"
-      },
-      "deleted": false,
-      "crmID": null,
-      "id": "74DA7D63-EAEB-431B-9745-76F9109FD842",
-      "updated": "2014-09-04T17:43:43Z",
-      "created": "2014-09-04T17:43:43Z",
-      "paymentMethods": [
-
-      ],
-      "changedBy": "7872F2F4-ED96-4038-BC82-39F7DDFECE60",
-      "organizationID": "F60667D7-583A-4A01-B4DC-F74CC45ACAE3"
-    }
-  ]
-}'
+require File.join(File.expand_path(File.dirname(__FILE__)), "..", "spec_helper")
+
+describe BillForward::BillingEntity do
+	before :all do
+		@client = BillForwardTest::TEST_CLIENT
+		BillForward::Client.default_client = @client
+	end
+	before :each do
+  		# skip OAuth request
+		allow_any_instance_of(BillForward::Client).to receive(:get_token).and_return('fake token')
+	end
+	context 'upon getting entity' do
+		before :each do
+			response = double
+		    allow(response).to receive(:to_str).and_return(canned_entity)
+		    allow(RestClient::Request).to receive(:execute).and_return(response)
+
+		    @entity = BillForward::Account.get_by_id 'anything'
+		end
+		subject (:entity) { @entity }
+		context 'using dot syntax' do
+			it "can get property" do
+				expect(entity.id).to eq('74DA7D63-EAEB-431B-9745-76F9109FD842')
+			end
+			it "can change property" do
+				newid = 'whatever'
+				entity.id = newid
+				expect(entity.id).to eq(newid)
+			end
+			it "can add property" do
+				value = 'whatever'
+				entity.fun = value
+				expect(entity.fun).to eq(value)
+			end
+			describe 'nested array of entities' do
+				context 'once unserialized' do
+					subject :roles do
+						roles = entity.roles
+					end
+					subject :role do
+						roles.first
+					end
+					it 'is an array' do
+						expect(roles.class).to eq(Array)
+					end
+					describe 'some element' do
+						it 'is an entity' do
+							expect(role.class).to eq(BillForward::Role)
+						end
+						it 'has expected properties' do
+							expect(role.role).to eq('user')
+						end
+						it 'has mutable properties' do
+							expect(role.role).to eq('user')
+							new_role = 'abuser'
+							role.role = new_role
+							expect(role.role).to eq(new_role)
+						end
+					end
+				end
+			end
+			describe 'nested entity' do
+				context 'once unserialized' do
+					subject :profile do
+						profile = entity.profile
+					end
+					it 'is an entity' do
+						expect(profile.class).to eq(BillForward::Profile)
+					end
+					it 'has expected properties' do
+						expect(profile.firstName).to eq('Test')
+					end
+					it 'has mutable properties' do
+						expect(profile.firstName).to eq('Test')
+						new_name = 'Best'
+						profile.firstName = new_name
+						expect(profile.firstName).to eq(new_name)
+					end
+				end
+			end
+		end
+		context 'using array access syntax' do
+			it "can get property" do
+				expect(entity['@type']).to eq('account')
+			end
+			it "can change property" do
+				newid = 'notever'
+				entity['id'] = newid
+				expect(entity['id']).to eq(newid)
+			end
+		end
+	end
+end
+
+def canned_entity
+'{
+  "executionTime": 1070093,
+  "results": [
+    {
+      "successfulSubscriptions": 0,
+      "@type": "account",
+      "roles": [
+      	{
+	      "id": "B4E623C2-2CE0-11E3-894A-FA163E717A7F",
+	      "accountID": "74DA7D63-EAEB-431B-9745-76F9109FD842",
+	      "role": "user",
+	      "created": "2014-09-04T17:43:44Z",
+	      "changedBy": "7872F2F4-ED96-4038-BC82-39F7DDFECE60"
+	    }
+      ],
+      "profile": {
+        "firstName": "Test",
+        "addresses": [
+          {
+            "landline": "02000000000",
+            "addressLine3": "address line 3",
+            "addressLine2": "address line 2",
+            "addressLine1": "address line 1",
+            "country": "United Kingdom",
+            "deleted": false,
+            "city": "London",
+            "profileID": "1B07A310-8B0F-4CFA-B2CF-48D206DC79C3",
+            "id": "34B5A980-A133-4B5F-9045-F1A41F20F2D6",
+            "primaryAddress": true,
+            "province": "London",
+            "created": "2014-09-04T17:43:44Z",
+            "postcode": "SW1 1AS",
+            "changedBy": "7872F2F4-ED96-4038-BC82-39F7DDFECE60",
+            "organizationID": "F60667D7-583A-4A01-B4DC-F74CC45ACAE3"
+          }
+        ],
+        "id": "1B07A310-8B0F-4CFA-B2CF-48D206DC79C3",
+        "updated": "2014-09-04T17:43:44Z",
+        "email": "always@testing.is.moe",
+        "created": "2014-09-04T17:43:44Z",
+        "changedBy": "7872F2F4-ED96-4038-BC82-39F7DDFECE60",
+        "organizationID": "F60667D7-583A-4A01-B4DC-F74CC45ACAE3",
+        "accountID": "74DA7D63-EAEB-431B-9745-76F9109FD842"
+      },
+      "deleted": false,
+      "crmID": null,
+      "id": "74DA7D63-EAEB-431B-9745-76F9109FD842",
+      "updated": "2014-09-04T17:43:43Z",
+      "created": "2014-09-04T17:43:43Z",
+      "paymentMethods": [
+
+      ],
+      "changedBy": "7872F2F4-ED96-4038-BC82-39F7DDFECE60",
+      "organizationID": "F60667D7-583A-4A01-B4DC-F74CC45ACAE3"
+    }
+  ]
+}'
 end

data/spec/functional/account_spec.rb

@@ -1,25 +1,25 @@
-require File.join(File.expand_path(File.dirname(__FILE__)), "..", "spec_helper")
-
-describe BillForward::Account do
-	before :all do
-		@client = BillForwardTest::TEST_CLIENT
-		BillForward::Client.default_client = @client
-	end
-	describe '::get_by_id' do
-		context 'upon looking up non-existent ID' do
-			it "should find empty results" do
-				account_id = "nonexist"
-
-				expect{BillForward::Account.get_by_id account_id}.to raise_error(IndexError)
-			end
-		end
-	end
-	describe '::get_all' do
-		it "should find accounts" do
-			accounts = BillForward::Account.get_all
-			accounts_first = accounts.first
-
-			expect(accounts_first['@type']).to eq(BillForward::Account.resource_path.entity_name)
-		end
-	end
+require File.join(File.expand_path(File.dirname(__FILE__)), "..", "spec_helper")
+
+describe BillForward::Account do
+	before :all do
+		@client = BillForwardTest::TEST_CLIENT
+		BillForward::Client.default_client = @client
+	end
+	describe '::get_by_id' do
+		context 'upon looking up non-existent ID' do
+			it "should find empty results" do
+				account_id = "nonexist"
+
+				expect{BillForward::Account.get_by_id account_id}.to raise_error(IndexError)
+			end
+		end
+	end
+	describe '::get_all' do
+		it "should find accounts" do
+			accounts = BillForward::Account.get_all
+			accounts_first = accounts.first
+
+			expect(accounts_first['@type']).to eq(BillForward::Account.resource_path.entity_name)
+		end
+	end
 end

data/spec/functional/bad_citizen/account_spec.rb

@@ -1,103 +1,103 @@
-require File.join(File.expand_path(File.dirname(__FILE__)), "..", "..", "spec_helper")
-# we want unique numbers to test updates with
-require 'SecureRandom'
-
-describe BillForward::Account do
-	before :all do
-		@client = BillForwardTest::TEST_CLIENT
-		BillForward::Client.default_client = @client
-	end
-	describe '::create' do
-		context 'upon creating minimal account' do
-			before :all do
-				@created_account = BillForward::Account.create
-			end
-			subject (:account) { @created_account }
-			it "can get property" do
-				expect(account['@type']).to eq(BillForward::Account.resource_path.entity_name)
-			end
-			# it "can be retired" do
-			# 	expect(account.deleted).to eq(false)
-
-			# 	retired_account = account.delete
-			# 	expect(retired_account.deleted).to eq(true)
-			# end
-		end
-		context 'upon creating account with profile' do
-			describe 'the created account' do
-				before :all do
-					@email = 'always@testing.is.moe'
-					addresses = Array.new
-					addresses.push(
-						BillForward::Address.new({
-						'addressLine1' => 'address line 1',
-					    'addressLine2' => 'address line 2',
-					    'addressLine3' => 'address line 3',
-					    'city' => 'London',
-					    'province' => 'London',
-					    'country' => 'United Kingdom',
-					    'postcode' => 'SW1 1AS',
-					    'landline' => '02000000000',
-					    'primaryAddress' => true
-						}))
-					profile = BillForward::Profile.new({
-						'email' => @email,
-	  					'firstName' => 'Test',
-						'addresses' => addresses
-						})
-					account = BillForward::Account.new({
-						'profile' => profile
-						})
-					@created_account = BillForward::Account.create account
-				end
-				subject (:account) { @created_account }
-				it "can get property" do
-					expect(account['@type']).to eq(BillForward::Account.resource_path.entity_name)
-				end
-				it "has profile" do
-					profile = account.profile
-					expect(profile.email).to eq(@email)
-				end
-				context 'after creation' do
-					before :all do
-						@gotten_account = BillForward::Account.get_by_id @created_account.id
-					end
-					subject (:account) { @gotten_account }
-					it "can be gotten" do
-						expect(account['@type']).to eq(BillForward::Account.resource_path.entity_name)
-						expect(account.id).to eq(@created_account.id)
-					end
-					it "can be updated" do
-						expect(account.deleted).to eq(false)
-						account.deleted = true
-						expect(account.deleted).to eq(true)
-						updated_account = account.save
-
-						expect(updated_account.deleted).to eq(true)
-					end
-					describe "profile" do
-						subject (:profile) { account.profile }
-						it 'has expected properties' do
-							expect(profile.email).to eq(@email)
-						end
-						it 'has updatable properties' do
-							unique_value = SecureRandom.hex(10)
-							profile.firstName = unique_value
-							updated_profile = profile.save
-
-							expect(updated_profile.firstName).to eq(unique_value)
-						end
-						it 'can update properties via cascade' do
-							unique_value = SecureRandom.hex(10)
-							profile.firstName = unique_value
-							updated_account = account.save
-							updated_profile = updated_account.profile
-							
-							expect(updated_profile.firstName).to eq(unique_value)
-						end
-					end
-				end
-			end
-		end
-	end
+require File.join(File.expand_path(File.dirname(__FILE__)), "..", "..", "spec_helper")
+# we want unique numbers to test updates with
+require 'SecureRandom'
+
+describe BillForward::Account do
+	before :all do
+		@client = BillForwardTest::TEST_CLIENT
+		BillForward::Client.default_client = @client
+	end
+	describe '::create' do
+		context 'upon creating minimal account' do
+			before :all do
+				@created_account = BillForward::Account.create
+			end
+			subject (:account) { @created_account }
+			it "can get property" do
+				expect(account['@type']).to eq(BillForward::Account.resource_path.entity_name)
+			end
+			# it "can be retired" do
+			# 	expect(account.deleted).to eq(false)
+
+			# 	retired_account = account.delete
+			# 	expect(retired_account.deleted).to eq(true)
+			# end
+		end
+		context 'upon creating account with profile' do
+			describe 'the created account' do
+				before :all do
+					@email = 'always@testing.is.moe'
+					addresses = Array.new
+					addresses.push(
+						BillForward::Address.new({
+						'addressLine1' => 'address line 1',
+					    'addressLine2' => 'address line 2',
+					    'addressLine3' => 'address line 3',
+					    'city' => 'London',
+					    'province' => 'London',
+					    'country' => 'United Kingdom',
+					    'postcode' => 'SW1 1AS',
+					    'landline' => '02000000000',
+					    'primaryAddress' => true
+						}))
+					profile = BillForward::Profile.new({
+						'email' => @email,
+	  					'firstName' => 'Test',
+						'addresses' => addresses
+						})
+					account = BillForward::Account.new({
+						'profile' => profile
+						})
+					@created_account = BillForward::Account.create account
+				end
+				subject (:account) { @created_account }
+				it "can get property" do
+					expect(account['@type']).to eq(BillForward::Account.resource_path.entity_name)
+				end
+				it "has profile" do
+					profile = account.profile
+					expect(profile.email).to eq(@email)
+				end
+				context 'after creation' do
+					before :all do
+						@gotten_account = BillForward::Account.get_by_id @created_account.id
+					end
+					subject (:account) { @gotten_account }
+					it "can be gotten" do
+						expect(account['@type']).to eq(BillForward::Account.resource_path.entity_name)
+						expect(account.id).to eq(@created_account.id)
+					end
+					it "can be updated" do
+						expect(account.deleted).to eq(false)
+						account.deleted = true
+						expect(account.deleted).to eq(true)
+						updated_account = account.save
+
+						expect(updated_account.deleted).to eq(true)
+					end
+					describe "profile" do
+						subject (:profile) { account.profile }
+						it 'has expected properties' do
+							expect(profile.email).to eq(@email)
+						end
+						it 'has updatable properties' do
+							unique_value = SecureRandom.hex(10)
+							profile.firstName = unique_value
+							updated_profile = profile.save
+
+							expect(updated_profile.firstName).to eq(unique_value)
+						end
+						it 'can update properties via cascade' do
+							unique_value = SecureRandom.hex(10)
+							profile.firstName = unique_value
+							updated_account = account.save
+							updated_profile = updated_account.profile
+							
+							expect(updated_profile.firstName).to eq(unique_value)
+						end
+					end
+				end
+			end
+		end
+	end
 end

data/spec/functional/bad_citizen/credit_note_spec.rb

@@ -11,24 +11,25 @@ describe BillForward::CreditNote do
 				before :all do
 					@created_account = BillForward::Account.create
 
-					payment_method = BillForward::PaymentMethod.new({
-						'accountID' => @created_account.id,
-						'name' => 'Credit Notes',
-						'description' => 'Pay using credit',
-						# engines will link this to an invoice once paid, for the sake of refunds
-						'linkID' => '',
-						'gateway' => 'credit_note',
-						'userEditable' => 0,
-						'priority' => 100,
-						'reusable' => 1
-						})
-					created_payment_method = BillForward::PaymentMethod::create(payment_method)
+					# account implicitly has these nowadays
+					# payment_method = BillForward::PaymentMethod.new({
+					# 	'accountID' => @created_account.id,
+					# 	'name' => 'Credit Notes',
+					# 	'description' => 'Pay using credit',
+					# 	# engines will link this to an invoice once paid, for the sake of refunds
+					# 	'linkID' => '',
+					# 	'gateway' => 'credit_note',
+					# 	'userEditable' => 0,
+					# 	'priority' => 100,
+					# 	'reusable' => 1
+					# 	})
+					# created_payment_method = BillForward::PaymentMethod::create(payment_method)
 				end
 				subject (:account) { @created_account }
 				it 'issues credit' do
 					credit_note = BillForward::CreditNote.new({
 						"accountID" => account.id,
-					    "nominalValue" => 15,
+					    "value" => 15,
 					    "currency" => "USD"
 						})
 					created_credit_note = BillForward::CreditNote.create(credit_note)

data/spec/functional/bad_citizen/payment_method_spec.rb

@@ -5,7 +5,7 @@ describe BillForward::PaymentMethod do
 		@client = BillForwardTest::TEST_CLIENT
 		BillForward::Client.default_client = @client
 	end
-	describe '::create' do
+	skip '::create' do
 		context 'account exists' do
 			context 'using credit' do
 				before :all do