bigcartel-theme-fonts 1.4.1 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a20f414c9c5c27e7cb0b6dd8bd31371177fd3766a9fadf2ad7aa9d96fbc84afa
-  data.tar.gz: c65070787bcff611e1c28bbc7b4349db488ece7ed2e8cff03a6268446a929cdf
+  metadata.gz: 94d6e9c61e3d2e86f2a2d6bdf15d950dc0aae7810a417029d1d014db27b454e2
+  data.tar.gz: b464678e48913602b566a2196779ab397613a150955ec59ae702b3770e37a0a1
 SHA512:
-  metadata.gz: 1ac6858bb15390c5c9966c38f31956d20b75256c5b309544cb5fc21743a855271645c8d7b396ed61d0190d4b335f2cae5df2a0e47222ceb60eb96aa0c4be9425
-  data.tar.gz: bc6cfdac7180a22fc5e9eb14859d02f73bcae82b36815c9255c309d761bd1e355f6fceeb7ced995e1209ddcbe4367a7a77abfe38a7f17f0bd14f2168c57f7610
+  metadata.gz: 57bb8894b5deae3ec2e7891ee6cad9b079952a9ede43836c0982dd9fee07204bed90ea4c9186933904d3d9a1a6ad2617442b182bcbc9dec8486fe97ea8c158fd
+  data.tar.gz: 01741df66641569e79fa6d8952a1533ac5d53be45eaf3c875c49e6c23af4e2b69829f4a136b14f4a43c84e38ee340cb228109f1552411dc38e2bcbfac8c0718c

data/bigcartel-theme-fonts.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'bigcartel-theme-fonts'
-  spec.version       = '1.4.1'
+  spec.version       = '1.4.3'
   spec.authors       = ['Big Cartel']
   spec.email         = ['dev@bigcartel.com']
   spec.description   = %q{A simple class for working with Big Cartel's supported theme fonts.}

data/lib/bigcartel/theme/fonts/theme_font.rb

@@ -49,7 +49,7 @@ class ThemeFont < Struct.new(:name, :family, :weights, :collection)
         end
       end
 
-      "//fonts.googleapis.com/css?family=#{ fonts.uniq.map { |font| font.gsub(' ', '+') }.join('|') }"
+      "//fonts.googleapis.com/css?family=#{ fonts.uniq.map { |font| font.gsub(' ', '+') }.join('|') }&display=swap"
     end
 
     def google_font_url_for_all_fonts

data/spec/theme_font_spec.rb

@@ -73,15 +73,15 @@ describe ThemeFont do
 
   describe ".google_font_url_for_fonts" do
     it "should return a url for a given array of font names" do
-      ThemeFont.google_font_url_for_fonts(['Oh Hey', 'Buddy', 'Yeah']).should == "//fonts.googleapis.com/css?family=Oh+Hey|Buddy|Yeah"
+      ThemeFont.google_font_url_for_fonts(['Oh Hey', 'Buddy', 'Yeah']).should == "//fonts.googleapis.com/css?family=Oh+Hey|Buddy|Yeah&display=swap"
     end
 
     it "should return a url for a singular font in an array" do
-      ThemeFont.google_font_url_for_fonts(['Oh Hey']).should == "//fonts.googleapis.com/css?family=Oh+Hey"
+      ThemeFont.google_font_url_for_fonts(['Oh Hey']).should == "//fonts.googleapis.com/css?family=Oh+Hey&display=swap"
     end
 
     it "should only use unique font names" do
-      ThemeFont.google_font_url_for_fonts(['Yeah', 'Buddy', 'Yeah']).should == "//fonts.googleapis.com/css?family=Yeah|Buddy"
+      ThemeFont.google_font_url_for_fonts(['Yeah', 'Buddy', 'Yeah']).should == "//fonts.googleapis.com/css?family=Yeah|Buddy&display=swap"
     end
 
     context "when the fonts are an array of ThemeFonts" do
@@ -93,7 +93,7 @@ describe ThemeFont do
       end
 
       it "includes font weights in the URL" do
-        ThemeFont.google_font_url_for_fonts(fonts).should == "//fonts.googleapis.com/css?family=One+Font:400,500|Two+Font:500,700,800"
+        ThemeFont.google_font_url_for_fonts(fonts).should == "//fonts.googleapis.com/css?family=One+Font:400,500|Two+Font:500,700,800&display=swap"
       end
     end
   end
@@ -108,7 +108,7 @@ describe ThemeFont do
     end
 
     it "should return a URL for all Google fonts" do
-      ThemeFont.google_font_url_for_all_fonts.should == "//fonts.googleapis.com/css?family=One+Font|Three:400,600"
+      ThemeFont.google_font_url_for_all_fonts.should == "//fonts.googleapis.com/css?family=One+Font|Three:400,600&display=swap"
     end
   end
 
@@ -125,17 +125,17 @@ describe ThemeFont do
 
     it "should return a URL if a theme has multiple" do
       settings = { :header_font => 'One Font', :body_font => 'Two', :paragraph_font => 'Three' }
-      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700|Three"
+      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700|Three&display=swap"
     end
 
     it "should return single font name if a theme has one" do
       settings = { :header_font => 'One Font', :body_font => 'Two' }
-      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700"
+      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700&display=swap"
     end
 
     it "should dedup" do
       settings = { :header_font => 'One Font', :body_font => 'One Font' }
-      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700"
+      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700&display=swap"
     end
 
     it "should return nil if a theme has none" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bigcartel-theme-fonts
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.3
 platform: ruby
 authors:
 - Big Cartel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-29 00:00:00.000000000 Z
+date: 2023-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler