bigcartel-theme-fonts 1.4.0 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aa0af318dfd860dd02234259cab01dfe83d646891eb5d6a3540fe315327574b9
-  data.tar.gz: f33226299c6cab36d34b43bc96a8ee531f475faca807ae7d611a3e4d8baa175b
+  metadata.gz: 937a4cc82e055861612a5304f8e14f040bf5661176bb3d63f4d53e45e2a3c85f
+  data.tar.gz: 60b0d74b6c92a90c395a41f37957c3cf6422a32db6da8752a375ad3b1c68aed1
 SHA512:
-  metadata.gz: 5ae2feef5ba30aedac7861ad8425c66150d7895fff408826c399b4024a6aca8cfb1a1a2ea9d44d83fbdf47bf07b0bfc4cf892a69c9e020191c2b8a6077265a0e
-  data.tar.gz: becea456998b01a1ca1812e20b787f7c5d09050b4d5fcbe4529d7c1418697c952448069ddf4322ca3fc6319537837d0ca84ef6d5b88ddaab9a3cc358eecfe136
+  metadata.gz: e9f7b2bf885a5148b17141c03633e0ea5a4363302564aaaba3d1299f05323dfc7baf78f6cb60f209b147be78853fd687a372c30e1e96e9bb9751fae0b3bc721b
+  data.tar.gz: 887806d277870a480ed787306d2f37ec5f5be3262dfcabb13f2fe09ab214c71afa2a86d73d3c5c49708dbc16868f329cefaaeb36f151df4a52253aca3ed5eee5

data/bigcartel-theme-fonts.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'bigcartel-theme-fonts'
-  spec.version       = '1.4.0'
+  spec.version       = '1.4.2'
   spec.authors       = ['Big Cartel']
   spec.email         = ['dev@bigcartel.com']
   spec.description   = %q{A simple class for working with Big Cartel's supported theme fonts.}

data/lib/bigcartel/theme/fonts/theme_font.rb

@@ -49,7 +49,7 @@ class ThemeFont < Struct.new(:name, :family, :weights, :collection)
         end
       end
 
-      "//fonts.googleapis.com/css?family=#{ fonts.uniq.map { |font| font.gsub(' ', '+') }.join('|') }"
+      "//fonts.googleapis.com/css?family=#{ fonts.uniq.map { |font| font.gsub(' ', '+') }.join('|') }&display=swap"
     end
 
     def google_font_url_for_all_fonts

data/lib/bigcartel/theme/fonts/theme_fonts.yml

@@ -81,8 +81,8 @@ google:
     family: '"Bevan", cursive'
 
   biorhyme:
-    name: Biorhyme
-    family: '"Biorhyme", serif'
+    name: BioRhyme
+    family: '"BioRhyme", serif'
     weights: "400,700"
 
   copse:

data/spec/theme_font_spec.rb

@@ -73,15 +73,15 @@ describe ThemeFont do
 
   describe ".google_font_url_for_fonts" do
     it "should return a url for a given array of font names" do
-      ThemeFont.google_font_url_for_fonts(['Oh Hey', 'Buddy', 'Yeah']).should == "//fonts.googleapis.com/css?family=Oh+Hey|Buddy|Yeah"
+      ThemeFont.google_font_url_for_fonts(['Oh Hey', 'Buddy', 'Yeah']).should == "//fonts.googleapis.com/css?family=Oh+Hey|Buddy|Yeah&display=swap"
     end
 
     it "should return a url for a singular font in an array" do
-      ThemeFont.google_font_url_for_fonts(['Oh Hey']).should == "//fonts.googleapis.com/css?family=Oh+Hey"
+      ThemeFont.google_font_url_for_fonts(['Oh Hey']).should == "//fonts.googleapis.com/css?family=Oh+Hey&display=swap"
     end
 
     it "should only use unique font names" do
-      ThemeFont.google_font_url_for_fonts(['Yeah', 'Buddy', 'Yeah']).should == "//fonts.googleapis.com/css?family=Yeah|Buddy"
+      ThemeFont.google_font_url_for_fonts(['Yeah', 'Buddy', 'Yeah']).should == "//fonts.googleapis.com/css?family=Yeah|Buddy&display=swap"
     end
 
     context "when the fonts are an array of ThemeFonts" do
@@ -93,7 +93,7 @@ describe ThemeFont do
       end
 
       it "includes font weights in the URL" do
-        ThemeFont.google_font_url_for_fonts(fonts).should == "//fonts.googleapis.com/css?family=One+Font:400,500|Two+Font:500,700,800"
+        ThemeFont.google_font_url_for_fonts(fonts).should == "//fonts.googleapis.com/css?family=One+Font:400,500|Two+Font:500,700,800&display=swap"
       end
     end
   end
@@ -108,7 +108,7 @@ describe ThemeFont do
     end
 
     it "should return a URL for all Google fonts" do
-      ThemeFont.google_font_url_for_all_fonts.should == "//fonts.googleapis.com/css?family=One+Font|Three:400,600"
+      ThemeFont.google_font_url_for_all_fonts.should == "//fonts.googleapis.com/css?family=One+Font|Three:400,600&display=swap"
     end
   end
 
@@ -125,17 +125,17 @@ describe ThemeFont do
 
     it "should return a URL if a theme has multiple" do
       settings = { :header_font => 'One Font', :body_font => 'Two', :paragraph_font => 'Three' }
-      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700|Three"
+      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700|Three&display=swap"
     end
 
     it "should return single font name if a theme has one" do
       settings = { :header_font => 'One Font', :body_font => 'Two' }
-      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700"
+      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700&display=swap"
     end
 
     it "should dedup" do
       settings = { :header_font => 'One Font', :body_font => 'One Font' }
-      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700"
+      ThemeFont.google_font_url_for_theme(fonts, settings).should == "//fonts.googleapis.com/css?family=One+Font:400,700&display=swap"
     end
 
     it "should return nil if a theme has none" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bigcartel-theme-fonts
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.2
 platform: ruby
 authors:
 - Big Cartel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-29 00:00:00.000000000 Z
+date: 2023-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler