bigcartel-currency-locales 2.0.0 → 2.2.0

data/spec/integration/currency_locales_spec.rb

@@ -1,441 +1,70 @@
-# encoding: utf-8
-
 require 'spec_helper'
 
-describe "CurrencyLocales" do
-  let(:small_amount) { 9.99 }
-  let(:small_currency) { number_to_currency(small_amount) }
-  let(:small_precision) { number_with_precision(small_amount) }
-
-  let(:big_amount) { 9999.99 }
-  let(:big_currency) { number_to_currency(big_amount) }
-  let(:big_precision) { number_with_precision(big_amount) }
-
-  def number_to_currency(number)
-    ActionController::Base.helpers.number_to_currency(number, :locale => locale)
-  end
-
-  def number_with_precision(number)
-    ActionController::Base.helpers.number_with_precision(number, :locale => locale)
-  end
-
-  describe "cs" do
-    let(:locale) { 'cs' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '9,99Kč'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '9999,99Kč'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9,99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9999,99'
-    end
-  end
-
-  describe "da" do
-    let(:locale) { 'da' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == 'kr9,99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == 'kr9.999,99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9,99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9.999,99'
-    end
-  end
-
-  describe "en-AU" do
-    let(:locale) { 'en-AU' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '$9.99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '$9,999.99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
-    end
-  end
-
-  describe "en-GB" do
-    let(:locale) { 'en-GB' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '£9.99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '£9,999.99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
-    end
-  end
-
-  describe "en-IN" do
-    let(:locale) { 'en-IN' }
+shared_examples_for "locale" do |locale_code, small_currency, big_currency, small_precision, big_precision|
+  let(:locale) { locale_code }
 
-    it "should translate the small amount to currency" do
-      small_currency.should == '₹9.99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '₹9,999.99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9999.99'
-    end
-  end
-
-  describe "en-PH" do
-    let(:locale) { 'en-PH' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '₱9.99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '₱9,999.99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
-    end
-  end
-
-  describe "es-MX" do
-    let(:locale) { 'es-MX' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '$9.99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '$9,999.99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
-    end
+  it "should translate the small amount to currency for locale #{locale_code}" do
+    expect(number_to_currency(small_amount)).to eq(small_currency)
   end
 
-  describe "en-US" do
-    let(:locale) { 'en-US' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '$9.99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '$9,999.99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
-    end
+  it "should translate the big amount to currency for locale #{locale_code}" do
+    expect(number_to_currency(big_amount)).to eq(big_currency)
   end
 
-  describe "eu" do
-    let(:locale) { 'eu' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '€9.99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '€9,999.99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
-    end
+  it "should translate the small amount with precision for locale #{locale_code}" do
+    expect(number_with_precision(small_amount)).to eq(small_precision)
   end
 
-  describe "gsw-CH" do
-    let(:locale) { 'gsw-CH' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == 'CHF9.99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == 'CHF9,999.99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
-    end
+  it "should translate the big amount with precision for locale #{locale_code}" do
+    expect(number_with_precision(big_amount)).to eq(big_precision)
   end
+end
 
-  describe "hu" do
-    let(:locale) { 'hu' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '10Ft'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '10000Ft'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9,99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9999,99'
-    end
-  end
-
-  describe "il" do
-    let(:locale) { 'il' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '₪9.99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '₪9,999.99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
-    end
-  end
-
-  describe "ja" do
-    let(:locale) { 'ja' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '¥10'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '¥10,000'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
-    end
-  end
-
-  describe "ms-MY" do
-    let(:locale) { 'ms-MY' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == 'RM9.99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == 'RM9,999.99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
-    end
-  end
-
-  describe "nb" do
-    let(:locale) { 'nb' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '9,99kr'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '9999,99kr'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9,99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9999,99'
-    end
-  end
-
-  describe "pl" do
-    let(:locale) { 'pl' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '9,99zł'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '9999,99zł'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9,99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9999,99'
-    end
-  end
-
-  describe "pt-BR" do
-    let(:locale) { 'pt-BR' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == 'R$9,99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == 'R$9.999,99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9,99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9.999,99'
-    end
-  end
-
-  describe "sv-SE" do
-    let(:locale) { 'sv-SE' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '9,99kr'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '9999,99kr'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9,99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9999,99'
-    end
-  end
-
-  describe "th" do
-    let(:locale) { 'th' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '9.99฿'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '9,999.99฿'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
+describe "CurrencyLocales" do
+  let(:small_amount) { 9.99 }
+  let(:big_amount) { 9999.99 }
 
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
-    end
+  def number_to_currency(number)
+    ActionController::Base.helpers.number_to_currency(number, :locale => locale)
   end
 
-  describe "tr" do
-    let(:locale) { 'tr' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == '9,99 ₺'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == '9.999,99 ₺'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9,99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9.999,99'
-    end
+  def number_with_precision(number)
+    ActionController::Base.helpers.number_with_precision(number, :locale => locale)
   end
 
-  describe "zh-TW" do
-    let(:locale) { 'zh-TW' }
-
-    it "should translate the small amount to currency" do
-      small_currency.should == 'NT$9.99'
-    end
-
-    it "should translate the big amount to currency" do
-      big_currency.should == 'NT$9,999.99'
-    end
-
-    it "should translate the small amount with precision" do
-      small_precision.should == '9.99'
-    end
-
-    it "should translate the big amount with precision" do
-      big_precision.should == '9,999.99'
+  locales = {
+    'ae' => ['AED 9.99', 'AED 9,999.99', '9.99', '9,999.99'],
+    'bg' => ['9,99лв', '9 999,99лв', '9,99', '9 999,99'],
+    'cs' => ['9,99Kč', '9999,99Kč', '9,99', '9999,99'],
+    'da' => ['9,99kr', '9.999,99kr', '9,99', '9.999,99'],
+    'en-AU' => ['$9.99', '$9,999.99', '9.99', '9,999.99'],
+    'en-GB' => ['£9.99', '£9,999.99', '9.99', '9,999.99'],
+    'en-IN' => ['₹9.99', '₹9,999.99', '9.99', '9,999.99'],
+    'en-PH' => ['₱9.99', '₱9,999.99', '9.99', '9,999.99'],
+    'en-US' => ['$9.99', '$9,999.99', '9.99', '9,999.99'],
+    'es-MX' => ['$9.99', '$9,999.99', '9.99', '9,999.99'],
+    'eu' => ['€9.99', '€9,999.99', '9.99', '9,999.99'],
+    'gsw-CH' => ['CHF9.99', 'CHF9,999.99', '9.99', '9,999.99'],
+    'hr' => ['9,99 kn', '9.999,99 kn', '9,99', '9.999,99'],
+    'hu' => ['10Ft', '10000Ft', '9,99', '9999,99'],
+    'il' => ['₪9.99', '₪9,999.99', '9.99', '9,999.99'],
+    'ja' => ['¥10', '¥10,000', '9.99', '9,999.99'],
+    'ms-MY' => ['RM9.99', 'RM9,999.99', '9.99', '9,999.99'],
+    'nb' => ['9,99 kr', '9999,99 kr', '9,99', '9999,99'],
+    'pl' => ['9,99 zł', '9999,99 zł', '9,99', '9999,99'],
+    'pt-BR' => ['R$9,99', 'R$9.999,99', '9,99', '9.999,99'],
+    'ro' => ['9,99 lei', '9.999,99 lei', '9,99', '9.999,99'],
+    'sv-SE' => ['9,99 kr', '9999,99 kr', '9,99', '9999,99'],
+    'th' => ['฿9.99', '฿9,999.99', '9.99', '9,999.99'],
+    'tr' => ['₺9,99', '₺9.999,99', '9,99', '9.999,99'],
+    'zh-TW' => ['NT$9.99', 'NT$9,999.99', '9.99', '9,999.99'],
+  }
+
+  sorted_locales = locales.sort_by { |locale, _| locale }.to_h
+
+  sorted_locales.each do |locale, values|
+    describe "locale #{locale}" do
+        it_behaves_like "locale", locale, *values
     end
   end
 end

data/spec/spec_helper.rb

@@ -12,6 +12,6 @@ RSpec.configure do |config|
   config.fail_fast = true
 
   config.expect_with(:rspec) do |c|
-    c.syntax = :should
+    c.syntax = [:should, :expect]
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bigcartel-currency-locales
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Big Cartel
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-01-19 00:00:00.000000000 Z
+date: 2024-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -28,30 +28,30 @@ dependencies:
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.6.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.6.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 description: Common locale data for Rails i18n of Big Cartel's supported currencies.
 email: dev@bigcartel.com
 executables: []
@@ -67,11 +67,17 @@ files:
 - Rakefile
 - bigcartel-currency-locales.gemspec
 - gemfiles/.bundle/config
+- gemfiles/rails_6.1.gemfile
+- gemfiles/rails_6.1.gemfile.lock
 - gemfiles/rails_6.gemfile
 - gemfiles/rails_6.gemfile.lock
+- gemfiles/rails_7.1.gemfile
+- gemfiles/rails_7.1.gemfile.lock
 - gemfiles/rails_7.gemfile
 - gemfiles/rails_7.gemfile.lock
 - lib/bigcartel-currency-locales.rb
+- lib/currency-locales/locales/ae.yml
+- lib/currency-locales/locales/bg.yml
 - lib/currency-locales/locales/cs.yml
 - lib/currency-locales/locales/da.yml
 - lib/currency-locales/locales/en-AU.yml
@@ -82,6 +88,7 @@ files:
 - lib/currency-locales/locales/es-MX.yml
 - lib/currency-locales/locales/eu.yml
 - lib/currency-locales/locales/gsw-CH.yml
+- lib/currency-locales/locales/hr.yml
 - lib/currency-locales/locales/hu.yml
 - lib/currency-locales/locales/il.yml
 - lib/currency-locales/locales/ja.yml
@@ -89,6 +96,7 @@ files:
 - lib/currency-locales/locales/nb.yml
 - lib/currency-locales/locales/pl.yml
 - lib/currency-locales/locales/pt-BR.yml
+- lib/currency-locales/locales/ro.yml
 - lib/currency-locales/locales/sv-SE.yml
 - lib/currency-locales/locales/th.yml
 - lib/currency-locales/locales/tr.yml