bigbluebutton_rails 1.2.0 → 1.3.0.beta1

data/spec/models/bigbluebutton_server_spec.rb

@@ -6,7 +6,9 @@ describe BigbluebuttonServer do
     BigbluebuttonServer.new.should be_a_kind_of(ActiveRecord::Base)
   end
 
-  it { should have_many(:rooms) }
+  it { should have_many(:rooms).dependent(:nullify) }
+
+  it { should have_many(:recordings).dependent(:nullify) }
 
   it { should validate_presence_of(:name) }
   it { should validate_presence_of(:url) }
@@ -14,37 +16,34 @@ describe BigbluebuttonServer do
   it { should validate_presence_of(:version) }
   it { should validate_presence_of(:param) }
 
-  it { should allow_mass_assignment_of(:name) }
-  it { should allow_mass_assignment_of(:url) }
-  it { should allow_mass_assignment_of(:salt) }
-  it { should allow_mass_assignment_of(:version) }
-  it { should allow_mass_assignment_of(:param) }
+  [:name, :url, :salt, :version, :param].each do |attribute|
+    it { should allow_mass_assignment_of(attribute) }
+  end
+  it { should_not allow_mass_assignment_of(:id) }
 
   context "uniqueness of" do
-    before(:each) { Factory.create(:bigbluebutton_server) }
+    before(:each) { FactoryGirl.create(:bigbluebutton_server) }
     it { should validate_uniqueness_of(:url) }
     it { should validate_uniqueness_of(:name) }
     it { should validate_uniqueness_of(:param) }
   end
 
   it "has associated rooms" do
-    server = Factory.create(:bigbluebutton_server)
+    server = FactoryGirl.create(:bigbluebutton_server)
     server.rooms.should be_empty
 
-    Factory.create(:bigbluebutton_room, :server => server)
+    r = FactoryGirl.create(:bigbluebutton_room, :server => server)
     server = BigbluebuttonServer.find(server.id)
-    server.rooms.should_not be_empty
+    server.rooms.should == [r]
   end
 
-  it "nullifies associated rooms" do
-    server = Factory.create(:bigbluebutton_server)
-    room = Factory.create(:bigbluebutton_room, :server => server)
-    expect {
-      expect {
-        server.destroy
-      }.to change{ BigbluebuttonServer.count }.by(-1)
-    }.to change{ BigbluebuttonRoom.count }.by(0)
-    BigbluebuttonRoom.find(room.id).server_id.should == nil
+  it "has associated recordings" do
+    server = FactoryGirl.create(:bigbluebutton_server)
+    server.rooms.should be_empty
+
+    r = FactoryGirl.create(:bigbluebutton_recording, :server => server)
+    server = BigbluebuttonServer.find(server.id)
+    server.recordings.should == [r]
   end
 
   it { should ensure_length_of(:name).is_at_least(1).is_at_most(500) }
@@ -55,7 +54,7 @@ describe BigbluebuttonServer do
   context ".to_param" do
     it { should respond_to(:to_param) }
     it {
-      s = Factory.create(:bigbluebutton_server)
+      s = FactoryGirl.create(:bigbluebutton_server)
       s.to_param.should be(s.param)
     }
   end
@@ -99,17 +98,17 @@ describe BigbluebuttonServer do
       @server.param.should == @server.name.downcase.parameterize
     end
     it "nil" do
-      @server = Factory.build(:bigbluebutton_server, :param => nil,
+      @server = FactoryGirl.build(:bigbluebutton_server, :param => nil,
                               :name => "-My Name@ _Is Odd_-")
     end
     it "empty" do
-      @server = Factory.build(:bigbluebutton_server, :param => "",
+      @server = FactoryGirl.build(:bigbluebutton_server, :param => "",
                               :name => "-My Name@ _Is Odd_-")
     end
   end
 
   context "has an api object" do
-    let(:server) { server = Factory.build(:bigbluebutton_server) }
+    let(:server) { server = FactoryGirl.build(:bigbluebutton_server) }
     it { should respond_to(:api) }
     it { server.api.should_not be_nil }
     it {
@@ -144,9 +143,9 @@ describe BigbluebuttonServer do
   it { should respond_to(:meetings) }
 
   context "fetching info from bbb" do
-    let(:server) { Factory.create(:bigbluebutton_server) }
-    let(:room1) { Factory.create(:bigbluebutton_room, :server => server, :meetingid => "room1", :randomize_meetingid => true) }
-    let(:room2) { Factory.create(:bigbluebutton_room, :server => server, :meetingid => "room2", :randomize_meetingid => true) }
+    let(:server) { FactoryGirl.create(:bigbluebutton_server) }
+    let(:room1) { FactoryGirl.create(:bigbluebutton_room, :server => server, :meetingid => "room1") }
+    let(:room2) { FactoryGirl.create(:bigbluebutton_room, :server => server, :meetingid => "room2") }
 
     # the hashes should be exactly as returned by bigbluebutton-api-ruby to be sure we are testing it right
     let(:meetings) {
@@ -186,8 +185,89 @@ describe BigbluebuttonServer do
     it { server.meetings[2].running.should == true }
     it { server.meetings[2].new_record?.should be_true }
     it { server.meetings[2].external.should be_true }
-    it { server.meetings[2].randomize_meetingid.should be_false }
     it { server.meetings[2].private.should be_true  }
   end
 
+  describe "#send_publish_recordings" do
+    let(:server) { FactoryGirl.create(:bigbluebutton_server) }
+
+    it { should respond_to(:send_publish_recordings) }
+
+    context "sends publish_recordings" do
+      let(:recording1) { FactoryGirl.create(:bigbluebutton_recording, :published => false) }
+      let(:recording2) { FactoryGirl.create(:bigbluebutton_recording, :published => false) }
+      let(:ids) { "#{recording1.recordid},#{recording2.recordid}" }
+      let(:publish) { true }
+      before do
+        @api_mock = mock(BigBlueButton::BigBlueButtonApi)
+        server.stub(:api).and_return(@api_mock)
+        @api_mock.should_receive(:publish_recordings).with(ids, publish)
+      end
+      before(:each) { server.send_publish_recordings(ids, publish) }
+      it { BigbluebuttonRecording.find(recording1.id).published.should == true }
+      it { BigbluebuttonRecording.find(recording2.id).published.should == true }
+    end
+  end
+
+  describe "#send_delete_recordings" do
+    let(:server) { FactoryGirl.create(:bigbluebutton_server) }
+
+    it { should respond_to(:send_delete_recordings) }
+
+    context "sends delete_recordings" do
+      let(:ids) { "id1,id2,id3" }
+      before do
+        @api_mock = mock(BigBlueButton::BigBlueButtonApi)
+        server.stub(:api).and_return(@api_mock)
+        @api_mock.should_receive(:delete_recordings).with(ids)
+      end
+      it { server.send_delete_recordings(ids) }
+    end
+  end
+
+  describe "#fetch_recordings" do
+    let(:server) { FactoryGirl.create(:bigbluebutton_server) }
+    let(:params) { { :meetingID => "id1,id2,id3" } }
+    before do
+      @api_mock = mock(BigBlueButton::BigBlueButtonApi)
+      server.stub(:api).and_return(@api_mock)
+    end
+
+    it { should respond_to(:fetch_recordings) }
+
+    context "calls get_recordings" do
+      let(:response) { { :recordings => [1, 2] } }
+      before do
+        @api_mock.should_receive(:get_recordings).with(params).and_return(response)
+        BigbluebuttonRecording.should_receive(:sync).with(server, response[:recordings])
+      end
+      it { server.fetch_recordings(params) }
+    end
+
+    context "when the response is empty" do
+      let(:response) { { :recordings => [1, 2] } }
+      before do
+        @api_mock.should_receive(:get_recordings).with(params).and_return(nil)
+        BigbluebuttonRecording.should_not_receive(:sync)
+      end
+      it { server.fetch_recordings(params) }
+    end
+
+    context "when the response has no :recordings element" do
+      before do
+        @api_mock.should_receive(:get_recordings).with(params).and_return({})
+        BigbluebuttonRecording.should_not_receive(:sync)
+      end
+      it { server.fetch_recordings(params) }
+    end
+
+    context "works without parameters" do
+      before do
+        @api_mock.should_receive(:get_recordings).with({}).and_return(nil)
+        BigbluebuttonRecording.should_not_receive(:sync)
+      end
+      it { server.fetch_recordings }
+    end
+  end
+
 end

data/spec/rails_app/.gitignore

@@ -3,3 +3,5 @@ db/migrate/*bigbluebutton_rails.rb
 db/schema.rb
 tmp/
 logs/
+.sass-cache/
+config/schedule.rb

data/spec/rails_app/app/assets/javascripts/application.js

@@ -0,0 +1,2 @@
+//= require jquery
+//= require jquery_ujs

data/spec/rails_app/app/controllers/application_controller.rb

@@ -10,8 +10,10 @@ end
 
 class User
   attr_accessor :name
+  attr_accessor :id
 
   def initialize
+    self.id = 0
     self.name = "Chuck"
   end
 end

data/spec/rails_app/app/controllers/custom_recordings_controller.rb

@@ -0,0 +1,8 @@
+class CustomRecordingsController < ApplicationController
+  def index
+  end
+
+  def show
+  end
+
+end

data/spec/rails_app/app/controllers/frontpage_controller.rb

@@ -0,0 +1,7 @@
+class FrontpageController < ApplicationController
+  def show
+    @servers = BigbluebuttonServer.all
+    @rooms = BigbluebuttonRoom.all
+    @recordings = BigbluebuttonRecording.all
+  end
+end

data/spec/rails_app/app/views/frontpage/show.html.erb

@@ -0,0 +1,5 @@
+<h1>Test application:</h1>
+
+<%= link_to('View server list', bigbluebutton_servers_path) %> (<%= @servers.count %> servers)<br/>
+<%= link_to('View room list', bigbluebutton_rooms_path) %> (<%= @rooms.count %> rooms)<br/>
+<%= link_to('View recording list', bigbluebutton_recordings_path) %> (<%= @recordings.count %> recordings)<br/>

data/spec/rails_app/app/views/layouts/application.html.erb

@@ -2,12 +2,15 @@
 <html>
 <head>
   <title>RailsApp</title>
-  <%= stylesheet_link_tag :all %>
-  <%= javascript_include_tag 'application', 'jquery.min' %>
+  <%= stylesheet_link_tag "/stylesheets/scaffold" %>
+  <%= stylesheet_link_tag "bigbluebutton_rails" %>
+  <%= javascript_include_tag "application" %>
   <%= csrf_meta_tag %>
 </head>
 <body>
 
+<%= bbb_rails_error_explanation %>
+
 <%= yield %>
 
 </body>

data/spec/rails_app/config/application.rb

@@ -9,6 +9,13 @@ require "action_mailer/railtie"
 Bundler.require
 require 'bigbluebutton_rails'
 
+if defined?(Bundler)
+  # If you precompile assets before deploying to production, use this line
+  Bundler.require(*Rails.groups(:assets => %w(development test)))
+  # If you want your assets lazily compiled in production, use this line
+  # Bundler.require(:default, :assets, Rails.env)
+end
+
 module RailsApp
   class Application < Rails::Application
     # Settings in config/environments/* take precedence over those specified here.
@@ -41,5 +48,11 @@ module RailsApp
 
     # Configure sensitive parameters which will be filtered from the log file.
     config.filter_parameters += [:password]
+
+    # Enable the asset pipeline
+    config.assets.enabled = true
+
+    # Version of your assets, change this if you want to expire all your assets
+    config.assets.version = '1.0'
   end
 end

data/spec/rails_app/config/environments/development.rb

@@ -11,7 +11,6 @@ RailsApp::Application.configure do
 
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true
-  config.action_view.debug_rjs             = true
   config.action_controller.perform_caching = false
 
   # Don't care if the mailer can't send
@@ -22,5 +21,11 @@ RailsApp::Application.configure do
 
   # Only use best-standards-support built into browsers
   config.action_dispatch.best_standards_support = :builtin
-end
 
+  # Raise exception on mass assignment protection for Active Record models
+  config.active_record.mass_assignment_sanitizer = :strict
+
+  # Log the query plan for queries taking more than this (works
+  # with SQLite, MySQL, and PostgreSQL)
+  config.active_record.auto_explain_threshold_in_seconds = 0.5
+end

data/spec/rails_app/config/environments/production.rb

@@ -46,4 +46,13 @@ RailsApp::Application.configure do
 
   # Send deprecation notices to registered listeners
   config.active_support.deprecation = :notify
+
+  # Compress JavaScript and CSS
+  config.assets.compress = true
+
+  # Don't fallback to assets pipeline
+  config.assets.compile = false
+
+  # Generate digests for assets URLs
+  config.assets.digest = true
 end

data/spec/rails_app/config/environments/test.rb

@@ -32,4 +32,14 @@ RailsApp::Application.configure do
 
   # Print deprecation notices to the stderr
   config.active_support.deprecation = :stderr
+
+  # Allow pass debug_assets=true as a query parameter to load pages with unpackaged assets
+  config.assets.allow_debugging = true
+
+  # Configure static asset server for tests with Cache-Control for performance
+  config.serve_static_assets = true
+  config.static_cache_control = "public, max-age=3600"
+
+  # Allow pass debug_assets=true as a query parameter to load pages with unpackaged assets
+  config.assets.allow_debugging = true
 end

data/spec/rails_app/config/routes.rb

@@ -11,7 +11,25 @@ RailsApp::Application.routes.draw do
     end
   end
 
-  # note: controllers modified here will be used in the routes added after this (if any)
-  bigbluebutton_routes :default, :scope => "custom", :controllers => { :servers => 'custom_servers', :rooms => 'custom_rooms' }
+  scope "only-servers" do
+    bigbluebutton_routes :default, :only => "servers"
+  end
+
+  scope "only-rooms" do
+    bigbluebutton_routes :default, :only => "rooms"
+  end
+
+  scope "only-recordings" do
+    bigbluebutton_routes :default, :only => "recordings"
+  end
+
+  bigbluebutton_routes :default,
+    :scope => "custom",
+    :controllers => { :servers => "custom_servers",
+                      :rooms => "custom_rooms",
+                      :recordings => "custom_recordings" },
+    :as => "custom_name"
+
+  root :to => "frontpage#show"
 
 end

data/spec/rails_app/features/edit_rooms.feature

@@ -15,7 +15,7 @@ Feature: Edit webconference rooms
       And a room in this server
     When he goes to the edit room page
       And change the room name to "Anything different"
-      And click in the button to save the room
+      And clicks in the button to save the room
     Then he should be at the show room URL
       And the room name should be "Anything different"
 
@@ -25,9 +25,8 @@ Feature: Edit webconference rooms
       And a room in this server
     When he goes to the edit room page
       And change the room name to ""
-      And click in the button to save the room
+      And clicks in the button to save the room
     Then he should be at the update room URL
       And see the edit room page
       And see 2 errors in the field "bigbluebutton_room[name]"
       And the room name should NOT be "Anything different"
-

data/spec/rails_app/features/edit_servers.feature

@@ -13,7 +13,7 @@ Feature: Edit webconference servers
       And a real server
     When he goes to the edit server page
       And change the server URL to "http://test.com/bigbluebutton/api"
-      And click in the button to save the server
+      And clicks in the button to save the server
     Then he should be at the show server URL
       And the server URL should be "http://test.com/bigbluebutton/api"
 
@@ -22,9 +22,8 @@ Feature: Edit webconference servers
       And a real server
     When he goes to the edit server page
       And change the server URL to "http://test.com/"
-      And click in the button to save the server
+      And clicks in the button to save the server
     Then he should be at the update server URL
       And see the edit server page
       And see 1 errors in the field "bigbluebutton_server[url]"
       And the server URL should NOT be "http://test.com/"
-

data/spec/rails_app/features/step_definitions/activity_monitor_servers_step.rb

@@ -2,7 +2,7 @@ When /^(\d+) meetings running in this server$/ do |count|
   msalt = FeaturesConfig.server.has_key?('mobile_salt') ? FeaturesConfig.server['mobile_salt'] : ""
   @rooms = []
   count.to_i.times do |i|
-    room = Factory.create(:bigbluebutton_room, :server => @server)
+    room = FactoryGirl.create(:bigbluebutton_room, :server => @server)
     room.send_create
     BigBlueButtonBot.new(@server.api, room.meetingid, msalt, 1,
                          FeaturesConfig.root['timeout_bot_start'])
@@ -14,7 +14,7 @@ When /^(\d+) meetings recently ended in this server$/ do |count|
   msalt = FeaturesConfig.server.has_key?('mobile_salt') ? FeaturesConfig.server['mobile_salt'] : ""
   @ended_rooms = []
   count.to_i.times do |i|
-    room = Factory.create(:bigbluebutton_room, :server => @server)
+    room = FactoryGirl.create(:bigbluebutton_room, :server => @server)
     room.send_create
     BigBlueButtonBot.new(@server.api, room.meetingid, msalt, 1,
                          FeaturesConfig.root['timeout_bot_start'])

data/spec/rails_app/features/step_definitions/common_steps.rb

@@ -1,20 +1,20 @@
 When /^a real server$/i do
-  @server = Factory.create(:bigbluebutton_server_integration)
+  @server = FactoryGirl.create(:bigbluebutton_server_integration)
 end
 
 When /^(\d+) server(s)?$/i do |count, _|
   # Note: these servers are not real, it will NOT be possible to make api requests
   #       for a real server use :bigbluebutton_server_integration
   count.to_i.times do
-    Factory.create(:bigbluebutton_server)
+    FactoryGirl.create(:bigbluebutton_server)
   end
 end
 
 When /^a(n external)? room in this server$/i do |external|
   if external.nil?
-    @room = Factory.create(:bigbluebutton_room, :server => @server)
+    @room = FactoryGirl.create(:bigbluebutton_room, :server => @server)
   else
-    @room = Factory.build(:bigbluebutton_room, :server => @server, :external => true)
+    @room = FactoryGirl.build(:bigbluebutton_room, :server => @server, :external => true)
   end
   @room.send_create
 end
@@ -54,7 +54,7 @@ When /see the (.+) page$/i do |page_name|
 end
 
 When /a user named "(.+)"/i do |username|
-  @user = Factory.build(:user, :name => username)
+  @user = FactoryGirl.build(:user, :name => username)
   ApplicationController.set_user(@user) # This is now the logged user
 end