bigbluebutton-api-ruby 1.8.0 → 1.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25726eaedf0a5b63156a7786a793f27a419e349a177419fdaecb0e0aac0295d6
-  data.tar.gz: 6e8ec707b2f53e06ba21163d2f5d34766436e49f852991434d3aa787a4108deb
+  metadata.gz: 895a139be87984c857d275c4d7df9268b06684da8afa4e645cbbdb89d52506f3
+  data.tar.gz: bc4c39bc4f9b9dd2e9985e2f70063df489ef0e43b46a43399550f0aa5a75cecc
 SHA512:
-  metadata.gz: 810382ae7b2f54be6ac766e10db46a61f76a4120c84bb1a99600012266db562da53149d7ee0bde1c7a2b3939542398556a7faa85dd24153c669f04875ac90213
-  data.tar.gz: 229132ef71db18f0a972daefb0b5b0ad49c53c63655877923323a163f99d15b383d4f0ac7344ebba61a6b5961f3a08abc2dc50a9ef217d4eccf0fcbfc2fdc527
+  metadata.gz: 30fc3a5fb527ffdfd58c9690075665e8a54b9385a184214b6d50da43ed3b5963b203b147426b02bcbe7644dfca65ca73ad30d831d7c2c8ad766d7aaa930c1fa6
+  data.tar.gz: 940781ee78ee9c962be935eff1c8d66b971c5658467dd92c827291b581a38a17badcfe4381a8e58bd1157176191a54f59d895fe197f1e6ca5399d9635d354067

data/.github/workflows/publish-gem-on-tag-push.yml

@@ -0,0 +1,22 @@
+name: Publish gem on tag push
+on:
+  push:
+    tags:
+      - 'v*' 
+      - '!v**-mconf*'
+# Tags that will trigger: v1.9.0; v1.9.0-beta1
+# Tags excluded (with the '!'): v1.9.0-mconf; v1.9.0-mconf-beta1
+
+jobs:
+  publish-gem:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Publish
+        uses: dawidd6/action-publish-gem@v1.2.0
+        with:
+          # Optional, will publish to RubyGems if specified
+          api_key: ${{secrets.RUBYGEMS_API_KEY}}
+          # Optional, will publish to GitHub Packages if specified
+          github_token: ${{secrets.GITHUB_TOKEN}}

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Change Log
 
+## [1.9.1] - 2023-03-31
+* [#60] Prevent problems with double slashes on API calls [thanks to [@farhatahmad](https://github.com/farhatahmad)]
+
+[#60]: https://github.com/mconf/bigbluebutton-api-ruby/pull/60
+[1.9.1]: https://github.com/mconf/bigbluebutton-api-ruby/compare/v1.9.0...v1.9.1
+
+## [1.9.0] - 2022-05-03
+* [#56] Add support for checksum using SHA256
+
+[#56]: https://github.com/mconf/bigbluebutton-api-ruby/pull/56
+[1.9.0]: https://github.com/mconf/bigbluebutton-api-ruby/compare/v1.8.0...v1.9.0
+
 ## [1.8.0] - 2021-12-06
 * [#43] Add keys to every `BigBlueButtonException`, to better identify them.
 * [#42] Change `BigBlueButtonException` to inherit from `StandardError` instead of `Exception`.

data/Gemfile.lock

@@ -7,7 +7,7 @@ GIT
 PATH
   remote: .
   specs:
-    bigbluebutton-api-ruby (1.8.0)
+    bigbluebutton-api-ruby (1.9.1)
       childprocess (>= 1.0.1)
       ffi (>= 1.9.24)
       json (>= 1.8.6)

data/bigbluebutton-api-ruby.gemspec

@@ -2,7 +2,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name             = "bigbluebutton-api-ruby"
-  s.version          = "1.8.0"
+  s.version          = "1.9.1"
   s.licenses         = ["MIT"]
   s.extra_rdoc_files = ["README.md", "LICENSE", "LICENSE_003", "CHANGELOG.md"]
   s.summary          = "BigBlueButton integration for ruby"

data/lib/bigbluebutton_api.rb

@@ -2,6 +2,7 @@ require 'net/http'
 require 'cgi'
 require 'rexml/document'
 require 'digest/sha1'
+require 'digest/sha2'
 require 'rubygems'
 require 'bigbluebutton_hash_to_xml'
 require 'bigbluebutton_exception'
@@ -68,13 +69,17 @@ module BigBlueButton
     # url::       URL to a BigBlueButton server (e.g. http://demo.bigbluebutton.org/bigbluebutton/api)
     # secret::    Shared secret for this server
     # version::   API version e.g. 0.81
-    def initialize(url, secret, version=nil, logger=nil)
+    # logger::    Logger object to log actions (so apps can use their own loggers)
+    # sha256::    Flag to use sha256 when hashing url contents for checksum
+    def initialize(url, secret, version=nil, logger=nil, sha256=false)
       @supported_versions = ['0.8', '0.81', '0.9', '1.0']
-      @url = url
+      @url = url.chomp('/')
       @secret = secret
       @timeout = 10         # default timeout for api requests
       @request_headers = {} # http headers sent in all requests
       @logger = logger
+      @sha256 = sha256
+      # If logger is not informed, it defaults to STDOUT with INFO level
       if logger.nil?
         @logger = Logger.new(STDOUT)
         @logger.level = Logger::INFO
@@ -680,7 +685,7 @@ module BigBlueButton
       # checksum calc
       checksum_param = params_string + @secret
       checksum_param = method.to_s + checksum_param
-      checksum = Digest::SHA1.hexdigest(checksum_param)
+      checksum = @sha256 ? Digest::SHA256.hexdigest(checksum_param) : Digest::SHA1.hexdigest(checksum_param)
 
       if method == :setConfigXML
         params_string = "checksum=#{checksum}&#{params_string}"

data/spec/bigbluebutton_api_spec.rb

@@ -474,17 +474,34 @@ describe BigBlueButton::BigBlueButtonApi do
         end
 
         context "includes the checksum" do
-          let(:params) { { :param1 => "value1", :param2 => "value2" } }
-          let(:checksum) {
-            # the hash can be sorted differently depending on the ruby version
-            if params.map{ |k,v| k }.join =~ /^param1/
-              "67882ae54f49600f56f358c10d24697ef7d8c6b2"
-            else
-              "85a54e28e4ec18bfdcb214a73f74d35b09a84176"
-            end
-          }
-          subject { api.get_url(:join, params)[0] }
-          it { subject.should match(/checksum=#{checksum}$/) }
+          context "when @sha256 is false or nil" do
+            let(:params) { { param1: "value1", param2: "value2" } }
+            let(:checksum) {
+              # the hash can be sorted differently depending on the ruby version
+              if params.map{ |k, v| k }.join =~ /^param1/
+                "67882ae54f49600f56f358c10d24697ef7d8c6b2"
+              else
+                "85a54e28e4ec18bfdcb214a73f74d35b09a84176"
+              end
+            }
+            subject { api.get_url(:join, params)[0] }
+            it('uses SHA1') { subject.should match(/checksum=#{checksum}$/) }
+          end
+
+          context "when @sha256 flag is true" do
+            let(:api) { BigBlueButton::BigBlueButtonApi.new(url, secret, version, logger, true) }
+            let(:params) { { param1: "value1", param2: "value2" } }
+            let(:checksum) {
+              # the hash can be sorted differently depending on the ruby version
+              if params.map{ |k,v| k }.join =~ /^param1/
+                "0e7b1611809fad890a114dddae1a37fecf14c28971afc10ee3eac432da5b8b41"
+              else
+                "21bf2d24c27251c4b2b2f0d5dd4b966a2f16fbfc7882e102b44c6d67f728f0c8"
+              end
+            }
+            subject { api.get_url(:join, params)[0] }
+            it('uses SHA256') { subject.should match(/checksum=#{checksum}$/) }
+          end
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bigbluebutton-api-ruby
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.9.1
 platform: ruby
 authors:
 - Mconf
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-12-06 00:00:00.000000000 Z
+date: 2023-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -122,6 +122,7 @@ extra_rdoc_files:
 - LICENSE_003
 - CHANGELOG.md
 files:
+- ".github/workflows/publish-gem-on-tag-push.yml"
 - ".gitignore"
 - ".rspec"
 - ".ruby-version"
@@ -199,7 +200,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.3.5
 signing_key: 
 specification_version: 4
 summary: BigBlueButton integration for ruby