big_money 1.1.0 → 1.2.0

data/VERSION.yml

@@ -1,5 +1,5 @@
 --- 
 :major: 1
-:minor: 1
+:minor: 2
 :patch: 0
 :build: 

data/big_money.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{big_money}
-  s.version = "1.1.0"
+  s.version = "1.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Shane Hanna", "Marshall Roch"]
-  s.date = %q{2010-01-22}
+  s.date = %q{2010-05-27}
   s.email = ["shane.hanna@gmail.com", "mroch@cmu.edu"]
   s.extra_rdoc_files = [
     "LICENSE",
@@ -42,14 +42,14 @@ Gem::Specification.new do |s|
   s.homepage = %q{http://github.com/shanna/big_money}
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.5}
+  s.rubygems_version = %q{1.3.6}
   s.summary = %q{BigDecimal backed amount of money in a particular currency.}
   s.test_files = [
     "test/test_exchange.rb",
-     "test/helper.rb",
      "test/test_currency.rb",
      "test/test_big_money.rb",
-     "test/test_parser.rb"
+     "test/test_parser.rb",
+     "test/helper.rb"
   ]
 
   if s.respond_to? :specification_version then

data/lib/big_money/exchange.rb

@@ -36,13 +36,31 @@ class BigMoney
 
   # Find the exchange rate between two currencies.
   #
-  # Be aware no caching is done at all at the moment.
-  #--
-  # TODO: Moneta would be ideal for this.
+  # ==== Notes
+  #
+  # No caching is done by default. You can set one though using anything that behaves like a Hash for example the
+  # moneta library.
+  #
+  # ==== Example
+  #
+  #   require 'bigmoney/exchanage'
+  #   require 'moneta/memcache'
+  #
+  #   BigMoney::Exchange.cache = Moneta::Memcache.new('localhost', default_ttl: 3_600)
   class Exchange
     class ConversionError < StandardError; end
 
     class << self
+      def cache=(store)
+        raise "Cache object #{store.class} does not respond to [] and []=." \
+          unless store.respond_to?(:'[]') and store.respond_to?(:'[]=')
+        @@cache = store
+      end
+
+      def cache
+        @@cache ||= nil
+      end
+
       @@services = []
       def inherited(service) #:nodoc:
         @@services << service
@@ -62,12 +80,20 @@ class BigMoney
         exchange << (Currency.find(to) or raise ArgumentError.new("Unknown +to+ currency #{to.inspect}."))
         return BigDecimal.new(1.to_s) if exchange.uniq.size == 1 || exchange.find{|c| c == Currency::XXX}
 
+        id = exchange.map{|c| c.code}.join(':')
+        if cache && rate = cache[id]
+          return rate
+        end
+
         service = @@services.reverse.find do |service|
           !!exchange.reject{|c| service.currencies.include?(c)}
         end
 
         service or raise ConversionError # TODO: Message?
-        BigDecimal.new(service.read_rate(*exchange).to_s)
+        rate = BigDecimal.new(service.read_rate(*exchange).to_s)
+
+        cache[id] = rate if cache
+        rate
       end
 
       protected

data/test/test_exchange.rb

@@ -33,5 +33,11 @@ class TestExchange < Test::Unit::TestCase
       assert_equal BigDecimal.new('1'), BigMoney::Exchange.rate(:usd, :xxx)
       assert_equal BigDecimal.new('1'), BigMoney::Exchange.rate(:xxx, :usd)
     end
+
+    should 'be cacheable' do
+      BigMoney::Exchange.cache = {}
+      BigMoney::Exchange.rate(:usd, :aud)
+      assert_equal BigDecimal.new('2'), BigMoney::Exchange.cache.values.first
+    end
   end
 end

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: big_money
 version: !ruby/object:Gem::Version 
-  version: 1.1.0
+  prerelease: false
+  segments: 
+  - 1
+  - 2
+  - 0
+  version: 1.2.0
 platform: ruby
 authors: 
 - Shane Hanna
@@ -10,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-22 00:00:00 +11:00
+date: 2010-05-27 00:00:00 +10:00
 default_executable: 
 dependencies: []
 
@@ -61,24 +66,26 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: BigDecimal backed amount of money in a particular currency.
 test_files: 
 - test/test_exchange.rb
-- test/helper.rb
 - test/test_currency.rb
 - test/test_big_money.rb
 - test/test_parser.rb
+- test/helper.rb