big_brother 0.6.8 → 0.8.7

data/spec/big_brother/configuration_spec.rb

@@ -2,7 +2,44 @@ require 'spec_helper'
 
 describe BigBrother::Configuration do
   describe 'self.from_file' do
-    it 'maintain a collection of clusters' do
+    context 'loading invalid config' do
+      before do
+        @config_file = Tempfile.new('config.yml')
+        File.open(@config_file, 'w') do |f|
+          f.puts(<<-EOF)
+---
+clusters:
+  - cluster_name: 1
+    check_interval: ""
+    scheduler: wrr
+    fwmark: 1
+    nodes:
+      - address: 127.0.0
+        port: 9001
+        path: /test/valid
+          EOF
+        end
+      end
+
+      it 'fails' do
+        BigBrother.configure(@config_file.path)
+
+        BigBrother.clusters.size.should be_zero
+      end
+
+      it 'logs errors' do
+        errors = ["- [/clusters/0/cluster_name] '1': not a string.", "- [/clusters/0/check_interval] '': not a integer.", "- [/clusters/0/nodes/0/address] '127.0.0': not matched to pattern /^\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}$/."]
+
+        BigBrother.logger = NullLogger.new([])
+        BigBrother::Configuration.from_file(@config_file.path)
+
+        BigBrother.logger.messages.should == errors
+
+        BigBrother.logger = NullLogger.new
+      end
+    end
+
+    it 'maintains a collection of clusters' do
       clusters = BigBrother::Configuration.from_file(TEST_CONFIG)
 
       clusters['test1'].check_interval.should == 1
@@ -17,11 +54,16 @@ describe BigBrother::Configuration do
       clusters['test2'].check_interval.should == 2
       clusters['test2'].scheduler.should == 'wrr'
       clusters['test2'].fwmark.should == 2
-      clusters['test2'].ramp_up_time.should == 60
 
       clusters['test3'].check_interval.should == 1
       clusters['test3'].scheduler.should == 'wrr'
       clusters['test3'].fwmark.should == 3
+
+      clusters['test4'].backend_mode.should == 'active_active'
+      clusters['test4'].offset.should == 10000
+      clusters['test4'].max_down_ticks.should == 100
+      clusters['test4'].ramp_up_time.should == 60
+      clusters['test4'].non_egress_locations.should == ['test']
     end
 
     it 'populates a clusters nodes' do
@@ -29,13 +71,15 @@ describe BigBrother::Configuration do
 
       clusters['test1'].nodes.length.should == 2
 
-      clusters['test1'].nodes[0].address == '127.0.0.1'
-      clusters['test1'].nodes[0].port == '9001'
-      clusters['test1'].nodes[0].path == '/test/valid'
+      clusters['test1'].nodes[0].address.should == '127.0.0.1'
+      clusters['test1'].nodes[0].port.should == 9001
+      clusters['test1'].nodes[0].path.should == '/test/valid'
 
-      clusters['test1'].nodes[1].address == '127.0.0.1'
-      clusters['test1'].nodes[1].port == '9002'
-      clusters['test1'].nodes[1].path == '/test/valid'
+      clusters['test1'].nodes[1].address.should == '127.0.0.1'
+      clusters['test1'].nodes[1].port.should == 9002
+      clusters['test1'].nodes[1].path.should == '/test/valid'
+
+      clusters['test4'].interpol_node.should be_interpol
     end
 
     it 'allows a default cluster configuration under the global config key' do
@@ -45,28 +89,29 @@ describe BigBrother::Configuration do
           ---
           _big_brother:
             check_interval: 2
-            scheduler: wrr
             nagios:
               server: 127.0.0.2
               host: ha-services
-          test_without_overrides:
-            fwmark: 2
-            nagios:
-              check: test_check
-            nodes:
-            - address: 127.0.0.1
-              port: 9001
-              path: /test/invalid
-          test_with_overrides:
-            fwmark: 3
-            scheduler: wlc
-            nagios:
-              host: override-host
-              check: test_overrides_check
-            nodes:
-            - address: 127.0.0.1
-              port: 9001
-              path: /test/invalid
+          clusters:
+            - cluster_name: test_without_overrides
+              scheduler: wrr
+              fwmark: 2
+              nagios:
+                check: test_check
+              nodes:
+                - address: 127.0.0.1
+                  port: 9001
+                  path: /test/invalid
+            - cluster_name: test_with_overrides
+              fwmark: 3
+              scheduler: wlc
+              nagios:
+                host: override-host
+                check: test_overrides_check
+              nodes:
+                - address: 127.0.0.1
+                  port: 9001
+                  path: /test/invalid
         EOF
       end
 

data/spec/big_brother/health_fetcher_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
 describe BigBrother::HealthFetcher do
-  describe "#current_health" do
-    run_in_reactor
+  run_in_reactor
 
+  describe "#current_health" do
     it "returns its health" do
       StubServer.new(<<-HTTP)
 HTTP/1.0 200 OK
@@ -48,4 +48,49 @@ HTTP
     end
   end
 
+  describe "#interpol_status" do
+    it "returns nodes as a list" do
+      StubServer.new(<<-HTTP)
+HTTP/1.0 200 OK
+Connection: close
+
+[{"aggregated_health":0,"count":1,"lb_ip_address":"load1.stq","lb_url":"http://load1.stq:80/lvs.json","health":0}]
+HTTP
+      BigBrother::HealthFetcher.interpol_status(Factory.node(:address => "127.0.0.1", :port => 8081, :interpol => true, :path => '/fwmark'), 'test').should == [
+        {"aggregated_health" => 0,"count" => 1,"lb_ip_address" => "load1.stq","lb_url" => "http://load1.stq:80/lvs.json","health" => 0}
+      ]
+    end
+
+    it "returns an empty list when HTTP status code is not 200" do
+      StubServer.new(<<-HTTP)
+HTTP/1.0 503 OK
+Connection: close
+
+HTTP
+      BigBrother::HealthFetcher.interpol_status(Factory.node(:address => "127.0.0.1", :port => 8081, :interpol => true, :path => '/fwmark'), 'test').should == []
+    end
+
+    it "returns an empty list for an unknown service" do
+      StubServer.new(<<-HTTP)
+HTTP/1.0 503 Service Unavailable
+Connection: close
+HTTP
+      BigBrother::HealthFetcher.interpol_status(Factory.node(:address => "127.0.0.1", :port => 8081, :interpol => true, :path => '/fwmark'), 'test').should == []
+    end
+
+    it "returns 0 for an unknown DNS entry" do
+      BigBrother::HealthFetcher.interpol_status(Factory.node(:address => "junk.local", :port => 8081, :interpol => true, :path => '/fwmark'), 'test').should == []
+    end
+
+    it "returns empty list for an unparseable response body" do
+      StubServer.new(<<-HTTP)
+HTTP/1.0 200 OK
+Connection: close
+
+This part is for people.
+HTTP
+      BigBrother::HealthFetcher.interpol_status(Factory.node(:address => "127.0.0.1", :port => 8081, :interpol => true, :path => '/fwmark'), 'test').should == []
+    end
+  end
+
 end

data/spec/big_brother/node_spec.rb

@@ -3,108 +3,49 @@ require 'spec_helper'
 describe BigBrother::Node do
 
   describe "#monitor" do
-    it "updates the weight for the node" do
-      BigBrother::HealthFetcher.stub(:current_health).and_return(56)
-      node = Factory.node(:address => '127.0.0.1')
-      cluster = Factory.cluster(:fwmark => 100, :nodes => [node])
-      cluster.start_monitoring!
-      @stub_executor.commands.clear
-
-      node.monitor(cluster)
-
-      @stub_executor.commands.should include("ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.1 --ipip --weight 56")
-    end
-
     it "a node's health should increase linearly over the specified ramp up time" do
       BigBrother::HealthFetcher.stub(:current_health).and_return(100)
       Time.stub(:now).and_return(1345043600)
 
       node = Factory.node(:address => '127.0.0.1')
       cluster = Factory.cluster(:ramp_up_time => 60, :fwmark => 100, :nodes => [node])
-      cluster.start_monitoring!
 
       Time.stub(:now).and_return(1345043630)
-      node.monitor(cluster)
-      @stub_executor.commands.last.should == "ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.1 --ipip --weight 50"
+      node.monitor(cluster).should == 50
 
       Time.stub(:now).and_return(1345043645)
-      node.monitor(cluster)
-      @stub_executor.commands.last.should == "ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.1 --ipip --weight 75"
+      node.monitor(cluster).should == 75
 
       Time.stub(:now).and_return(1345043720)
-      node.monitor(cluster)
-      @stub_executor.commands.last.should == "ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.1 --ipip --weight 100"
+      node.monitor(cluster).should == 100
     end
 
     it "sets the weight to 100 for each node if an up file exists" do
       BigBrother::HealthFetcher.stub(:current_health).and_return(56)
       node = Factory.node(:address => '127.0.0.1', :weight => 10)
       cluster = Factory.cluster(:fwmark => 100, :nodes => [node])
-      cluster.start_monitoring!
-      @stub_executor.commands.clear
 
       BigBrother::StatusFile.new('up', 'test').create('Up for testing')
 
-      node.monitor(cluster)
-
-      @stub_executor.commands.should include("ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.1 --ipip --weight 100")
+      node.monitor(cluster).should == 100
     end
 
     it "sets the weight to 0 for each node if a down file exists" do
       BigBrother::HealthFetcher.stub(:current_health).and_return(56)
       node = Factory.node(:address => '127.0.0.1')
       cluster = Factory.cluster(:fwmark => 100, :nodes => [node])
-      cluster.start_monitoring!
-      @stub_executor.commands.clear
 
       BigBrother::StatusFile.new('down', 'test').create('Down for testing')
 
-      node.monitor(cluster)
-
-      @stub_executor.commands.should include("ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.1 --ipip --weight 0")
-    end
-
-    it "does not run multiple ipvsadm commands if the health does not change" do
-      BigBrother::HealthFetcher.stub(:current_health).and_return(56)
-      node = Factory.node(:address => '127.0.0.1')
-      cluster = Factory.cluster(:fwmark => 100, :nodes => [node])
-      cluster.start_monitoring!
-      @stub_executor.commands.clear
-
-      node.monitor(cluster)
-      node.monitor(cluster)
-
-      @stub_executor.commands.should == ["ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.1 --ipip --weight 56"]
-    end
-
-    it "will run multiple ipvsadm commands if the health does change" do
-      BigBrother::HealthFetcher.stub(:current_health).and_return(56)
-      node = Factory.node(:address => '127.0.0.1')
-      cluster = Factory.cluster(:fwmark => 100, :nodes => [node])
-      cluster.start_monitoring!
-      @stub_executor.commands.clear
-
-      node.monitor(cluster)
-      node.monitor(cluster)
-      BigBrother::HealthFetcher.stub(:current_health).and_return(41)
-      node.monitor(cluster)
-
-      @stub_executor.commands.should == [
-        "ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.1 --ipip --weight 56",
-        "ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.1 --ipip --weight 41"
-      ]
+      node.monitor(cluster).should == 0
     end
 
-    it "does not update the weight if the cluster is no longer monitored" do
-      BigBrother::HealthFetcher.stub(:current_health).and_return(56)
-      node = Factory.node(:address => '127.0.0.1')
+    it "caps the weight of a node to the max_weight configured" do
+      BigBrother::HealthFetcher.stub(:current_health).and_return(100)
+      node = Factory.node(:address => '127.0.0.1', :max_weight => 10)
       cluster = Factory.cluster(:fwmark => 100, :nodes => [node])
-      cluster.stop_monitoring!
-
-      @stub_executor.commands.clear
-      node.monitor(cluster)
 
-      @stub_executor.commands.should == []
+      node.monitor(cluster).should == 10
     end
   end
 
@@ -122,6 +63,39 @@ describe BigBrother::Node do
     end
   end
 
+  describe "<=>" do
+    it "returns 1 when compared to a node with a nil weight" do
+      node1 = Factory.node(:address => "127.0.0.1", :port => "8000", :priority => 1, :weight => 0)
+      node2 = Factory.node(:address => "127.0.0.2", :port => "8000", :priority => 2, :weight => nil)
+      (node1 <=> node2).should == 1
+    end
+
+    it "returns 1 for comparison of an unhealthy node to an healthy one" do
+      node1 = Factory.node(:address => "127.0.0.1", :port => "8000", :priority => 1, :weight => 0)
+      node2 = Factory.node(:address => "127.0.0.2", :port => "8000", :priority => 2, :weight => 90)
+      (node1 <=> node2).should == 1
+    end
+
+    it "returns -1 for a node with lower priority" do
+      node1 = Factory.node(:address => "127.0.0.1", :port => "8000", :priority => 1)
+      node2 = Factory.node(:address => "127.0.0.2", :port => "8000", :priority => 2)
+      (node1 <=> node2).should == -1
+    end
+
+    it "returns 1 for a node with higher priority" do
+      node1 = Factory.node(:address => "127.0.0.1", :port => "8000", :priority => 1)
+      node2 = Factory.node(:address => "127.0.0.2", :port => "8000", :priority => 2)
+      (node2 <=> node1).should == 1
+    end
+
+    it "uses ip address for comparison if the priorities are the same" do
+      node1 = Factory.node(:address => "127.0.0.1", :port => "8000", :priority => 1)
+      node2 = Factory.node(:address => "127.0.0.2", :port => "8000", :priority => 1)
+      (node2 <=> node1).should == 1
+      (node1 <=> node2).should == -1
+    end
+  end
+
   describe "age" do
     it "is the time in seconds since the node started" do
       Time.stub(:now).and_return(1345043612)

data/spec/big_brother/ticker_spec.rb

@@ -23,9 +23,10 @@ describe BigBrother::Ticker do
             Factory.node(:address  => public_ip_address, :port => 8082)
           ]
         )
-        BigBrother.clusters['test'].start_monitoring!
+        BigBrother.clusters['test'].instance_variable_set(:@monitored, true)
         @stub_executor.commands.clear
 
+        BigBrother::Ticker.instance_variable_set(:@outstanding_ticks, 0)
         BigBrother::Ticker.tick
 
         @stub_executor.commands.should include("ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.1 --ipip --weight 74")
@@ -37,9 +38,10 @@ describe BigBrother::Ticker do
           :fwmark => 100,
           :nodes => [Factory.node(:address  => '127.0.0.1', :port => 8081)]
         )
-        BigBrother.clusters['test'].start_monitoring!
+        BigBrother.clusters['test'].instance_variable_set(:@monitored, true)
         @stub_executor.commands.clear
 
+        BigBrother::Ticker.instance_variable_set(:@outstanding_ticks, 0)
         BigBrother::Ticker.tick
         BigBrother::Ticker.tick
 
@@ -48,12 +50,14 @@ describe BigBrother::Ticker do
     end
 
     it "monitors clusters requiring monitoring" do
+      BigBrother::HealthFetcher.stub(:current_health)
       BigBrother.clusters['one'] = Factory.cluster
       BigBrother.clusters['two'] = Factory.cluster
       BigBrother.clusters['two'].start_monitoring!
 
       BigBrother.clusters['two'].should_receive(:monitor_nodes)
 
+      BigBrother::Ticker.instance_variable_set(:@outstanding_ticks, 0)
       BigBrother::Ticker.tick
     end
   end

data/spec/big_brother_spec.rb

@@ -1,10 +1,29 @@
 require 'spec_helper'
 
 describe BigBrother do
+  describe '.monitor_nodes' do
+    it "updates the weight for all the nodes in a cluster" do
+      BigBrother::HealthFetcher.stub(:current_health).and_return(76)
+      node1 = Factory.node(:address => '127.0.0.1', :weight => 90)
+      node2 = Factory.node(:address => '127.0.0.2', :weight => 30)
+      cluster = Factory.cluster(:fwmark => 100, :nodes => [node1, node2])
+      cluster.start_monitoring!
+      @stub_executor.commands.clear
+
+      BigBrother::HealthFetcher.stub(:current_health).and_return(56)
+      cluster.monitor_nodes
+
+      cluster.nodes.map(&:weight).uniq.should == [56]
+      @stub_executor.commands.should include("ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.1 --ipip --weight 56")
+      @stub_executor.commands.should include("ipvsadm --edit-server --fwmark-service 100 --real-server 127.0.0.2 --ipip --weight 56")
+    end
+
+  end
+
   describe '.configure' do
     it "reads the configuration file" do
       BigBrother.configure(TEST_CONFIG)
-      BigBrother.clusters.size.should == 3
+      BigBrother.clusters.size.should == 4
     end
   end
 
@@ -27,14 +46,15 @@ HTTP
       File.open(config_file, 'w') do |f|
         f.puts(<<-EOF)
 ---
-test1:
-  check_interval: 1
-  scheduler: wrr
-  fwmark: 1
-  nodes:
-  - address: 127.0.0.1
-    port: 9001
-    path: /test/valid
+clusters:
+  - cluster_name: test1
+    check_interval: 1
+    scheduler: wrr
+    fwmark: 1
+    nodes:
+      - address: 127.0.0.1
+        port: 9001
+        path: /test/valid
 EOF
       end
       BigBrother.configure(config_file)
@@ -44,17 +64,24 @@ EOF
       File.open(config_file, 'w') do |f|
         f.puts(<<-EOF)
 ---
-test1:
-  check_interval: 1
-  scheduler: wrr
-  fwmark: 1
-  nodes:
-  - address: 127.0.0.1
-    port: 9001
-    path: /test/another/path
+clusters:
+  - cluster_name: test1
+    check_interval: 1
+    scheduler: wrr
+    backend_mode: 'active_active'
+    fwmark: 1
+    nodes:
+      - address: 127.0.0.1
+        port: 9001
+        path: /test/another/path
+      - address: 127.0.0.9
+        port: 9000
+        path: /fwmark
+        interpol: true
 EOF
       end
       BigBrother.reconfigure
+      BigBrother.clusters['test1'].class.should == BigBrother::ActiveActiveCluster
       BigBrother.clusters['test1'].nodes.first.path.should == "/test/another/path"
     end
 
@@ -64,14 +91,15 @@ EOF
       File.open(config_file, 'w') do |f|
         f.puts(<<-EOF)
 ---
-test1:
-  check_interval: 1
-  scheduler: wrr
-  fwmark: 1
-  nodes:
-  - address: 127.0.0.1
-    port: 9001
-    path: /test/valid
+clusters:
+  - cluster_name: test1
+    check_interval: 1
+    scheduler: wrr
+    fwmark: 1
+    nodes:
+      - address: 127.0.0.1
+        port: 9001
+        path: /test/valid
 EOF
       end
       BigBrother.configure(config_file)
@@ -84,17 +112,18 @@ EOF
       File.open(config_file, 'w') do |f|
         f.puts(<<-EOF)
 ---
-test1:
-  check_interval: 1
-  scheduler: wrr
-  fwmark: 1
-  nodes:
-  - address: 127.0.0.1
-    port: 9001
-    path: /test/valid
-  - address: 127.0.0.2
-    port: 9001
-    path: /test/valid
+clusters:
+  - cluster_name: test1
+    check_interval: 1
+    scheduler: wrr
+    fwmark: 1
+    nodes:
+      - address: 127.0.0.1
+        port: 9001
+        path: /test/valid
+      - address: 127.0.0.2
+        port: 9001
+        path: /test/valid
 EOF
       end
       BigBrother.reconfigure
@@ -109,20 +138,20 @@ EOF
       File.open(config_file, 'w') do |f|
         f.puts(<<-EOF)
 ---
-test1:
-  check_interval: 1
-  scheduler: wrr
-  fwmark: 1
-  ramp_up_time: 0
-  nodes:
-  - address: 127.0.0.1
-    port: 9001
-    path: /test/valid
+clusters:
+  - cluster_name: test1
+    check_interval: 1
+    scheduler: wrr
+    fwmark: 1
+    ramp_up_time: 0
+    nodes:
+      - address: 127.0.0.1
+        port: 9001
+        path: /test/valid
 EOF
       end
       BigBrother.configure(config_file)
       BigBrother.clusters['test1'].start_monitoring!
-      @stub_executor.commands.clear
 
       BigBrother.start_ticker!
 
@@ -131,20 +160,21 @@ EOF
       File.open(config_file, 'w') do |f|
         f.puts(<<-EOF)
 ---
-test1:
-  check_interval: 1
-  scheduler: wrr
-  fwmark: 1
-  nodes:
-  - address: 127.0.0.1
-    port: 9001
-    path: /test/another/path
+clusters:
+  - cluster_name: test1
+    check_interval: 1
+    scheduler: wrr
+    fwmark: 1
+    nodes:
+      - address: 127.0.0.1
+        port: 9001
+        path: /test/another/path
 EOF
       end
       BigBrother.reconfigure
       BigBrother.clusters['test1'].nodes.first.path.should == "/test/another/path"
 
-      @stub_executor.commands.first.should include("--weight 50")
+      @stub_executor.commands.last.should include("--weight 50")
     end
   end
 end