bidu-house 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 61df7ae9ad7055e431d7912230db3f33cd23c672
-  data.tar.gz: 6e2d298063bbd83ffa628bf2da57bb314a468d47
+  metadata.gz: 25cc0841110cb3f8c649f8a42343f80736c1c910
+  data.tar.gz: e9ef4b32c0651fe1400d053d38ffae6a3a385b27
 SHA512:
-  metadata.gz: 8fbf8718e925ea3e3d005e5178a940c32ddcbbc76edd3900693221b6144beae7ed9b430b28321f96dcb09f74e302a415b3b77082dca36a80b631bf1c3cbe977b
-  data.tar.gz: 090601be4bbd3711920ea90fcea1853da102bd033b468ccb955ffa3ecd05aaad8d529b5aaa4f5cf11cb5eafdf42392c91d69e2d2b76a65dfcc737864d25b66a2
+  metadata.gz: 3e52af0063573133cffdb10b444a236a6081559622b4af79f0bd10227011a73ebdcf11ec6ca296504952d560afe53990428788f3cc9606c2cd2529c4f31d15bc
+  data.tar.gz: 6aa8cfde4107f3a1d4a50fc5aa937a06a672dfd8b8ef95531a5e91a4708987350728120aae37ba5733451b06fb8c7d8541eb32345c8c2468fdbd838e36c24f55

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    bidu-house (0.1.2)
+    bidu-house (0.2.0)
       activesupport
-      bidu-core_ext
+      bidu-active_ext
       concern_builder
       json_parser (~> 1.1)
 
@@ -24,10 +24,14 @@ GEM
       thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
     arel (6.0.0)
-    bidu-core_ext (1.0.0)
+    bidu-active_ext (1.0.0)
+      activesupport
+      bidu-core_ext
+    bidu-core_ext (1.2.0)
       activesupport
     builder (3.2.2)
-    concern_builder (0.0.1)
+    coderay (1.1.0)
+    concern_builder (0.0.2)
       activesupport
     diff-lcs (1.2.5)
     docile (1.1.5)
@@ -36,7 +40,14 @@ GEM
     json_parser (1.1.0)
       activesupport
       concern_builder
+    method_source (0.8.2)
     minitest (5.7.0)
+    pry (0.10.1)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
+    pry-nav (0.2.4)
+      pry (>= 0.9.10, < 0.11.0)
     rake (10.4.2)
     rspec (2.99.0)
       rspec-core (~> 2.99.0)
@@ -51,6 +62,7 @@ GEM
       json (~> 1.8)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.0)
+    slop (3.6.0)
     sqlite3 (1.3.10)
     thread_safe (0.3.5)
     tzinfo (1.2.2)
@@ -63,7 +75,11 @@ DEPENDENCIES
   activerecord
   bidu-house!
   bundler (~> 1.6)
+  pry-nav
   rake
   rspec (~> 2.14)
   simplecov
   sqlite3
+
+BUNDLED WITH
+   1.10.6

data/README.md

@@ -6,10 +6,10 @@ report and making it avaliable in a controller
 
 Getting started
 ---------------
-1. Add JsonParser to your `Gemfile` and `bundle install`:
+1. Add House to your `Gemfile` and `bundle install`:
 
     ```ruby
-    gem 'json_parser'
+    gem 'bidu-house'
     ```
 
 
@@ -51,7 +51,7 @@ with error and render the report
  - period: default search period (default: 1 day)
  - on: report bucket (default: :default)
 
- 4. Run the server and hit the health-check routes
+4. Run the server and hit the health-check routes
 
  ```
  wget http://localhost:3000/health-check/status
@@ -62,4 +62,4 @@ with error and render the report
  ```
  wget http://localhost:3000/health-check/status?period=3.days&threshold=0.005
  wget http://localhost:3000/health-check/late-status?period=1.hours&threshold=0.1
- ```
+ ```

data/house.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |gem|
 
   gem.add_runtime_dependency 'activesupport'
   gem.add_runtime_dependency 'concern_builder'
-  gem.add_runtime_dependency 'bidu-core_ext'
+  gem.add_runtime_dependency 'bidu-active_ext'
   gem.add_runtime_dependency 'json_parser', '~> 1.1'
 
   gem.add_development_dependency "activerecord"
@@ -28,5 +28,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "bundler", "~> 1.6"
   gem.add_development_dependency "rake"
   gem.add_development_dependency "rspec", "~> 2.14"
+  gem.add_development_dependency 'pry-nav'
   gem.add_development_dependency 'simplecov'
 end

data/lib/bidu/house.rb

@@ -1,4 +1,4 @@
-require 'active_record/relation_ext'
+require 'bidu/active_ext'
 require 'concern_builder'
 require 'bidu/core_ext'
 require 'bidu/period_parser'
@@ -8,7 +8,8 @@ require 'json_parser/type_cast_ext'
 module Bidu
   module House
     require 'bidu/house/concern'
-    require 'bidu/house/error_report'
+    require 'bidu/house/report_config'
+    require 'bidu/house/report'
     require 'bidu/house/status'
     require 'bidu/house/report_builder'
     require 'bidu/house/status_builder'

data/lib/bidu/house/concern.rb

@@ -4,7 +4,7 @@ module Bidu
 
     def render_status(key = :default)
       status = self.class.status_builder.build(key, params)
-      render json: status.as_json, status: status.status
+      render json: status.as_json.stringify_keys.to_deep_hash, status: status.status
     end
   end
 end

data/lib/bidu/house/report.rb

@@ -0,0 +1,7 @@
+module Bidu
+  module House
+    module Report
+      require 'bidu/house/report/error'
+    end
+  end
+end

data/lib/bidu/house/report/error.rb

@@ -0,0 +1,78 @@
+module Bidu
+  module House
+    module Report
+      class Error
+        include JsonParser
+
+        ALLOWED_PARAMETERS=[:period, :threshold]
+
+        attr_reader :json
+
+        json_parse :threshold, type: :float
+        json_parse :period, type: :period
+        json_parse :scope, :id, :clazz, :base_scope, :external_key, case: :snake
+
+        def initialize(options)
+          @json = {
+            external_key: :id,
+            threshold: 0.02,
+            period: 1.day,
+            scope: :with_error,
+            base_scope: :all
+          }.merge(options)
+        end
+
+        def status
+          @status ||= error? ? :error : :ok
+        end
+
+        def percentage
+          @percentage ||= fetch_percentage
+        end
+
+        def scoped
+          @scoped ||= fetch_scoped(last_entries, scope)
+        end
+
+        def error?
+          percentage > threshold
+        end
+
+        def as_json
+          {
+            ids: scoped.pluck(external_key),
+            percentage: percentage
+          }
+        end
+
+        private
+
+        def fetch_percentage
+          if (scope.is_a?(Symbol))
+            last_entries.percentage(*(scope.to_s.split('.').map(&:to_sym)))
+          else
+            last_entries.percentage(scope)
+          end
+        end
+
+        def fetch_scoped(base, scope)
+          if (scope.is_a?(Symbol))
+            scope.to_s.split('.').inject(base) do |entries, method|
+              entries.public_send(method)
+            end
+          else
+            base.where(scope)
+          end
+        end
+
+        def last_entries
+          @last_entries ||= base.where('updated_at >= ?', period.seconds.ago)
+        end
+
+        def base
+          fetch_scoped(clazz, base_scope)
+        end
+      end
+    end
+  end
+end

data/lib/bidu/house/report_builder.rb

@@ -2,17 +2,20 @@ module Bidu
   module House
     class ReportBuilder
       def build(key, parameters = {})
-        params = parameters.slice(:period, :threshold)
-        config = configs[key].merge(params)
-        Bidu::House::ErrorReport.new(config)
+        config = config_for(key)
+        config.build(parameters)
       end
 
       def add_config(key, config)
-        configs[key] = config
+        configs[key] = Bidu::House::ReportConfig.new(config)
       end
 
       private
 
+      def config_for(key)
+        configs[key]
+      end
+
       def configs
         @configs ||= {}
       end

data/lib/bidu/house/report_config.rb

@@ -0,0 +1,37 @@
+module Bidu
+  module House
+    class ReportConfig
+      attr_accessor :config
+
+      delegate :[], :[]=, :merge, to: :config
+
+      def initialize(config)
+        @config = config
+      end
+
+      def build(parameters)
+        params = slice_parameters(parameters)
+        report_class.new(config.merge(params))
+      end
+
+      private
+
+      def type
+        self[:type] ||= :error
+      end
+
+      def report_class
+        return type if type.is_a?(Class)
+        @report_class ||= Bidu::House::Report.const_get(type.to_s.camelize)
+      end
+
+      def slice_parameters(parameters)
+        parameters.slice(*allowed_parameters)
+      end
+
+      def allowed_parameters
+        report_class::ALLOWED_PARAMETERS
+      end
+    end
+  end
+end

data/lib/bidu/house/version.rb

@@ -1,5 +1,5 @@
 module Bidu
   module House
-    VERSION = '0.1.2'
+    VERSION = '0.2.0'
   end
 end

data/spec/lib/bidu/house/{error_report_spec.rb → report/error_spec.rb}

@@ -1,29 +1,37 @@
 require 'spec_helper'
 
-describe Bidu::House::ErrorReport do
+describe Bidu::House::Report::Error do
   let(:errors) { 1 }
   let(:successes) { 1 }
   let(:old_errors) { 2 }
   let(:threshold) { 0.02 }
   let(:period) { 1.day }
   let(:external_key) { :external_id }
+  let(:scope) { :with_error }
+  let(:base_scope) { :all }
   let(:options) do
     {
       period: period,
       threshold: threshold,
-      scope: :with_error,
+      scope: scope,
+      base_scope: base_scope,
       clazz: Document,
       external_key: external_key
     }
   end
   let(:subject) { described_class.new(options) }
+  let(:types) { [:a] }
   before do
     Document.all.each(&:destroy)
-    successes.times { Document.create status: :success }
-    errors.times do |i|
-      Document.create status: :error, external_id: 10 * successes + i, outter_external_id: i
+    types.each do |type|
+      successes.times { Document.create status: :success, doc_type: type }
+      errors.times do |i|
+        Document.create status: :error, external_id: 10 * successes + i, outter_external_id: i, doc_type: type
+      end
+      old_errors.times do
+        Document.create status: :error, created_at: 2.days.ago, updated_at: 2.days.ago, doc_type: type
+      end
     end
-    old_errors.times { Document.create status: :error, created_at: 2.days.ago, updated_at: 2.days.ago }
   end
 
   describe '#status' do
@@ -108,6 +116,68 @@ describe Bidu::House::ErrorReport do
         end
       end
     end
+
+    context 'when configuring with a complex scope' do
+      let(:types) { [:a, :b] }
+      let(:old_errors) { 0 }
+      let(:scope) { :'with_error.type_b' }
+      let(:errors) { 1 }
+      let(:successes) { 3 }
+      context 'as symbol' do
+        let(:scope) { :'with_error.type_b' }
+
+        it 'fetches from each scope in order' do
+          expect(subject.percentage).to eq(0.125)
+        end
+      end
+
+      context 'as string where scope' do
+        let(:scope) { "status = 'error' and doc_type = 'b'" }
+
+        it 'fetches from each scope in order' do
+          expect(subject.percentage).to eq(0.125)
+        end
+      end
+
+      context 'as hash where scope' do
+        let(:scope) { { status: :error, doc_type: :b } }
+
+        it 'fetches from each scope in order' do
+          expect(subject.percentage).to eq(0.125)
+        end
+      end
+    end
+
+    context 'when using a base scope' do
+      let(:types) { [:a, :b, :b, :b] }
+      let(:old_errors) { 0 }
+      let(:errors) { 1 }
+      let(:successes) { 3 }
+
+      context 'as symbol' do
+        let(:base_scope) { :type_b }
+
+        it 'fetches from each scope in order' do
+          expect(subject.percentage).to eq(0.25)
+        end
+      end
+
+      context 'as where clause' do
+        let(:base_scope) { "doc_type = 'b'" }
+
+        it 'fetches from each scope in order' do
+          expect(subject.percentage).to eq(0.25)
+        end
+      end
+
+      context 'as hash' do
+        let(:base_scope) { { doc_type: :b } }
+
+        it 'fetches from each scope in order' do
+          expect(subject.percentage).to eq(0.25)
+        end
+      end
+    end
   end
 
   describe '#scoped' do
@@ -146,6 +216,70 @@ describe Bidu::House::ErrorReport do
         end
       end
     end
+
+    context 'when configured with a complex scope' do
+      let(:types) { [:a, :b, :b] }
+      let(:old_errors) { 0 }
+
+      context 'as symbol' do
+        let(:scope) { :'with_error.type_b' }
+
+        it 'fetches from each scope in order' do
+          expect(subject.scoped.count).to eq(Document.with_error.type_b.count)
+          expect(subject.scoped.count).to eq(2 * Document.with_error.type_a.count)
+        end
+      end
+
+      context 'as hash' do
+        let(:scope) { { status: :error, doc_type: :b } }
+
+        it 'fetches from each scope in order' do
+          expect(subject.scoped.count).to eq(Document.with_error.type_b.count)
+          expect(subject.scoped.count).to eq(2 * Document.with_error.type_a.count)
+        end
+      end
+
+      context 'as string where scope' do
+        let(:scope) { "status = 'error' and doc_type = 'b'" }
+
+        it 'fetches from each scope in order' do
+          expect(subject.scoped.count).to eq(Document.with_error.type_b.count)
+          expect(subject.scoped.count).to eq(2 * Document.with_error.type_a.count)
+        end
+      end
+    end
+
+    context 'when using a base scope' do
+      let(:types) { [:a, :b, :b, :b] }
+      let(:old_errors) { 0 }
+
+      context 'as symbol' do
+        let(:base_scope) { :type_b }
+
+        it 'fetches from each scope in order' do
+          expect(subject.scoped.count).to eq(Document.with_error.type_b.count)
+          expect(subject.scoped.count).to eq(3 * Document.with_error.type_a.count)
+        end
+      end
+
+      context 'as where clause' do
+        let(:base_scope) { "doc_type = 'b'" }
+
+        it 'fetches from each scope in order' do
+          expect(subject.scoped.count).to eq(Document.with_error.type_b.count)
+          expect(subject.scoped.count).to eq(3 * Document.with_error.type_a.count)
+        end
+      end
+
+      context 'as hash' do
+        let(:base_scope) { { doc_type: :b } }
+
+        it 'fetches from each scope in order' do
+          expect(subject.scoped.count).to eq(Document.with_error.type_b.count)
+          expect(subject.scoped.count).to eq(3 * Document.with_error.type_a.count)
+        end
+      end
+    end
   end
 
   describe '#error?' do

data/spec/lib/bidu/house/report/report_config_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+describe Bidu::House::ReportConfig do
+  let(:config) { {} }
+  let(:parameters) { {} }
+  let(:subject) { described_class.new(config) }
+
+  describe '#build' do
+    context 'when no config is given' do
+      it do
+        expect(subject.build(parameters)).to be_a(Bidu::House::Report::Error)
+      end
+    end
+
+    context 'when a dummy type is given' do
+      let(:config) { { type: :dummy } }
+
+      it do
+        expect(subject.build(parameters)).to be_a(Bidu::House::Report::Dummy)
+      end
+    end
+
+    context 'when a class is given as type' do
+      let(:config) { { type: Bidu::House::Report::Dummy } }
+
+      it do
+        expect(subject.build(parameters)).to be_a(Bidu::House::Report::Dummy)
+      end
+    end
+
+    context 'when a global class is given as type' do
+      let(:config) { { type: Dummy } }
+
+      it do
+        expect(subject.build(parameters)).to be_a(Dummy)
+      end
+    end
+  end
+end

data/spec/lib/bidu/house/report_builder_spec.rb

@@ -33,7 +33,7 @@ describe Bidu::House::ReportBuilder do
   describe '#build' do
     let(:ids) { [ 10 ] }
     it do
-      expect(report).to be_a(Bidu::House::ErrorReport)
+      expect(report).to be_a(Bidu::House::Report::Error)
     end
 
     it 'builds the report using the given configuration' do
@@ -59,7 +59,7 @@ describe Bidu::House::ReportBuilder do
 
     context 'when passing a custom other parameters' do
       let(:parameters) do
-        { scope: :with_success, clazz: Bidu::House::ErrorReport, external_key: :id, id: :failures }
+        { scope: :with_success, clazz: Bidu::House::Report::Error, external_key: :id, id: :failures }
       end
 
       it 'ignores the non customizable parameters' do

data/spec/lib/bidu/house/status_spec.rb

@@ -20,9 +20,9 @@ describe Bidu::House::Status do
   end
   let(:errors) { 0 }
   let(:successes) { 1 }
-  let(:error_report) { Bidu::House::ErrorReport.new(report_options) }
+  let(:error_report) { Bidu::House::Report::Error.new(report_options) }
   let(:success_report) do
-    Bidu::House::ErrorReport.new(success_options)
+    Bidu::House::Report::Error.new(success_options)
   end
   let(:reports) { [ error_report ] }
   let(:subject) { described_class.new(reports) }
@@ -56,7 +56,7 @@ describe Bidu::House::Status do
 
     context 'when there are both success and error reports' do
       let(:success_report) do
-        Bidu::House::ErrorReport.new(report_options.merge(scope: :with_success))
+        Bidu::House::Report::Error.new(report_options.merge(scope: :with_success))
       end
       let(:reports) { [ success_report, error_report ] }
 

data/spec/spec_helper.rb

@@ -1,6 +1,11 @@
 require 'simplecov'
-SimpleCov.start
+SimpleCov.profiles.define 'gem' do
+  add_filter '/spec/'
+end
+
+SimpleCov.start 'gem'
 
+require 'pry-nav'
 require 'bidu/house'
 
 require 'active_record'

data/spec/support/models/document.rb

@@ -1,4 +1,6 @@
 class Document < ActiveRecord::Base
   scope :with_error, proc { where(status: :error) }
   scope :with_success, proc { where(status: :success) }
+  scope :type_a, proc { where(doc_type: :a) }
+  scope :type_b, proc { where(doc_type: :b) }
 end

data/spec/support/report/dummy.rb

@@ -0,0 +1,17 @@
+module Bidu
+  module House
+    module Report
+      class Dummy
+        ALLOWED_PARAMETERS=[:period, :threshold]
+        def initialize(options)
+        end
+      end
+    end
+  end
+end
+
+class Dummy
+  ALLOWED_PARAMETERS=[:period, :threshold]
+  def initialize(options)
+  end
+end

data/spec/support/schema.rb

@@ -3,6 +3,7 @@ ActiveRecord::Schema.define do
 
   create_table :documents, :force => true do |t|
     t.string :status
+    t.string :doc_type
     t.integer :external_id
     t.integer :outter_external_id
     t.timestamps null: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bidu-house
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Bidu Dev's Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-06 00:00:00.000000000 Z
+date: 2015-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -39,7 +39,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bidu-core_ext
+  name: bidu-active_ext
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -136,6 +136,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: pry-nav
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -165,20 +179,21 @@ files:
 - README.md
 - Rakefile
 - house.gemspec
-- lib/active_record/relation_ext.rb
 - lib/bidu.rb
 - lib/bidu/house.rb
 - lib/bidu/house/class_methods.rb
 - lib/bidu/house/concern.rb
-- lib/bidu/house/error_report.rb
+- lib/bidu/house/report.rb
+- lib/bidu/house/report/error.rb
 - lib/bidu/house/report_builder.rb
+- lib/bidu/house/report_config.rb
 - lib/bidu/house/status.rb
 - lib/bidu/house/status_builder.rb
 - lib/bidu/house/version.rb
 - lib/bidu/period_parser.rb
 - lib/json_parser/type_cast_ext.rb
-- spec/lib/active_record/relation_spec.rb
-- spec/lib/bidu/house/error_report_spec.rb
+- spec/lib/bidu/house/report/error_spec.rb
+- spec/lib/bidu/house/report/report_config_spec.rb
 - spec/lib/bidu/house/report_builder_spec.rb
 - spec/lib/bidu/house/status_builder_spec.rb
 - spec/lib/bidu/house/status_spec.rb
@@ -186,6 +201,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/fixture_helpers.rb
 - spec/support/models/document.rb
+- spec/support/report/dummy.rb
 - spec/support/schema.rb
 homepage: https://github.com/Bidu/house
 licenses: []

data/lib/active_record/relation_ext.rb

@@ -1,19 +0,0 @@
-require 'active_record'
-
-module ActiveRecord
-  class Relation
-    def percentage(*filters)
-      return 0 if count == 0
-
-      if filters.first.is_a?(Symbol)
-        filtered = filters.inject(self) do |relation, scope|
-          relation.public_send(scope)
-        end
-      else
-        filtered = where(*filters)
-      end
-
-      filtered.count * 1.0 / count
-    end
-  end
-end

data/lib/bidu/house/error_report.rb

@@ -1,51 +0,0 @@
-module Bidu
-  module House
-    class ErrorReport
-      include JsonParser
-
-      attr_reader :json
-
-      json_parse :threshold, type: :float
-      json_parse :period, type: :period
-      json_parse :scope, :id, :clazz, :external_key, case: :snake
-
-      def initialize(options)
-        @json = {
-          external_key: :id,
-          threshold: 0.02,
-          period: 1.day,
-          scope: :with_error
-        }.merge(options)
-      end
-
-      def status
-        @status ||= error? ? :error : :ok
-      end
-
-      def percentage
-        @percentage ||= last_entires.percentage(scope)
-      end
-
-      def scoped
-        @scoped ||= last_entires.public_send(scope)
-      end
-
-      def error?
-        percentage > threshold
-      end
-
-      def as_json
-        {
-          ids: scoped.pluck(external_key),
-          percentage: percentage
-        }
-      end
-
-      private
-
-      def last_entires
-        @last_entires ||= clazz.where('updated_at >= ?', period.seconds.ago)
-      end
-    end
-  end
-end

data/spec/lib/active_record/relation_spec.rb

@@ -1,44 +0,0 @@
-require 'spec_helper'
-
-describe ActiveRecord::Relation do
-  describe '#percentage' do
-    let(:error_number) { 1 }
-    let(:success_number) { 1 }
-
-    before do
-      Document.all.each(&:destroy)
-      error_number.times { Document.create(status: :error) }
-      success_number.times { Document.create(status: :success) }
-    end
-
-    context 'when there are 50% documents with error' do
-      it do
-        expect(Document.all.percentage(status: :error)).to eq(0.5)
-      end
-    end
-
-    context 'when there are 25% documents with error' do
-      let(:success_number) { 3 }
-
-      it do
-        expect(Document.all.percentage(status: :error)).to eq(0.25)
-      end
-    end
-
-    context 'when passing a sub scope' do
-      before do
-        Document.create(status: :on_going)
-      end
-
-      it 'does the math inside the scope' do
-        expect(Document.where(status: [:error, :success]).percentage(status: :error)).to eq(0.5)
-      end
-    end
-
-    context 'when passing a scope name instead of query' do
-      it 'does the math inside the scope' do
-        expect(Document.all.percentage(:with_error)).to eq(0.5)
-      end
-    end
-  end
-end