bidu-core_ext 1.2.4 → 1.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 46ca9596bf1bd9395697f6d139e95529443dfeed
-  data.tar.gz: 1f867d81d89c0da0a422bad9ec9ff241cb16c057
+  metadata.gz: 3aece23d84b190a26be718796ea4986a5a90b3ce
+  data.tar.gz: 41c946d5b73bfea41809ecfaec23ce6c827f1c1c
 SHA512:
-  metadata.gz: 9cc16aa3de7626debf7b94218590db05eb5deefacd264a5dd1bf1cdea39f41e66e47df1e13b5b434ec3a1e02e345f07d890bda70d3cb149d494a39e408c24933
-  data.tar.gz: 5c18491c6ae48e0fbed356615fcf1026b68585597167d9d7fa9eda3a4a1419ea32daa864b0aa31389dcbf3fe0e9647318a31c7e46837b25595365613fcc7a50e
+  metadata.gz: eb361421619c5377fc49cc859c152650715a6922d0f11aec782c6f18ca4afd5b271ce6f415b6efcba2a2679ad047cf4840fee2ef725d09617c72faf32df80e87
+  data.tar.gz: 8d42a46be5315f9c21bb5530f81374394c1e3bca46ffdc905f3073c7d88761807deb2595195415a0eeeebf15469c4c98db0b67cbabf0d611c0a7113c7d8e8b47

data/.gitignore

@@ -1 +1,2 @@
 coverage
+pkg

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bidu-core_ext (1.2.4)
+    bidu-core_ext (1.2.5)
       activesupport (~> 5.1.1)
 
 GEM

data/README.md

@@ -4,7 +4,7 @@ Core_Ext
 This project adds some new methods to the core ruby classes
 
 ## Array
-###map_to_hash
+### map_to_hash
 map returning a hash with the original array for keys
 
 ```ruby
@@ -40,7 +40,7 @@ returns
 ```
 
 ## Hash
-###map_to_hash
+### map_to_hash
 map returning a hash with the original keys
 
 ```ruby
@@ -62,7 +62,7 @@ h.chain_fetch(:a, :x, :y, :z) { |key, missed_keys| "returned #{key}" }
 'returned x'
 ```
 
-###squash
+### squash
 Squash a deep hash into a simple level hash
 
 ```ruby
@@ -106,7 +106,7 @@ returns
   { 'CA_B' => 1 }
 ```
 
-###chain_change_keys
+### chain_change_keys
 Change the hash keys usin a chained method call
 
 ```ruby

data/lib/bidu/core_ext/version.rb

@@ -1,5 +1,5 @@
 module Bidu
   module CoreExt
-    VERSION = '1.2.4'
+    VERSION = '1.2.5'
   end
 end

data/lib/hash/value_changer.rb

@@ -11,9 +11,9 @@ class Hash::ValueChanger
   end
 
   def change(object)
-    if object.is_a? Hash
+    if object.respond_to?(:change_values)
       change_hash(object)
-    elsif object.is_a? Array
+    elsif is_iterable?(object)
       change_array(object)
     end
   end
@@ -30,15 +30,24 @@ class Hash::ValueChanger
   end
 
   def change_array(array)
+    array = array.to_a
+
     array.each.with_index do |value, index|
-      value = value.change_values(options, &block) if value.is_a? Hash
-      value = change_array(value) if value.is_a? Array
+      if value.respond_to?(:change_values)
+        value = value.change_values(options, &block)
+      elsif is_iterable?(value)
+        value = change_array(value)
+      end
       array[index] = value
     end
   end
 
   def change_value?(value)
-    !(value.is_a?(Hash) || value.is_a?(Array)) || !options[:skip_inner]
+    !is_iterable?(value) || !options[:skip_inner]
+  end
+
+  def is_iterable?(value)
+    value.respond_to?(:each)
   end
 
   def new_value(value)
@@ -47,6 +56,6 @@ class Hash::ValueChanger
   end
 
   def apply_recursion?(value)
-    (value.is_a?(Hash) || value.is_a?(Array)) && options[:recursive]
+    is_iterable?(value) && options[:recursive]
   end
 end

data/spec/support/models/hash/value_changer/dummy.rb

@@ -0,0 +1,15 @@
+class Hash::ValueChanger::Dummy
+  attr_reader :value
+
+  delegate :+, to: :value
+
+  def initialize(value)
+    @value = value
+  end
+
+  def eql?(other)
+    return true if equals?(other)
+    return false unless other.is_a?(self.class)
+    a.value == value
+  end
+end

data/spec/support/models/hash/value_changer/dummy_iteractor.rb

@@ -0,0 +1,12 @@
+class Hash::ValueChanger::DummyIteractor
+  def initialize(*array)
+    @array = array
+  end
+
+  delegate :each, :to_a, to: :array
+
+  private
+
+  attr_reader :array
+end
+

data/spec/support/shared_examples/value_changer.rb

@@ -5,17 +5,9 @@ shared_examples 'a class with change_values method' do
     it_behaves_like 'a method that change the hash values', :change_values
 
     it 'does not change original hash' do
-      subject.change_values { |value| value + 1 }
-      expect(subject).to eq(a: 1, b: 2, c: { d: 3, e: 4 })
-    end
-
-    it 'should call change_values!' do
-      original = { 'a' => 1, c: { d: 3, e: 4 } }
-      copy = { 'a' => 1, c: { d: 3, e: 4 } }
-
-      expect(original).to receive(:deep_dup).and_return(copy)
-      expect(copy).to receive(:change_values!)
-      original.change_values { |value| value + 1 }
+      expect do
+        subject.change_values { |value| value + 1 }
+      end.not_to change { subject }
     end
   end
 
@@ -23,41 +15,78 @@ shared_examples 'a class with change_values method' do
     it_behaves_like 'a method that change the hash values', :change_values!
 
     it 'changes original hash' do
-      subject.change_values! { |value| value + 1 }
-
-      expect(subject).to_not eq(a: 1, b: 2, c: { d: 3, e: 4 })
-      expect(subject).to eq(a: 2, b: 3, c: { d: 4, e: 5 })
+      expect do
+        subject.change_values! { |value| value + 1 }
+      end.to change { subject }
     end
   end
 end
 
 shared_examples 'a method that change the hash values' do |method|
-  it 'updates values of hash' do
-    expect(subject.public_send(method) { |value| value + 1 }).to eq(a: 2, b: 3, c: { d: 4, e: 5 })
-  end
+  context 'when using deeply nested hashes' do
+    it 'updates values of hash' do
+      expect(subject.public_send(method) { |value| value + 1 }).to eq(a: 2, b: 3, c: { d: 4, e: 5 })
+    end
 
-  it 'works recursively when parameter is passed' do
-    expect(subject.change_values(recursive: true) { |value| value + 1 }).to eq(a: 2, b: 3, c: { d: 4, e: 5 })
-  end
+    it 'works recursively when parameter is passed' do
+      expect(subject.public_send(method, recursive: true) { |value| value + 1 }).to eq(a: 2, b: 3, c: { d: 4, e: 5 })
+    end
 
-  it 'does not work recursively when parameter is passed as false' do
-    expect(subject.change_values(recursive: false) { |value| value + 1 }).to eq(a: 2, b: 3, c: { d: 3, e: 4 })
-  end
+    it 'does not work recursively when parameter is passed as false' do
+      expect(subject.public_send(method, recursive: false) { |value| value + 1 }).to eq(a: 2, b: 3, c: { d: 3, e: 4 })
+    end
 
-  it 'does not ignore hash when option is passed' do
-    expect(subject.change_values(skip_inner: false) { |value| value.is_a?(Hash) ? 10 + value.size : value + 1 }).to eq(a: 2, b: 3, c: 12)
-  end
+    it 'does not ignore hash when option is passed' do
+      expect(subject.public_send(method, skip_inner: false) { |value| value.is_a?(Hash) ? 10 + value.size : value + 1 }).to eq(a: 2, b: 3, c: 12)
+    end
 
-  it 'ignore hash and work recursively when option is passed' do
-    expect(subject.change_values(skip_inner: false) { |value| value.is_a?(Hash) ? value : value + 1 }).to eq(a: 2, b: 3, c: { d: 4, e: 5 })
+    it 'ignore hash and work recursively when option is passed' do
+      expect(subject.public_send(method, skip_inner: true) { |value| value.is_a?(Hash) ?  10 + value.size : value + 1 }).to eq(a: 2, b: 3, c: { d: 4, e: 5 })
+    end
+
+    it 'ignore hash and does not work recursively when option is passed' do
+      expect(subject.public_send(method, skip_inner: false, recursive: false) { |value| value.is_a?(Hash) ? value : value + 1 }).to eq(a: 2, b: 3, c: { d: 3, e: 4 })
+    end
   end
 
-  it 'ignore hash and does not work recursively when option is passed' do
-    expect(subject.change_values(skip_inner: false, recursive: false) { |value| value.is_a?(Hash) ? value : value + 1 }).to eq(a: 2, b: 3, c: { d: 3, e: 4 })
+  context 'when using deeply nested arrays' do
+    let(:subject) { { a: 1, b: 2, c: [{ d: 3 }, { e: { f: 4 } } ] } }
+
+    it 'goes recursivly true arrays' do
+      expect(subject.public_send(method) { |value| value + 1 }).to eq(a: 2, b: 3, c: [{ d: 4 }, { e: { f: 5 } }])
+    end
+
+    it 'does not work recursively when parameter is passed as false' do
+      expect(subject.public_send(method, recursive: false) { |value| value + 1 }).to eq(a: 2, b: 3, c: [{ d: 3 }, { e: { f: 4 } }])
+    end
+
+    it 'does not ignore array when option is passed' do
+      expect(subject.public_send(method, skip_inner: false) { |value| value.is_a?(Array) ? 10 + value.size : value + 1 }).to eq(a: 2, b: 3, c: 12)
+    end
+
+    it 'ignores array when option is passed' do
+      expect(subject.public_send(method, skip_inner: true) { |value| value.is_a?(Array) ? 10 + value.size : value + 1 }).to eq(a: 2, b: 3, c: [{ d: 4 }, { e: { f: 5 } }])
+    end
+
+    it 'ignore hash and does not work recursively when option is passed' do
+      expect(subject.public_send(method, skip_inner: false, recursive: false) { |value| value.is_a?(Array) ? value : value + 1 }).to eq(a: 2, b: 3, c: [{ d: 3 }, { e: { f: 4 } }])
+    end
   end
 
-  it 'applies to arrays as well' do
-    subject = { a: 1, b: 2, c: [{ d: 3 }, { e: 4 }] }
-    expect(subject.public_send(method) { |value| value + 1 }).to eq(a: 2, b: 3, c: [{ d: 4 }, { e: 5 }])
+  context 'when using a nested extra class' do
+    let(:subject) { { a: 1, b: 2, c: Hash::ValueChanger::Dummy.new(3) } }
+
+    it 'goes perform the mapping with the extra class' do
+      expect(subject.public_send(method) { |value| value + 1 }).to eq(a: 2, b: 3, c: 4)
+    end
+
+    context 'when class is an interactor' do
+      let(:subject) { { a: 1, b: 2, c: Hash::ValueChanger::DummyIteractor.new({ d: 3 }, { e: { f: 4 } }) } }
+
+      it 'goes through the iteractor' do
+        expect(subject.public_send(method) { |value| value + 1 }).to eq(a: 2, b: 3, c: [{ d: 4 }, { e: { f: 5 } }])
+      end
+    end
+
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bidu-core_ext
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.2.5
 platform: ruby
 authors:
 - Bidu Developers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-04 00:00:00.000000000 Z
+date: 2017-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -157,6 +157,8 @@ files:
 - spec/lib/numeric_spec.rb
 - spec/lib/symbol_spec.rb
 - spec/spec_helper.rb
+- spec/support/models/hash/value_changer/dummy.rb
+- spec/support/models/hash/value_changer/dummy_iteractor.rb
 - spec/support/shared_examples/array_random.rb
 - spec/support/shared_examples/chain_fetch.rb
 - spec/support/shared_examples/chain_hash_keys_changer.rb
@@ -200,6 +202,8 @@ test_files:
 - spec/lib/numeric_spec.rb
 - spec/lib/symbol_spec.rb
 - spec/spec_helper.rb
+- spec/support/models/hash/value_changer/dummy.rb
+- spec/support/models/hash/value_changer/dummy_iteractor.rb
 - spec/support/shared_examples/array_random.rb
 - spec/support/shared_examples/chain_fetch.rb
 - spec/support/shared_examples/chain_hash_keys_changer.rb