bidify 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 869c99f4077d50f88ff976b15ab4106fd15900e45af1bd5673de5255b6cfb8ef
-  data.tar.gz: 688dfb1fcab1cbfb627a851951ca80a16479c96c6498b036f3a0e3453441b7f0
+  metadata.gz: 28b6f2a2a467a1c0c61b7da79e06f2113cce82e0142c1c4646ba07a47261033f
+  data.tar.gz: 82ac8d4762aaf7ca746c5e7a3b1d285e85528929c4649c1396f68884b2b4863b
 SHA512:
-  metadata.gz: 56b5b3058a06f7fe748796490cf53d940b81257bfa4e7990045d788170082a000c463a2fce8c85a9e1d63eb306d2ff471b95f5091fddd0ed49a2e328aaebd3cc
-  data.tar.gz: aa3cdec3d581149a8c57ee692d4bb912eb86adadddbad364ebda35acda25d6c0905eb329b79406adf187f486adef4077ac246c28b73aacbea4b1ac63922c4fdf
+  metadata.gz: efa3b752d9cabd3f6a37deb3a6a3a870214d2ccb3ccb6471d754dc99e6402ec389b2e18b44cc8c94ba2602a5c67a11628c72e572bed14f55e3adaf7884c2453a
+  data.tar.gz: 68f8d08def9b0a02c3ed7e34d10832bb29cbd918f6c59337585f51acf83a85e4c7d75ea50c89f8285f0d2d3e061f982d060edc0c4c00810a64ae775aa87d0b71

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bidify (0.1.0)
+    bidify (0.1.1)
       nokogiri (~> 1.14)
 
 GEM

data/README.md

@@ -14,6 +14,32 @@ bidified_html = Bidify.bidify(html_input)
 # bidified_html: '<p dir="auto">some content even in nested format</p>' 
 ```
 
+## Rules
+
+The `dir="auto"` attribute should be applied on "bidifiable" tags as per the following rules:
+
+- Only apply on "bidifiable" tags.
+- All top-level elements
+- All child elements except the first child
+
+Bidifiable elements can be defined as per the use case requirements (not yet implemented).
+The default bidifiable tags are: `div`, `h1`, `h2`, `h3`, `h4`, `h5`, `h6`, `p`, `ul`, `ol`, `blockquote`.
+
+Notice that `li` elements shouldn't get `dir=auto` otherwise, the list appearance gets damaged.
+
+As a complementary step, CSS styles should use [logical properties](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_logical_properties_and_values). Here are a few examples:
+
+```css
+/* Physical properties */
+text-align: left;
+padding-right: 10px;
+border-left: 1px;
+/* Logical properties */
+text-align: start;
+padding-inline-end: 10px;
+border-inline-start: 1px;
+```
+
 ## License
 
 This project is a Free/Libre and Open Source software released under LGPLv3 license.

data/lib/bidify/bidifier.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module Bidify
+  # Super class for custom bidifiers
+  class Bidifier
+    ###
+    # Instanciate a bidifier object with the given optional options hash
+    #
+    # @param [Hash] options
+    #
+    def initialize(options = {})
+      @options = options
+
+      configure
+    end
+
+    def apply
+      raise NotImplementedError
+    end
+
+    private
+
+    def configure
+      @bidifiable_tags = DEFAULT_BIDIFIABLE_TAGS.dup
+      @bidifiable_tags.concat(TABLE_TAGS) if @options[:with_table_support]
+    end
+
+    def bidify_recursively(html_node, options = {})
+      seen_the_first_bidifiable_element = false
+
+      html_node.children.each do |child_node|
+        bidify_recursively(child_node)
+
+        if (options[:root] || seen_the_first_bidifiable_element) && @bidifiable_tags.include?(child_node.name)
+          child_node.set_attribute('dir', 'auto')
+        end
+
+        seen_the_first_bidifiable_element = true if actual_content?(child_node)
+      end
+    end
+
+    def actual_content?(node)
+      node.element? || (node.text? && !node.blank?)
+    end
+  end
+end

data/lib/bidify/html_string_bidifier.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'nokogiri'
+require_relative 'bidifier'
+
+module Bidify
+  ###
+  # Bidifying html input as string
+  #
+  # == Example Usage
+  #
+  # Here's an example of how to use the class:
+  #
+  #   bidifier = HtmlStringBidifier.new
+  #   bidifier.apply("<p>text</p>")
+  #
+  class HtmlStringBidifier < Bidifier
+    ###
+    # Applies dir="auto" to the given html string with default configuration
+    #
+    # @param [String] html_string a stringified HTML content
+    # @return [String] Bidified version of the input string
+    #
+    def apply(html_input)
+      html_node = Nokogiri::HTML.fragment(html_input)
+      bidify_recursively(html_node, { root: true })
+
+      html_node.to_s
+    end
+  end
+end

data/lib/bidify/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bidify
-  VERSION = '0.1.1'
+  VERSION = '0.2.0'
 end

data/lib/bidify.rb

@@ -1,43 +1,27 @@
 # frozen_string_literal: true
 
-require 'nokogiri'
+require 'bidify/html_string_bidifier'
 
-# Bidify applies `dir="auto"` to the given html string
+# == Bidify module
 #
-# ### Example:
+# The namespace and helper methods for bidiying HTML contents
 #
-#    bidified_html = Bidify.bidify(regular_html)
+# == Example:
+#
+#    bidified_html = Bidify.bidify_html_string(regular_html)
 module Bidify
-  @bidifiable_tags = %w[div h1 h2 h3 h4 h5 h6 p ul ol blockquote]
+  DEFAULT_BIDIFIABLE_TAGS = %w[div h1 h2 h3 h4 h5 h6 p ul ol blockquote].freeze
+  TABLE_TAGS = %w[table thead tbody th tr td].freeze
 
   class << self
     ###
-    # bidify applies dir="auto" to the given html string
-    def bidify(input_html)
-      html_node = Nokogiri::HTML.fragment(input_html)
-      bidify_recursively(html_node, { root: true })
-
-      html_node.to_s
-    end
-
-    private
-
-    def bidify_recursively(html_node, options = {})
-      seen_the_first_bidifiable_element = false
-
-      html_node.children.each do |child_node|
-        bidify_recursively(child_node)
-
-        if (options[:root] || seen_the_first_bidifiable_element) && @bidifiable_tags.include?(child_node.name)
-          child_node.set_attribute('dir', 'auto')
-        end
-
-        seen_the_first_bidifiable_element = true if actual_content?(child_node)
-      end
-    end
-
-    def actual_content?(node)
-      node.element? || (node.text? && !node.blank?)
+    # Applies dir="auto" to the given html string with default configuration
+    #
+    # @param [String] html_string a stringified HTML content
+    # @return [String] Bidified version of the input string
+    #
+    def bidify_html_string(html_string)
+      Bidify::HtmlStringBidifier.new.apply(html_string)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bidify
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Mostafa Ahangarha
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-25 00:00:00.000000000 Z
+date: 2023-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -36,6 +36,8 @@ files:
 - LICENSE
 - README.md
 - lib/bidify.rb
+- lib/bidify/bidifier.rb
+- lib/bidify/html_string_bidifier.rb
 - lib/bidify/version.rb
 homepage: https://github.com/dobidi/bidify-rb
 licenses: