bidi2pdf 0.1.13 → 0.1.15

data/lib/bidi2pdf/bidi/browser_tab.rb

@@ -444,6 +444,58 @@ module Bidi2pdf
 
       # rubocop:enable Metrics/AbcSize, Metrics/PerceivedComplexity
 
+      # Captures a screenshot of the browser tab, mirroring #print's own
+      # file/block/base64-return trichotomy.
+      #
+      # @param [String, nil] outputfile The output file for the PNG. Defaults to nil.
+      # @param [String] origin "document" (default) or "viewport" - see browsingContext.captureScreenshot.
+      # @param [String, nil] format Image format override, e.g. "image/png". Defaults to the browser's own default.
+      # @param [Hash, nil] clip A clip rectangle/element, passed through verbatim. Defaults to nil (full capture).
+      # @yield [png_base64] A block to handle the PNG content.
+      # @return [String, nil] The base64-encoded PNG content, or nil if outputfile or block is provided.
+      # rubocop:disable Metrics/AbcSize
+      def screenshot(outputfile = nil, origin: "document", format: nil, clip: nil, &block)
+        Bidi2pdf.notification_service.instrument("screenshot.bidi2pdf") do |instrumentation_payload|
+          cmd = Commands::CaptureScreenshot.new(context: browsing_context_id, origin: origin, format: format, clip: clip)
+
+          instrumentation_payload[:cmd] = cmd
+
+          client.send_cmd_and_wait(cmd) do |response|
+            if response["result"]
+              png_base64 = response.dig("result", "data")
+
+              instrumentation_payload[:png_base64] = png_base64
+
+              if outputfile
+                raise ScreenshotError, "Folder does not exist: #{File.dirname(outputfile)}" unless File.directory?(File.dirname(outputfile))
+
+                File.binwrite(outputfile, Base64.decode64(png_base64))
+                Bidi2pdf.logger.info "Screenshot saved as '#{outputfile}'."
+              end
+
+              block.call(png_base64) if block_given?
+
+              return png_base64 unless outputfile || block_given?
+            else
+              Bidi2pdf.logger.error "Error capturing screenshot: #{response}"
+            end
+          end
+        end
+      end
+
+      # rubocop:enable Metrics/AbcSize
+
+      # Sets the browsing context's viewport - makes a headless render deterministic across
+      # machines, unlike leaving it at the browser's own default.
+      #
+      # @param [Integer] width
+      # @param [Integer] height
+      # @param [Float, nil] device_pixel_ratio Defaults to nil (browser default).
+      def set_viewport(width:, height:, device_pixel_ratio: nil)
+        cmd = Commands::SetViewport.new(context: browsing_context_id, width: width, height: height, device_pixel_ratio: device_pixel_ratio)
+        client.send_cmd_and_wait(cmd) { |response| response }
+      end
+
       private
 
       def build_command_and_extractor(print_options)
@@ -481,11 +533,21 @@ module Bidi2pdf
 
         cmd = Bidi2pdf::Bidi::Commands::BrowsingContextNavigate.new url: url, context: browsing_context_id, wait: wait
 
-        client.send_cmd_and_wait(cmd) do |response|
-          Bidi2pdf.logger.debug "Navigated to page url: #{url} response: #{response}"
+        navigation_id = client.send_cmd_and_wait(cmd) do |response|
+          logged_url = url.start_with?("data:") ? "data:[#{url.bytesize} bytes]" : url
+          response_navigation_id = response.dig("result", "navigation")
+          Bidi2pdf.logger.debug "Navigated to page url: #{logged_url} navigation: #{response_navigation_id}"
+
+          response_navigation_id
         end
+
+        check_navigation_http_status(url, navigation_id)
       rescue Bidi2pdf::CmdError => e
-        msg = e.response["message"]
+        raise_navigation_error_for(url, e)
+      end
+
+      def raise_navigation_error_for(url, error)
+        msg = error.response["message"]
         case msg
         when /^net::ERR_INVALID_AUTH_CREDENTIALS/
           raise NavigationAuthError.new(url, msg)
@@ -494,10 +556,41 @@ module Bidi2pdf
         when /^net::/
           raise NavigationError, "Connection error: #{url} #{msg}"
         else
-          raise e
+          raise error
         end
       end
 
+      # browsingContext.navigate's own response never carries an HTTP status - only a
+      # network.responseCompleted event does, correlated back to this specific navigation via its
+      # "navigation" field (a Chrome/redirect-chain-wide ID, not the network request's own id).
+      # register_event_listeners already ran above, so network_events has been tracking since
+      # before the navigate command was even sent. Deliberately conservative: with no navigation
+      # ID, or no correlated *completed* request found, this stays silent rather than guessing -
+      # only a positively confirmed >= 400 status raises. max_by(&:start_timestamp) picks the last
+      # hop of a redirect chain (every hop shares the same navigation ID), matching the page the
+      # browser actually ended up on.
+      def check_navigation_http_status(url, navigation_id)
+        return unless navigation_id
+
+        final_response = correlated_navigation_response(navigation_id)
+        return unless final_response
+
+        status = final_response.http_status_code
+        return if status < 400
+
+        raise NavigationNotFoundError, "Navigation to #{url} failed: HTTP 404 Not Found" if status == 404
+
+        raise NavigationError, "Navigation to #{url} failed: HTTP #{status}"
+      end
+
+      # The last hop of a redirect chain (every hop shares the same navigation ID) - the page the
+      # browser actually ended up on, not wherever the chain started.
+      def correlated_navigation_response(navigation_id)
+        network_events.all_events
+                      .select { |event| event.navigation == navigation_id && event.http_status_code }
+                      .max_by(&:start_timestamp)
+      end
+
       def register_event_listeners
         return if @event_handlers_registered
 

data/lib/bidi2pdf/bidi/buffered_web_socket_client.rb

@@ -0,0 +1,178 @@
+# frozen_string_literal: true
+
+require "monitor"
+require "openssl"
+require "socket"
+require "uri"
+require "websocket"
+
+module Bidi2pdf
+  module Bidi
+    # A threaded WebSocket client on the `websocket` gem's framing - the same shape Selenium's Ruby
+    # BiDi client uses. It replaces websocket-client-simple, whose reader pulled one byte at a time
+    # (`getc`, then a frame-parse attempt per byte): a printed PDF comes back as one base64 message
+    # and every network event for a `data:` navigation echoes the whole URL, so that loop ran
+    # millions of times per render - ~730 ms to decode a 700 KB frame, against ~0.5 ms in 16 KB
+    # chunks.
+    #
+    # Emits :open, :message (a WebSocket frame, payload in #data), :error and :close.
+    class BufferedWebSocketClient
+      READ_CHUNK_BYTES = 16_384
+
+      attr_reader :url
+
+      def self.connect(url, options = {})
+        client = new
+        yield client if block_given?
+        client.connect url, options
+        client
+      end
+
+      def initialize
+        @listeners = Hash.new { |hash, event| hash[event] = [] }
+        @listeners_mutex = Mutex.new
+        @write_mutex = Mutex.new
+        # Re-entrant: a failed write inside #close closes again.
+        @close_monitor = Monitor.new
+        @handshaked = false
+        @closed = false
+      end
+
+      def on(event, &listener)
+        @listeners_mutex.synchronize { @listeners[event] << listener }
+        listener
+      end
+
+      def connect(url, options = {})
+        return if @socket
+
+        @url = url
+        @socket = open_socket(URI.parse(url), options)
+        ::WebSocket.should_raise = true
+        @handshake = ::WebSocket::Handshake::Client.new url: url, headers: options[:headers]
+
+        socket = @socket # #close clears the ivar; the reader keeps its own reference
+        @thread = Thread.new { read_loop(socket, ::WebSocket::Frame::Incoming::Client.new) }
+        write @handshake.to_s
+      end
+
+      # Commands are sent from whichever thread issues them. On a plain TCP socket one IO#write is
+      # already atomic, but OpenSSL::SSL::SSLSocket#write is not, so writes share a lock for wss://.
+      def send(data, type: :text)
+        return unless open?
+
+        write ::WebSocket::Frame::Outgoing::Client.new(data: data, type: type, version: @handshake.version).to_s
+      rescue IOError, SystemCallError, OpenSSL::SSL::SSLError => e
+        close e
+      end
+
+      # Safe from any thread, including the reader's own: the reader sees the peer hang up and
+      # closes from inside its loop, so it must neither race a caller closing at the same moment
+      # nor be killed before :close has been emitted.
+      def close(error = nil)
+        @close_monitor.synchronize do
+          return if @closed
+
+          say_goodbye unless error
+          @closed = true
+          @socket&.close
+          @socket = nil
+          emit :close, error
+          @thread.kill if @thread && @thread != Thread.current
+        end
+      end
+
+      def open? = @handshaked && !@closed
+
+      def closed? = @closed
+
+      private
+
+      def emit(event, *)
+        @listeners_mutex.synchronize { @listeners[event].dup }.each { |listener| listener.call(*) }
+      end
+
+      def write(bytes)
+        @write_mutex.synchronize { @socket&.write bytes }
+      end
+
+      def say_goodbye
+        write ::WebSocket::Frame::Outgoing::Client.new(data: nil, type: :close, version: @handshake.version).to_s if @handshaked
+      rescue IOError, SystemCallError, OpenSSL::SSL::SSLError
+        nil # the peer is already gone; there is nobody left to say goodbye to
+      end
+
+      def open_socket(uri, options)
+        tcp_socket = TCPSocket.new(uri.host, uri.port || (uri.scheme == "wss" ? 443 : 80))
+        return tcp_socket unless %w[https wss].include?(uri.scheme)
+
+        ::OpenSSL::SSL::SSLSocket.new(tcp_socket, ssl_context(options)).tap do |ssl_socket|
+          ssl_socket.sync_close = true
+          ssl_socket.hostname = uri.host
+          ssl_socket.connect
+        end
+      end
+
+      def ssl_context(options)
+        ::OpenSSL::SSL::SSLContext.new.tap do |context|
+          context.ssl_version = options[:ssl_version] if options[:ssl_version]
+          context.verify_mode = options[:verify_mode] if options[:verify_mode]
+          context.cert_store = (options[:cert_store] || ::OpenSSL::X509::Store.new).tap(&:set_default_paths)
+        end
+      end
+
+      def read_loop(socket, frame)
+        until @closed
+          begin
+            consume(socket.readpartial(READ_CHUNK_BYTES), frame)
+            # Same terminal-error list as #send/#say_goodbye - Errno::ECONNRESET is already a
+            # SystemCallError, so listing it separately was both redundant and, worse, incomplete: any
+            # *other* SystemCallError or OpenSSL::SSL::SSLError fell through to the generic rescue
+            # below, which only emits :error and loops back into readpartial - on a permanently broken
+            # socket (not just ECONNRESET) that re-raises the same error every iteration forever
+            # instead of ever closing.
+          rescue IOError, SystemCallError, OpenSSL::SSL::SSLError => e # EOFError is an IOError
+            close e
+          rescue StandardError => e
+            emit :error, e
+          end
+        end
+      end
+
+      def consume(chunk, frame)
+        if @handshaked
+          frame << chunk
+        else
+          @handshake << chunk
+          return unless @handshake.finished?
+
+          @handshaked = true
+          emit :open
+          # Anything the server sent straight after its handshake response is already in this chunk.
+          frame << @handshake.leftovers unless @handshake.leftovers.to_s.empty?
+        end
+
+        while (message = frame.next)
+          dispatch_frame(message)
+        end
+      end
+
+      # WebSocket control frames (ping/pong/close) must never reach a JSON-parsing consumer -
+      # WebSocketDispatcher tries to parse every :message payload as JSON, so a raw close frame
+      # would raise JSON::ParserError, and an unanswered ping can make chromedriver or an
+      # intermediate proxy tear down an otherwise healthy connection on its own keepalive timeout.
+      def dispatch_frame(message)
+        case message.type
+        when :ping
+          send(message.data, type: :pong)
+        when :pong
+          nil
+        when :close
+          close
+        else
+          emit :message, message
+        end
+      end
+    end
+  end
+end

data/lib/bidi2pdf/bidi/client.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
 require "json"
-require "websocket-client-simple"
-
+require_relative "buffered_web_socket_client"
 require_relative "web_socket_dispatcher"
 require_relative "command_manager"
 require_relative "connection_manager"
@@ -44,11 +43,11 @@ module Bidi2pdf
 
       # Starts the WebSocket client and establishes a connection.
       #
-      # @return [WebSocket::Client::Simple] The WebSocket connection object.
+      # @return [BufferedWebSocketClient] The WebSocket connection object.
       def start
         return @socket if started?
 
-        WebSocket::Client::Simple.connect(ws_url) do |socket|
+        BufferedWebSocketClient.connect(ws_url) do |socket|
           @socket = socket
           @command_manager = CommandManager.new(@socket)
 
@@ -62,11 +61,19 @@ module Bidi2pdf
         @socket
       end
 
-      # Checks if the WebSocket client has started.
+      # Checks if the WebSocket client has started. Unlike #open?, this never flips back to false on
+      # its own if the connection dies externally - it only reflects whether #start has run.
       #
       # @return [Boolean] True if the client has started, false otherwise.
       def started? = @started
 
+      # Checks if the underlying WebSocket connection is actually open right now - false before
+      # #start, after #close, or if the reader thread noticed the connection died on its own (a
+      # real liveness signal, not just an internal "did we ever start" flag).
+      #
+      # @return [Boolean] True if the underlying socket reports itself open.
+      def open? = !!@socket&.open?
+
       # Waits until the WebSocket connection is open.
       #
       # @param [Integer] timeout The timeout duration in seconds.

data/lib/bidi2pdf/bidi/commands/base.rb

@@ -89,6 +89,8 @@ module Bidi2pdf
             end
           when Array
             obj.map { |item| redact_sensitive_fields(item, sensitive_keys) }
+          when String
+            Bidi2pdf.truncate_for_log(obj)
           else
             obj
           end

data/lib/bidi2pdf/bidi/commands/capture_screenshot.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Bidi2pdf
+  module Bidi
+    module Commands
+      class CaptureScreenshot
+        include Base
+
+        attr_reader :context, :origin, :format, :clip
+
+        def initialize(context:, origin: "document", format: nil, clip: nil)
+          @context = context
+          @origin = origin
+          @format = format
+          @clip = clip
+        end
+
+        def method_name
+          "browsingContext.captureScreenshot"
+        end
+
+        def params
+          {
+            context: context,
+            origin: origin,
+            format: format,
+            clip: clip
+          }.compact
+        end
+      end
+    end
+  end
+end

data/lib/bidi2pdf/bidi/commands/set_viewport.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module Bidi2pdf
+  module Bidi
+    module Commands
+      class SetViewport
+        include Base
+
+        attr_reader :context, :width, :height, :device_pixel_ratio
+
+        def initialize(context:, width:, height:, device_pixel_ratio: nil)
+          @context = context
+          @width = width
+          @height = height
+          @device_pixel_ratio = device_pixel_ratio
+        end
+
+        def method_name
+          "browsingContext.setViewport"
+        end
+
+        def params
+          {
+            context: context,
+            viewport: { width: width, height: height },
+            devicePixelRatio: device_pixel_ratio
+          }.compact
+        end
+      end
+    end
+  end
+end

data/lib/bidi2pdf/bidi/commands.rb

@@ -18,6 +18,8 @@ module Bidi2pdf
       require_relative "commands/browsing_context_close"
       require_relative "commands/browsing_context_navigate"
       require_relative "commands/browsing_context_print"
+      require_relative "commands/capture_screenshot"
+      require_relative "commands/set_viewport"
       require_relative "commands/cdp_get_session"
       require_relative "commands/page_print"
       require_relative "commands/session_subscribe"

data/lib/bidi2pdf/bidi/network_event.rb

@@ -4,7 +4,7 @@ module Bidi2pdf
   module Bidi
     class NetworkEvent
       attr_reader :id, :url, :state, :start_timestamp, :end_timestamp, :timing, :http_status_code,
-                  :http_method, :bytes_received
+                  :http_method, :bytes_received, :navigation
 
       STATE_MAP = {
         "network.responseStarted" => "started",
@@ -12,7 +12,13 @@ module Bidi2pdf
         "network.fetchError" => "error"
       }.freeze
 
-      def initialize(id:, url:, timestamp:, timing:, state:, http_status_code: nil, http_method: nil)
+      # @param [String, nil] navigation The BiDi navigation ID this request belongs to - present on
+      #   the main-frame document request, letting a caller correlate a specific
+      #   browsingContext.navigate call to the network event carrying its actual HTTP status. A
+      #   sub-resource request (an image, a script, ...) has no real BiDi navigation ID and stays
+      #   nil here - #id already distinguishes one event from another in logs, so this field is
+      #   left alone rather than filled with a value the protocol never sent.
+      def initialize(id:, url:, timestamp:, timing:, state:, http_status_code: nil, http_method: nil, navigation: nil)
         @id = id
         @url = url
         @start_timestamp = timestamp
@@ -20,6 +26,7 @@ module Bidi2pdf
         @state = map_state(state)
         @http_status_code = http_status_code
         @http_method = http_method
+        @navigation = navigation
       end
 
       def update_state(new_state, timestamp: nil, timing: nil, http_status_code: nil, bytes_received: nil)
@@ -61,6 +68,7 @@ module Bidi2pdf
           "method=#{method_str.inspect}, " \
           "url=#{@url.inspect}, " \
           "state=#{@state.inspect}, " \
+          "navigation=#{@navigation.inspect}, " \
           "#{http_status}, " \
           "bytes_received=#{bytes_str}, " \
           "start=#{start_str}, " \
@@ -76,7 +84,8 @@ module Bidi2pdf
           timing: @timing&.dup,
           state: @state,
           http_status_code: @http_status_code,
-          http_method: @http_method
+          http_method: @http_method,
+          navigation: @navigation
         ).tap do |duped|
           duped.instance_variable_set(:@end_timestamp, @end_timestamp)
           duped.instance_variable_set(:@bytes_received, @bytes_received)

data/lib/bidi2pdf/bidi/network_events.rb

@@ -41,6 +41,13 @@ module Bidi2pdf
         timing = request["timings"]
         http_method = request["method"]
 
+        # A top-level sibling of "request"/"response" in BiDi's own network.BaseParameters, not
+        # nested under either - present for the main-frame document request of a navigation, nil
+        # for an unrelated sub-resource fetch (an image, a script, ...). Lets a caller correlate a
+        # specific browsingContext.navigate call to the exact network event carrying its real HTTP
+        # status, which the navigate command's own response never includes.
+        navigation = event["navigation"]
+
         timestamp = event["timestamp"]
 
         Bidi2pdf.notification_service.instrument("network_event_received.bidi2pdf",
@@ -57,7 +64,8 @@ module Bidi2pdf
               timestamp: timestamp,
               timing: timing,
               state: method,
-              http_method: http_method
+              http_method: http_method,
+              navigation: navigation
             )
           elsif events.key?(id)
             events[id].update_state(method, timestamp: timestamp, timing: timing, http_status_code: http_status_code, bytes_received: bytes_received)

data/lib/bidi2pdf/bidi/session.rb

@@ -62,7 +62,7 @@ module Bidi2pdf
         "--disable-breakpad", # Disable the Breakpad crash-reporting library entirely
         "--enable-features=PdfOopif", # Enable out-of-process iframe (OOPIF) architecture for PDF rendering
         "--disable-features=Translate,AcceptCHFrame,MediaRouter,OptimizationHints,ProcessPerSiteUpToMainFrameThreshold,IsolateSandboxedIframes",
-        "--disable-extensions about:blank"
+        "--disable-extensions" # Don't load extensions. One switch per entry: it used to read "--disable-extensions about:blank", which Chrome rejected whole ("Ignoring switch with invalid name").
       ].freeze
 
       # @return [URI] The URI of the session.

data/lib/bidi2pdf/chromedriver_manager.rb

@@ -194,13 +194,17 @@ module Bidi2pdf
       cmd.join(" ")
     end
 
+    # Chromedriver's own internal log verbosity is independent from this app's - defaults to
+    # mirroring Bidi2pdf.logger.level for backward compatibility, but Bidi2pdf.chromedriver_log_level
+    # lets a consumer quiet chromedriver's own (often much more verbose, e.g. full BiDi command/
+    # response dumps at its own INFO level) output without changing their app's own log level.
     def chromedriver_log_level
-      case Bidi2pdf.logger.level
-      when Logger::DEBUG then "ALL"
-      when Logger::INFO then "INFO"
-      when Logger::WARN then "WARNING"
-      else "SEVERE"
-      end
+      Bidi2pdf.chromedriver_log_level || case Bidi2pdf.logger.level
+                                         when Logger::DEBUG then "ALL"
+                                         when Logger::INFO then "INFO"
+                                         when Logger::WARN then "WARNING"
+                                         else "SEVERE"
+                                         end
     end
 
     def user_data_dir_arg

data/lib/bidi2pdf/cli.rb

@@ -40,6 +40,8 @@ module Bidi2pdf
     option :header, type: :array, default: [], banner: "name=value", desc: "One or more custom headers", aliases: "-H"
     option :auth, type: :string, banner: "user:pass", desc: "Basic auth credentials", aliases: "-a"
     option :headless, type: :boolean, default: true, desc: "Run Chrome in headless mode"
+    option :no_sandbox, type: :boolean, default: false, desc: "Disable Chrome sandbox (needed inside containers)"
+    option :chrome_flag, type: :array, default: [], banner: "--flag[=value]", desc: "Extra Chrome flags appended to defaults", aliases: "--cf"
     option :port, type: :numeric, default: 0, desc: "Port to run ChromeDriver on (0 = auto)"
     option :wait_window_loaded,
            type: :boolean,
@@ -114,6 +116,8 @@ module Bidi2pdf
         "url" => "https://example.com",
         "output" => "output.pdf",
         "headless" => true,
+        "no_sandbox" => false,
+        "chrome_flag" => [],
         "print_options" => {
           "background" => true,
           "orientation" => "portrait",
@@ -210,6 +214,11 @@ module Bidi2pdf
       @launcher ||= begin
                       username, password = parse_auth(merged_options[:auth]) if merged_options[:auth]
 
+                      chrome_args = Bidi2pdf::Bidi::Session::DEFAULT_CHROME_ARGS.dup
+                      no_sandbox = merged_options[:no_sandbox] || ENV["DISABLE_CHROME_SANDBOX"] == "true"
+                      chrome_args << "--no-sandbox" if no_sandbox
+                      chrome_args.concat(Array(merged_options[:chrome_flag]))
+
                       Bidi2pdf::Launcher.new(
                         url: merged_options[:url],
                         inputfile: merged_options[:hmtl_file],
@@ -223,7 +232,8 @@ module Bidi2pdf
                         wait_window_loaded: merged_options[:wait_window_loaded],
                         wait_network_idle: merged_options[:wait_network_idle],
                         print_options: print_options,
-                        network_log_format: merged_options[:network_log_format]
+                        network_log_format: merged_options[:network_log_format],
+                        chrome_args: chrome_args
                       )
                     end
     end

data/lib/bidi2pdf/launcher.rb

@@ -38,7 +38,8 @@ module Bidi2pdf
   class Launcher
     # rubocop:disable Metrics/ParameterLists
     def initialize(url:, inputfile:, output:, cookies:, headers:, auth:, headless: true, port: 0, wait_window_loaded: false,
-                   wait_network_idle: false, print_options: {}, remote_browser_url: nil, network_log_format: :console)
+                   wait_network_idle: false, print_options: {}, remote_browser_url: nil, network_log_format: :console,
+                   chrome_args: Bidi::Session::DEFAULT_CHROME_ARGS)
       @url = url
       @inputfile = inputfile
       @port = port
@@ -54,6 +55,7 @@ module Bidi2pdf
       @remote_browser_url = remote_browser_url
       @custom_session = nil
       @network_log_format = network_log_format
+      @chrome_args = chrome_args
     end
 
     # rubocop:enable Metrics/ParameterLists
@@ -84,9 +86,9 @@ module Bidi2pdf
 
     def session
       if @remote_browser_url
-        @custom_session = Bidi::Session.new(session_url: @remote_browser_url, headless: @headless)
+        @custom_session = Bidi::Session.new(session_url: @remote_browser_url, headless: @headless, chrome_args: @chrome_args)
       else
-        @manager = ChromedriverManager.new(port: @port, headless: @headless)
+        @manager = ChromedriverManager.new(port: @port, headless: @headless, chrome_args: @chrome_args)
         @manager.start
         @manager.session
       end

data/lib/bidi2pdf/notifications/logging_subscriber.rb

@@ -95,6 +95,8 @@ module Bidi2pdf
           end
         when Array
           obj.map { |item| redact_sensitive_fields(item, sensitive_keys) }
+        when String
+          Bidi2pdf.truncate_for_log(obj)
         else
           obj
         end