bidi2pdf 0.1.11 → 0.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f566dbc37d780cfb8596d673639ab1ed944cf9306107a7ff65d0712d74fd9276
-  data.tar.gz: 58273f6e806ea14372ae37f942c05582b80effe6a16cf172b965ea4f45e18108
+  metadata.gz: 50d4ec887f857a06009238d753ce6185f82afc416b54d63d38004cbc7ddc1d1f
+  data.tar.gz: 7790352b50f7f4b0af65a6ec7fb42b324430b4963f088fe909cef77c4acd2af6
 SHA512:
-  metadata.gz: 1ec28d088c92fb1d48b42a68f51613045c13ad3d115c8fcd208ea37268ccc1520bf33af1070df513eaa50001259438222af0413f378195539b3eb3e2c95ef292
-  data.tar.gz: e52a3b58e025f726d46c1a512a54e932e744181a021e3e2b3c02b6f12f5d13b8a3d3d285568ce09e98f61476c37eb2ba13cb2b1920f75f443a076931f6dd067c
+  metadata.gz: 118ea121a673b57dec8de4af3c2b95e28cd24b817a8042de91a2760fa16a004b38c94525cdd5f8acb324832d0a13f216c2a11c2d2e303fd636bf90dfa5121e05
+  data.tar.gz: a5f5ceaa9811449fb41bdccde0c9d4f5a74bf5cfb216c159874a20b4e6dcc0caf9719468c2b44e94a827b7ca12af3f80ddc40bb39d8814026791c97c49f7f768

data/CHANGELOG.md

@@ -10,6 +10,34 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 <!-- generated by git-cliff end -->
 
+## [0.1.12] - 2025-09-02
+
+### 🔄 Changed
+
+- Merge pull request #37 from dieter-medium/dependabot/bundler/main/ruby-vips-2.2.5
+- Merge pull request #34 from dieter-medium/enhance-timeout-error-handling-during-navigate
+- Merge pull request #33 from dieter-medium/dependabot/bundler/main/rubocop-1.79.2
+- Merge pull request #32 from dieter-medium/dependabot/bundler/main/rubocop-1.79.1
+- Merge pull request #31 from dieter-medium/dependabot/bundler/main/json-2.13.2
+- Merge branch 'main' into dependabot/bundler/main/json-2.13.2
+- Merge pull request #30 from dieter-medium/dependabot/bundler/main/rubocop-1.79.0
+- Merge pull request #29 from dieter-medium/remove-codeclimate
+- Merge pull request #27 from dieter-medium/dependabot/bundler/main/json-2.13.0
+- Merge branch 'main' into dependabot/bundler/main/json-2.13.0
+- Merge pull request #28 from dieter-medium/dependabot/bundler/main/thor-1.4.0
+- Merge pull request #26 from dieter-medium/dependabot/bundler/main/rubocop-1.78.0
+
+### 🔧 Build
+
+- Bump ruby-vips from 2.2.4 to 2.2.5
+- Bump rubocop from 1.77.0 to 1.79.2
+- Bump json from 2.12.2 to 2.13.2
+- Bump thor from 1.3.2 to 1.4.0
+
+### 🚀 Added
+
+- Improve navigation timeout error handling
+
 ## [0.1.11] - 2025-07-09
 
 ### 🐛 Fixed

data/README.md

@@ -1,7 +1,6 @@
 [![Build Status](https://github.com/dieter-medium/bidi2pdf/actions/workflows/ruby.yml/badge.svg)](https://github.com/dieter-medium/bidi2pdf/blob/main/.github/workflows/ruby.yml)
 [![Maintainability](https://api.codeclimate.com/v1/badges/6425d9893aa3a9ca243e/maintainability)](https://codeclimate.com/github/dieter-medium/bidi2pdf/maintainability)
 [![Gem Version](https://badge.fury.io/rb/bidi2pdf.svg)](https://badge.fury.io/rb/bidi2pdf)
-[![Test Coverage](https://api.codeclimate.com/v1/badges/6425d9893aa3a9ca243e/test_coverage)](https://codeclimate.com/github/dieter-medium/bidi2pdf/test_coverage)
 [![Open Source Helpers](https://www.codetriage.com/dieter-medium/bidi2pdf/badges/users.svg)](https://www.codetriage.com/dieter-medium/bidi2pdf)
 
 ---

data/lib/bidi2pdf/bidi/browser_tab.rb

@@ -172,7 +172,7 @@ module Bidi2pdf
       # @raise [NavigationError] If the URL is invalid or improperly formatted.
       # @example
       #   browser_tab.navigate_to("https://example.com")
-      def navigate_to(url)
+      def navigate_to(url, wait: "complete")
         begin
           URI.parse(url)
         rescue URI::InvalidURIError => e
@@ -180,14 +180,15 @@ module Bidi2pdf
         end
 
         Bidi2pdf.notification_service.instrument("navigate_to.bidi2pdf", url: url) do
-          navigate_with_listeners url
+          navigate_with_listeners url, wait: wait
         end
       end
 
       # Renders HTML content in the browser tab.
       #
       # @param [String] html_content The HTML content to render.
-      def render_html_content(html_content)
+      # rubocop:disable  Metrics/BlockLength
+      def render_html_content(html_content, wait: "complete")
         Bidi2pdf.notification_service.instrument("render_html_content.bidi2pdf", url: "data:text/html") do |instrumentation_payload|
           base64_encoded = Base64.strict_encode64(html_content)
 
@@ -195,10 +196,51 @@ module Bidi2pdf
 
           data_url = "data:text/html;charset=utf-8;base64,#{base64_encoded}"
 
-          navigate_with_listeners data_url
+          begin
+            navigate_with_listeners data_url, wait: wait
+          rescue Bidi2pdf::CmdTimeoutError
+            Bidi2pdf.logger.info "Waiting for page to load seemed to have timed out. Checking if page is ready via javascript..."
+
+            # check if the page is still loading
+            execute_script <<~JS, wrap_in_promise: false
+              const desiredState = "interactive";#{" "}
+              const timeoutMs = 30000;#{"        "}
+              const intervalMs = 50;
+
+              result = new Promise((resolveReady, rejectReady) => {
+                const start = Date.now();
+
+                const reachedDesired = (state) =>
+                  desiredState === "interactive"
+                    ? state === "interactive" || state === "complete"
+                    : state === "complete";
+
+                const check = () => {
+                  const state = document.readyState;
+                  if (reachedDesired(state)) {
+                    resolveReady(state); // resolves to "interactive" or "complete"
+                    return;
+                  }
+                  if (Date.now() - start >= timeoutMs) {
+                    rejectReady(new Error(`Timeout waiting for document.readyState="${desiredState}". Last state="${state}".`));
+                    return;
+                  }
+
+                  console.warn(`Waiting for document.readyState="${desiredState}". Last state="${state}".`);
+
+                  setTimeout(check, intervalMs);
+                };
+
+                // Immediate check in case the page is already loaded
+                check();
+              });
+            JS
+          end
         end
       end
 
+      # rubocop:enable  Metrics/BlockLength
+
       # Executes a script in the browser tab.
       #
       # This method allows you to execute JavaScript code within the context of the browser tab.
@@ -434,10 +476,10 @@ module Bidi2pdf
                          end
       end
 
-      def navigate_with_listeners(url)
+      def navigate_with_listeners(url, wait: "complete")
         register_event_listeners
 
-        cmd = Bidi2pdf::Bidi::Commands::BrowsingContextNavigate.new url: url, context: browsing_context_id
+        cmd = Bidi2pdf::Bidi::Commands::BrowsingContextNavigate.new url: url, context: browsing_context_id, wait: wait
 
         client.send_cmd_and_wait(cmd) do |response|
           Bidi2pdf.logger.debug "Navigated to page url: #{url} response: #{response}"

data/lib/bidi2pdf/test_helpers/pdf_text_sanitizer.rb

@@ -32,8 +32,8 @@ module Bidi2pdf
           text.gsub("\uFB01", "fi")
               .gsub("\uFB02", "fl")
               .gsub("-\n", "")
-              .gsub(/["]/, '"')
-              .gsub(/[']/, "'")
+              .gsub('"', '"')
+              .gsub("'", "'")
               .gsub("…", "...")
               .gsub("—", "--")
               .gsub("–", "-")

data/lib/bidi2pdf/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bidi2pdf
-  VERSION = "0.1.11"
+  VERSION = "0.1.12"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bidi2pdf
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 0.1.12
 platform: ruby
 authors:
 - Dieter S.