bicho 0.0.8 → 0.0.9

data/Gemfile

@@ -1,4 +1,4 @@
-source "http://rubygems.org"
+source 'http://rubygems.org'
 
 # Specify your gem's dependencies in bicho.gemspec
 gemspec

data/README.rdoc

@@ -29,6 +29,8 @@ Plugins can be written to deal with specific bugzilla installations.
     server.get_bugs(127043).each do |bug|
       puts bug.summary
       puts bug.url
+
+      puts bug.history
     end
 
 You can give more than one bug or a named query, or both:
@@ -46,13 +48,13 @@ to set the Bicho common client:
 
     Bicho.client = Bicho::Client.new('https://bugzilla.gnome.org')
 
-    Bicho::Bug.where(:product => "vala", :status => "resolved").each do |bug|
+    Bicho::Bug.where(product: 'vala', status: 'resolved').each do |bug|
       # .. do something with bug
     end
 
     Or alternatively:
 
-    Bicho::Bug.where.product("vala").status("resolved").each do |bug|
+    Bicho::Bug.where.product('vala').status('resolved').each do |bug|
       # .. do something with bug
     end
 
@@ -60,6 +62,8 @@ to set the Bicho common client:
 
     bicho -b http://bugzilla.gnome.org show 127043
 
+    bicho -b http://bugzilla.gnome.org history 127043
+
     bicho -b https://bugzilla.gnome.org search --summary "crash"
 
     bicho -b https://bugzilla.gnome.org search --help

data/Rakefile

@@ -1,11 +1,11 @@
-$:.push(File.join(File.dirname(__FILE__), 'lib'))
+$LOAD_PATH.push(File.join(File.dirname(__FILE__), 'lib'))
 require 'bundler/gem_tasks'
 require 'bicho/version'
 require 'rake/testtask'
 
 extra_docs = ['README*', 'TODO*', 'CHANGELOG*']
 
-task :default => [:test]
+task default: [:test]
 
 Rake::TestTask.new do |t|
   t.libs << File.expand_path('../test', __FILE__)
@@ -15,17 +15,17 @@ Rake::TestTask.new do |t|
 end
 
 begin
- require 'yard'
+  require 'yard'
   YARD::Rake::YardocTask.new(:doc) do |t|
     t.files   = ['lib/**/*.rb', *extra_docs]
     t.options = ['--no-private']
   end
-rescue LoadError
-  STDERR.puts "Install yard if you want prettier docs"
-  require 'rdoc/task'
-  Rake::RDocTask.new(:doc) do |rdoc|
-    rdoc.rdoc_dir = "doc"
-    rdoc.title = "bicho #{Bicho::VERSION}"
-    extra_docs.each { |ex| rdoc.rdoc_files.include ex }
-  end
+ rescue LoadError
+   STDERR.puts 'Install yard if you want prettier docs'
+   require 'rdoc/task'
+   Rake::RDocTask.new(:doc) do |rdoc|
+     rdoc.rdoc_dir = 'doc'
+     rdoc.title = "bicho #{Bicho::VERSION}"
+     extra_docs.each { |ex| rdoc.rdoc_files.include ex }
+   end
 end

data/bicho.gemspec

@@ -1,26 +1,25 @@
 # -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
-require "bicho/version"
+$LOAD_PATH.push File.expand_path('../lib', __FILE__)
+require 'bicho/version'
 
 Gem::Specification.new do |s|
-  s.name        = "bicho"
+  s.name        = 'bicho'
   s.version     = Bicho::VERSION
-  s.authors     = ["Duncan Mac-Vicar P."]
-  s.email       = ["dmacvicar@suse.de"]
-  s.homepage    = "http://github.com/dmacvicar/bicho"
-  s.summary     = %q{Library to access bugzilla}
-  s.description = %q{Library to access bugzilla}
+  s.authors     = ['Duncan Mac-Vicar P.']
+  s.email       = ['dmacvicar@suse.de']
+  s.homepage    = 'http://github.com/dmacvicar/bicho'
+  s.summary     = 'Library to access bugzilla'
+  s.description = 'Library to access bugzilla'
 
-  s.add_dependency("inifile", ["~> 0.4.1"])
-  s.add_dependency("trollop", [">= 1.16"])
-  s.add_dependency("highline", ["~> 1.6.2"])
-  s.add_dependency("nokogiri")
+  s.add_dependency('inifile', ['~> 0.4.1'])
+  s.add_dependency('trollop', ['>= 1.16'])
+  s.add_dependency('highline', ['~> 1.6.2'])
+  s.add_dependency('nokogiri')
 
-
-  s.rubyforge_project = "bicho"
+  s.rubyforge_project = 'bicho'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ["lib"]
+  s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
+  s.require_paths = ['lib']
 end

data/bin/bicho

@@ -23,17 +23,20 @@
 # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
-$:.push(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.push(File.join(File.dirname(__FILE__), '..', 'lib'))
 require 'bicho'
 require 'highline/import'
 
 # Set the console color scheme
 ft = HighLine::ColorScheme.new do |cs|
-  cs[:headline]        = [ :bold ]
-  cs[:horizontal_line] = [ :bold, :white ]
-  cs[:even_row]        = [ :green ]
-  cs[:odd_row]         = [ :magenta ]
-  cs[:error]           = [ :red ]
+  cs[:headline]        = [:bold]
+  cs[:horizontal_line] = [:bold, :white]
+  cs[:even_row]        = [:green]
+  cs[:odd_row]         = [:magenta]
+  cs[:error]           = [:red]
+  cs[:remove]           = [ :red ]
+  cs[:add]           = [ :green ]
+  cs[:changeset]           = [ :blue ]
 end
 
 HighLine.color_scheme = ft
@@ -57,15 +60,15 @@ begin
   # symbols in BzConsole module
   SUB_COMMANDS = Bicho::CLI::Commands.constants.sort.map(&:to_s).map(&:downcase)
 
-  global_opts = Trollop::options do
+  global_opts = Trollop.options do
     banner <<-EOS
     Usage: #{File.basename(__FILE__)} [global options] <command> ...
 
     Bugzilla url can be given as https://bugs.kde.org or bko
 EOS
-    opt :config, "Read FILE as configuration file.", :type => :io
-    opt :debug, "Show debug messages", :default => false
-    opt :bugzilla, "Bugzilla URL or alias", :default => 'bnz'
+    opt :config, 'Read FILE as configuration file.', type: :io
+    opt :debug, 'Show debug messages', default: false
+    opt :bugzilla, 'Bugzilla URL or alias', default: 'bnz'
     stop_on SUB_COMMANDS
   end
 
@@ -74,8 +77,8 @@ EOS
   # get the subcommand
   cmd = ARGV.shift rescue nil
 
-  if (!cmd || !SUB_COMMANDS.include?(cmd))
-    Trollop.die "available subcommands: #{SUB_COMMANDS.join(" ")}"
+  if !cmd || !SUB_COMMANDS.include?(cmd)
+    Trollop.die "available subcommands: #{SUB_COMMANDS.join(' ')}"
   end
 
   # Create an instance for the command

data/lib/bicho.rb

@@ -30,32 +30,30 @@ require 'bicho/client'
 require 'bicho/bug'
 
 module Bicho
-
   SEARCH_FIELDS = [
     # name, type, description, multi
-    [ :alias, :strings, "The unique alias for this bug", true],
-    [ :assigned_to, :strings, "The login name of a user that a bug is assigned to.", true],
-    [ :component, :strings, "The name of the Component", true],
-    [ :creation_time, :string, "Searches for bugs that were created at this time or later.", false],
-    [ :id, :ints, "The numeric id of the bug.", true],
-    [ :last_change_time, :string, "Searches for bugs that were modified at this time or later.", false],
-    [ :limit, :ints, "Limit the number of results returned to int records.", true],
-    [ :offset, :ints, "Used in conjunction with the limit argument, offset defines the starting position for the search.", true],
-    [ :op_sys, :strings, "The 'Operating System' field of a bug.", true],
-    [ :platform, :strings, "The Platform field of a bug.", true],
-    [ :priority, :strings, "The Priority field on a bug.", true],
-    [ :product, :strings, "The name of the Product that the bug is in.", true],
-    [ :reporter, :strings, "The login name of the user who reported the bug.", true],
-    [ :resolution, :strings, "The current resolution--only set if a bug is closed.", true],
-    [ :severity, :strings, "The Severity field on a bug.", true],
-    [ :status, :strings, "The current status of a bug", true],
-    [ :summary, :strings, "Searches for substrings in the single-line Summary field on bugs.", true],
-    [ :target_milestone, :strings, "The Target Milestone field of a bug.", true],
-    [ :qa_contact, :strings, "The login name of the bug's QA Contact.", true],
-    [ :url, :strings, "The 'URL' field of a bug.", true],
-    [ :version, :strings, "The Version field of a bug.", true],
-    [ :votes, :ints, "Searches for bugs with this many votes or greater", false],
-    [ :whiteboard, :strings, "Search the 'Status Whiteboard' field on bugs for a substring.", true]
+    [:alias, :strings, 'The unique alias for this bug', true],
+    [:assigned_to, :strings, 'The login name of a user that a bug is assigned to.', true],
+    [:component, :strings, 'The name of the Component', true],
+    [:creation_time, :string, 'Searches for bugs that were created at this time or later.', false],
+    [:id, :ints, 'The numeric id of the bug.', true],
+    [:last_change_time, :string, 'Searches for bugs that were modified at this time or later.', false],
+    [:limit, :ints, 'Limit the number of results returned to int records.', true],
+    [:offset, :ints, 'Used in conjunction with the limit argument, offset defines the starting position for the search.', true],
+    [:op_sys, :strings, "The 'Operating System' field of a bug.", true],
+    [:platform, :strings, 'The Platform field of a bug.', true],
+    [:priority, :strings, 'The Priority field on a bug.', true],
+    [:product, :strings, 'The name of the Product that the bug is in.', true],
+    [:reporter, :strings, 'The login name of the user who reported the bug.', true],
+    [:resolution, :strings, 'The current resolution--only set if a bug is closed.', true],
+    [:severity, :strings, 'The Severity field on a bug.', true],
+    [:status, :strings, 'The current status of a bug', true],
+    [:summary, :strings, 'Searches for substrings in the single-line Summary field on bugs.', true],
+    [:target_milestone, :strings, 'The Target Milestone field of a bug.', true],
+    [:qa_contact, :strings, "The login name of the bug's QA Contact.", true],
+    [:url, :strings, "The 'URL' field of a bug.", true],
+    [:version, :strings, 'The Version field of a bug.', true],
+    [:votes, :ints, 'Searches for bugs with this many votes or greater', false],
+    [:whiteboard, :strings, "Search the 'Status Whiteboard' field on bugs for a substring.", true]
   ]
-
 end

data/lib/bicho/bug.rb

@@ -1,9 +1,7 @@
 require 'bicho/query'
 
 module Bicho
-
   class Bug
-
     # ActiveRecord like interface
     #
     # @example Searching for bugs
@@ -43,8 +41,8 @@ module Bicho
     #
     # @see http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/WebService/Bug.html#search bugzilla search API and allowed attributes
     #
-    def self.where(conditions={})
-      return Query.new(conditions)
+    def self.where(conditions = {})
+      Query.new(conditions)
     end
 
     # Normally you will not use this constructor as
@@ -57,7 +55,7 @@ module Bicho
       @data = data
     end
 
-    def method_missing(name, *args)
+    def method_missing(name, *_args)
       @data[name.to_s]
     end
 
@@ -71,7 +69,7 @@ module Bicho
       "##{id} - #{summary} (#{url})"
     end
 
-    def [] name, subname = nil
+    def [](name, subname = nil)
       v = @data[name.to_s]
       v = v[subname.to_s] if subname # for 'internals' properties
       v
@@ -83,6 +81,10 @@ module Bicho
       "#{@client.site_url}/#{id}"
     end
 
-  end
+    # @return [History] history for this bug
+    def history
+      @client.get_history(id).first
+    end
 
+  end
 end

data/lib/bicho/cli/command.rb

@@ -27,9 +27,7 @@ require 'trollop'
 require 'highline'
 
 module Bicho
-
   module CLI
-
     # Bicho allows to easily add commands to the
     # command line interface.
     #
@@ -55,7 +53,6 @@ module Bicho
     # </tt>
     #
     class Command
-
       include ::Bicho::Logging
 
       class << self; attr_accessor :parser end
@@ -68,8 +65,8 @@ module Bicho
 
       # Gateway to Trollop
       def self.opt(*args)
-        self.parser = Trollop::Parser.new if not self.parser
-        self.parser.opt(*args)
+        self.parser = Trollop::Parser.new unless parser
+        parser.opt(*args)
       end
 
       # DSL method to describe a command's option
@@ -80,8 +77,8 @@ module Bicho
       # Called by the cli to get the options
       # with current ARGV
       def parse_options
-        self.class.parser = Trollop::Parser.new if not self.class.parser
-        opts = Trollop::with_standard_exception_handling(self.class.parser) do
+        self.class.parser = Trollop::Parser.new unless self.class.parser
+        opts = Trollop.with_standard_exception_handling(self.class.parser) do
           o = self.class.parser.parse ARGV
         end
       end
@@ -90,10 +87,9 @@ module Bicho
         self.class.parser
       end
 
-      def do(opts, args)
-        raise RuntimeError, "No implementation for #{self.class}" if self.class =~ /CommandTemplate/
+      def do(_opts, _args)
+        fail RuntimeError, "No implementation for #{self.class}" if self.class =~ /CommandTemplate/
       end
-
     end
   end
 end

data/lib/bicho/cli/commands/history.rb

@@ -0,0 +1,53 @@
+#--
+# Copyright (c) 2011 SUSE LINUX Products GmbH
+#
+# Author: Duncan Mac-Vicar P. <dmacvicar@suse.de>
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+#++
+
+require 'bicho/cli/command'
+require 'bicho/client'
+require 'pp'
+
+module Bicho::CLI::Commands
+  # command that shows the history colored as a
+  # changelog
+  class History < ::Bicho::CLI::Command
+
+    def do(global_opts, _opts, args)
+      client = ::Bicho::Client.new(global_opts[:bugzilla])
+      client.get_history(*args).each do |history|
+        t.say("#{t.color(history.bug_id.to_s, :headline)} #{history.bug.summary}")
+        history.changesets.each do |cs|
+          text = "  #{cs.date} - #{cs.who}"
+          t.say(t.color(text, :changeset))
+          cs.changes.each do |change|
+            text = "    - #{change.field_name} = #{change.removed}"
+            t.say(t.color(text, :remove))
+            text = "    + #{change.field_name} = #{change.added}"
+            t.say(t.color(text, :add))
+          end
+        end
+      end
+      0
+    end
+  end
+end

data/lib/bicho/cli/commands/search.rb

@@ -34,18 +34,18 @@ module Bicho::CLI::Commands
     options do
       # add all fields as command line options of this command
       Bicho::SEARCH_FIELDS.each do |field|
-        opt field[0], field[2], :type => field[1], :multi => field[3]
+        opt field[0], field[2], type: field[1], multi: field[3]
       end
     end
 
-    def do(global_opts, opts, args)
+    def do(global_opts, opts, _args)
       server = ::Bicho::Client.new(global_opts[:bugzilla])
       # for most parameter we accept arrays, and also multi mode
       # this means parameters come in arrays of arrays
       query = ::Bicho::Query.new
-      opts.each do |n,v|
+      opts.each do |n, v|
         # skip any option that is not part of SEARCH_FIELDS
-        next if not Bicho::SEARCH_FIELDS.map { |x| x[0] }.include?(n)
+        next unless Bicho::SEARCH_FIELDS.map { |x| x[0] }.include?(n)
         next if v.nil? || v.flatten.empty?
         v.flatten.each do |single_val|
           query.send(n.to_sym, single_val)
@@ -53,10 +53,9 @@ module Bicho::CLI::Commands
       end
 
       server.search_bugs(query).each do |bug|
-        t.say("#{t.color(bug.id, :headline)} #{bug.summary}")
+        t.say("#{t.color(bug.id.to_s, :headline)} #{bug.summary}")
       end
-      return 0
+      0
     end
-
   end
 end

data/lib/bicho/cli/commands/show.rb

@@ -31,13 +31,12 @@ module Bicho::CLI::Commands
     options do
     end
 
-    def do(global_opts, opts, args)
+    def do(global_opts, _opts, args)
       client = ::Bicho::Client.new(global_opts[:bugzilla])
       client.get_bugs(*args).each do |bug|
         t.say("#{t.color(bug.id.to_s, :headline)} #{bug.summary}")
       end
-      return 0
+      0
     end
-
   end
 end

data/lib/bicho/client.rb

@@ -30,6 +30,7 @@ require 'net/https'
 require 'cgi'
 
 require 'bicho/bug'
+require 'bicho/history'
 require 'bicho/query'
 require 'bicho/logging'
 
@@ -48,18 +49,16 @@ end
 # @private
 class XMLRPC::Client
   def set_debug
-    @http.set_debug_output(Bicho::LoggerIODevice.new);
+    @http.set_debug_output(Bicho::LoggerIODevice.new)
   end
 end
 
 module Bicho
-
   module Plugins
   end
 
   # Client to query bugzilla
   class Client
-
     include Bicho::Logging
 
     # @return [URI] XML-RPC API end-point
@@ -85,15 +84,15 @@ module Bicho
     # Implemented only to warn users about the replacement
     # APIs
     def url
-      warn "url is deprecated. Use site_url or api_url"
-      raise NoMethodError
+      warn 'url is deprecated. Use site_url or api_url'
+      fail NoMethodError
     end
 
     # @param [String] site_url Bugzilla installation site url
     def initialize(site_url)
       # Don't modify the original url
-      @site_url = site_url.is_a?(URI) ? site_url.clone : URI.parse(site_url) 
-      
+      @site_url = site_url.is_a?(URI) ? site_url.clone : URI.parse(site_url)
+
       @api_url = @site_url.clone
       @api_url.path = '/xmlrpc.cgi'
 
@@ -104,7 +103,7 @@ module Bicho
         load plugin
       end
 
-      #instantiate plugins
+      # instantiate plugins
       ::Bicho::Plugins.constants.each do |cnt|
         pl_class = ::Bicho::Plugins.const_get(cnt)
         pl_instance = pl_class.new
@@ -121,7 +120,7 @@ module Bicho
 
       # User.login sets the credentials cookie for subsequent calls
       if @client.user && @client.password
-        ret = @client.call("User.login", { 'login' => @client.user, 'password' => @client.password, 'remember' => 0 } )
+        ret = @client.call('User.login',  'login' => @client.user, 'password' => @client.password, 'remember' => 0)
         handle_faults(ret)
         @userid = ret['id']
       end
@@ -132,7 +131,7 @@ module Bicho
     end
 
     def handle_faults(ret)
-      if ret.has_key?('faults')
+      if ret.key?('faults')
         ret['faults'].each do |fault|
           logger.error fault
         end
@@ -149,7 +148,7 @@ module Bicho
       # allow plain strings to be passed, interpretting them
       query = Query.new.summary(query) if query.is_a?(String)
 
-      ret = @client.call("Bug.search", query.query_map)
+      ret = @client.call('Bug.search', query.query_map)
       handle_faults(ret)
       bugs = []
       ret['bugs'].each do |bug_data|
@@ -173,14 +172,14 @@ module Bicho
     # @private
     # @returns [Array<String>] list of bugs
     def fetch_named_query_url(url, redirects_left)
-      if not @userid
-        raise "You need to be authenticated to use named queries"
+      unless @userid
+        fail 'You need to be authenticated to use named queries'
       end
       http = Net::HTTP.new(@api_url.host, @api_url.port)
       http.set_debug_output(Bicho::LoggerIODevice.new)
       http.verify_mode = OpenSSL::SSL::VERIFY_NONE
       http.use_ssl = (@api_url.scheme == 'https')
-      #request = Net::HTTP::Get.new(url.request_uri, {'Cookie' => self.cookie})
+      # request = Net::HTTP::Get.new(url.request_uri, {'Cookie' => self.cookie})
       request = Net::HTTP::Get.new(url.request_uri)
       request.basic_auth @api_url.user, @api_url.password
       response = http.request(request)
@@ -189,9 +188,9 @@ module Bicho
         bugs = []
         begin
           xml = Nokogiri::XML.parse(response.body)
-          xml.root.xpath("//xmlns:entry/xmlns:link/@href", xml.root.namespace).each do |attr|
+          xml.root.xpath('//xmlns:entry/xmlns:link/@href', xml.root.namespace).each do |attr|
             uri = URI.parse attr.value
-            bugs << uri.query.split("=")[1]
+            bugs << uri.query.split('=')[1]
           end
           return bugs
         rescue Nokogiri::XML::XPath::SyntaxError
@@ -200,19 +199,26 @@ module Bicho
       when Net::HTTPRedirection
         location = response['location']
         if (redirects_left == 0)
-          raise "Maximum redirects exceeded (redirected to #{location})"
+          fail "Maximum redirects exceeded (redirected to #{location})"
         end
         new_location_uri = URI.parse(location)
         logger.debug("Moved to #{new_location_uri}")
         fetch_named_query_url(new_location_uri, redirects_left - 1)
       else
-        raise "Error when expanding named query '#{url.request_uri}': #{response}"
+        fail "Error when expanding named query '#{url.request_uri}': #{response}"
       end
     end
 
+    # Gets a single bug
+    # @return [Bug] a single bug by id
+    def get_bug(id)
+      get_bugs(id).first
+    end
+
     # Retrieves one or more bugs by id
+    # @return [Array<Bug>] a list of bugs
     def get_bugs(*ids)
-      params = Hash.new
+      params = {}
       params[:ids] = ids.collect(&:to_s).map do |what|
         if what =~ /^[0-9]+$/
           next what.to_i
@@ -222,7 +228,7 @@ module Bicho
       end.flatten
 
       bugs = []
-      ret = @client.call("Bug.get", params)
+      ret = @client.call('Bug.get', params)
       handle_faults(ret)
       ret['bugs'].each do |bug_data|
         bugs << Bug.new(self, bug_data)
@@ -230,5 +236,25 @@ module Bicho
       bugs
     end
 
+    # @return [Array<History>] the history of the given bugs
+    def get_history(*ids)
+      params = {}
+      params[:ids] = ids.collect(&:to_s).map do |what|
+        if what =~ /^[0-9]+$/
+          next what.to_i
+        else
+          next expand_named_query(what)
+        end
+      end.flatten
+
+      histories = []
+      ret = @client.call("Bug.history", params)
+      handle_faults(ret)
+      ret['bugs'].each do |history_data|
+        histories << History.new(self, history_data)
+      end
+      histories
+    end
+
   end
 end

data/lib/bicho/common_client.rb

@@ -30,12 +30,12 @@ module Bicho
   # API by allowing to set a default [Client]
   # to make operations.
   module CommonClient
-    def self.common_client=(client)
-      @common_client = client
+    class << self
+      attr_writer :common_client
     end
 
     def self.common_client
-      @common_client || (raise "No common client set")
+      @common_client || (fail 'No common client set')
     end
 
     def common_client
@@ -53,5 +53,4 @@ module Bicho
   def self.client
     CommonClient.common_client
   end
-
 end

data/lib/bicho/ext/logger_colors.rb

@@ -26,22 +26,22 @@ class Logger
     WHITE        = '1;37'
 
     SCHEMA = {
-      STDOUT => %w[nothing green brown red purple cyan],
-      STDERR => %w[nothing green yellow light_red light_purple light_cyan],
+      STDOUT => %w(nothing green brown red purple cyan),
+      STDERR => %w(nothing green yellow light_red light_purple light_cyan)
     }
   end
 end
 
 class Logger
-  alias format_message_colorless format_message
+  alias_method :format_message_colorless, :format_message
 
   def format_message(level, *args)
     if Logger::Colors::SCHEMA[@logdev.dev]
       color = begin
         Logger::Colors.const_get \
-          Logger::Colors::SCHEMA[@logdev.dev][Logger.const_get(level.sub "ANY","UNKNOWN")].to_s.upcase
+          Logger::Colors::SCHEMA[@logdev.dev][Logger.const_get(level.sub 'ANY', 'UNKNOWN')].to_s.upcase
       rescue NameError
-        "0;0"
+        '0;0'
       end
       "\e[#{ color }m#{ format_message_colorless(level, *args) }\e[0;0m"
     else

data/lib/bicho/history.rb

@@ -0,0 +1,139 @@
+#--
+# Copyright (c) 2011 SUSE LINUX Products GmbH
+#
+# Author: Duncan Mac-Vicar P. <dmacvicar@suse.de>
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+#++
+require 'stringio'
+
+module Bicho
+  class Change
+    def field_name
+      @data['field_name']
+    end
+
+    def removed
+      @data['removed']
+    end
+
+    def added
+      @data['added']
+    end
+
+    def to_s
+      buffer = StringIO.new
+      buffer << "- #{field_name} = #{removed}\n"
+      buffer << "+ #{field_name} = #{added}"
+      buffer.string
+    end
+
+    def initialize(client, data)
+      @client = client
+      @data = data
+    end
+  end
+
+  class ChangeSet
+    # return [Date] The date the bug activity/change happened.
+    def date
+      @data['when'].to_date
+    end
+
+    # @return [String] The login name of the user who performed the bug change
+    def who
+      @data['who']
+    end
+
+    # @return [Array<Change>] list of changes, with details of what changed
+    def changes
+      @data['changes'].map do |change|
+        Change.new(@client, change)
+      end
+    end
+
+    def initialize(client, data)
+      @client = client
+      @data = data
+    end
+
+    def to_s
+      buffer = StringIO.new
+      buffer << "#{date}- #{who}\n"
+      changes.each do |diff|
+        buffer << "#{diff}\n"
+      end
+      buffer.string
+    end
+  end
+
+  # A collection of Changesets associated with a bug
+  class History
+    include Enumerable
+
+    # iterate over each changeset
+    def each
+      changesets.each
+    end
+
+    # @return [Fixnum] number of changesets
+    def size
+      changesets.size
+    end
+
+    # @return [Boolean] true when there are no changesets
+    def empty?
+      changesets.empty?
+    end
+
+    def initialize(client, data)
+      @client = client
+      @data = data
+    end
+
+    def bug_id
+      @data['id']
+    end
+
+    # @return [String] The numeric id of the bug
+    def bug
+      unless @bug
+        @bug = @client.get_bug(@data['id'])
+      end
+      @bug
+    end
+
+    # @return [Array<ChangeSet>] collection of changesets
+    def changesets
+      @data['history'].map do |changeset|
+        ChangeSet.new(@client, changeset)
+      end
+    end
+
+    def to_s
+      buffer = StringIO.new
+      buffer << "#{bug_id}\n"
+      change_sets.each do |cs|
+        buffer << "#{cs}\n"
+      end
+      buffer.string
+    end
+  end
+end

data/lib/bicho/logging.rb

@@ -27,9 +27,8 @@ require 'bicho/ext/logger_colors'
 
 module Bicho
   module Logging
-
-    def self.logger=(logger)
-      @logger = logger
+    class << self
+      attr_writer :logger
     end
 
     def self.logger
@@ -39,6 +38,5 @@ module Bicho
     def logger
       Logging.logger
     end
-
   end
 end

data/lib/bicho/plugins/novell.rb

@@ -1,6 +1,6 @@
 #--
 # Copyright (c) 2011 SUSE LINUX Products GmbH
-# => 
+# =>
 # Author: Duncan Mac-Vicar P. <dmacvicar@suse.de>
 #
 # Permission is hereby granted, free of charge, to any person obtaining
@@ -27,7 +27,6 @@ require 'uri'
 
 module Bicho
   module Plugins
-
     # Novell bugzilla is behind ichain
     #
     # Plugin that rewrites the bugzilla API url
@@ -38,12 +37,11 @@ module Bicho
     # your oscrc.
     #
     class Novell
-
-      OSCRC_CREDENTIALS = "https://api.opensuse.org"
+      OSCRC_CREDENTIALS = 'https://api.opensuse.org'
       DEFAULT_OSCRC_PATH = File.join(ENV['HOME'], '.oscrc')
 
-      def self.oscrc_path=(path)
-        @oscrc_path = path
+      class << self
+        attr_writer :oscrc_path
       end
 
       def self.oscrc_path
@@ -57,21 +55,21 @@ module Bicho
       def self.oscrc_credentials
         oscrc = IniFile.load(oscrc_path)
         urls = [OSCRC_CREDENTIALS]
-        urls << "#{OSCRC_CREDENTIALS}/" if not OSCRC_CREDENTIALS.end_with?('/')
+        urls << "#{OSCRC_CREDENTIALS}/" unless OSCRC_CREDENTIALS.end_with?('/')
         urls.each do |section|
-          next if not oscrc.has_section?(section)
+          next unless oscrc.has_section?(section)
           user = oscrc[section]['user']
           pass = oscrc[section]['pass']
           if user && pass
-            return {:user => user, :password => pass}
+            return { user: user, password: pass }
           end
         end
-        raise "No valid .oscrc credentials for Novell/SUSE bugzilla (#{oscrc_path})"
+        fail "No valid .oscrc credentials for Novell/SUSE bugzilla (#{oscrc_path})"
       end
 
       def transform_api_url_hook(url, logger)
         domains = ['bugzilla.novell.com', 'bugzilla.suse.com']
-        return url unless domains.map {|domain| url.host.include?(domain)}.any?
+        return url unless domains.map { |domain| url.host.include?(domain) }.any?
 
         auth = Novell.oscrc_credentials
 
@@ -82,10 +80,9 @@ module Bicho
         url.host = url.host.gsub(/bugzilla\.suse.com/, 'apibugzilla.novell.com')
         url.scheme = 'https'
 
-        logger.debug("#{self} : Rewrote url to '#{url.to_s.gsub(/#{url.user}:#{url.password}/, "USER:PASS")}'")
-        return url
+        logger.debug("#{self} : Rewrote url to '#{url.to_s.gsub(/#{url.user}:#{url.password}/, 'USER:PASS')}'")
+        url
       end
-
     end
   end
 end

data/lib/bicho/query.rb

@@ -25,13 +25,11 @@
 require 'bicho/common_client'
 
 module Bicho
-
   # Represents a bug search to the server and it can
   # be configured with all bug attributes.
   #
   #
   class Query
-
     include Enumerable
 
     # Iterates through the result of the current query.
@@ -41,7 +39,7 @@ module Bicho
     # @yield [Bicho::Bug]
     def each
       ret = Bicho.client.search_bugs(self)
-      return ret.each if not block_given?
+      return ret.each unless block_given?
       ret.each { |bug| yield bug }
      end
 
@@ -57,7 +55,7 @@ module Bicho
     # @example using chainable methods:
     #   q = Query.new.assigned_to("foo@bar.com@).summary("some text")
     #
-    def initialize(conditions={})
+    def initialize(conditions = {})
       @query_map = conditions
     end
 
@@ -79,11 +77,12 @@ module Bicho
     # Shortcut, equivalent to
     #   :summary => "L3"
     def L3
-      append_query("summary", "L3")
+      append_query('summary', 'L3')
       self
     end
 
     private
+
     # Appends a parameter to the query map
     #
     # Only used internally.
@@ -93,12 +92,10 @@ module Bicho
     #
     # @private
     def append_query(param, value)
-      if not @query_map.has_key?(param)
-        @query_map[param] = Array.new
+      unless @query_map.key?(param)
+        @query_map[param] = []
       end
       @query_map[param] = [@query_map[param], value].flatten
     end
-
   end
-
 end

data/lib/bicho/version.rb

@@ -1,3 +1,3 @@
 module Bicho
-  VERSION = '0.0.8'
+  VERSION = '0.0.9'
 end

data/test/helper.rb

@@ -1,9 +1,8 @@
-$: << File.join(File.dirname(__FILE__), "..", "lib")
+$LOAD_PATH << File.join(File.dirname(__FILE__), '..', 'lib')
 require 'test/unit'
 require 'bicho'
 
-if ENV["DEBUG"]
+if ENV['DEBUG']
   Bicho::Logging.logger = Logger.new(STDERR)
   Bicho::Logging.logger.level = Logger::DEBUG
 end
-

data/test/test_history.rb

@@ -0,0 +1,13 @@
+require File.join(File.dirname(__FILE__), 'helper')
+
+class History_test < Test::Unit::TestCase
+
+  def test_basic_history
+    Bicho.client = Bicho::Client.new('https://bugzilla.gnome.org')
+
+    bug = Bicho.client.get_bug(645150)
+
+    assert bug.history.size > 0
+  end
+
+end

data/test/test_novell_plugin.rb

@@ -3,16 +3,15 @@ require 'bicho/plugins/novell'
 require 'tmpdir'
 
 class NovellPlugin_test < Test::Unit::TestCase
-
   def test_urls_are_correct
-    ['novell', 'suse'].each do |domain|
+    %w(novell suse).each do |domain|
       client = Bicho::Client.new("https://bugzilla.#{domain}.com")
       assert_raises NoMethodError do
         client.url
       end
 
-      #assert_equal "https://apibugzilla.#{domain}.com/xmlrpc.cgi", "#{client.api_url.scheme}://#{client.api_url.host}#{client.api_url.path}"
-      #assert_equal "https://bugzilla.#{domain}.com", "#{client.site_url.scheme}://#{client.site_url.host}#{client.site_url.path}"
+      # assert_equal "https://apibugzilla.#{domain}.com/xmlrpc.cgi", "#{client.api_url.scheme}://#{client.api_url.host}#{client.api_url.path}"
+      # assert_equal "https://bugzilla.#{domain}.com", "#{client.site_url.scheme}://#{client.site_url.host}#{client.site_url.path}"
     end
   end
 
@@ -35,10 +34,9 @@ EOS
       plugin = Bicho::Plugins::Novell.new
       credentials = Bicho::Plugins::Novell.oscrc_credentials
       assert_not_nil(credentials)
-      assert(credentials.has_key?(:user))
-      assert(credentials.has_key?(:password))
+      assert(credentials.key?(:user))
+      assert(credentials.key?(:password))
       Bicho::Plugins::Novell.oscrc_path = nil
     end
   end
-
 end

data/test/test_query.rb

@@ -1,30 +1,27 @@
 require File.join(File.dirname(__FILE__), 'helper')
 
 class Query_test < Test::Unit::TestCase
-
   def test_active_record_style
     # No client set yet
     assert_raise RuntimeError do
-      Bicho::Bug.where.assigned_to("foo@bar.com").each do |bug|
+      Bicho::Bug.where.assigned_to('foo@bar.com').each do |bug|
         puts bug
       end
     end
 
     Bicho.client = Bicho::Client.new('https://bugzilla.gnome.org')
 
-    ret  = Bicho::Bug.where.product("vala").status("resolved").component("Basic Types").each.to_a
-    assert ret.collect(&:id).include?(645150)
-
+    ret  = Bicho::Bug.where.product('vala').status('resolved').component('Basic Types').each.to_a
+    assert ret.collect(&:id).include?(645_150)
   end
-  
+
   def test_query_addition_of_attributes
-    ret = Bicho::Query.new.status("foo").status("bar")
-    assert_equal({"status" => ["foo", "bar"]}, ret.query_map)
+    ret = Bicho::Query.new.status('foo').status('bar')
+    assert_equal({ 'status' => %w(foo bar) }, ret.query_map)
   end
 
   def test_query_shortcuts
     ret = Bicho::Query.new.open
-    assert_equal({"status" => [:new, :assigned, :needinfo, :reopened]}, ret.query_map)
+    assert_equal({ 'status' => [:new, :assigned, :needinfo, :reopened] }, ret.query_map)
   end
-
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bicho
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-26 00:00:00.000000000 Z
+date: 2014-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: inifile
@@ -93,16 +93,19 @@ files:
 - lib/bicho.rb
 - lib/bicho/bug.rb
 - lib/bicho/cli/command.rb
+- lib/bicho/cli/commands/history.rb
 - lib/bicho/cli/commands/search.rb
 - lib/bicho/cli/commands/show.rb
 - lib/bicho/client.rb
 - lib/bicho/common_client.rb
 - lib/bicho/ext/logger_colors.rb
+- lib/bicho/history.rb
 - lib/bicho/logging.rb
 - lib/bicho/plugins/novell.rb
 - lib/bicho/query.rb
 - lib/bicho/version.rb
 - test/helper.rb
+- test/test_history.rb
 - test/test_novell_plugin.rb
 - test/test_query.rb
 homepage: http://github.com/dmacvicar/bicho
@@ -131,6 +134,7 @@ specification_version: 3
 summary: Library to access bugzilla
 test_files:
 - test/helper.rb
+- test/test_history.rb
 - test/test_novell_plugin.rb
 - test/test_query.rb
 has_rdoc: