bic_validation 0.0.2 → 0.1.0

data/.rubocop.yml

@@ -0,0 +1,5 @@
+Documentation:
+  Enabled: false
+
+Encoding:
+  Enabled: false

data/.travis.yml

@@ -6,6 +6,10 @@ rvm:
   - jruby-19mode
   - jruby-head
   - rbx-19mode
-  - rbx
+  - rbx-2.0.0
   - rbx-head
+matrix:
+  allow_failures:
+    - rvm: rbx-2.0.0
+    - rvm: rbx-head
 script: rspec

data/README.md

@@ -1,6 +1,8 @@
 # BicValidation
 
 [![Build Status](https://travis-ci.org/opahk/bic_validation.png?branch=master)](https://travis-ci.org/opahk/bic_validation)
+[![Coverage Status](https://coveralls.io/repos/opahk/bic_validation/badge.png?branch=master)](https://coveralls.io/r/opahk/bic_validation?branch=master)
+[![Code Climate](https://codeclimate.com/github/opahk/bic_validation.png)](https://codeclimate.com/github/opahk/bic_validation)
 
 ActiveModel Business Identifier Code (BIC) validator
 ## Installation

data/bic_validation.gemspec

@@ -21,7 +21,10 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
 
   gem.add_dependency 'activemodel'
+  gem.add_dependency 'activesupport'
+  gem.add_dependency 'banking_data'
   gem.add_development_dependency 'rspec'
   gem.add_development_dependency 'coveralls'
   gem.add_development_dependency 'pry'
+  gem.add_development_dependency 'rubocop'
 end

data/lib/bic_validation/bic.rb

@@ -1,3 +1,5 @@
+require 'active_support/core_ext/object/try'
+
 module BicValidation
   class Bic
 
@@ -22,10 +24,16 @@ module BicValidation
       country[0] =~ /[^01]/ && country[1] =~ /[^O]/
     end
 
+    def known?
+      !known_bics.include?(country.to_sym) ||
+        known_bics[country.to_sym].include?(@code.try(:gsub, /XXX$/, ''))
+    end
+
     def valid?
-      of_valid_length? and
-        of_valid_format? and
-        has_valid_country_code?
+      of_valid_length? &&
+        of_valid_format? &&
+        has_valid_country_code? &&
+        has_valid_branch_code?
     end
 
     def bank
@@ -46,17 +54,33 @@ module BicValidation
 
     private
 
-    def format
-      /([A-Z]{4})([A-Z]{2})([0-9A-Z]{2})([0-9A-Z]{3})?/
-    end
+      def format
+        /([A-Z]{4})([A-Z]{2})([0-9A-Z]{2})([0-9A-Z]{3})?/
+      end
 
-    def match
-      format.match(@code)
-    end
+      def match
+        format.match(@code)
+      end
 
-    def country_codes
-      # http://www.iso.org/iso/country_codes/iso_3166_code_lists/country_names_and_code_elements.htm
-      YAML.load(File.read(File.dirname(__FILE__) + '/country_codes.yml'))
-    end
+      def known_bics
+        {
+          DE: bics(:de),
+          AT: bics(:at),
+          CH: bics(:ch)
+        }
+      end
+
+      def bics(country)
+        BankingData::Bank.where(locale: country).only(:bic)
+          .map { |bic| bic.first.gsub(/XXX$/, '') }
+          .reject(&:blank?)
+          .uniq
+      end
+
+      def country_codes
+        # http://www.iso.org/iso/country_codes/iso_3166_code_lists/country_\
+        # names_and_code_elements.htm
+        YAML.load(File.read(File.dirname(__FILE__) + '/country_codes.yml'))
+      end
   end
 end

data/lib/bic_validation/bic_validator.rb

@@ -1,8 +1,13 @@
 module BicValidation
   class BicValidator < ActiveModel::EachValidator
     def validate_each(record, attribute, value)
-      unless Bic.new(value).valid?
-        record.errors.add attribute, 'is not a valid BIC'
+      bic = Bic.new(value)
+      if bic.valid?
+        unless bic.known?
+          record.errors.add attribute, :unknown
+        end
+      else
+        record.errors.add attribute, :invalid
       end
     end
   end

data/lib/bic_validation/version.rb

@@ -1,3 +1,3 @@
 module BicValidation
-  VERSION = '0.0.2'
+  VERSION = '0.1.0'
 end

data/lib/bic_validation.rb

@@ -1,7 +1,8 @@
-require "active_model"
-require "bic_validation/bic"
-require "bic_validation/bic_validator"
-require "bic_validation/version"
+require 'active_model'
+require 'banking_data'
+require 'bic_validation/bic'
+require 'bic_validation/bic_validator'
+require 'bic_validation/version'
 
 module BicValidation
 end

data/spec/bic_validation/bic_spec.rb

@@ -3,10 +3,75 @@ require 'spec_helper'
 module BicValidation
   describe Bic do
 
-    describe '#valid?' do
-      bic = Bic.new "MARKDEFF"
-      bic.valid?.should == true
+    context 'basic methods 11 digit' do
+      before { @bic = Bic.new 'MARKDEF1850' }
+
+      subject { @bic }
+
+      describe '#valid?' do
+        it { should be_valid }
+      end
+
+      describe '#known?' do
+        it { should be_known }
+      end
+
+      describe '#bank' do
+        its(:bank) { should eq('MARK') }
+      end
+
+      describe '#country' do
+        its(:country) { should eq('DE') }
+      end
+
+      describe '#location' do
+        its(:location) { should eq('F1') }
+      end
+
+      describe '#branch' do
+        its(:branch) { should eq('850') }
+      end
     end
 
+    context 'basic methods 8 digit' do
+      before { @bic = Bic.new 'DEUTDEBB' }
+
+      subject { @bic }
+
+      describe '#valid?' do
+        it { should be_valid }
+      end
+
+      describe '#known?' do
+        it { should be_known }
+      end
+
+      describe '#bank' do
+        its(:bank) { should eq('DEUT') }
+      end
+
+      describe '#country' do
+        its(:country) { should eq('DE') }
+      end
+
+      describe '#location' do
+        its(:location) { should eq('BB') }
+      end
+
+      describe '#branch' do
+        its(:branch) { should be_nil }
+      end
+    end
+
+    ['DEUTDEBB', 'CRESCHZZ10S', 'UBSWCHZH86N', 'OEKOATWWXXX',
+     'OEKOATWW'].each do |swift|
+      describe 'validity checks' do
+        it "validates #{swift}" do
+          bic = Bic.new(swift)
+          expect(bic).to be_valid
+          expect(bic).to be_known
+        end
+      end
+    end
   end
 end

data/spec/bic_validation/bic_validator_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+module BicValidation
+  describe BicValidator do
+    class Model
+      include ActiveModel::Validations
+      attr_accessor :bic
+      validates :bic, bic: true
+
+      def initialize(bic)
+        @bic = bic
+      end
+    end
+
+    it 'is valid' do
+      model = Model.new 'DEUTDEFF'
+      model.valid?
+      expect(model.errors.count).to eq(0)
+    end
+
+    it 'is unknown' do
+      model = Model.new 'DXUTDEFF'
+      model.valid?
+      expect(model.errors.count).to eq(1)
+    end
+
+    it 'is invalid' do
+      model = Model.new 'DXUTDE'
+      model.valid?
+      expect(model.errors.count).to eq(1)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 require 'simplecov'
 require 'coveralls'
+require 'pry'
 
 SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
   SimpleCov::Formatter::HTMLFormatter,
@@ -21,4 +22,8 @@ RSpec.configure do |config|
   # the seed, which is printed after each run.
   #     --seed 1234
   config.order = 'random'
+
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bic_validation
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-11 00:00:00.000000000 Z
+date: 2013-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -27,6 +27,38 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: banking_data
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -75,6 +107,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: ! "    BicValidation provides a simple ActiveModel::EachValidator for\n
   \   formally validating Business Identifier Codes (BIC) aka SWIFT-codes.\n"
 email:
@@ -85,6 +133,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .rubocop.yml
 - .travis.yml
 - Gemfile
 - LICENSE.txt
@@ -97,6 +146,7 @@ files:
 - lib/bic_validation/country_codes.yml
 - lib/bic_validation/version.rb
 - spec/bic_validation/bic_spec.rb
+- spec/bic_validation/bic_validator_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/opahk/bic_validation
 licenses: []
@@ -124,5 +174,6 @@ specification_version: 3
 summary: ActiveModel BIC validator
 test_files:
 - spec/bic_validation/bic_spec.rb
+- spec/bic_validation/bic_validator_spec.rb
 - spec/spec_helper.rb
 has_rdoc: