bibsync 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5578a98ae327ca6b8ee4b5fb0da4b2bbd1786116
-  data.tar.gz: eb56b9ab2ce3d9f1b6599da6a1b4ca0c76db220e
+  metadata.gz: 1ee82317ca7e8c3e5fa9de627bfd9b2f240dced2
+  data.tar.gz: 547ff333dc6cb12d5b98e3280aed47aa539889b5
 SHA512:
-  metadata.gz: 3050a0ec740223617d6f700bca7725443e3ab2b1a1cce7ef46c6091ed777d18b3bdc3f6f9ad17abcce3b40f923959069960d977128c112cfbe84e933a3bcfbcd
-  data.tar.gz: d4692dcd5ce86c2cfaf6698a7c77ca5450487067077ba87804325b54cf77a2e7654ae025914819476be79f649e56d21e1c5e056402e46dc02a5d8a3113ed0a57
+  metadata.gz: 3778420afe0ea4faeedca5e56c74c7f518f258ddc4cc6ce1dcc09d63fc62b42fa77ec752bc9b5ae0c2c74fbf79138abd3aeb5ee4d00cfe75530e2a7b7540d0bd
+  data.tar.gz: f68cd142a1f99b983df76b3b311def93d0a765d4af8ff1b7d2222d96812b2fd70d7ca5683362a42a31e84ca730a475a393e11303ef8c866907d203feb9860574

data/lib/bibsync.rb

@@ -13,3 +13,4 @@ require 'bibsync/bibliography'
 require 'bibsync/entry'
 require 'bibsync/literal'
 require 'bibsync/actions'
+require 'bibsync/jabref_formatter'

data/lib/bibsync/bibliography.rb

@@ -4,12 +4,13 @@ module BibSync
     extend Forwardable
 
     attr_reader :file
-    attr_accessor :save_hook
+    attr_accessor :transform_hook, :format_hook
     def_delegators :@entries, :empty?, :size
     def_delegator :@entries, :each_value, :each
 
     def initialize(file = nil)
-      @entries, @save_hook = {}, nil
+      @entries = {}
+      @transform_hook, @format_hook = nil, nil
       load(file)
     end
 
@@ -54,10 +55,11 @@ module BibSync
 
       raise 'No filename given' unless @file
       if @dirty
-        @save_hook.call(self) if @save_hook
+        @transform_hook.call(self) if @transform_hook
         tmpfile = "#{@file}.tmp"
         begin
           File.open(tmpfile, 'w') {|f| f.write(self) }
+          @format_hook.call(tmpfile) if @format_hook
           File.rename(tmpfile, @file)
         ensure
           File.unlink(tmpfile) rescue nil

data/lib/bibsync/command.rb

@@ -90,7 +90,8 @@ module BibSync
 
       if @options[:bib]
         bib = @options[:bib] = Bibliography.new(@options[:bib])
-        bib.save_hook = Transformer.new
+        bib.transform_hook = Transformer.new
+        bib.format_hook = JabRefFormatter.new if @options[:jabref]
         at_exit { bib.save }
       end
 
@@ -100,7 +101,6 @@ module BibSync
       actions << :SynchronizeFiles << :DetermineArXivDOI << :SynchronizeMetadata if @options[:sync] || @options[:resync]
       actions << :FindMyCitations if @options[:citedbyme]
       actions << :Validate if @options[:bib]
-      actions << :JabRefFormat if @options[:jabref]
 
       if actions.empty?
         puts "Please specify actions! See #{$0} --help"

data/lib/bibsync/jabref_formatter.rb

@@ -0,0 +1,18 @@
+module BibSync
+  class JabRefFormatter
+    include Log
+
+    def call(file)
+      if File.read(file, 80) !~ /JabRef/
+        notice 'Transforming file with JabRef'
+        tmp_file = "#{file}.formatted.bib"
+        begin
+          `jabref --primp #{Shellwords.escape File.join(File.dirname(__FILE__), 'jabref.xml')} --nogui --import #{Shellwords.escape file} --output #{Shellwords.escape tmp_file} 2>&1 >/dev/null`
+          File.rename(tmp_file, file) if File.exists?(tmp_file)
+        ensure
+          File.unlink(tmp_file) rescue nil
+        end
+      end
+    end
+  end
+end

data/lib/bibsync/version.rb

@@ -1,3 +1,3 @@
 module BibSync
-  VERSION = '0.0.8'
+  VERSION = '0.0.9'
 end

data/test/fixture/test.bib

@@ -31,4 +31,8 @@
   file = {:PhysRevLett.104.106404.txt:TXT}
 }
 
+@ARTICLE{NoShortJournal,
+  journal={Physical Review Letters}
+}
+
 @COMMENT{TestComment}

data/test/test_bibliography.rb

@@ -114,6 +114,28 @@ describe BibSync::Bibliography do
   end
 
   describe '#save' do
+    it 'must support transform hook' do
+      begin
+        bib['NoShortJournal'][:shortjournal].must_equal nil
+        tmpfile = File.join(fixturedir, 'transform.bib')
+        bib.transform_hook = BibSync::Transformer.new
+        bib.save(tmpfile)
+        bib['NoShortJournal'][:shortjournal].must_equal 'PRL'
+      ensure
+        File.unlink(tmpfile) rescue nil
+      end
+    end
+
+    it 'must support format hook' do
+      begin
+        tmpfile = File.join(fixturedir, 'format.bib')
+        bib.format_hook = BibSync::JabRefFormatter.new
+        bib.save(tmpfile)
+        File.read(tmpfile).must_match(/created\s+with\s+JabRef/)
+      ensure
+        File.unlink(tmpfile) rescue nil
+      end
+    end
   end
 
   describe '#<<' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bibsync
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Daniel Mendler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-08 00:00:00.000000000 Z
+date: 2013-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -89,14 +89,14 @@ files:
 - lib/bibsync/actions/determine_arxiv_doi.rb
 - lib/bibsync/actions/fetch_from_arxiv.rb
 - lib/bibsync/actions/find_my_citations.rb
-- lib/bibsync/actions/jabref.xml
-- lib/bibsync/actions/jabref_format.rb
 - lib/bibsync/actions/synchronize_files.rb
 - lib/bibsync/actions/synchronize_metadata.rb
 - lib/bibsync/actions/validate.rb
 - lib/bibsync/bibliography.rb
 - lib/bibsync/command.rb
 - lib/bibsync/entry.rb
+- lib/bibsync/jabref.xml
+- lib/bibsync/jabref_formatter.rb
 - lib/bibsync/literal.rb
 - lib/bibsync/log.rb
 - lib/bibsync/transformer.rb
@@ -106,7 +106,6 @@ files:
 - test/actions/test_determine_arxiv_doi.rb
 - test/actions/test_fetch_from_arxiv.rb
 - test/actions/test_find_my_citations.rb
-- test/actions/test_jabref_format.rb
 - test/actions/test_synchronize_files.rb
 - test/actions/test_synchronize_metadata.rb
 - test/actions/test_validate.rb
@@ -140,7 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: bibsync
-rubygems_version: 2.0.0
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: BibSync is a tool to synchronize scientific papers and BibTeX bibliography

data/lib/bibsync/actions/jabref_format.rb

@@ -1,22 +0,0 @@
-module BibSync
-  module Actions
-    class JabRefFormat
-      include Utils
-      include Log
-
-      def initialize(options)
-        raise 'Option --bib is required' unless @bib = options[:bib]
-      end
-
-      def run
-        @bib.save
-        if File.read(@bib.file, 80) !~ /JabRef/
-          notice 'Transforming file with JabRef'
-          tmp_file = "#{@bib.file}.tmp.bib"
-          `jabref --primp #{Shellwords.escape File.join(File.dirname(__FILE__), 'jabref.xml')} --nogui --import #{Shellwords.escape @bib.file} --output #{Shellwords.escape tmp_file} 2>&1 >/dev/null`
-          File.rename(tmp_file, @bib.file) if File.exists?(tmp_file)
-        end
-      end
-    end
-  end
-end

data/test/actions/test_jabref_format.rb

@@ -1,25 +0,0 @@
-require 'helper'
-
-describe BibSync::Actions::JabRefFormat do
-  before do
-    @tmpfile = File.join(fixturedir, 'tmp.bib')
-    FileUtils.copy(File.join(fixturedir, 'test.bib'), @tmpfile)
-  end
-
-  after do
-    File.unlink(@tmpfile) if File.exists?(@tmpfile)
-  end
-
-  let(:bib) do
-    BibSync::Bibliography.new(@tmpfile)
-  end
-
-  let(:action) do
-    BibSync::Actions::JabRefFormat.new(bib: bib)
-  end
-
-  it 'should format file' do
-    action.run
-    File.read(@tmpfile).must_match(/created\s+with\s+JabRef/)
-  end
-end