bibliothecary 8.7.4 → 8.7.5

data/lib/bibliothecary/parsers/hackage.rb

@@ -1,5 +1,5 @@
 require "json"
-require 'deb_control'
+require "deb_control"
 
 module Bibliothecary
   module Parsers
@@ -9,13 +9,13 @@ module Bibliothecary
       def self.mapping
         {
           match_extension(".cabal") => {
-            kind: 'manifest',
-            parser: :parse_cabal
+            kind: "manifest",
+            parser: :parse_cabal,
           },
           match_extension("cabal.config") => {
-            kind: 'lockfile',
-            parser: :parse_cabal_config
-          }
+            kind: "lockfile",
+            parser: :parse_cabal_config,
+          },
         }
       end
 
@@ -23,9 +23,9 @@ module Bibliothecary
       add_multi_parser(Bibliothecary::MultiParsers::DependenciesCSV)
       add_multi_parser(Bibliothecary::MultiParsers::Spdx)
 
-      def self.parse_cabal(file_contents, options: {})
+      def self.parse_cabal(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         headers = {
-          'Content-Type' => "text/plain;charset=utf-8"
+          "Content-Type" => "text/plain;charset=utf-8",
         }
 
         response = Typhoeus.post("#{Bibliothecary.configuration.cabal_parser_host}/parse", headers: headers, body: file_contents)
@@ -34,15 +34,15 @@ module Bibliothecary
         JSON.parse(response.body, symbolize_names: true)
       end
 
-      def self.parse_cabal_config(file_contents, options: {})
+      def self.parse_cabal_config(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         manifest = DebControl::ControlFileBase.parse(file_contents)
-        deps = manifest.first['constraints'].delete("\n").split(',').map(&:strip)
+        deps = manifest.first["constraints"].delete("\n").split(",").map(&:strip)
         deps.map do |dependency|
-          dep = dependency.delete("==").split(' ')
+          dep = dependency.delete("==").split(" ")
           {
             name: dep[0],
-            requirement: dep[1] || '*',
-            type: 'runtime'
+            requirement: dep[1] || "*",
+            type: "runtime",
           }
         end
       end

data/lib/bibliothecary/parsers/haxelib.rb

@@ -1,4 +1,4 @@
-require 'json'
+require "json"
 
 module Bibliothecary
   module Parsers
@@ -9,9 +9,9 @@ module Bibliothecary
       def self.mapping
         {
           match_filename("haxelib.json") => {
-            kind: 'manifest',
-            parser: :parse_json_runtime_manifest
-          }
+            kind: "manifest",
+            parser: :parse_json_runtime_manifest,
+          },
         }
       end
 

data/lib/bibliothecary/parsers/hex.rb

@@ -1,4 +1,4 @@
-require 'json'
+require "json"
 
 module Bibliothecary
   module Parsers
@@ -8,13 +8,13 @@ module Bibliothecary
       def self.mapping
         {
           match_filename("mix.exs") => {
-            kind: 'manifest',
-            parser: :parse_mix
+            kind: "manifest",
+            parser: :parse_mix,
           },
           match_filename("mix.lock") => {
-            kind: 'lockfile',
-            parser: :parse_mix_lock
-          }
+            kind: "lockfile",
+            parser: :parse_mix_lock,
+          },
         }
       end
 
@@ -22,7 +22,7 @@ module Bibliothecary
       add_multi_parser(Bibliothecary::MultiParsers::DependenciesCSV)
       add_multi_parser(Bibliothecary::MultiParsers::Spdx)
 
-      def self.parse_mix(file_contents, options: {})
+      def self.parse_mix(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         response = Typhoeus.post("#{Bibliothecary.configuration.mix_parser_host}/", body: file_contents)
         raise Bibliothecary::RemoteParsingError.new("Http Error #{response.response_code} when contacting: #{Bibliothecary.configuration.mix_parser_host}/", response.response_code) unless response.success?
         json = JSON.parse response.body
@@ -31,12 +31,12 @@ module Bibliothecary
           {
             name: name,
             requirement: version,
-            type: "runtime"
+            type: "runtime",
           }
         end
       end
 
-      def self.parse_mix_lock(file_contents, options: {})
+      def self.parse_mix_lock(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         response = Typhoeus.post("#{Bibliothecary.configuration.mix_parser_host}/lock", body: file_contents)
         raise Bibliothecary::RemoteParsingError.new("Http Error #{response.response_code} when contacting: #{Bibliothecary.configuration.mix_parser_host}/", response.response_code) unless response.success?
         json = JSON.parse response.body
@@ -44,8 +44,8 @@ module Bibliothecary
         json.map do |name, info|
           {
             name: name,
-            requirement: info['version'],
-            type: "runtime"
+            requirement: info["version"],
+            type: "runtime",
           }
         end
       end

data/lib/bibliothecary/parsers/julia.rb

@@ -7,14 +7,14 @@ module Bibliothecary
         {
           match_filename("REQUIRE", case_insensitive: true) => {
             kind: "manifest",
-            parser: :parse_require
-          }
+            parser: :parse_require,
+          },
         }
       end
 
       add_multi_parser(Bibliothecary::MultiParsers::DependenciesCSV)
 
-      def self.parse_require(file_contents, options: {})
+      def self.parse_require(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         deps = []
         file_contents.split("\n").each do |line|
           next if line.match(/^#/) || line.empty?
@@ -32,7 +32,7 @@ module Bibliothecary
           deps << {
             name: name,
             requirement: reqs,
-            type: "runtime"
+            type: "runtime",
           }
         end
         deps

data/lib/bibliothecary/parsers/maven.rb

@@ -1,5 +1,5 @@
-require 'ox'
-require 'strings-ansi'
+require "ox"
+require "strings-ansi"
 
 # Known shortcomings and unimplemented Maven features:
 #   pom.xml
@@ -11,19 +11,19 @@ module Bibliothecary
       include Bibliothecary::Analyser
 
       # e.g. "annotationProcessor - Annotation processors and their dependencies for source set 'main'."
-      GRADLE_TYPE_REGEX = /^(\w+)/
+      GRADLE_TYPE_REGEXP = /^(\w+)/
 
       # e.g. "|    \\--- com.google.guava:guava:23.5-jre (*)"
-      GRADLE_DEP_REGEX = /(\+---|\\---){1}/
+      GRADLE_DEP_REGEXP = /(\+---|\\---){1}/
 
       # Dependencies that are on-disk projects, eg:
       # e.g. "\--- project :api:my-internal-project"
       # e.g. "+--- my-group:my-alias:1.2.3 -> project :client (*)"
-      GRADLE_PROJECT_REGEX = /project :(\S+)?/
+      GRADLE_PROJECT_REGEXP = /project :(\S+)?/
 
       # line ending legend: (c) means a dependency constraint, (n) means not resolved, or (*) means resolved previously, e.g. org.springframework.boot:spring-boot-starter-web:2.1.0.M3 (*)
       # e.g. the "(n)" in "+--- my-group:my-name:1.2.3 (n)"
-      GRADLE_LINE_ENDING_REGEX = /(\((c|n|\*)\))$/
+      GRADLE_LINE_ENDING_REGEXP = /(\((c|n|\*)\))$/
 
       # Builtin methods: https://docs.gradle.org/current/userguide/java_plugin.html#tab:configurations
       # Deprecated methods: https://docs.gradle.org/current/userguide/upgrading_version_6.html#sec:configuration_removal
@@ -32,70 +32,70 @@ module Bibliothecary
       # Intentionally overly-simplified regexes to scrape deps from build.gradle (Groovy) and build.gradle.kts (Kotlin) files.
       # To be truly useful bibliothecary would need full Groovy / Kotlin parsers that speaks Gradle,
       # because the Groovy and Kotlin DSLs have many dynamic ways of declaring dependencies.
-      GRADLE_VERSION_REGEX = /[\w.-]+/ # e.g. '1.2.3'
-      GRADLE_VAR_INTERPOLATION_REGEX = /\$\w+/ # e.g. '$myVersion'
-      GRADLE_CODE_INTERPOLATION_REGEX = /\$\{.*\}/ # e.g. '${my-project-settings["version"]}'
-      GRADLE_GAV_REGEX = /([\w.-]+)\:([\w.-]+)(?:\:(#{GRADLE_VERSION_REGEX}|#{GRADLE_VAR_INTERPOLATION_REGEX}|#{GRADLE_CODE_INTERPOLATION_REGEX}))?/ # e.g. "group:artifactId:1.2.3"
-      GRADLE_GROOVY_SIMPLE_REGEX = /(#{GRADLE_DEPENDENCY_METHODS.join('|')})\s*\(?\s*['"]#{GRADLE_GAV_REGEX}['"]/m
-      GRADLE_KOTLIN_SIMPLE_REGEX = /(#{GRADLE_DEPENDENCY_METHODS.join('|')})\s*\(\s*"#{GRADLE_GAV_REGEX}"/m
-
-      MAVEN_PROPERTY_REGEX = /\$\{(.+?)\}/
+      GRADLE_VERSION_REGEXP = /[\w.-]+/ # e.g. '1.2.3'
+      GRADLE_VAR_INTERPOLATION_REGEXP = /\$\w+/ # e.g. '$myVersion'
+      GRADLE_CODE_INTERPOLATION_REGEXP = /\$\{.*\}/ # e.g. '${my-project-settings["version"]}'
+      GRADLE_GAV_REGEXP = /([\w.-]+)\:([\w.-]+)(?:\:(#{GRADLE_VERSION_REGEXP}|#{GRADLE_VAR_INTERPOLATION_REGEXP}|#{GRADLE_CODE_INTERPOLATION_REGEXP}))?/ # e.g. "group:artifactId:1.2.3"
+      GRADLE_GROOVY_SIMPLE_REGEXP = /(#{GRADLE_DEPENDENCY_METHODS.join('|')})\s*\(?\s*['"]#{GRADLE_GAV_REGEXP}['"]/m
+      GRADLE_KOTLIN_SIMPLE_REGEXP = /(#{GRADLE_DEPENDENCY_METHODS.join('|')})\s*\(\s*"#{GRADLE_GAV_REGEXP}"/m
+
+      MAVEN_PROPERTY_REGEXP = /\$\{(.+?)\}/
       MAX_DEPTH = 5
 
       # e.g. "[info]  test:"
-      SBT_TYPE_REGEX = /^\[info\]\s+([-\w]+):$/
+      SBT_TYPE_REGEXP = /^\[info\]\s+([-\w]+):$/
 
       # e.g. "[info]  org.typelevel:spire-util_2.12"
-      SBT_DEP_REGEX = /^\[info\]\s+(.+)$/
+      SBT_DEP_REGEXP = /^\[info\]\s+(.+)$/
 
       # e.g. "[info] 		- 1.7.5"
-      SBT_VERSION_REGEX = /^\[info\]\s+-\s+(.+)$/
+      SBT_VERSION_REGEXP = /^\[info\]\s+-\s+(.+)$/
 
       # e.g. "[info] 			homepage: http://www.slf4j.org"
-      SBT_FIELD_REGEX = /^\[info\]\s+([^:]+):\s+(.+)$/
+      SBT_FIELD_REGEXP = /^\[info\]\s+([^:]+):\s+(.+)$/
 
       # e.g. "[info]  "
-      SBT_IGNORE_REGEX = /^\[info\]\s*$/
+      SBT_IGNORE_REGEXP = /^\[info\]\s*$/
 
       def self.mapping
         {
           match_filename("ivy.xml", case_insensitive: true) => {
-            kind: 'manifest',
-            parser: :parse_ivy_manifest
+            kind: "manifest",
+            parser: :parse_ivy_manifest,
           },
           match_filename("pom.xml", case_insensitive: true) => {
-            kind: 'manifest',
-            parser: :parse_standalone_pom_manifest
+            kind: "manifest",
+            parser: :parse_standalone_pom_manifest,
           },
           match_filename("build.gradle", case_insensitive: true) => {
-            kind: 'manifest',
-            parser: :parse_gradle
+            kind: "manifest",
+            parser: :parse_gradle,
           },
           match_filename("build.gradle.kts", case_insensitive: true) => {
-            kind: 'manifest',
-            parser: :parse_gradle_kts
+            kind: "manifest",
+            parser: :parse_gradle_kts,
           },
           match_extension(".xml", case_insensitive: true) => {
             content_matcher: :ivy_report?,
-            kind: 'lockfile',
-            parser: :parse_ivy_report
+            kind: "lockfile",
+            parser: :parse_ivy_report,
           },
           match_filename("gradle-dependencies-q.txt", case_insensitive: true) => {
-            kind: 'lockfile',
-            parser: :parse_gradle_resolved
+            kind: "lockfile",
+            parser: :parse_gradle_resolved,
           },
           match_filename("maven-resolved-dependencies.txt", case_insensitive: true) => {
-            kind: 'lockfile',
-            parser: :parse_maven_resolved
+            kind: "lockfile",
+            parser: :parse_maven_resolved,
           },
           match_filename("sbt-update-full.txt", case_insensitive: true) => {
-            kind: 'lockfile',
-            parser: :parse_sbt_update_full
+            kind: "lockfile",
+            parser: :parse_sbt_update_full,
           },
           match_filename("maven-dependency-tree.txt", case_insensitive: true) => {
-            kind: 'lockfile',
-            parser: :parse_maven_tree
-          }
+            kind: "lockfile",
+            parser: :parse_maven_tree,
+          },
         }
       end
 
@@ -103,14 +103,14 @@ module Bibliothecary
       add_multi_parser(Bibliothecary::MultiParsers::Spdx)
       add_multi_parser(Bibliothecary::MultiParsers::DependenciesCSV)
 
-      def self.parse_ivy_manifest(file_contents, options: {})
+      def self.parse_ivy_manifest(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         manifest = Ox.parse file_contents
-        manifest.dependencies.locate('dependency').map do |dependency|
+        manifest.dependencies.locate("dependency").map do |dependency|
           attrs = dependency.attributes
           {
             name: "#{attrs[:org]}:#{attrs[:name]}",
             requirement: attrs[:rev],
-            type: 'runtime'
+            type: "runtime",
           }
         end
       end
@@ -126,7 +126,7 @@ module Bibliothecary
         false
       end
 
-      def self.parse_ivy_report(file_contents, options: {})
+      def self.parse_ivy_report(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         doc = Ox.parse file_contents
         root = doc.locate("ivy-report").first
         raise "ivy-report document does not have ivy-report at the root" if root.nil?
@@ -139,44 +139,44 @@ module Bibliothecary
           attrs = mod.attributes
           org = attrs[:organisation]
           name = attrs[:name]
-          version = mod.locate('revision').first&.attributes[:name]
+          version = mod.locate("revision").first&.attributes[:name]
 
           next nil if org.nil? or name.nil? or version.nil?
 
           {
             name: "#{org}:#{name}",
             requirement: version,
-            type: type
+            type: type,
           }
         end.compact
       end
 
-      def self.parse_gradle_resolved(file_contents, options: {})
+      def self.parse_gradle_resolved(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         current_type = nil
 
         file_contents.split("\n").map do |line|
-          current_type_match = GRADLE_TYPE_REGEX.match(line)
+          current_type_match = GRADLE_TYPE_REGEXP.match(line)
           current_type = current_type_match.captures[0] if current_type_match
 
-          gradle_dep_match = GRADLE_DEP_REGEX.match(line)
+          gradle_dep_match = GRADLE_DEP_REGEXP.match(line)
           next unless gradle_dep_match
 
           split = gradle_dep_match.captures[0]
 
           # gradle can import on-disk projects and deps will be listed under them, e.g. `+--- project :test:integration`,
           # so we treat these projects as "internal" deps with requirement of "1.0.0"
-          if (project_match = line.match(GRADLE_PROJECT_REGEX))
+          if (project_match = line.match(GRADLE_PROJECT_REGEXP))
             # an empty project name is self-referential (i.e. a cycle), and we don't need to track the manifest's project itself, e.g. "+--- project :"
             next if project_match[1].nil?
 
             # project names can have colons (e.g. for gradle projects in subfolders), which breaks maven artifact naming assumptions, so just replace them with hyphens.
             project_name = project_match[1].gsub(/:/, "-")
-            line = line.sub(GRADLE_PROJECT_REGEX, "internal:#{project_name}:1.0.0")
+            line = line.sub(GRADLE_PROJECT_REGEXP, "internal:#{project_name}:1.0.0")
           end
 
           dep = line
             .split(split)[1]
-            .sub(GRADLE_LINE_ENDING_REGEX, "")
+            .sub(GRADLE_LINE_ENDING_REGEXP, "")
             .sub(/ FAILED$/, "") # dependency could not be resolved (but still may have a version)
             .sub(" -> ", ":") # handle version arrow syntax
             .strip
@@ -193,7 +193,7 @@ module Bibliothecary
               original_requirement: dep[2],
               name: dep[-3..-2].join(":"),
               requirement: dep[-1],
-              type: current_type
+              type: current_type,
             }
           elsif dep.count == 5
             # get name from renamed package resolution "org:name -> renamed_org:name:version"
@@ -202,14 +202,14 @@ module Bibliothecary
               original_requirement: "*",
               name: dep[-3..-2].join(":"),
               requirement: dep[-1],
-              type: current_type
+              type: current_type,
             }
           else
             # get name from version conflict resolution ("org:name:version -> version") and no-resolution ("org:name:version")
             {
               name: dep[0..1].join(":"),
               requirement: dep[-1],
-              type: current_type
+              type: current_type,
             }
           end
         end
@@ -217,7 +217,7 @@ module Bibliothecary
           .uniq { |item| item.values_at(:name, :requirement, :type, :original_name, :original_requirement) }
       end
 
-      def self.parse_maven_resolved(file_contents, options: {})
+      def self.parse_maven_resolved(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         Strings::ANSI.sanitize(file_contents)
           .split("\n")
           .map(&method(:parse_resolved_dep_line))
@@ -225,7 +225,7 @@ module Bibliothecary
           .uniq
       end
 
-      def self.parse_maven_tree(file_contents, options: {})
+      def self.parse_maven_tree(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         captures = Strings::ANSI.sanitize(file_contents)
           .gsub(/\r\n?/, "\n")
           .scan(/^\[INFO\](?:(?:\+-)|\||(?:\\-)|\s)+((?:[\w\.-]+:)+[\w\.\-${}]+)/)
@@ -244,7 +244,7 @@ module Bibliothecary
           {
             name: parts[0..1].join(":"),
             requirement: version,
-            type: type
+            type: type,
           }
         end
 
@@ -264,7 +264,7 @@ module Bibliothecary
         {
           name: dep_parts[0, 2].join(":"),
           requirement: dep_parts[3],
-          type: dep_parts[4].split("--").first.strip
+          type: dep_parts[4].split("--").first.strip,
         }
       end
 
@@ -274,9 +274,9 @@ module Bibliothecary
 
       # parent_properties is used by Libraries:
       # https://github.com/librariesio/libraries.io/blob/e970925aade2596a03268b6e1be785eba8502c62/app/models/package_manager/maven.rb#L129
-      def self.parse_pom_manifest(file_contents, parent_properties = {}, options: {})
+      def self.parse_pom_manifest(file_contents, parent_properties = {}, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         manifest = Ox.parse file_contents
-        xml = manifest.respond_to?('project') ? manifest.project : manifest
+        xml = manifest.respond_to?("project") ? manifest.project : manifest
         [].tap do |deps|
           # <dependencyManagement> is a namespace to specify artifact configuration (e.g. version), but it doesn't
           # actually add dependencies to your project. Grab these and keep them for reference while parsing <dependencies>
@@ -292,10 +292,10 @@ module Bibliothecary
           end
           # <dependencies> is the namespace that will add dependencies to your project.
           xml.locate("dependencies/dependency").each do |dep|
-            groupId = extract_pom_dep_info(xml, dep, 'groupId', parent_properties)
-            artifactId = extract_pom_dep_info(xml, dep, 'artifactId', parent_properties)
-            version = extract_pom_dep_info(xml, dep, 'version', parent_properties)
-            scope = extract_pom_dep_info(xml, dep, 'scope', parent_properties)
+            groupId = extract_pom_dep_info(xml, dep, "groupId", parent_properties)
+            artifactId = extract_pom_dep_info(xml, dep, "artifactId", parent_properties)
+            version = extract_pom_dep_info(xml, dep, "version", parent_properties)
+            scope = extract_pom_dep_info(xml, dep, "scope", parent_properties)
 
             # Use any dep configurations from <dependencyManagement> as fallbacks
             if (depConfig = dependencyManagement.find { |d| d[:groupId] == groupId && d[:artifactId] == artifactId })
@@ -306,38 +306,38 @@ module Bibliothecary
             dep_hash = {
               name: "#{groupId}:#{artifactId}",
               requirement: version,
-              type: scope || 'runtime',
+              type: scope || "runtime",
             }
             # optional field is, itself, optional, and will be either "true" or "false"
-            optional = extract_pom_dep_info(xml, dep, 'optional', parent_properties)
+            optional = extract_pom_dep_info(xml, dep, "optional", parent_properties)
             dep_hash[:optional] = optional == "true" unless optional.nil?
             deps.push(dep_hash)
           end
         end
       end
 
-      def self.parse_gradle(file_contents, options: {})
+      def self.parse_gradle(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         file_contents
-        .scan(GRADLE_GROOVY_SIMPLE_REGEX)                                                # match 'implementation "group:artifactId:version"'
-        .reject { |(_type, group, artifactId, _version)| group.nil? || artifactId.nil? } # remove any matches with missing group/artifactId
-        .map { |(type, group, artifactId, version)|
+          .scan(GRADLE_GROOVY_SIMPLE_REGEXP)                                                # match 'implementation "group:artifactId:version"'
+          .reject { |(_type, group, artifactId, _version)| group.nil? || artifactId.nil? } # remove any matches with missing group/artifactId
+          .map { |(type, group, artifactId, version)|
           {
             name: [group, artifactId].join(":"),
             requirement: version || "*",
-            type: type
+            type: type,
+          }
           }
-        }
       end
 
-      def self.parse_gradle_kts(file_contents, options: {})
+      def self.parse_gradle_kts(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         file_contents
-          .scan(GRADLE_KOTLIN_SIMPLE_REGEX)                                                # match 'implementation("group:artifactId:version")'
+          .scan(GRADLE_KOTLIN_SIMPLE_REGEXP)                                                # match 'implementation("group:artifactId:version")'
           .reject { |(_type, group, artifactId, _version)| group.nil? || artifactId.nil? } # remove any matches with missing group/artifactId
           .map { |(type, group, artifactId, version)|
             {
               name: [group, artifactId].join(":"),
               requirement: version || "*",
-              type: type
+              type: type,
             }
           }
       end
@@ -371,7 +371,7 @@ module Bibliothecary
         value = value.value if value.is_a?(Ox::CData)
         # whitespace in dependency tags should be ignored
         value = value&.strip
-        match = value&.match(MAVEN_PROPERTY_REGEX)
+        match = value&.match(MAVEN_PROPERTY_REGEXP)
         if match
           return extract_property(xml, match[1], value, parent_properties)
         else
@@ -390,7 +390,7 @@ module Bibliothecary
 
         resolved_value = replace_value_with_prop(value, prop_value, property_name)
         # check to see if we just resolved to another property name
-        match = resolved_value.match(MAVEN_PROPERTY_REGEX)
+        match = resolved_value.match(MAVEN_PROPERTY_REGEXP)
         if match && depth < MAX_DEPTH
           depth += 1
           return extract_property(xml, match[1], resolved_value, parent_properties, depth)
@@ -407,8 +407,8 @@ module Bibliothecary
 
         prop_field = xml.properties.locate(property_name).first if xml.respond_to?("properties")
         parent_prop = parent_properties[property_name] ||                 # e.g. "${foo}"
-          parent_properties[property_name.sub(/^project\./, '')] ||       # e.g. "${project.foo}"
-          parent_properties[property_name.sub(/^project\.parent\./, '')]  # e.g. "${project.parent.foo}"
+          parent_properties[property_name.sub(/^project\./, "")] ||       # e.g. "${project.foo}"
+          parent_properties[property_name.sub(/^project\.parent\./, "")]  # e.g. "${project.parent.foo}"
 
         if prop_field
           prop_field.nodes.first
@@ -425,14 +425,13 @@ module Bibliothecary
         end
       end
 
-      def self.parse_sbt_update_full(file_contents, options: {})
+      def self.parse_sbt_update_full(file_contents, options: {}) # rubocop:disable Lint/UnusedMethodArgument
         all_deps = []
-        type = nil
         lines = file_contents.split("\n")
         while lines.any?
           line = lines.shift
 
-          type_match = SBT_TYPE_REGEX.match(line)
+          type_match = SBT_TYPE_REGEXP.match(line)
           next unless type_match
           type = type_match.captures[0]
 
@@ -464,12 +463,12 @@ module Bibliothecary
 
       def self.parse_sbt_deps(type, lines)
         deps = []
-        while lines.any? and not SBT_TYPE_REGEX.match(lines[0])
+        while lines.any? and not SBT_TYPE_REGEXP.match(lines[0])
           line = lines.shift
 
-          next if SBT_IGNORE_REGEX.match(line)
+          next if SBT_IGNORE_REGEXP.match(line)
 
-          dep_match = SBT_DEP_REGEX.match(line)
+          dep_match = SBT_DEP_REGEXP.match(line)
           if dep_match
             versions = parse_sbt_versions(type, dep_match.captures[0], lines)
             deps.concat(versions)
@@ -484,10 +483,10 @@ module Bibliothecary
 
       def self.parse_sbt_versions(type, name, lines)
         versions = []
-        while lines.any? and not SBT_TYPE_REGEX.match(lines[0])
+        while lines.any? and not SBT_TYPE_REGEXP.match(lines[0])
           line = lines.shift
 
-          version_match = SBT_VERSION_REGEX.match(line)
+          version_match = SBT_VERSION_REGEXP.match(line)
           if version_match
             versions.push(parse_sbt_version(type, name, version_match.captures[0], lines))
           else
@@ -501,10 +500,10 @@ module Bibliothecary
 
       def self.parse_sbt_version(type, name, version, lines)
         fields = {}
-        while lines.any? and not SBT_TYPE_REGEX.match(lines[0])
+        while lines.any? and not SBT_TYPE_REGEXP.match(lines[0])
           line = lines.shift
 
-          field_match = SBT_FIELD_REGEX.match(line)
+          field_match = SBT_FIELD_REGEXP.match(line)
           if field_match
             fields[field_match.captures[0]] = field_match.captures[1]
           else
@@ -518,7 +517,7 @@ module Bibliothecary
           requirement: version,
           type: type,
           # we post-process using some of these fields and then delete them again
-          fields: fields
+          fields: fields,
         }
       end
     end

data/lib/bibliothecary/parsers/meteor.rb

@@ -1,4 +1,4 @@
-require 'json'
+require "json"
 
 module Bibliothecary
   module Parsers
@@ -9,9 +9,9 @@ module Bibliothecary
       def self.mapping
         {
           match_filename("versions.json") => {
-            kind: 'manifest',
-            parser: :parse_json_runtime_manifest
-          }
+            kind: "manifest",
+            parser: :parse_json_runtime_manifest,
+          },
         }
       end