bible270 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ddb40f5dac18c21c5661cf6b290eb55247b87666d01a1a4239c97cbde95fc251
-  data.tar.gz: ac97b21064ffe1658dd62c5cd0df71fb748b2db88829e2f7a71fbd799302a065
+  metadata.gz: c39318054ec3245ba579a3c7f14ece0d8749cfd6bcf4209e90338ac48fe0294c
+  data.tar.gz: 05cfa41ce39280c39c6a278503a1f89248a2a057b96cda3c9e994dd831840864
 SHA512:
-  metadata.gz: 9543258320235373bd87deb1b39aed672c9a2fa1f753f5d39951f4b28db048a2b627e2a9cfbf30df4db5f506d4469e641b2b437394b21192ab2e859914deaa06
-  data.tar.gz: 54f1d379ba07ef8850f5e23f68d1d3b77e0ac29f01fb3e9b2e5b408e3c2b4c079d88049fb0e1b20f72a3f821d50d32b2a037541bd98accd0cdc41fc585cc16a7
+  metadata.gz: 759bbd980b0f1994719f0323b487bd86270fc3b0ae6489899c849a807f5cef9e0c528da104881a3602b68ab8d734aa9ff8b507019ebbd427641128bff4f55db6
+  data.tar.gz: 7c2c28f53b206dba13947676da4b7c9d2468fcfa7a1e202f2c0850602732fa11a0185462b37a6ee1965000d60dab5b7463b8f8e58a1552bf9ec0ea825c282470

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to bible270. Format follows [Keep a Changelog](https://keepa
 
 ## [Unreleased]
 
+**[Full Changelog](https://github.com/avonderluft/bible270/compare/v1.6.0...main)**
+
+## [1.6.0] - 2026-09-14
+
 ### Added
 
 - let administrators sort the reader list by first name, last name, most completed days, or least completed days, and open the Rake task's progress report in a dismissable Reader Stats dialog that follows the current sort selection
@@ -12,12 +16,13 @@ All notable changes to bible270. Format follows [Keep a Changelog](https://keepa
 ### Changed
 
 - send each broad reflection/reply notification once with all eligible subscribers in BCC, while keeping direct reply and mention notices individually addressed
+- expand regression coverage for registration delivery and failure isolation, legacy reader names, custom footer composition, mention compatibility, and stale completion-animation schema caches
 
 ### Fixed
 
 - normalize boolean column defaults reported by Rails adapters so migration reconciliation and tests work consistently across Rails 7.1 through 8.1
 
-**[Full Changelog](https://github.com/avonderluft/bible270/compare/v1.5.1...main)**
+**[Full Changelog](https://github.com/avonderluft/bible270/compare/v1.5.1...v1.6.0)**
 
 ## [1.5.1] - 2026-09-11
 
@@ -696,7 +701,8 @@ This is the initial public release.
 
 * Email sign-in requires working Action Mailer delivery in the host application. Set `config.mailer_from`; delivery is inline by default, or set `email_sign_in_deliver_later` when a queue backend is available.
 
-[Unreleased]: https://github.com/avonderluft/bible270/compare/v1.5.1...HEAD
+[Unreleased]: https://github.com/avonderluft/bible270/compare/v1.6.0...HEAD
+[1.6.0]: https://github.com/avonderluft/bible270/releases/tag/v1.6.0
 [1.5.1]: https://github.com/avonderluft/bible270/releases/tag/v1.5.1
 [1.5.0]: https://github.com/avonderluft/bible270/releases/tag/v1.5.0
 [1.4.2]: https://github.com/avonderluft/bible270/releases/tag/v1.4.2

data/app/controllers/bible270/comments_controller.rb

@@ -52,7 +52,7 @@ module Bible270
     def update
       return unless require_reader!
 
-      @comment = own_comment
+      @comment = editable_comment
       head :not_found and return unless @comment
 
       @day = @comment.day
@@ -147,18 +147,16 @@ module Bible270
       params.require(:comment).permit(*permitted)
     end
 
-    # Scoped to the reader, so someone else's reflection is simply not found —
-    # it reveals nothing about what exists.
-    def own_comment
-      current_reader.comments.find_by(id: params[:id])
+    # Scoped to the reader unless they are an administrator, so an ordinary reader
+    # cannot use editing or deletion to discover someone else's reflection.
+    def editable_comment
+      return current_reader.comments.find_by(id: params[:id]) unless Bible270.config.admin?(current_reader)
+
+      Comment.find_by(id: params[:id])
     end
 
-    # An admin may remove any reflection; everyone else only their own. Editing
-    # stays with the writer either way.
     def deletable_comment
-      return own_comment unless Bible270.config.admin?(current_reader)
-
-      Comment.find_by(id: params[:id])
+      editable_comment
     end
   end
 end

data/app/controllers/bible270/days_controller.rb

@@ -28,12 +28,13 @@ module Bible270
 
   private
 
-    # The reflection the reader has asked to edit: their own, on this day. Anything
-    # else is ignored rather than refused — the page still renders.
+    # The reflection the reader has asked to edit: their own, or any reflection
+    # when they are an administrator. Anything else is ignored rather than refused.
     def editing_comment_id
       return nil if params[:edit].blank? || current_reader.nil?
 
-      current_reader.comments.where(day: @day, id: params[:edit]).pick(:id)
+      comments = Bible270.config.admin?(current_reader) ? Comment.all : current_reader.comments
+      comments.where(day: @day, id: params[:edit]).pick(:id)
     end
 
     # The reflection being replied to, if the link carried one and it is a

data/app/helpers/bible270/plan_helper.rb

@@ -181,11 +181,12 @@ module Bible270
       local&.strftime('%b %-d, %Y at %-I:%M %p')
     end
 
-    # Only the writer may change their own words. An admin can remove a reflection
-    # but not rewrite it: putting words in someone's mouth is worse than taking
-    # them away, and taking them away is already the moderator's job.
+    # Writers may revise their own words; administrators may also correct or
+    # moderate any reflection without changing its recorded author.
     def b270_can_edit?(comment)
-      signed_in? && comment.reader_id == current_reader.id
+      return false unless signed_in?
+
+      comment.reader_id == current_reader.id || Bible270.config.admin?(current_reader)
     end
 
     def b270_can_delete?(comment)

data/app/views/bible270/comments/_comment.html.erb

@@ -25,7 +25,7 @@
         <%= button_to "delete", comment_path(comment), method: :delete, class: "b270-cdel",
               form: { style: "display:inline",
                       data: { turbo_stream: true,
-                              turbo_confirm: (b270_can_edit?(comment) ? nil : "Delete #{comment.reader.display_name}'s reflection?") } } %>
+                              turbo_confirm: (comment.reader_id == current_reader.id ? nil : "Delete #{comment.reader.display_name}'s reflection?") } } %>
       <% end %>
     </div>
 

data/app/views/bible270/shared/_markdown_toolbar.html.erb

@@ -59,14 +59,39 @@
       const start = textarea.value.lastIndexOf("\n", Math.max(selectionStart - 1, 0)) + 1;
       const nextNewline = textarea.value.indexOf("\n", selectionEnd);
       const finish = nextNewline === -1 ? textarea.value.length : nextNewline;
-      const source = textarea.value.slice(start, finish) || (action === "quote" ? "quoted text" : "list item");
+      const existing = textarea.value.slice(start, finish);
+      const placeholder = action === "quote" ? "quoted text" : "list item";
+      const source = existing || placeholder;
       const lines = source.split("\n");
       const replacement = lines.map((line, index) => {
         if (action === "quote") return `> ${line}`;
         if (action === "number-list") return `${index + 1}. ${line}`;
         return `- ${line}`;
       }).join("\n");
-      update(editor, textarea, replacement, start, finish, 0, replacement.length);
+      const selectListPlaceholder = !existing && action.endsWith("-list");
+      const selectedStart = selectListPlaceholder ? replacement.indexOf(placeholder) : 0;
+      const selectedEnd = selectListPlaceholder ? selectedStart + placeholder.length : replacement.length;
+      update(editor, textarea, replacement, start, finish, selectedStart, selectedEnd);
+    }
+
+    function continueList(editor, textarea, event) {
+      if (event.key !== "Enter" || event.isComposing || event.shiftKey || event.ctrlKey ||
+          event.metaKey || event.altKey || textarea.selectionStart !== textarea.selectionEnd) return false;
+
+      const caret = textarea.selectionStart;
+      const lineStart = textarea.value.lastIndexOf("\n", Math.max(caret - 1, 0)) + 1;
+      const beforeCaret = textarea.value.slice(lineStart, caret);
+      const bullet = beforeCaret.match(/^(\s*)([-+*])\s+/);
+      const numbered = beforeCaret.match(/^(\s*)(\d+)([.)])\s+/);
+      let marker;
+      if (bullet) marker = `${bullet[1]}${bullet[2]} `;
+      else if (numbered) marker = `${numbered[1]}${Number(numbered[2]) + 1}${numbered[3]} `;
+      else return false;
+
+      event.preventDefault();
+      const insertion = `\n${marker}`;
+      update(editor, textarea, insertion, caret, caret, insertion.length, insertion.length);
+      return true;
     }
 
     function addLink(editor, textarea) {
@@ -212,6 +237,7 @@
         formattingToggle.focus();
       });
       textarea.addEventListener("keydown", (event) => {
+        if (continueList(editor, textarea, event)) return;
         if (!(event.ctrlKey || event.metaKey) || event.altKey) return;
         const action = event.key.toLocaleLowerCase() === "b" ? "bold" :
           event.key.toLocaleLowerCase() === "i" ? "italic" : null;

data/lib/bible270/comment_formatter.rb

@@ -17,6 +17,7 @@ module Bible270
     ALLOWED_TAGS = %w[p br strong em blockquote ul ol li a].freeze
     ALLOWED_ATTRIBUTES = %w[href rel].freeze
     LINK_REL = 'nofollow ugc noopener'
+    URL_PATTERN = %r{https?://[^\s<>"]*[^\s<>".,;:!?)\]\}]}i
     SKIP_MENTIONS_IN = %w[a code pre].freeze
 
   module_function
@@ -26,6 +27,7 @@ module Bible270
       rendered = format == MARKDOWN ? markdown_html(source) : plain_html(source)
       fragment = fragment_for(sanitize(rendered))
       hard_wrap(fragment) if format == MARKDOWN
+      link_urls(fragment) if format == MARKDOWN
       decorate_links(fragment)
       link_mentions(fragment, &mention_path) if mention_path
       fragment.to_html
@@ -94,6 +96,28 @@ module Bible270
     end
     private_class_method :hard_wrap
 
+    def link_urls(fragment)
+      fragment.xpath('.//text()').to_a.each do |node|
+        next if node.ancestors.any? { |ancestor| SKIP_MENTIONS_IN.include?(ancestor.name) }
+        next unless node.text.match?(URL_PATTERN)
+
+        replacement = Nokogiri::HTML::DocumentFragment.parse('')
+        cursor = 0
+        node.text.to_enum(:scan, URL_PATTERN).each do
+          match = Regexp.last_match
+          replacement.add_child(Nokogiri::XML::Text.new(node.text[cursor...match.begin(0)], fragment.document))
+          link = Nokogiri::XML::Node.new('a', fragment.document)
+          link['href'] = match[0]
+          link.content = match[0]
+          replacement.add_child(link)
+          cursor = match.end(0)
+        end
+        replacement.add_child(Nokogiri::XML::Text.new(node.text[cursor..].to_s, fragment.document))
+        node.replace(replacement)
+      end
+    end
+    private_class_method :link_urls
+
     def decorate_links(fragment)
       fragment.css('a:not([href])').each do |link|
         link.replace(Nokogiri::XML::Text.new(link.text, fragment.document))

data/lib/bible270/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bible270
-  VERSION = '1.6.0'
+  VERSION = '1.6.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bible270
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Andrew vonderLuft