bible270 1.4.1 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bcb59bf731c08118644e9303ed749397492c6c7fea523a20cf4eb3c17b84281f
-  data.tar.gz: e1f6b1be1b245e859370ae745eb05f8adf47df953f89ad7cb28c700ad705830c
+  metadata.gz: 8792007d09956f4b53cbe9842007baea209a5eb0010758ef35e7d6f1977928f0
+  data.tar.gz: 0c5d16299136af62a6e1466210e962ef6e8d48065d759d9b5b57450215471c31
 SHA512:
-  metadata.gz: 312efc5cd9bfcb503430d1adc601b21a93658c9d378060182d3453b747d43674a736a83b753accaf0f0d738b0da005656c87490f17a51814800b3798632c09ab
-  data.tar.gz: c45129d6950f6b40f8bb0477b9de95ed9e98bb5ad3c1f9fa36bfb1b44eb5c1b26e337fc9d31e7dc9554115f2c4ecde14427127333bf2287925a0c0a33457b470
+  metadata.gz: 89cbba3ff6adfc107efacddb9b2d80903452488384983b488ecf733aa6e16d55451a0137626cda5a446591b2c28585201f49b612927a6ba80ad0b54a5889c377
+  data.tar.gz: d2d501c3f9935405bf0b850124f2329b3c5355ccfdf5d7403688329a65f1bfdc4a779fc3d65d957eba242363393e6a057519ef509b337986f6426bb2a3c6ffdc

data/CHANGELOG.md

@@ -4,9 +4,18 @@ All notable changes to bible270. Format follows [Keep a Changelog](https://keepa
 
 ## Unreleased Changes
 
+### Added
+
+- let administrators disable the day-completion dove animation for individual readers
+
 ### Changed
 
 - simplify day completion to one continuous server-confirmed dove flight from the lower center, eliminating the stagger between a pre-submit animation and the Turbo or HTML response
+- keep the dove bright in dark mode, grow it to an 80%-of-viewport fit, and finish with a quick fade instead of veering offscreen
+
+### Fixed
+
+- show the dove only once for each persisted day-completion event, even when Turbo replays a response or retries a stale-session request
 
 **[Full Changelog](https://github.com/avonderluft/bible270/compare/v1.4.0...main)**
 

data/app/controllers/bible270/admin_controller.rb

@@ -13,8 +13,8 @@ module Bible270
 
     before_action :require_admin!
     before_action :load_reader,
-                  only: %i[show destroy update_start update_profile update_notifications remove_avatar complete_through
-                           toggle_day]
+                  only: %i[show destroy update_start update_profile update_notifications update_completion_animation
+                           remove_avatar complete_through toggle_day]
     before_action :load_comment, only: %i[hide_comment unhide_comment destroy_comment]
 
     # ---- enrolment --------------------------------------------------------
@@ -74,6 +74,7 @@ module Bible270
 
     def show
       @comment_notifications_available = comment_notifications_available_for?(@reader)
+      @completion_dove_preference_available = completion_dove_available_for(@reader)
       @days_completed = @reader.days_completed
       @comments = @reader.comments.order(created_at: :desc).limit(50)
     end
@@ -236,6 +237,16 @@ module Bible270
       redirect_to admin_reader_path(@reader), notice: 'Reflection email setting updated.'
     end
 
+    def update_completion_animation
+      unless completion_dove_available_for(@reader)
+        alert = 'Run the pending Bible270 database migration before changing the completion animation.'
+        return redirect_to(admin_reader_path(@reader), alert: alert)
+      end
+
+      @reader.update!(completion_dove_disabled: params[:completion_dove_disabled] == '1')
+      redirect_to admin_reader_path(@reader), notice: 'Completion animation setting updated.'
+    end
+
     def remove_avatar
       @reader.remove_avatar!
       redirect_to admin_reader_path(@reader), notice: "Removed #{@reader.display_name}'s picture."
@@ -298,6 +309,12 @@ module Bible270
       true
     end
 
+    def completion_dove_available_for(reader)
+      available = Reader.completion_dove_column?
+      reader.reload if available && !reader.has_attribute?('completion_dove_disabled')
+      available
+    end
+
     def require_admin!
       return if Bible270.config.admin_configured? && Bible270.config.admin?(current_reader)
 

data/app/controllers/bible270/checkoffs_controller.rb

@@ -18,25 +18,27 @@ module Bible270
       requested_state = params[:checked] if params.key?(:checked)
       head :bad_request and return if params.key?(:checked) && !%w[0 1].include?(requested_state)
 
-      marked_read, checkoff_changed = apply_checkoff(requested_state)
-
-      @reader = current_reader.reload.reload_progress
-      @day_just_completed = marked_read && checkoff_changed && @reader.day_complete?(@day)
+      # Serialize this reader's transitions so two different final portions
+      # submitted concurrently cannot both announce the same day completion.
+      marked_read = nil
+      current_reader.with_lock do
+        marked_read, @completion_event_id = apply_checkoff(requested_state)
+        @reader = current_reader.reload.reload_progress
+        @day_just_completed = marked_read && @completion_event_id && @reader.day_complete?(@day)
+      end
       @reader_tracks = @reader.read_tracks_for(@day)
       @readings = Plan.readings_for(@day)
 
-      required = Plan.total_parts(@day)
-      completer_ids = Checkoff.where(day: @day)
-        .group(:reader_id)
-        .having('COUNT(*) >= ?', required)
-        .pluck(:reader_id)
-      @completers = Reader.where(id: completer_ids).order(:display_name)
+      @completers = Reader.completers_for(@day)
 
       respond_to do |format|
         format.turbo_stream
         format.html do
           if @day_just_completed
-            redirect_to day_path(@day), flash: { b270_day_just_completed: @day }
+            redirect_to day_path(@day), flash: {
+              b270_day_just_completed: @day,
+              b270_completion_event_id: @completion_event_id
+            }
           else
             message = marked_read ? 'Reading marked read.' : 'Reading marked unread.'
             redirect_to day_path(@day), flash: { b270_interaction_status: message }
@@ -51,9 +53,10 @@ module Bible270
       existing = find_checkoff
       if requested_state == '1'
         current_reader.ensure_started!
-        [true, existing.nil? && create_checkoff]
+        [true, existing.nil? ? create_checkoff : nil]
       elsif requested_state == '0' || existing
-        [false, existing ? existing.destroy.present? : false]
+        existing&.destroy
+        [false, nil]
       else
         current_reader.ensure_started!
         [true, create_checkoff]
@@ -66,15 +69,16 @@ module Bible270
       end
     end
 
+    # The created id is stable if Turbo replays this response, while a later
+    # re-completion creates a new id and is correctly treated as a new event.
     def create_checkoff
-      Checkoff.create!(reader: current_reader, day: @day, track: @track, part: @part)
-      true
+      Checkoff.create!(reader: current_reader, day: @day, track: @track, part: @part).id
     rescue ActiveRecord::RecordInvalid, ActiveRecord::RecordNotUnique
       # A repeated or concurrent desired-state request is already successful. Do
       # not hide any other validation failure under the same recovery.
       raise unless find_checkoff
 
-      false
+      nil
     end
   end
 end

data/app/controllers/bible270/days_controller.rb

@@ -21,16 +21,9 @@ module Bible270
       @new_comment = Comment.new(day: @day, parent_id: reply_parent&.id)
       @reader_tracks = current_reader ? current_reader.read_tracks_for(@day) : []
       @day_just_completed = flash[:b270_day_just_completed].to_i == @day
+      @completion_event_id = flash[:b270_completion_event_id] if @day_just_completed
 
-      # Every box on the day, not every track: an Old Testament reading of three
-      # chapters is three rows, so counting tracks would call someone finished
-      # who had only read the Old Testament.
-      required = Plan.total_parts(@day)
-      completer_ids = Checkoff.where(day: @day)
-        .group(:reader_id)
-        .having('COUNT(*) >= ?', required)
-        .pluck(:reader_id)
-      @completers = Reader.where(id: completer_ids).order(:display_name)
+      @completers = Reader.completers_for(@day)
     end
 
   private

data/app/models/bible270/reader.rb

@@ -33,6 +33,7 @@ module Bible270
     REFLECTIONS_SEEN_COLUMN = 'reflections_seen_at'
     COMMENT_NOTIFICATION_LEVELS = %w[all personal none].freeze
     COMMENT_NOTIFICATION_COLUMNS = %w[notify_on_mention notify_on_all_comments].freeze
+    COMPLETION_DOVE_COLUMN = 'completion_dove_disabled'
     MENTION_SUGGESTION_LIMIT = 5
 
     validates :display_name, presence: true
@@ -64,6 +65,18 @@ module Bible270
       end
     end
 
+    # A day is completed when its final required checkoff is created, so MAX(created_at)
+    # is the completion moment. Keep reader_id as a deterministic tie-breaker.
+    def self.completers_for(day)
+      reader_ids = Checkoff.where(day: day)
+        .group(:reader_id)
+        .having('COUNT(*) >= ?', Plan.total_parts(day))
+        .order(Checkoff.arel_table[:created_at].maximum.asc, :reader_id)
+        .pluck(:reader_id)
+      readers_by_id = where(id: reader_ids).index_by(&:id)
+      reader_ids.filter_map { |reader_id| readers_by_id[reader_id] }
+    end
+
     def self.reflections_seen_column?
       column_names.include?(REFLECTIONS_SEEN_COLUMN)
     rescue ActiveRecord::StatementInvalid
@@ -289,6 +302,22 @@ module Bible270
       where(notify_on_all_comments: true).where.not(email: [nil, ''])
     end
 
+    def self.completion_dove_column?
+      return true if column_names.include?(COMPLETION_DOVE_COLUMN)
+
+      reset_column_information
+      column_names.include?(COMPLETION_DOVE_COLUMN)
+    rescue ActiveRecord::StatementInvalid
+      false
+    end
+
+    # Keep day completion usable while an upgraded host is waiting to run the
+    # preference migration. Historically the dove was enabled, so a missing
+    # column preserves that behavior.
+    def completion_dove_disabled?
+      has_attribute?(COMPLETION_DOVE_COLUMN) && self[COMPLETION_DOVE_COLUMN] == true
+    end
+
     # Small, deterministic suggestions for the reflection composer. Full-handle
     # collisions are omitted because the server must never guess which reader a
     # mention intended.

data/app/views/bible270/admin/show.html.erb

@@ -70,6 +70,29 @@
   <% end %>
 </div>
 
+<div class="b270-panel">
+  <h2 class="b270-subhead">Completion animation</h2>
+  <% unless @completion_dove_preference_available %>
+    <p class="b270-flash alert" style="margin:0">
+      Run the pending Bible270 database migration before changing the completion animation.
+    </p>
+  <% else %>
+    <%= form_with url: admin_reader_completion_animation_path(@reader), method: :patch,
+                  class: "b270-emailform" do %>
+      <div class="b270-field">
+        <label class="b270-reminder-optin">
+          <%= check_box_tag :completion_dove_disabled, "1", @reader.completion_dove_disabled? %>
+          <span>Turn off the dove animation for this reader</span>
+        </label>
+      </div>
+      <p class="b270-hint" style="margin:0">
+        Day completion and progress tracking still work normally when the animation is off.
+      </p>
+      <%= submit_tag 'Save', class: 'b270-btn' %>
+    <% end %>
+  <% end %>
+</div>
+
 <div class="b270-panel">
   <h2 class="b270-subhead">Where they are in the plan</h2>
   <%= form_with url: admin_reader_start_path(@reader), method: :patch, class: "b270-startform" do %>

data/app/views/bible270/checkoffs/toggle.turbo_stream.erb

@@ -5,7 +5,7 @@
 
 <%= turbo_stream.replace "day_progress_#{@day}" do %>
   <%= render "bible270/days/day_progress", day: @day, reader: @reader,
-        just_completed: @day_just_completed %>
+        just_completed: @day_just_completed, completion_event_id: @completion_event_id %>
 <% end %>
 
 <%= turbo_stream.replace "completers_#{@day}" do %>

data/app/views/bible270/days/_completers.html.erb

@@ -2,9 +2,8 @@
 <div class="b270-completers" id="completers_<%= day %>">
   <% if completers.any? %>
     <span>Finished this day:</span>
-    <% completers.first(12).each do |reader| %>
-      <%= link_to b270_avatar(reader), reader_path(reader), title: reader.display_name %>
+    <% completers.each do |reader| %>
+      <%= link_to b270_avatar(reader, size: 56), reader_path(reader), title: reader.display_name %>
     <% end %>
-    <% if completers.size > 12 %><span><%= completers.size - 12 %> more</span><% end %>
   <% end %>
 </div>

data/app/views/bible270/days/_day_progress.html.erb

@@ -1,4 +1,4 @@
-<%# locals: (day:, reader:, just_completed: false) %>
+<%# locals: (day:, reader:, just_completed: false, completion_event_id: nil) %>
 <%
   previous_day = day > 1 ? day - 1 : nil
   next_day = day < Bible270::Plan::DAYS ? day + 1 : nil
@@ -33,7 +33,9 @@
 
 
   <% if complete %>
-    <%= render "bible270/shared/day_completion_dove", day: day if just_completed %>
+    <% if just_completed && completion_event_id && !reader&.completion_dove_disabled? %>
+      <%= render "bible270/shared/day_completion_dove", day: day, completion_event_id: completion_event_id %>
+    <% end %>
     <div class="b270-day-complete" role="status" aria-live="polite"
          <%= tag.attributes(data: completion_data) %>>
       <div>

data/app/views/bible270/days/show.html.erb

@@ -2,7 +2,7 @@
 
 <div class="b270-day-page">
   <%= render "bible270/days/day_progress", day: @day, reader: current_reader,
-        just_completed: @day_just_completed %>
+        just_completed: @day_just_completed, completion_event_id: @completion_event_id %>
 
   <%= render "bible270/shared/interaction_status" %>
 
@@ -16,8 +16,6 @@
   <% end %>
 
   <div class="b270-day-community">
-    <%= render "bible270/days/completers", day: @day, completers: @completers %>
-
     <h2 class="b270-section-h">Reflections</h2>
     <div id="comments">
       <%= render partial: "bible270/comments/comment", collection: @comments, as: :comment %>
@@ -30,6 +28,8 @@
       <%= render "bible270/shared/comment_drafts" %>
       <%= render "bible270/shared/mention_typeahead" %>
     <% end %>
+
+    <%= render "bible270/days/completers", day: @day, completers: @completers %>
   </div>
 </div>
 

data/app/views/bible270/shared/_day_completion_dove.html.erb

@@ -1,17 +1,19 @@
-<%# locals: (day:) %>
+<%# locals: (day:, completion_event_id:) %>
 <svg class="b270-completion-dove" data-b270-completion-dove data-b270-day="<%= day %>"
+     data-b270-completion-event="<%= completion_event_id %>" data-turbo-temporary
      viewBox="0 0 260 200" aria-hidden="true" focusable="false">
   <defs>
     <radialGradient id="b270-dove-light" cx="50%" cy="43%" r="68%">
-      <stop offset="0%" stop-color="#fff" />
-      <stop offset="58%" stop-color="#fffef8" />
-      <stop offset="100%" stop-color="#fff9e2" />
+      <stop class="b270-dove-light-center" offset="0%" stop-color="#fff" />
+      <stop class="b270-dove-light-middle" offset="58%" stop-color="#fffef8" />
+      <stop class="b270-dove-light-edge" offset="100%" stop-color="#fff9e2" />
     </radialGradient>
   </defs>
   <g class="b270-dove-silhouette">
     <path d="M122 94C103 82 87 69 72 53L39 17l11 28-23-23 15 32-23-20 19 30-24-16 22 26-25-12 27 23-24-7 30 19-22-3 31 17c20 11 42 16 59 8 5-9 8-18 10-25Z" />
     <path d="M138 94c19-12 35-25 50-41l33-36-11 28 23-23-15 32 23-20-19 30 24-16-22 26 25-12-27 23 24-7-30 19 22-3-31 17c-20 11-42 16-59 8-5-9-8-18-10-25Z" />
     <path d="M148 140c6 7 16 14 24 19 2 2 1 5-2 6-5 2-10-1-14-5 4 8 7 17 4 22-2 3-5 1-7-2l-6-11c3 10 2 19-3 24-2 3-5 1-6-3l-4-15c0 11-3 21-8 24-3 2-5-1-6-5l-1-19c-3 10-6 17-11 20-3 2-5-1-5-5l2-19c-4 8-9 13-14 14-3 1-5-2-4-6l6-18c-5 5-11 7-16 4-3-1-3-4 0-7 7-7 17-13 26-19Z" />
-    <path d="M108 116c5-10 9-17 14-17-1-11-2-23 4-29 5-4 12-3 15 1 2 3 2 6 1 9 3 .2 6 .8 8 1.5-2.5 1.3-5.5 2.1-8 2.5-1 5-3 10-5 15 6 3 11 9 15 17-1 15-6 28-16 39-3 4-7 7-10 9-4-2-8-5-11-9-9-11-14-25-11-37 1-1 2-2 4-2Z" />
+    <path class="b270-dove-beak" d="M140 80C144 80 148 80.8 151 82 152 82.4 152 83.2 151 83.8 148 85.1 144 85.8 140 85 138.5 83.5 138.5 81.2 140 80Z" />
+    <path d="M108 116c5-10 9-17 14-17-1-11-2-23 4-29 5-4 12-3 15 1 2 3 2 6 1 9 1 1 1 3 0 4-1 5-3 10-5 15 6 3 11 9 15 17-1 15-6 28-16 39-3 4-7 7-10 9-4-2-8-5-11-9-9-11-14-25-11-37 1-1 2-2 4-2Z" />
   </g>
 </svg>

data/app/views/bible270/shared/_interaction_ui.html.erb

@@ -18,6 +18,53 @@
       region.dataset.state = state;
     }
 
+    const shownCompletionDoves = new Set();
+
+    function claimCompletionDove(dove) {
+      const eventId = dove.dataset.b270CompletionEvent;
+      if (!eventId) return false;
+
+      const key = `b270-completion-dove:${eventId}`;
+      if (shownCompletionDoves.has(key)) return false;
+
+      try {
+        if (window.sessionStorage.getItem(key) === "shown") return false;
+        window.sessionStorage.setItem(key, "shown");
+      } catch (_error) {
+        // Some privacy modes disable session storage. The in-memory set still
+        // prevents duplicate Turbo rendering within the current page.
+      }
+      shownCompletionDoves.add(key);
+      return true;
+    }
+
+    function initializeCompletionDove(dove) {
+      if (dove.dataset.b270DoveInitialized === "true") return;
+      dove.dataset.b270DoveInitialized = "true";
+
+      if (window.matchMedia("(prefers-reduced-motion: reduce)").matches) {
+        dove.remove();
+        return;
+      }
+
+      if (!claimCompletionDove(dove)) {
+        dove.remove();
+        return;
+      }
+
+      // Keep an active flight outside the Turbo-replaced progress panel so a
+      // replayed response cannot restart or cut short the same completion event.
+      if (dove.parentElement !== document.body) document.body.appendChild(dove);
+      requestAnimationFrame(() => {
+        if (dove.isConnected) dove.classList.add("b270-completion-dove-active");
+      });
+    }
+
+    function initializeCompletionDoves(root = document) {
+      if (root.matches && root.matches("[data-b270-completion-dove]")) initializeCompletionDove(root);
+      root.querySelectorAll?.("[data-b270-completion-dove]").forEach(initializeCompletionDove);
+    }
+
     function resetForm(form) {
       form.removeAttribute("aria-busy");
       form.dataset.b270Submitting = "false";
@@ -29,8 +76,18 @@
 
     function reset() {
       document.querySelectorAll("form[data-b270-submit='true']").forEach(resetForm);
+      initializeCompletionDoves();
     }
 
+    const completionDoveObserver = new MutationObserver((mutations) => {
+      mutations.forEach((mutation) => {
+        mutation.addedNodes.forEach((node) => {
+          if (node.nodeType === Node.ELEMENT_NODE) initializeCompletionDoves(node);
+        });
+      });
+    });
+    completionDoveObserver.observe(document.documentElement, { childList: true, subtree: true });
+
     const SESSION_REFRESH_AFTER = 5 * 60 * 1000;
     let sessionRefreshedAt = Date.now();
     let sessionRefresh = null;
@@ -201,8 +258,12 @@
       }
     });
     document.addEventListener("turbo:load", reset);
+    document.addEventListener("turbo:before-cache", () => {
+      document.querySelectorAll("[data-b270-completion-dove]").forEach((dove) => dove.remove());
+    });
     document.addEventListener("animationend", (event) => {
-      if (event.target.matches("[data-b270-completion-dove]")) event.target.remove();
+      if (event.animationName === "b270-dove-flight" &&
+          event.target.matches("[data-b270-completion-dove]")) event.target.remove();
     });
 
     window.Bible270InteractionUI = { reset };

data/app/views/bible270/shared/_styles.html.erb

@@ -148,16 +148,20 @@
   .b270-day-complete span{font-size:12px;color:var(--muted)}
   .b270 .b270-day-complete .b270-btn{flex:none;margin:0 0 0 auto}
   .b270-completion-dove{position:fixed;z-index:1000;top:72vh;left:50vw;
-                        width:min(75vw,97.5vh);height:auto;overflow:visible;pointer-events:none;opacity:0;
+                        width:min(80vw,104vh);height:auto;overflow:visible;pointer-events:none;opacity:0;
+                        color-scheme:only light;forced-color-adjust:none;
                         filter:drop-shadow(0 0 8px rgba(255,255,255,1)) drop-shadow(0 0 24px rgba(255,252,220,1)) drop-shadow(0 0 52px rgba(225,191,92,.82));
-                        will-change:top,left,transform,opacity;animation:b270-dove-flight 1.6s cubic-bezier(.18,.72,.28,1) both}
-  .b270-dove-silhouette{fill:url(#b270-dove-light);stroke:none}
+                        will-change:top,left,transform,opacity}
+  .b270-completion-dove-active{animation:b270-dove-flight 1.7s cubic-bezier(.18,.72,.28,1) both}
+  .b270-dove-silhouette{fill:url(#b270-dove-light)!important;stroke:none}
+  .b270-dove-light-center{stop-color:#fff!important}
+  .b270-dove-light-middle{stop-color:#fffef8!important}
+  .b270-dove-light-edge{stop-color:#fff9e2!important}
   @keyframes b270-dove-flight{
     0%{top:72vh;left:50vw;opacity:.22;visibility:visible;transform:translate(-50%,-50%) scale(.02) rotate(-8deg)}
     8%{top:calc(72vh - 10px);left:50vw;opacity:.78;transform:translate(-50%,-50%) scale(.08) rotate(-5deg)}
-    64%{top:38vh;left:52vw;opacity:.92;transform:translate(-50%,-50%) scale(1) rotate(4deg)}
-    99%{visibility:visible}
-    100%{top:-25vh;left:115vw;opacity:0;visibility:hidden;transform:translate(-50%,-50%) scale(1.55) rotate(12deg)}
+    33%{top:50vh;left:50vw;opacity:1;visibility:visible;transform:translate(-50%,-50%) scale(1) rotate(4deg)}
+    100%{top:50vh;left:50vw;opacity:0;visibility:hidden;transform:translate(-50%,-50%) scale(1) rotate(4deg)}
   }
 
   /* readings */

data/config/routes.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Rails routes are intentionally kept in one cohesive DSL block.
 Bible270::Engine.routes.draw do
   root to: 'days#index'
 
@@ -22,6 +23,8 @@ Bible270::Engine.routes.draw do
   delete 'admin/readers/:id',            to: 'admin#destroy'
   patch  'admin/readers/:id/profile',    to: 'admin#update_profile', as: :admin_reader_profile
   patch  'admin/readers/:id/notifications', to: 'admin#update_notifications', as: :admin_reader_notifications
+  patch  'admin/readers/:id/completion-animation', to: 'admin#update_completion_animation',
+                                                   as: :admin_reader_completion_animation
   delete 'admin/readers/:id/avatar',     to: 'admin#remove_avatar', as: :admin_reader_avatar
   patch  'admin/readers/:id/version',    to: 'admin#update_bible_version', as: :admin_reader_version
   patch  'admin/readers/:id/start',      to: 'admin#update_start',     as: :admin_reader_start

data/db/migrate/20260101000020_add_completion_dove_disabled_to_bible270_readers.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class AddCompletionDoveDisabledToBible270Readers < ActiveRecord::Migration[7.0]
+  def change
+    add_column :bible270_readers, :completion_dove_disabled, :boolean, null: false, default: false
+  end
+end

data/lib/bible270/migration_reconciler.rb

@@ -29,6 +29,7 @@ module Bible270
       'AddReflectionsSeenAtToBible270Readers' => :check_reflections_seen_at,
       'AddAllCommentNoticesToBible270Readers' => :check_all_comment_notices,
       'ChangePassageSourceDefaultToBibleCom' => :check_passage_source_default,
+      'AddCompletionDoveDisabledToBible270Readers' => :check_completion_dove_disabled,
       'CreateActiveStorageTables' => :check_active_storage
     }.freeze
 
@@ -204,6 +205,10 @@ module Bible270
       column&.default == 'bible_com' ? [] : ['column bible270_readers.passage_source default bible_com']
     end
 
+    def check_completion_dove_disabled
+      table_missing(:bible270_readers, columns: %i[completion_dove_disabled])
+    end
+
     # The Bible270 installer can install Active Storage for reader avatars. A
     # copied database can therefore have the same timestamp mismatch for Rails'
     # generated Active Storage migration as it has for the engine migrations.

data/lib/bible270/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bible270
-  VERSION = '1.4.1'
+  VERSION = '1.4.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bible270
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - Andrew vonderLuft
@@ -175,6 +175,7 @@ files:
 - db/migrate/20260101000017_add_reflections_seen_at_to_bible270_readers.rb
 - db/migrate/20260101000018_add_all_comment_notices_to_bible270_readers.rb
 - db/migrate/20260101000019_change_passage_source_default_to_bible_com.rb
+- db/migrate/20260101000020_add_completion_dove_disabled_to_bible270_readers.rb
 - lib/bible270.rb
 - lib/bible270/avatars.rb
 - lib/bible270/configuration.rb